Files
probo/e2e/mcp/third_party_contact_test.go
Sacha Al Himdani eecbe4c46c Rename vendors to third parties
Renames the user-facing 'vendor' concept to 'third party' across the
entire codebase. The shared common_third_parties reference table is
unchanged.

Migration. Renames the vendor_category enum, the vendors and
vendor_<entity> tables (contacts, services, compliance_reports,
business_associate_agreements, data_privacy_agreements,
risk_assessments) and their vendor_id columns, the asset_vendors /
data_vendors / processing_activity_vendors junction tables,
generated_documents.vendors_document_id, the webhook_event_type
'vendor:<verb>' values, and the snapshots_type 'VENDORS' value.

Backend. Renames coredata models and SQL queries, probo services,
GraphQL / MCP API surface, console / trust / webhook resolvers and
types, the CLI (prb vendor* -> prb third-party*; pkg/cmd/vendormgmt
-> pkg/cmd/thirdpartymgmt), the document generator, vetting agent
prompts, and the common-third-parties-import command.

Frontend, packages, n8n, e2e. Renames apps/console pages, components,
hooks, routes, dialogs, and tabs; the shared @probo/vendors package
(now @probo/third-parties); the @probo/ui Vendors atoms (now
ThirdParties, VendorLogo -> ThirdPartyLogo); the n8n community node
actions/vendor folder (now actions/thirdParty); and the e2e Go test
suite (console and MCP). Filesystem and URL paths use kebab-case
(third-parties), GraphQL fields and TypeScript identifiers use
camelCase (thirdParty / thirdParties), Go types use PascalCase
(ThirdParty), and human-facing text uses 'third party' with a space.

Co-authored-by: Bryan Frimin <bryan@getprobo.com>
Signed-off-by: Bryan Frimin <bryan@getprobo.com>
Signed-off-by: Sacha Al Himdani <sacha@getprobo.com>
2026-05-13 21:21:39 +02:00

143 lines
4.4 KiB
Go

// Copyright (c) 2025-2026 Probo Inc <hello@getprobo.com>.
//
// Permission to use, copy, modify, and/or distribute this software for any
// purpose with or without fee is hereby granted, provided that the above
// copyright notice and this permission notice appear in all copies.
//
// THE SOFTWARE IS PROVIDED "AS IS" AND THE AUTHOR DISCLAIMS ALL WARRANTIES WITH
// REGARD TO THIS SOFTWARE INCLUDING ALL IMPLIED WARRANTIES OF MERCHANTABILITY
// AND FITNESS. IN NO EVENT SHALL THE AUTHOR BE LIABLE FOR ANY SPECIAL, DIRECT,
// INDIRECT, OR CONSEQUENTIAL DAMAGES OR ANY DAMAGES WHATSOEVER RESULTING FROM
// LOSS OF USE, DATA OR PROFITS, WHETHER IN AN ACTION OF CONTRACT, NEGLIGENCE OR
// OTHER TORTIOUS ACTION, ARISING OUT OF OR IN CONNECTION WITH THE USE OR
// PERFORMANCE OF THIS SOFTWARE.
package mcp_test
import (
"testing"
"github.com/stretchr/testify/assert"
"github.com/stretchr/testify/require"
"go.probo.inc/probo/e2e/internal/factory"
"go.probo.inc/probo/e2e/internal/testutil"
)
type thirdPartyContact struct {
ID string `json:"id"`
Name string `json:"name"`
Email *string `json:"email"`
Phone *string `json:"phone"`
Role *string `json:"role"`
}
func TestMCP_AddThirdPartyContact(t *testing.T) {
t.Parallel()
owner := testutil.NewClient(t, testutil.RoleOwner)
mc := testutil.NewMCPClient(t, owner)
thirdPartyID := factory.CreateThirdParty(owner)
var result struct {
ThirdPartyContact thirdPartyContact `json:"thirdPartyContact"`
}
mc.CallToolInto("addThirdPartyContact", map[string]any{
"thirdPartyId": thirdPartyID,
"name": "Alice Smith",
"email": "alice@example.com",
"phone": "+1-555-0100",
"role": "Account Manager",
}, &result)
assert.NotEmpty(t, result.ThirdPartyContact.ID)
assert.Equal(t, "Alice Smith", result.ThirdPartyContact.Name)
}
func TestMCP_UpdateThirdPartyContact(t *testing.T) {
t.Parallel()
owner := testutil.NewClient(t, testutil.RoleOwner)
mc := testutil.NewMCPClient(t, owner)
thirdPartyID := factory.CreateThirdParty(owner)
// Create
var addResult struct {
ThirdPartyContact thirdPartyContact `json:"thirdPartyContact"`
}
mc.CallToolInto("addThirdPartyContact", map[string]any{
"thirdPartyId": thirdPartyID,
"name": "Bob Jones",
"email": "bob@example.com",
}, &addResult)
require.NotEmpty(t, addResult.ThirdPartyContact.ID)
// Update
var updateResult struct {
ThirdPartyContact thirdPartyContact `json:"thirdPartyContact"`
}
mc.CallToolInto("updateThirdPartyContact", map[string]any{
"id": addResult.ThirdPartyContact.ID,
"name": "Robert Jones",
"role": "CTO",
}, &updateResult)
assert.Equal(t, addResult.ThirdPartyContact.ID, updateResult.ThirdPartyContact.ID)
assert.Equal(t, "Robert Jones", updateResult.ThirdPartyContact.Name)
}
func TestMCP_DeleteThirdPartyContact(t *testing.T) {
t.Parallel()
owner := testutil.NewClient(t, testutil.RoleOwner)
mc := testutil.NewMCPClient(t, owner)
thirdPartyID := factory.CreateThirdParty(owner)
// Create
var addResult struct {
ThirdPartyContact thirdPartyContact `json:"thirdPartyContact"`
}
mc.CallToolInto("addThirdPartyContact", map[string]any{
"thirdPartyId": thirdPartyID,
"name": "Contact to delete",
}, &addResult)
require.NotEmpty(t, addResult.ThirdPartyContact.ID)
// Delete
var deleteResult struct {
DeletedThirdPartyContactID string `json:"deletedThirdPartyContactId"`
}
mc.CallToolInto("deleteThirdPartyContact", map[string]any{
"id": addResult.ThirdPartyContact.ID,
}, &deleteResult)
assert.Equal(t, addResult.ThirdPartyContact.ID, deleteResult.DeletedThirdPartyContactID)
}
func TestMCP_ListThirdPartyContacts(t *testing.T) {
t.Parallel()
owner := testutil.NewClient(t, testutil.RoleOwner)
mc := testutil.NewMCPClient(t, owner)
thirdPartyID := factory.CreateThirdParty(owner)
// Create contacts
for i := range 3 {
var result struct {
ThirdPartyContact thirdPartyContact `json:"thirdPartyContact"`
}
mc.CallToolInto("addThirdPartyContact", map[string]any{
"thirdPartyId": thirdPartyID,
"name": factory.SafeName("Contact"),
"email": factory.SafeEmail(),
}, &result)
require.NotEmpty(t, result.ThirdPartyContact.ID)
_ = i
}
// List
var listResult struct {
ThirdPartyContacts []thirdPartyContact `json:"thirdPartyContacts"`
}
mc.CallToolInto("listThirdPartyContacts", map[string]any{
"thirdPartyId": thirdPartyID,
}, &listResult)
assert.GreaterOrEqual(t, len(listResult.ThirdPartyContacts), 3)
}