Files
probo/pkg/accessreview/drivers/tally.go
Aurélien Sibiril da80ce3eb1 Include all accounts in access-review fetch
Drivers whose source API surfaces an account-status signal return every
account (including inactive / suspended / deleted) and populate Active
accordingly; drivers without such a signal no longer fabricate it.

The fetch pipeline records every account with decision PENDING and no
flags. Producing flags or a non-PENDING decision is reserved to human
reviewers or a purpose-built agent run against the campaign -- the engine
must not form an implicit verdict.

Signed-off-by: Aurélien Sibiril <81782+aureliensibiril@users.noreply.github.com>
2026-04-22 11:15:48 +02:00

187 lines
4.8 KiB
Go

// Copyright (c) 2026 Probo Inc <hello@getprobo.com>.
//
// Permission to use, copy, modify, and/or distribute this software for any
// purpose with or without fee is hereby granted, provided that the above
// copyright notice and this permission notice appear in all copies.
//
// THE SOFTWARE IS PROVIDED "AS IS" AND THE AUTHOR DISCLAIMS ALL WARRANTIES WITH
// REGARD TO THIS SOFTWARE INCLUDING ALL IMPLIED WARRANTIES OF MERCHANTABILITY
// AND FITNESS. IN NO EVENT SHALL THE AUTHOR BE LIABLE FOR ANY SPECIAL, DIRECT,
// INDIRECT, OR CONSEQUENTIAL DAMAGES OR ANY DAMAGES WHATSOEVER RESULTING FROM
// LOSS OF USE, DATA OR PROFITS, WHETHER IN AN ACTION OF CONTRACT, NEGLIGENCE OR
// OTHER TORTIOUS ACTION, ARISING OUT OF OR IN CONNECTION WITH THE USE OR
// PERFORMANCE OF THIS SOFTWARE.
package drivers
import (
"context"
"encoding/json"
"fmt"
"net/http"
"net/url"
"time"
"go.probo.inc/probo/pkg/coredata"
)
type TallyDriver struct {
httpClient *http.Client
organizationID string
}
var _ Driver = (*TallyDriver)(nil)
type tallyUser struct {
ID string `json:"id"`
FirstName string `json:"firstName"`
LastName string `json:"lastName"`
FullName string `json:"fullName"`
Email string `json:"email"`
IsDeleted bool `json:"isDeleted"`
HasTwoFactorEnabled bool `json:"hasTwoFactorEnabled"`
CreatedAt time.Time `json:"createdAt"`
}
type tallyInvite struct {
ID string `json:"id"`
Email string `json:"email"`
}
func NewTallyDriver(httpClient *http.Client, organizationID string) *TallyDriver {
return &TallyDriver{
httpClient: httpClient,
organizationID: organizationID,
}
}
func (d *TallyDriver) ListAccounts(ctx context.Context) ([]AccountRecord, error) {
records, err := d.listUsers(ctx)
if err != nil {
return nil, err
}
inviteRecords, err := d.listInvites(ctx)
if err != nil {
return nil, err
}
records = append(records, inviteRecords...)
return records, nil
}
func (d *TallyDriver) listUsers(ctx context.Context) ([]AccountRecord, error) {
u := &url.URL{
Scheme: "https",
Host: "api.tally.so",
}
u = u.JoinPath("organizations", d.organizationID, "users")
req, err := http.NewRequestWithContext(ctx, http.MethodGet, u.String(), nil)
if err != nil {
return nil, fmt.Errorf("cannot create tally users request: %w", err)
}
req.Header.Set("Accept", "application/json")
httpResp, err := d.httpClient.Do(req)
if err != nil {
return nil, fmt.Errorf("cannot execute tally users request: %w", err)
}
defer func() {
_ = httpResp.Body.Close()
}()
if httpResp.StatusCode < 200 || httpResp.StatusCode >= 300 {
return nil, fmt.Errorf(
"cannot fetch tally users: unexpected status %d",
httpResp.StatusCode,
)
}
var users []tallyUser
if err := json.NewDecoder(httpResp.Body).Decode(&users); err != nil {
return nil, fmt.Errorf("cannot decode tally users response: %w", err)
}
var records []AccountRecord
for _, u := range users {
mfaStatus := coredata.MFAStatusDisabled
if u.HasTwoFactorEnabled {
mfaStatus = coredata.MFAStatusEnabled
}
record := AccountRecord{
Email: u.Email,
FullName: u.FullName,
Active: new(!u.IsDeleted),
ExternalID: u.ID,
MFAStatus: mfaStatus,
AuthMethod: coredata.AccessEntryAuthMethodUnknown,
AccountType: coredata.AccessEntryAccountTypeUser,
CreatedAt: new(u.CreatedAt),
}
if record.Email != "" {
records = append(records, record)
}
}
return records, nil
}
func (d *TallyDriver) listInvites(ctx context.Context) ([]AccountRecord, error) {
u := &url.URL{
Scheme: "https",
Host: "api.tally.so",
}
u = u.JoinPath("organizations", d.organizationID, "invites")
req, err := http.NewRequestWithContext(ctx, http.MethodGet, u.String(), nil)
if err != nil {
return nil, fmt.Errorf("cannot create tally invites request: %w", err)
}
req.Header.Set("Accept", "application/json")
httpResp, err := d.httpClient.Do(req)
if err != nil {
return nil, fmt.Errorf("cannot execute tally invites request: %w", err)
}
defer func() {
_ = httpResp.Body.Close()
}()
if httpResp.StatusCode < 200 || httpResp.StatusCode >= 300 {
return nil, fmt.Errorf(
"cannot fetch tally invites: unexpected status %d",
httpResp.StatusCode,
)
}
var invites []tallyInvite
if err := json.NewDecoder(httpResp.Body).Decode(&invites); err != nil {
return nil, fmt.Errorf("cannot decode tally invites response: %w", err)
}
var records []AccountRecord
for _, inv := range invites {
record := AccountRecord{
Email: inv.Email,
Active: new(false),
ExternalID: inv.ID,
MFAStatus: coredata.MFAStatusUnknown,
AuthMethod: coredata.AccessEntryAuthMethodUnknown,
AccountType: coredata.AccessEntryAccountTypeUser,
Role: "Invited",
}
if record.Email != "" {
records = append(records, record)
}
}
return records, nil
}