Remove assets from the snapshot system and replace with a publish-based document workflow that generates versioned ProseMirror documents. - Remove snapshot_id/source_id from asset and asset_vendor models - Delete AssetFilter (no longer needed without snapshot filtering) - Add PublishAssetList service, GraphQL mutation, MCP tool, CLI command, and n8n operation - Add asset_list_document_id column to generated_documents table - Generate ProseMirror documents with asset inventory tables (name, type, amount, data types stored, owner, vendors) - Add AssetListDocument resolver on Organization type - Update frontend to remove snapshot routes/params and add publish dialog - Add e2e tests for asset publish (immediate, with approvers, reuse, RBAC) - Add migration script for converting legacy asset snapshots to documents - Exclude ASSETS from snapshot type lists and e2e snapshot tests - Move generated_documents SQL to coredata methods on Datum and Asset - Clear generated document and SOA references on soft delete and archive Signed-off-by: Sacha Al Himdani <sacha@getprobo.com>
407 lines
9.5 KiB
Go
407 lines
9.5 KiB
Go
// Copyright (c) 2026 Probo Inc <hello@getprobo.com>.
|
|
//
|
|
// Permission to use, copy, modify, and/or distribute this software for any
|
|
// purpose with or without fee is hereby granted, provided that the above
|
|
// copyright notice and this permission notice appear in all copies.
|
|
//
|
|
// THE SOFTWARE IS PROVIDED "AS IS" AND THE AUTHOR DISCLAIMS ALL WARRANTIES WITH
|
|
// REGARD TO THIS SOFTWARE INCLUDING ALL IMPLIED WARRANTIES OF MERCHANTABILITY
|
|
// AND FITNESS. IN NO EVENT SHALL THE AUTHOR BE LIABLE FOR ANY SPECIAL, DIRECT,
|
|
// INDIRECT, OR CONSEQUENTIAL DAMAGES OR ANY DAMAGES WHATSOEVER RESULTING FROM
|
|
// LOSS OF USE, DATA OR PROFITS, WHETHER IN AN ACTION OF CONTRACT, NEGLIGENCE OR
|
|
// OTHER TORTIOUS ACTION, ARISING OUT OF OR IN CONNECTION WITH THE USE OR
|
|
// PERFORMANCE OF THIS SOFTWARE.
|
|
|
|
package console_test
|
|
|
|
import (
|
|
"testing"
|
|
|
|
"github.com/stretchr/testify/assert"
|
|
"github.com/stretchr/testify/require"
|
|
"go.probo.inc/probo/e2e/internal/factory"
|
|
"go.probo.inc/probo/e2e/internal/testutil"
|
|
)
|
|
|
|
func TestAsset_PublishAssetList(t *testing.T) {
|
|
t.Parallel()
|
|
|
|
owner := testutil.NewClient(t, testutil.RoleOwner)
|
|
|
|
t.Run(
|
|
"publish without approvers publishes immediately",
|
|
func(t *testing.T) {
|
|
t.Parallel()
|
|
|
|
owner := testutil.NewClient(t, testutil.RoleOwner)
|
|
profileID := factory.CreateUser(owner)
|
|
|
|
createAssetForPublish(t, owner, profileID, "Test Asset")
|
|
|
|
const query = `
|
|
mutation($input: PublishAssetListInput!) {
|
|
publishAssetList(input: $input) {
|
|
documentEdge {
|
|
node {
|
|
id
|
|
writeMode
|
|
status
|
|
}
|
|
}
|
|
documentVersionEdge {
|
|
node {
|
|
id
|
|
title
|
|
documentType
|
|
status
|
|
major
|
|
minor
|
|
content
|
|
}
|
|
}
|
|
}
|
|
}
|
|
`
|
|
|
|
var result struct {
|
|
PublishAssetList struct {
|
|
DocumentEdge struct {
|
|
Node struct {
|
|
ID string `json:"id"`
|
|
WriteMode string `json:"writeMode"`
|
|
Status string `json:"status"`
|
|
} `json:"node"`
|
|
} `json:"documentEdge"`
|
|
DocumentVersionEdge struct {
|
|
Node struct {
|
|
ID string `json:"id"`
|
|
Title string `json:"title"`
|
|
DocumentType string `json:"documentType"`
|
|
Status string `json:"status"`
|
|
Major int `json:"major"`
|
|
Minor int `json:"minor"`
|
|
Content string `json:"content"`
|
|
} `json:"node"`
|
|
} `json:"documentVersionEdge"`
|
|
} `json:"publishAssetList"`
|
|
}
|
|
|
|
err := owner.Execute(
|
|
query,
|
|
map[string]any{
|
|
"input": map[string]any{
|
|
"organizationId": owner.GetOrganizationID(),
|
|
},
|
|
},
|
|
&result,
|
|
)
|
|
|
|
require.NoError(t, err)
|
|
|
|
doc := result.PublishAssetList.DocumentEdge.Node
|
|
assert.NotEmpty(t, doc.ID)
|
|
assert.Equal(t, "GENERATED", doc.WriteMode)
|
|
assert.Equal(t, "ACTIVE", doc.Status)
|
|
|
|
ver := result.PublishAssetList.DocumentVersionEdge.Node
|
|
assert.NotEmpty(t, ver.ID)
|
|
assert.Equal(t, "REGISTER", ver.DocumentType)
|
|
assert.Equal(t, "PUBLISHED", ver.Status)
|
|
assert.Equal(t, 1, ver.Major)
|
|
assert.Equal(t, 0, ver.Minor)
|
|
assert.Contains(t, ver.Content, "Purpose")
|
|
assert.Contains(t, ver.Content, "Test Asset")
|
|
},
|
|
)
|
|
|
|
t.Run(
|
|
"publish with approvers creates draft with quorum",
|
|
func(t *testing.T) {
|
|
t.Parallel()
|
|
|
|
const query = `
|
|
mutation($input: PublishAssetListInput!) {
|
|
publishAssetList(input: $input) {
|
|
documentEdge {
|
|
node {
|
|
id
|
|
writeMode
|
|
}
|
|
}
|
|
documentVersionEdge {
|
|
node {
|
|
id
|
|
status
|
|
major
|
|
}
|
|
}
|
|
}
|
|
}
|
|
`
|
|
|
|
var result struct {
|
|
PublishAssetList struct {
|
|
DocumentEdge struct {
|
|
Node struct {
|
|
ID string `json:"id"`
|
|
WriteMode string `json:"writeMode"`
|
|
} `json:"node"`
|
|
} `json:"documentEdge"`
|
|
DocumentVersionEdge struct {
|
|
Node struct {
|
|
ID string `json:"id"`
|
|
Status string `json:"status"`
|
|
Major int `json:"major"`
|
|
} `json:"node"`
|
|
} `json:"documentVersionEdge"`
|
|
} `json:"publishAssetList"`
|
|
}
|
|
|
|
err := owner.Execute(
|
|
query,
|
|
map[string]any{
|
|
"input": map[string]any{
|
|
"organizationId": owner.GetOrganizationID(),
|
|
"approverIds": []string{owner.GetProfileID().String()},
|
|
},
|
|
},
|
|
&result,
|
|
)
|
|
|
|
require.NoError(t, err)
|
|
|
|
doc := result.PublishAssetList.DocumentEdge.Node
|
|
assert.NotEmpty(t, doc.ID)
|
|
assert.Equal(t, "GENERATED", doc.WriteMode)
|
|
|
|
ver := result.PublishAssetList.DocumentVersionEdge.Node
|
|
assert.NotEmpty(t, ver.ID)
|
|
assert.Equal(t, "PENDING_APPROVAL", ver.Status)
|
|
},
|
|
)
|
|
|
|
t.Run(
|
|
"creating second document reuses existing document",
|
|
func(t *testing.T) {
|
|
t.Parallel()
|
|
|
|
secondOwner := testutil.NewClient(t, testutil.RoleOwner)
|
|
profileID := factory.CreateUser(secondOwner)
|
|
|
|
createAssetForPublish(t, secondOwner, profileID, "Reuse Test Asset")
|
|
|
|
const query = `
|
|
mutation($input: PublishAssetListInput!) {
|
|
publishAssetList(input: $input) {
|
|
documentEdge {
|
|
node { id }
|
|
}
|
|
documentVersionEdge {
|
|
node { id major }
|
|
}
|
|
}
|
|
}
|
|
`
|
|
|
|
var result1, result2 struct {
|
|
PublishAssetList struct {
|
|
DocumentEdge struct {
|
|
Node struct {
|
|
ID string `json:"id"`
|
|
} `json:"node"`
|
|
} `json:"documentEdge"`
|
|
DocumentVersionEdge struct {
|
|
Node struct {
|
|
ID string `json:"id"`
|
|
Major int `json:"major"`
|
|
} `json:"node"`
|
|
} `json:"documentVersionEdge"`
|
|
} `json:"publishAssetList"`
|
|
}
|
|
|
|
input := map[string]any{
|
|
"input": map[string]any{
|
|
"organizationId": secondOwner.GetOrganizationID(),
|
|
},
|
|
}
|
|
|
|
err := secondOwner.Execute(query, input, &result1)
|
|
require.NoError(t, err)
|
|
|
|
err = secondOwner.Execute(query, input, &result2)
|
|
require.NoError(t, err)
|
|
|
|
doc1 := result1.PublishAssetList.DocumentEdge.Node.ID
|
|
doc2 := result2.PublishAssetList.DocumentEdge.Node.ID
|
|
assert.Equal(t, doc1, doc2, "should reuse same document")
|
|
|
|
ver1Major := result1.PublishAssetList.DocumentVersionEdge.Node.Major
|
|
ver2Major := result2.PublishAssetList.DocumentVersionEdge.Node.Major
|
|
assert.Equal(t, 1, ver1Major)
|
|
assert.Equal(t, 2, ver2Major)
|
|
},
|
|
)
|
|
|
|
t.Run(
|
|
"document linked back to organization",
|
|
func(t *testing.T) {
|
|
t.Parallel()
|
|
|
|
thirdOwner := testutil.NewClient(t, testutil.RoleOwner)
|
|
profileID := factory.CreateUser(thirdOwner)
|
|
|
|
createAssetForPublish(t, thirdOwner, profileID, "Link Test Asset")
|
|
|
|
const publishQuery = `
|
|
mutation($input: PublishAssetListInput!) {
|
|
publishAssetList(input: $input) {
|
|
documentEdge {
|
|
node { id }
|
|
}
|
|
documentVersionEdge {
|
|
node { id }
|
|
}
|
|
}
|
|
}
|
|
`
|
|
|
|
var publishResult struct {
|
|
PublishAssetList struct {
|
|
DocumentEdge struct {
|
|
Node struct {
|
|
ID string `json:"id"`
|
|
} `json:"node"`
|
|
} `json:"documentEdge"`
|
|
DocumentVersionEdge struct {
|
|
Node struct {
|
|
ID string `json:"id"`
|
|
} `json:"node"`
|
|
} `json:"documentVersionEdge"`
|
|
} `json:"publishAssetList"`
|
|
}
|
|
|
|
err := thirdOwner.Execute(
|
|
publishQuery,
|
|
map[string]any{
|
|
"input": map[string]any{
|
|
"organizationId": thirdOwner.GetOrganizationID(),
|
|
},
|
|
},
|
|
&publishResult,
|
|
)
|
|
require.NoError(t, err)
|
|
|
|
docID := publishResult.PublishAssetList.DocumentEdge.Node.ID
|
|
|
|
const orgQuery = `
|
|
query($id: ID!) {
|
|
node(id: $id) {
|
|
... on Organization {
|
|
id
|
|
assetListDocument { id }
|
|
}
|
|
}
|
|
}
|
|
`
|
|
|
|
var orgResult struct {
|
|
Node struct {
|
|
ID string `json:"id"`
|
|
AssetListDocument *struct {
|
|
ID string `json:"id"`
|
|
} `json:"assetListDocument"`
|
|
} `json:"node"`
|
|
}
|
|
|
|
err = thirdOwner.Execute(
|
|
orgQuery,
|
|
map[string]any{"id": thirdOwner.GetOrganizationID()},
|
|
&orgResult,
|
|
)
|
|
require.NoError(t, err)
|
|
require.NotNil(t, orgResult.Node.AssetListDocument)
|
|
assert.Equal(t, docID, orgResult.Node.AssetListDocument.ID)
|
|
},
|
|
)
|
|
}
|
|
|
|
func TestAsset_PublishAssetList_RBAC(t *testing.T) {
|
|
t.Parallel()
|
|
|
|
owner := testutil.NewClient(t, testutil.RoleOwner)
|
|
viewer := testutil.NewClientInOrg(t, testutil.RoleViewer, owner)
|
|
|
|
profileID := factory.CreateUser(owner)
|
|
createAssetForPublish(t, owner, profileID, "RBAC Test Asset")
|
|
|
|
const query = `
|
|
mutation($input: PublishAssetListInput!) {
|
|
publishAssetList(input: $input) {
|
|
documentEdge {
|
|
node { id }
|
|
}
|
|
documentVersionEdge {
|
|
node { id }
|
|
}
|
|
}
|
|
}
|
|
`
|
|
|
|
t.Run(
|
|
"viewer cannot publish asset list",
|
|
func(t *testing.T) {
|
|
t.Parallel()
|
|
|
|
err := viewer.ExecuteShouldFail(
|
|
query,
|
|
map[string]any{
|
|
"input": map[string]any{
|
|
"organizationId": owner.GetOrganizationID(),
|
|
},
|
|
},
|
|
)
|
|
testutil.RequireForbiddenError(t, err)
|
|
},
|
|
)
|
|
}
|
|
|
|
func createAssetForPublish(t *testing.T, client *testutil.Client, ownerProfileID string, name string) string {
|
|
t.Helper()
|
|
|
|
const query = `
|
|
mutation($input: CreateAssetInput!) {
|
|
createAsset(input: $input) {
|
|
assetEdge {
|
|
node {
|
|
id
|
|
}
|
|
}
|
|
}
|
|
}
|
|
`
|
|
|
|
var result struct {
|
|
CreateAsset struct {
|
|
AssetEdge struct {
|
|
Node struct {
|
|
ID string `json:"id"`
|
|
} `json:"node"`
|
|
} `json:"assetEdge"`
|
|
} `json:"createAsset"`
|
|
}
|
|
|
|
err := client.Execute(query, map[string]any{
|
|
"input": map[string]any{
|
|
"organizationId": client.GetOrganizationID().String(),
|
|
"name": name,
|
|
"amount": 1,
|
|
"ownerId": ownerProfileID,
|
|
"assetType": "VIRTUAL",
|
|
"dataTypesStored": "Test data types",
|
|
},
|
|
}, &result)
|
|
require.NoError(t, err)
|
|
|
|
return result.CreateAsset.AssetEdge.Node.ID
|
|
}
|