9abea50507
Failed OIDC, magic-link, and SAML sign-ins sent users to /auth/error without the post-login destination, so Sign in dropped OAuth flows and deep links. Propagate a validated continue query through auth error redirects, recover it from OIDC state when the IdP denies or cancels login, and forward it from AuthErrorPage to /auth/login. Signed-off-by: Cursor Agent <cursoragent@cursor.com> Co-authored-by: Bryan FRIMIN <bryan@frimin.fr>
64 lines
2.4 KiB
Go
64 lines
2.4 KiB
Go
// Copyright (c) 2026 Probo Inc <hello@probo.com>.
|
|
//
|
|
// Permission is hereby granted, free of charge, to any person obtaining a copy
|
|
// of this software and associated documentation files (the "Software"), to deal
|
|
// in the Software without restriction, including without limitation the rights
|
|
// to use, copy, modify, merge, publish, distribute, sublicense, and/or sell
|
|
// copies of the Software, and to permit persons to whom the Software is
|
|
// furnished to do so, subject to the following conditions:
|
|
//
|
|
// The above copyright notice and this permission notice shall be included in
|
|
// all copies or substantial portions of the Software.
|
|
//
|
|
// THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
|
|
// IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
|
|
// FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE
|
|
// AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
|
|
// LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
|
|
// OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE
|
|
// SOFTWARE.
|
|
|
|
package connect_v1
|
|
|
|
import (
|
|
"net/http"
|
|
"net/http/httptest"
|
|
"testing"
|
|
|
|
"github.com/stretchr/testify/assert"
|
|
"github.com/stretchr/testify/require"
|
|
)
|
|
|
|
func TestRedirectAuthError(t *testing.T) {
|
|
t.Parallel()
|
|
|
|
req := httptest.NewRequest(http.MethodGet, "/api/connect/v1/oidc/google/callback", nil)
|
|
rec := httptest.NewRecorder()
|
|
|
|
redirectAuthError(rec, req, authErrorPersonalAccountNotAllowed, "")
|
|
|
|
assert.Equal(t, http.StatusFound, rec.Code)
|
|
location, err := rec.Result().Location()
|
|
require.NoError(t, err)
|
|
assert.Equal(t, "/auth/error", location.Path)
|
|
assert.Equal(t, authErrorPersonalAccountNotAllowed, location.Query().Get("error"))
|
|
assert.Empty(t, location.Query().Get("continue"))
|
|
}
|
|
|
|
func TestRedirectAuthErrorWithContinue(t *testing.T) {
|
|
t.Parallel()
|
|
|
|
req := httptest.NewRequest(http.MethodGet, "/api/connect/v1/oidc/google/callback", nil)
|
|
rec := httptest.NewRecorder()
|
|
|
|
continueURL := "/overview"
|
|
redirectAuthError(rec, req, authErrorAuthenticationFailed, continueURL)
|
|
|
|
assert.Equal(t, http.StatusFound, rec.Code)
|
|
location, err := rec.Result().Location()
|
|
require.NoError(t, err)
|
|
assert.Equal(t, "/auth/error", location.Path)
|
|
assert.Equal(t, authErrorAuthenticationFailed, location.Query().Get("error"))
|
|
assert.Equal(t, continueURL, location.Query().Get("continue"))
|
|
}
|