121d4dcf93
Address several provisioning defects that either stalled the retry budget or crashed the process: - Classify CAA resolver/transport failures apart from a real CAA policy denial. Both shared the "caa records" wording, so a transient resolver error was persisted as customer misconfiguration and retried forever without consuming the retry budget. A new ErrCAANotPermitted sentinel now marks the genuine misconfiguration; other CAA errors are treated as ordinary transient failures. - Honor an explicit Retry-After: 0 (or a past date) as permission for an immediate retry instead of promoting it to the one-hour default cooldown. acme.RateLimit collapses zero, invalid, and absent headers to a zero duration, so the header is now parsed directly to tell an explicit zero apart from a missing one. - Reuse already-registered Prometheus collectors when a second ACMEService shares a registerer. The fixed-name collectors were MustRegistered, so a duplicate registration panicked the process. - Persist provisioning failures on a context detached from the process tick deadline. A timed-out attempt reached persistFailure with an expired context, so the write-back failed and the retry budget never advanced, leaving the certificate indefinitely retriable. - Use pgx.StrictNamedArgs in the certificate FOR UPDATE loaders to match the coredata SQL contract. Signed-off-by: Bryan Frimin <bryan@probo.com>
79 lines
2.7 KiB
Go
79 lines
2.7 KiB
Go
// Copyright (c) 2025-2026 Probo Inc <hello@probo.com>.
|
|
//
|
|
// Permission is hereby granted, free of charge, to any person obtaining a copy
|
|
// of this software and associated documentation files (the "Software"), to deal
|
|
// in the Software without restriction, including without limitation the rights
|
|
// to use, copy, modify, merge, publish, distribute, sublicense, and/or sell
|
|
// copies of the Software, and to permit persons to whom the Software is
|
|
// furnished to do so, subject to the following conditions:
|
|
//
|
|
// The above copyright notice and this permission notice shall be included in
|
|
// all copies or substantial portions of the Software.
|
|
//
|
|
// THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
|
|
// IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
|
|
// FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE
|
|
// AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
|
|
// LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
|
|
// OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE
|
|
// SOFTWARE.
|
|
|
|
package certmanager
|
|
|
|
import (
|
|
"errors"
|
|
"strings"
|
|
)
|
|
|
|
const (
|
|
ProvisioningErrorDNSCNAME = "DNS_CNAME"
|
|
ProvisioningErrorDNSCAA = "DNS_CAA"
|
|
ProvisioningErrorACMERateLimited = "ACME_RATE_LIMITED"
|
|
ProvisioningErrorACMEInvalidOrder = "ACME_INVALID_ORDER"
|
|
ProvisioningErrorACMETemporary = "ACME_TEMPORARY"
|
|
ProvisioningErrorACMEFailed = "ACME_FAILED"
|
|
)
|
|
|
|
// ErrCAANotPermitted marks a CAA policy that actively forbids issuance by our
|
|
// CA. This is a customer-side misconfiguration and is intentionally
|
|
// non-terminal. It must stay distinct from a CAA resolver/transport failure,
|
|
// which shares the "caa records" wording but is a transient error that has to
|
|
// consume the normal retry budget instead of retrying forever.
|
|
var ErrCAANotPermitted = errors.New("caa records do not permit issuance")
|
|
|
|
func classifyProvisioningError(err error) string {
|
|
if err == nil {
|
|
return ""
|
|
}
|
|
|
|
if errors.Is(err, ErrACMERateLimited) {
|
|
return ProvisioningErrorACMERateLimited
|
|
}
|
|
|
|
if errors.Is(err, ErrOrderInvalid) {
|
|
return ProvisioningErrorACMEInvalidOrder
|
|
}
|
|
|
|
if errors.Is(err, ErrCAANotPermitted) {
|
|
return ProvisioningErrorDNSCAA
|
|
}
|
|
|
|
msg := strings.ToLower(err.Error())
|
|
switch {
|
|
case strings.Contains(msg, "cname"):
|
|
return ProvisioningErrorDNSCNAME
|
|
case strings.Contains(msg, "status: invalid"), strings.Contains(msg, "order is in unexpected status \"invalid\""):
|
|
return ProvisioningErrorACMEInvalidOrder
|
|
default:
|
|
return ProvisioningErrorACMETemporary
|
|
}
|
|
}
|
|
|
|
func provisioningErrorCodePtr(code string) *string {
|
|
if code == "" {
|
|
return nil
|
|
}
|
|
|
|
return &code
|
|
}
|