8094e7cfd0
Long role strings in the access review table broke row layout when drivers joined many roles into one comma-separated value. Expose roles as a string array in GraphQL by splitting the stored role at the API layer, and render the first three roles as badges with a "+X more" popover for the rest. Closes ENG-459. Signed-off-by: Ludovic Vielle <ludovic@probo.com>
100 lines
3.3 KiB
Go
100 lines
3.3 KiB
Go
// Copyright (c) 2026 Probo Inc <hello@probo.com>.
|
|
//
|
|
// Permission to use, copy, modify, and/or distribute this software for any
|
|
// purpose with or without fee is hereby granted, provided that the above
|
|
// copyright notice and this permission notice appear in all copies.
|
|
//
|
|
// THE SOFTWARE IS PROVIDED "AS IS" AND THE AUTHOR DISCLAIMS ALL WARRANTIES WITH
|
|
// REGARD TO THIS SOFTWARE INCLUDING ALL IMPLIED WARRANTIES OF MERCHANTABILITY
|
|
// AND FITNESS. IN NO EVENT SHALL THE AUTHOR BE LIABLE FOR ANY SPECIAL, DIRECT,
|
|
// INDIRECT, OR CONSEQUENTIAL DAMAGES OR ANY DAMAGES WHATSOEVER RESULTING FROM
|
|
// LOSS OF USE, DATA OR PROFITS, WHETHER IN AN ACTION OF CONTRACT, NEGLIGENCE OR
|
|
// OTHER TORTIOUS ACTION, ARISING OUT OF OR IN CONNECTION WITH THE USE OR
|
|
// PERFORMANCE OF THIS SOFTWARE.
|
|
|
|
package drivers
|
|
|
|
import (
|
|
"context"
|
|
"os"
|
|
"testing"
|
|
|
|
"github.com/stretchr/testify/assert"
|
|
"github.com/stretchr/testify/require"
|
|
)
|
|
|
|
func TestCursorDriver(t *testing.T) {
|
|
t.Parallel()
|
|
|
|
rec := newRecorder(t, "testdata/cursor", "CURSOR_ADMIN_TOKEN")
|
|
// Cursor authenticates via HTTP Basic auth (the admin key as the
|
|
// username). The cassette matcher ignores Authorization, so replay
|
|
// needs no auth; the value matters only when re-recording.
|
|
client := newVCRClient(rec, basicAuth(os.Getenv("CURSOR_ADMIN_TOKEN")))
|
|
|
|
driver := NewCursorDriver(client)
|
|
records, err := driver.ListAccounts(context.Background())
|
|
require.NoError(t, err)
|
|
require.Len(t, records, 4)
|
|
|
|
member := records[0]
|
|
assert.Equal(t, "jane@example.com", member.Email)
|
|
assert.Equal(t, "Jane Doe", member.FullName)
|
|
assert.Equal(t, []string{"Member"}, member.Roles)
|
|
assert.False(t, member.IsAdmin)
|
|
// The Cursor Admin API returns the member id as a string; it is used
|
|
// verbatim as the stable ExternalID.
|
|
assert.Equal(t, "10000001", member.ExternalID)
|
|
require.NotNil(t, member.Active)
|
|
assert.True(t, *member.Active)
|
|
|
|
owner := records[1]
|
|
assert.Equal(t, []string{"Owner"}, owner.Roles)
|
|
assert.True(t, owner.IsAdmin)
|
|
require.NotNil(t, owner.Active)
|
|
assert.True(t, *owner.Active)
|
|
|
|
// A removed member (role "removed", isRemoved true) is still returned,
|
|
// flagged inactive rather than dropped, per the AccountRecord contract.
|
|
removed := records[2]
|
|
assert.Equal(t, []string{"Removed"}, removed.Roles)
|
|
assert.False(t, removed.IsAdmin)
|
|
require.NotNil(t, removed.Active)
|
|
assert.False(t, *removed.Active)
|
|
|
|
// Cursor's two removal signals are not always consistent: a member can
|
|
// carry role "removed" while isRemoved is still false. The role alone
|
|
// must mark the account inactive.
|
|
removedByRole := records[3]
|
|
assert.Equal(t, []string{"Removed"}, removedByRole.Roles)
|
|
assert.False(t, removedByRole.IsAdmin)
|
|
require.NotNil(t, removedByRole.Active)
|
|
assert.False(t, *removedByRole.Active)
|
|
}
|
|
|
|
func TestCursorRoles(t *testing.T) {
|
|
t.Parallel()
|
|
|
|
cases := []struct {
|
|
in string
|
|
want []string
|
|
isAdmin bool
|
|
}{
|
|
{"owner", []string{"Owner"}, true},
|
|
{"free-owner", []string{"Owner"}, true},
|
|
{"member", []string{"Member"}, false},
|
|
{"removed", []string{"Removed"}, false},
|
|
{"unknown_future_role", []string{"unknown_future_role"}, false},
|
|
{"", []string{}, false},
|
|
}
|
|
|
|
for _, c := range cases {
|
|
t.Run(c.in, func(t *testing.T) {
|
|
t.Parallel()
|
|
|
|
assert.Equal(t, c.want, cursorRoles(c.in))
|
|
assert.Equal(t, c.isAdmin, cursorIsAdmin(c.in))
|
|
})
|
|
}
|
|
}
|