From f83b42d2ec816d082f07833af09bd304d8041018 Mon Sep 17 00:00:00 2001 From: Sacha Al Himdani Date: Fri, 3 Jul 2026 16:55:31 +0200 Subject: [PATCH] Rename signature filter state field to profileState The DocumentVersionSignatureFilter exposed a field named `state` that actually filters on the signatory's profile state, which was ambiguous next to the signature `states` field. Rename it to `profileState` (GraphQL) / `profile_state` (MCP) across the schema, spec, resolvers, console app, and n8n node for clarity. Signed-off-by: Sacha Al Himdani --- .../src/pages/organizations/documents/DocumentLayout.tsx | 8 ++++---- .../documents/_components/DocumentListItem.tsx | 4 ++-- .../signatures/_components/DocumentSignatureList.tsx | 4 ++-- .../Probo/actions/document/getAllSignatures.operation.ts | 2 +- pkg/coredata/document_version_signature_filter.go | 8 ++++---- pkg/server/api/console/v1/document_resolvers.go | 4 ++-- pkg/server/api/console/v1/graphql/document.graphql | 2 +- pkg/server/api/mcp/v1/schema.resolvers.go | 4 ++-- pkg/server/api/mcp/v1/specification.yaml | 2 +- 9 files changed, 19 insertions(+), 19 deletions(-) diff --git a/apps/console/src/pages/organizations/documents/DocumentLayout.tsx b/apps/console/src/pages/organizations/documents/DocumentLayout.tsx index 396351264..6a9953f67 100644 --- a/apps/console/src/pages/organizations/documents/DocumentLayout.tsx +++ b/apps/console/src/pages/organizations/documents/DocumentLayout.tsx @@ -40,10 +40,10 @@ export const documentLayoutQuery = graphql` ...DocumentTitleFormFragment ...DocumentActionsDropdown_versionFragment ...DocumentDetailsCard_versionFragment - signatures(first: 0 filter: { activeContract: true, state: ACTIVE }) { + signatures(first: 0 filter: { activeContract: true, profileState: ACTIVE }) { totalCount } - signedSignatures: signatures(first: 0 filter: { states: [SIGNED], activeContract: true, state: ACTIVE }) { + signedSignatures: signatures(first: 0 filter: { states: [SIGNED], activeContract: true, profileState: ACTIVE }) { totalCount } approvalQuorums(first: 1, orderBy: { field: CREATED_AT, direction: DESC }) { @@ -85,10 +85,10 @@ export const documentLayoutQuery = graphql` ...DocumentTitleFormFragment ...DocumentActionsDropdown_versionFragment ...DocumentDetailsCard_versionFragment - signatures(first: 0 filter: { activeContract: true, state: ACTIVE }) { + signatures(first: 0 filter: { activeContract: true, profileState: ACTIVE }) { totalCount } - signedSignatures: signatures(first: 0 filter: { states: [SIGNED], activeContract: true, state: ACTIVE }) { + signedSignatures: signatures(first: 0 filter: { states: [SIGNED], activeContract: true, profileState: ACTIVE }) { totalCount } approvalQuorums(first: 1, orderBy: { field: CREATED_AT, direction: DESC }) { diff --git a/apps/console/src/pages/organizations/documents/_components/DocumentListItem.tsx b/apps/console/src/pages/organizations/documents/_components/DocumentListItem.tsx index eab9d498b..60508ca1b 100644 --- a/apps/console/src/pages/organizations/documents/_components/DocumentListItem.tsx +++ b/apps/console/src/pages/organizations/documents/_components/DocumentListItem.tsx @@ -78,10 +78,10 @@ const fragment = graphql` } } } - signatures(first: 0 filter: { activeContract: true, state: ACTIVE }) { + signatures(first: 0 filter: { activeContract: true, profileState: ACTIVE }) { totalCount } - signedSignatures: signatures(first: 0 filter: { states: [SIGNED], activeContract: true, state: ACTIVE }) { + signedSignatures: signatures(first: 0 filter: { states: [SIGNED], activeContract: true, profileState: ACTIVE }) { totalCount } } diff --git a/apps/console/src/pages/organizations/documents/signatures/_components/DocumentSignatureList.tsx b/apps/console/src/pages/organizations/documents/signatures/_components/DocumentSignatureList.tsx index ce7af2539..06befd3b6 100644 --- a/apps/console/src/pages/organizations/documents/signatures/_components/DocumentSignatureList.tsx +++ b/apps/console/src/pages/organizations/documents/signatures/_components/DocumentSignatureList.tsx @@ -29,7 +29,7 @@ const versionFragment = graphql` @argumentDefinitions( count: { type: "Int", defaultValue: 1000 } cursor: { type: "CursorKey" } - signatureFilter: { type: "DocumentVersionSignatureFilter", defaultValue: { activeContract: true, state: ACTIVE } } + signatureFilter: { type: "DocumentVersionSignatureFilter", defaultValue: { activeContract: true, profileState: ACTIVE } } ) { ...DocumentSignaturePlaceholder_versionFragment signatures(first: $count, after: $cursor, filter: $signatureFilter) @@ -104,7 +104,7 @@ export function DocumentSignatureList(props: { const filter = { activeContract: true, - state: "ACTIVE" as const, + profileState: "ACTIVE" as const, ...(selectedStates.length > 0 ? { states: selectedStates } : {}), }; diff --git a/packages/n8n-node/nodes/Probo/actions/document/getAllSignatures.operation.ts b/packages/n8n-node/nodes/Probo/actions/document/getAllSignatures.operation.ts index 98b394b9d..5e7062445 100644 --- a/packages/n8n-node/nodes/Probo/actions/document/getAllSignatures.operation.ts +++ b/packages/n8n-node/nodes/Probo/actions/document/getAllSignatures.operation.ts @@ -119,7 +119,7 @@ export async function execute( const filter: IDataObject = {}; if ((filters.states as string[])?.length) filter.states = filters.states; if (filters.activeContract !== undefined) filter.activeContract = filters.activeContract; - if (filters.state) filter.state = filters.state; + if (filters.state) filter.profileState = filters.state; const hasFilter = Object.keys(filter).length > 0; diff --git a/pkg/coredata/document_version_signature_filter.go b/pkg/coredata/document_version_signature_filter.go index ef9849cea..6368d8664 100644 --- a/pkg/coredata/document_version_signature_filter.go +++ b/pkg/coredata/document_version_signature_filter.go @@ -22,15 +22,15 @@ type ( DocumentVersionSignatureFilter struct { states DocumentVersionSignatureStates activeContract *bool - state *ProfileState + profileState *ProfileState } ) -func NewDocumentVersionSignatureFilter(states []DocumentVersionSignatureState, activeContract *bool, state *ProfileState) *DocumentVersionSignatureFilter { +func NewDocumentVersionSignatureFilter(states []DocumentVersionSignatureState, activeContract *bool, profileState *ProfileState) *DocumentVersionSignatureFilter { return &DocumentVersionSignatureFilter{ states: DocumentVersionSignatureStates(states), activeContract: activeContract, - state: state, + profileState: profileState, } } @@ -38,7 +38,7 @@ func (f *DocumentVersionSignatureFilter) SQLArguments() pgx.StrictNamedArgs { return pgx.StrictNamedArgs{ "states": f.states, "active_contract": f.activeContract, - "profile_state": f.state, + "profile_state": f.profileState, } } diff --git a/pkg/server/api/console/v1/document_resolvers.go b/pkg/server/api/console/v1/document_resolvers.go index 7dba7929c..b8c77fd49 100644 --- a/pkg/server/api/console/v1/document_resolvers.go +++ b/pkg/server/api/console/v1/document_resolvers.go @@ -294,8 +294,8 @@ func (r *documentVersionResolver) Signatures(ctx context.Context, obj *types.Doc activeContract = filter.ActiveContract } - if filter.State != nil { - profileState = filter.State + if filter.ProfileState != nil { + profileState = filter.ProfileState } } diff --git a/pkg/server/api/console/v1/graphql/document.graphql b/pkg/server/api/console/v1/graphql/document.graphql index 88a9d4f69..cb06e7630 100644 --- a/pkg/server/api/console/v1/graphql/document.graphql +++ b/pkg/server/api/console/v1/graphql/document.graphql @@ -247,7 +247,7 @@ input DocumentVersionSignatureOrder { input DocumentVersionSignatureFilter { states: [DocumentVersionSignatureState!] activeContract: Boolean - state: ProfileState + profileState: ProfileState } input DocumentVersionApprovalQuorumOrder { diff --git a/pkg/server/api/mcp/v1/schema.resolvers.go b/pkg/server/api/mcp/v1/schema.resolvers.go index 2414b14a2..8377aa095 100644 --- a/pkg/server/api/mcp/v1/schema.resolvers.go +++ b/pkg/server/api/mcp/v1/schema.resolvers.go @@ -2407,8 +2407,8 @@ func (r *Resolver) ListDocumentVersionSignaturesTool(ctx context.Context, req *m activeContract = input.Filter.ActiveContract } - if input.Filter.State != nil { - profileState = input.Filter.State + if input.Filter.ProfileState != nil { + profileState = input.Filter.ProfileState } } diff --git a/pkg/server/api/mcp/v1/specification.yaml b/pkg/server/api/mcp/v1/specification.yaml index 94d7660e3..2a7280f50 100644 --- a/pkg/server/api/mcp/v1/specification.yaml +++ b/pkg/server/api/mcp/v1/specification.yaml @@ -6376,7 +6376,7 @@ components: active_contract: type: boolean description: Signatory contract status - state: + profile_state: $ref: "#/components/schemas/ProfileState" description: Signatory profile state