Cancel signature requests on deactivation
Disabling a profile now removes pending document signature requests tied to that signatory. This keeps inactive accounts from retaining signature work across manual, archived, and SCIM deactivation flows. Signed-off-by: Cursor Agent <cursoragent@cursor.com> Co-authored-by: Bryan FRIMIN <bryan@frimin.fr>
This commit is contained in:
committed by
Bryan Frimin
parent
122bc02a23
commit
f7309c642a
@@ -321,6 +321,114 @@ func TestUser_ArchiveUser(t *testing.T) {
|
||||
assert.Equal(t, "INACTIVE", archivedUserState)
|
||||
}
|
||||
|
||||
func TestUser_DeactivateUserCancelsSignatureRequests(t *testing.T) {
|
||||
t.Parallel()
|
||||
owner := testutil.NewClient(t, testutil.RoleOwner)
|
||||
signer := testutil.NewClientInOrg(t, testutil.RoleViewer, owner)
|
||||
|
||||
docID, _ := createTestDocument(t, owner)
|
||||
approveTestDocument(t, owner, docID)
|
||||
|
||||
var versionResult struct {
|
||||
Node struct {
|
||||
Versions struct {
|
||||
Edges []struct {
|
||||
Node struct {
|
||||
ID string `json:"id"`
|
||||
} `json:"node"`
|
||||
} `json:"edges"`
|
||||
} `json:"versions"`
|
||||
} `json:"node"`
|
||||
}
|
||||
|
||||
err := owner.Execute(`
|
||||
query($id: ID!) {
|
||||
node(id: $id) {
|
||||
... on Document {
|
||||
versions(first: 1, orderBy: { field: CREATED_AT, direction: DESC }) {
|
||||
edges { node { id } }
|
||||
}
|
||||
}
|
||||
}
|
||||
}
|
||||
`, map[string]any{"id": docID}, &versionResult)
|
||||
require.NoError(t, err)
|
||||
require.NotEmpty(t, versionResult.Node.Versions.Edges)
|
||||
|
||||
documentVersionID := versionResult.Node.Versions.Edges[0].Node.ID
|
||||
signerProfileID := signer.GetProfileID().String()
|
||||
|
||||
_, err = owner.Do(`
|
||||
mutation($input: RequestSignatureInput!) {
|
||||
requestSignature(input: $input) {
|
||||
documentVersionSignatureEdge { node { id } }
|
||||
}
|
||||
}
|
||||
`, map[string]any{
|
||||
"input": map[string]any{
|
||||
"documentVersionId": documentVersionID,
|
||||
"signatoryId": signerProfileID,
|
||||
},
|
||||
})
|
||||
require.NoError(t, err)
|
||||
|
||||
assertRequestedSignatureCount(t, owner, documentVersionID, 1)
|
||||
|
||||
var deactivateResult struct {
|
||||
DeactivateUser struct {
|
||||
Success bool `json:"success"`
|
||||
} `json:"deactivateUser"`
|
||||
}
|
||||
|
||||
err = owner.ExecuteConnect(`
|
||||
mutation($input: DeactivateUserInput!) {
|
||||
deactivateUser(input: $input) {
|
||||
success
|
||||
}
|
||||
}
|
||||
`, map[string]any{
|
||||
"input": map[string]any{
|
||||
"organizationId": owner.GetOrganizationID().String(),
|
||||
"profileId": signerProfileID,
|
||||
},
|
||||
}, &deactivateResult)
|
||||
require.NoError(t, err)
|
||||
require.True(t, deactivateResult.DeactivateUser.Success)
|
||||
|
||||
assertRequestedSignatureCount(t, owner, documentVersionID, 0)
|
||||
}
|
||||
|
||||
func assertRequestedSignatureCount(
|
||||
t *testing.T,
|
||||
owner *testutil.Client,
|
||||
documentVersionID string,
|
||||
expected int,
|
||||
) {
|
||||
t.Helper()
|
||||
|
||||
var result struct {
|
||||
Node struct {
|
||||
Signatures struct {
|
||||
TotalCount int `json:"totalCount"`
|
||||
} `json:"signatures"`
|
||||
} `json:"node"`
|
||||
}
|
||||
|
||||
err := owner.Execute(`
|
||||
query($id: ID!) {
|
||||
node(id: $id) {
|
||||
... on DocumentVersion {
|
||||
signatures(first: 10, filter: { states: [REQUESTED] }) {
|
||||
totalCount
|
||||
}
|
||||
}
|
||||
}
|
||||
}
|
||||
`, map[string]any{"id": documentVersionID}, &result)
|
||||
require.NoError(t, err)
|
||||
assert.Equal(t, expected, result.Node.Signatures.TotalCount)
|
||||
}
|
||||
|
||||
func TestUser_RemoveOwner(t *testing.T) {
|
||||
t.Parallel()
|
||||
owner := testutil.NewClient(t, testutil.RoleOwner)
|
||||
|
||||
Reference in New Issue
Block a user