Enforce Go style rules across codebase

Apply five style rules: convert iota string enums to typed
string constants, replace errors.As with errors.AsType,
merge three-group imports into two groups, fix multiline
parameter/argument formatting, and replace fmt.Sprintf URL
construction with net/url.

Signed-off-by: Émile Ré <emile@probo.com>
This commit is contained in:
Émile Ré
2026-05-20 11:46:39 +04:00
parent 34c25c2727
commit f5703d390b
105 changed files with 1180 additions and 940 deletions

View File

@@ -67,10 +67,21 @@ type bitbucketMembersPage struct {
func (d *BitbucketDriver) ListAccounts(ctx context.Context) ([]AccountRecord, error) {
var records []AccountRecord
next := fmt.Sprintf(
"https://api.bitbucket.org/2.0/workspaces/%s/members?fields=%%2Bvalues.user.email&pagelen=100",
url.PathEscape(d.workspace),
)
u, err := url.JoinPath("https://api.bitbucket.org", "2.0", "workspaces", d.workspace, "members")
if err != nil {
return nil, fmt.Errorf("cannot build bitbucket members URL: %w", err)
}
parsed, err := url.Parse(u)
if err != nil {
return nil, fmt.Errorf("cannot parse bitbucket members URL: %w", err)
}
q := parsed.Query()
q.Set("fields", "+values.user.email")
q.Set("pagelen", "100")
parsed.RawQuery = q.Encode()
next := parsed.String()
for range maxPaginationPages {
page, err := d.queryMembers(ctx, next)