Enforce Go style rules across codebase

Apply five style rules: convert iota string enums to typed
string constants, replace errors.As with errors.AsType,
merge three-group imports into two groups, fix multiline
parameter/argument formatting, and replace fmt.Sprintf URL
construction with net/url.

Signed-off-by: Émile Ré <emile@probo.com>
This commit is contained in:
Émile Ré
2026-05-20 11:46:39 +04:00
parent 34c25c2727
commit f5703d390b
105 changed files with 1180 additions and 940 deletions

BIN
dump.dump Normal file

Binary file not shown.

View File

@@ -385,51 +385,67 @@ func (s AccessSourceService) ConfigureAccessSource(
switch dbConnector.Provider {
case coredata.ConnectorProviderGitHub:
if err := dbConnector.SetSettings(&coredata.GitHubConnectorSettings{
Organization: req.OrganizationSlug,
}); err != nil {
if err := dbConnector.SetSettings(
&coredata.GitHubConnectorSettings{
Organization: req.OrganizationSlug,
},
); err != nil {
return fmt.Errorf("cannot set github settings: %w", err)
}
case coredata.ConnectorProviderSentry:
if err := dbConnector.SetSettings(&coredata.SentryConnectorSettings{
OrganizationSlug: req.OrganizationSlug,
}); err != nil {
if err := dbConnector.SetSettings(
&coredata.SentryConnectorSettings{
OrganizationSlug: req.OrganizationSlug,
},
); err != nil {
return fmt.Errorf("cannot set sentry settings: %w", err)
}
case coredata.ConnectorProviderGitLab:
if err := dbConnector.SetSettings(&coredata.GitLabConnectorSettings{
GroupID: req.OrganizationSlug,
}); err != nil {
if err := dbConnector.SetSettings(
&coredata.GitLabConnectorSettings{
GroupID: req.OrganizationSlug,
},
); err != nil {
return fmt.Errorf("cannot set gitlab settings: %w", err)
}
case coredata.ConnectorProviderBitbucket:
if err := dbConnector.SetSettings(&coredata.BitbucketConnectorSettings{
Workspace: req.OrganizationSlug,
}); err != nil {
if err := dbConnector.SetSettings(
&coredata.BitbucketConnectorSettings{
Workspace: req.OrganizationSlug,
},
); err != nil {
return fmt.Errorf("cannot set bitbucket settings: %w", err)
}
case coredata.ConnectorProviderHeroku:
if err := dbConnector.SetSettings(&coredata.HerokuConnectorSettings{
TeamID: req.OrganizationSlug,
}); err != nil {
if err := dbConnector.SetSettings(
&coredata.HerokuConnectorSettings{
TeamID: req.OrganizationSlug,
},
); err != nil {
return fmt.Errorf("cannot set heroku settings: %w", err)
}
case coredata.ConnectorProviderAsana:
if err := dbConnector.SetSettings(&coredata.AsanaConnectorSettings{
WorkspaceGID: req.OrganizationSlug,
}); err != nil {
if err := dbConnector.SetSettings(
&coredata.AsanaConnectorSettings{
WorkspaceGID: req.OrganizationSlug,
},
); err != nil {
return fmt.Errorf("cannot set asana settings: %w", err)
}
case coredata.ConnectorProviderNetlify:
if err := dbConnector.SetSettings(&coredata.NetlifyConnectorSettings{
AccountSlug: req.OrganizationSlug,
}); err != nil {
if err := dbConnector.SetSettings(
&coredata.NetlifyConnectorSettings{
AccountSlug: req.OrganizationSlug,
},
); err != nil {
return fmt.Errorf("cannot set netlify settings: %w", err)
}
case coredata.ConnectorProviderClickUp:
if err := dbConnector.SetSettings(&coredata.ClickUpConnectorSettings{
TeamID: req.OrganizationSlug,
}); err != nil {
if err := dbConnector.SetSettings(
&coredata.ClickUpConnectorSettings{
TeamID: req.OrganizationSlug,
},
); err != nil {
return fmt.Errorf("cannot set clickup settings: %w", err)
}
default:

View File

@@ -67,10 +67,21 @@ type asanaUsersPage struct {
func (d *AsanaDriver) ListAccounts(ctx context.Context) ([]AccountRecord, error) {
var records []AccountRecord
next := fmt.Sprintf(
"https://app.asana.com/api/1.0/workspaces/%s/users?opt_fields=email,name&limit=100",
url.PathEscape(d.workspaceGID),
)
u, err := url.JoinPath("https://app.asana.com", "api", "1.0", "workspaces", d.workspaceGID, "users")
if err != nil {
return nil, fmt.Errorf("cannot build asana users URL: %w", err)
}
parsed, err := url.Parse(u)
if err != nil {
return nil, fmt.Errorf("cannot parse asana users URL: %w", err)
}
q := parsed.Query()
q.Set("opt_fields", "email,name")
q.Set("limit", "100")
parsed.RawQuery = q.Encode()
next := parsed.String()
for range maxPaginationPages {
page, err := d.queryUsers(ctx, next)
@@ -85,14 +96,17 @@ func (d *AsanaDriver) ListAccounts(ctx context.Context) ([]AccountRecord, error)
// Active=false from any of those would fabricate state, so
// leave Active nil (unknown) and let downstream review surface
// the gap honestly.
records = append(records, AccountRecord{
Email: u.Email,
FullName: u.Name,
ExternalID: u.GID,
MFAStatus: coredata.MFAStatusUnknown,
AuthMethod: coredata.AccessEntryAuthMethodUnknown,
AccountType: coredata.AccessEntryAccountTypeUser,
})
records = append(
records,
AccountRecord{
Email: u.Email,
FullName: u.Name,
ExternalID: u.GID,
MFAStatus: coredata.MFAStatusUnknown,
AuthMethod: coredata.AccessEntryAuthMethodUnknown,
AccountType: coredata.AccessEntryAccountTypeUser,
},
)
}
if page.NextPage == nil || page.NextPage.URI == "" {

View File

@@ -67,10 +67,21 @@ type bitbucketMembersPage struct {
func (d *BitbucketDriver) ListAccounts(ctx context.Context) ([]AccountRecord, error) {
var records []AccountRecord
next := fmt.Sprintf(
"https://api.bitbucket.org/2.0/workspaces/%s/members?fields=%%2Bvalues.user.email&pagelen=100",
url.PathEscape(d.workspace),
)
u, err := url.JoinPath("https://api.bitbucket.org", "2.0", "workspaces", d.workspace, "members")
if err != nil {
return nil, fmt.Errorf("cannot build bitbucket members URL: %w", err)
}
parsed, err := url.Parse(u)
if err != nil {
return nil, fmt.Errorf("cannot parse bitbucket members URL: %w", err)
}
q := parsed.Query()
q.Set("fields", "+values.user.email")
q.Set("pagelen", "100")
parsed.RawQuery = q.Encode()
next := parsed.String()
for range maxPaginationPages {
page, err := d.queryMembers(ctx, next)

View File

@@ -71,7 +71,10 @@ type clickupTeamResponse struct {
}
func (d *ClickUpDriver) ListAccounts(ctx context.Context) ([]AccountRecord, error) {
endpoint := fmt.Sprintf("https://api.clickup.com/api/v2/team/%s", url.PathEscape(d.teamID))
endpoint, err := url.JoinPath("https://api.clickup.com", "api", "v2", "team", d.teamID)
if err != nil {
return nil, fmt.Errorf("cannot build clickup team URL: %w", err)
}
req, err := http.NewRequestWithContext(ctx, http.MethodGet, endpoint, nil)
if err != nil {

View File

@@ -19,6 +19,8 @@ import (
"encoding/json"
"fmt"
"net/http"
"net/url"
"strconv"
"strings"
"go.probo.inc/probo/pkg/coredata"
@@ -114,12 +116,17 @@ func (d *CloudflareDriver) queryAllAccounts(ctx context.Context) ([]cloudflareAc
}
func (d *CloudflareDriver) queryAccounts(ctx context.Context, page int) (*cloudflareListAccountsResponse, error) {
url := fmt.Sprintf(
"https://api.cloudflare.com/client/v4/accounts?page=%d&per_page=50",
page,
)
parsed, err := url.Parse("https://api.cloudflare.com/client/v4/accounts")
if err != nil {
return nil, fmt.Errorf("cannot parse cloudflare accounts URL: %w", err)
}
req, err := http.NewRequestWithContext(ctx, http.MethodGet, url, nil)
q := parsed.Query()
q.Set("page", strconv.Itoa(page))
q.Set("per_page", "50")
parsed.RawQuery = q.Encode()
req, err := http.NewRequestWithContext(ctx, http.MethodGet, parsed.String(), nil)
if err != nil {
return nil, fmt.Errorf("cannot create cloudflare accounts request: %w", err)
}
@@ -208,13 +215,22 @@ func (d *CloudflareDriver) queryAllMembers(ctx context.Context, accountID string
}
func (d *CloudflareDriver) queryMembers(ctx context.Context, accountID string, page int) (*cloudflareListMembersResponse, error) {
url := fmt.Sprintf(
"https://api.cloudflare.com/client/v4/accounts/%s/members?page=%d&per_page=50",
accountID,
page,
)
u, err := url.JoinPath("https://api.cloudflare.com", "client", "v4", "accounts", accountID, "members")
if err != nil {
return nil, fmt.Errorf("cannot build cloudflare members URL: %w", err)
}
req, err := http.NewRequestWithContext(ctx, http.MethodGet, url, nil)
parsed, err := url.Parse(u)
if err != nil {
return nil, fmt.Errorf("cannot parse cloudflare members URL: %w", err)
}
q := parsed.Query()
q.Set("page", strconv.Itoa(page))
q.Set("per_page", "50")
parsed.RawQuery = q.Encode()
req, err := http.NewRequestWithContext(ctx, http.MethodGet, parsed.String(), nil)
if err != nil {
return nil, fmt.Errorf("cannot create cloudflare members request: %w", err)
}

View File

@@ -19,6 +19,7 @@ import (
"encoding/json"
"fmt"
"net/http"
"net/url"
"strconv"
"strings"
"time"
@@ -179,10 +180,23 @@ func (d *DocuSignDriver) discoverAccount(ctx context.Context) (accountID string,
}
func (d *DocuSignDriver) queryUsers(ctx context.Context, baseURI string, accountID string, startPosition int) (*docusignUsersResponse, error) {
url := fmt.Sprintf("%s/restapi/v2.1/accounts/%s/users?additional_info=true&count=%d&start_position=%d",
baseURI, accountID, docusignUsersPageSize, startPosition)
u, err := url.JoinPath(baseURI, "restapi", "v2.1", "accounts", accountID, "users")
if err != nil {
return nil, fmt.Errorf("cannot build docusign users URL: %w", err)
}
req, err := http.NewRequestWithContext(ctx, http.MethodGet, url, nil)
parsed, err := url.Parse(u)
if err != nil {
return nil, fmt.Errorf("cannot parse docusign users URL: %w", err)
}
q := parsed.Query()
q.Set("additional_info", "true")
q.Set("count", strconv.Itoa(docusignUsersPageSize))
q.Set("start_position", strconv.Itoa(startPosition))
parsed.RawQuery = q.Encode()
req, err := http.NewRequestWithContext(ctx, http.MethodGet, parsed.String(), nil)
if err != nil {
return nil, fmt.Errorf("cannot create docusign users request: %w", err)
}

View File

@@ -19,6 +19,7 @@ import (
"encoding/json"
"fmt"
"net/http"
"net/url"
"strconv"
"time"
@@ -82,7 +83,9 @@ func (d *GitHubDriver) ListAccounts(ctx context.Context) ([]AccountRecord, error
for _, m := range members {
membership, err := d.fetchMembership(ctx, m.Login)
if err != nil {
d.logger.WarnCtx(ctx, "cannot fetch github membership, skipping member",
d.logger.WarnCtx(
ctx,
"cannot fetch github membership, skipping member",
log.Error(err),
)
@@ -91,7 +94,9 @@ func (d *GitHubDriver) ListAccounts(ctx context.Context) ([]AccountRecord, error
profile, err := d.fetchUserProfile(ctx, m.Login)
if err != nil {
d.logger.WarnCtx(ctx, "cannot fetch github user profile, skipping member",
d.logger.WarnCtx(
ctx,
"cannot fetch github user profile, skipping member",
log.Error(err),
)
@@ -145,13 +150,23 @@ func (d *GitHubDriver) ListAccounts(ctx context.Context) ([]AccountRecord, error
func (d *GitHubDriver) fetchAllMembers(ctx context.Context) ([]githubMember, error) {
var members []githubMember
url := fmt.Sprintf(
"https://api.github.com/orgs/%s/members?per_page=100",
d.org,
)
u, err := url.JoinPath("https://api.github.com", "orgs", d.org, "members")
if err != nil {
return nil, fmt.Errorf("cannot build github members URL: %w", err)
}
parsed, err := url.Parse(u)
if err != nil {
return nil, fmt.Errorf("cannot parse github members URL: %w", err)
}
q := parsed.Query()
q.Set("per_page", "100")
parsed.RawQuery = q.Encode()
endpoint := parsed.String()
for range maxPaginationPages {
page, nextURL, err := d.fetchMembersPage(ctx, url)
page, nextURL, err := d.fetchMembersPage(ctx, endpoint)
if err != nil {
return nil, err
}
@@ -162,7 +177,7 @@ func (d *GitHubDriver) fetchAllMembers(ctx context.Context) ([]githubMember, err
return members, nil
}
url = nextURL
endpoint = nextURL
}
return nil, fmt.Errorf("cannot list all github members: %w", ErrPaginationLimitReached)
@@ -202,13 +217,24 @@ func (d *GitHubDriver) fetchMembersPage(ctx context.Context, url string) ([]gith
func (d *GitHubDriver) fetchAll2FADisabledLogins(ctx context.Context) (map[string]bool, error) {
set := make(map[string]bool)
url := fmt.Sprintf(
"https://api.github.com/orgs/%s/members?filter=2fa_disabled&per_page=100",
d.org,
)
u, err := url.JoinPath("https://api.github.com", "orgs", d.org, "members")
if err != nil {
return nil, fmt.Errorf("cannot build github 2fa-disabled URL: %w", err)
}
parsed, err := url.Parse(u)
if err != nil {
return nil, fmt.Errorf("cannot parse github 2fa-disabled URL: %w", err)
}
q := parsed.Query()
q.Set("filter", "2fa_disabled")
q.Set("per_page", "100")
parsed.RawQuery = q.Encode()
endpoint := parsed.String()
for range maxPaginationPages {
page, nextURL, err := d.fetchMembersPage(ctx, url)
page, nextURL, err := d.fetchMembersPage(ctx, endpoint)
if err != nil {
return nil, err
}
@@ -221,20 +247,19 @@ func (d *GitHubDriver) fetchAll2FADisabledLogins(ctx context.Context) (map[strin
return set, nil
}
url = nextURL
endpoint = nextURL
}
return nil, fmt.Errorf("cannot list all github 2fa-disabled members: %w", ErrPaginationLimitReached)
}
func (d *GitHubDriver) fetchMembership(ctx context.Context, login string) (*githubMembership, error) {
url := fmt.Sprintf(
"https://api.github.com/orgs/%s/memberships/%s",
d.org,
login,
)
endpoint, err := url.JoinPath("https://api.github.com", "orgs", d.org, "memberships", login)
if err != nil {
return nil, fmt.Errorf("cannot build github membership URL: %w", err)
}
req, err := http.NewRequestWithContext(ctx, http.MethodGet, url, nil)
req, err := http.NewRequestWithContext(ctx, http.MethodGet, endpoint, nil)
if err != nil {
return nil, fmt.Errorf("cannot create github membership request: %w", err)
}
@@ -263,9 +288,12 @@ func (d *GitHubDriver) fetchMembership(ctx context.Context, login string) (*gith
}
func (d *GitHubDriver) fetchUserProfile(ctx context.Context, login string) (*githubUserProfile, error) {
url := fmt.Sprintf("https://api.github.com/users/%s", login)
endpoint, err := url.JoinPath("https://api.github.com", "users", login)
if err != nil {
return nil, fmt.Errorf("cannot build github user profile URL: %w", err)
}
req, err := http.NewRequestWithContext(ctx, http.MethodGet, url, nil)
req, err := http.NewRequestWithContext(ctx, http.MethodGet, endpoint, nil)
if err != nil {
return nil, fmt.Errorf("cannot create github user profile request: %w", err)
}

View File

@@ -67,10 +67,20 @@ type gitlabMember struct {
func (d *GitLabDriver) ListAccounts(ctx context.Context) ([]AccountRecord, error) {
var records []AccountRecord
next := fmt.Sprintf(
"https://gitlab.com/api/v4/groups/%s/members/all?per_page=100",
url.PathEscape(d.groupID),
)
u, err := url.JoinPath("https://gitlab.com", "api", "v4", "groups", d.groupID, "members", "all")
if err != nil {
return nil, fmt.Errorf("cannot build gitlab members URL: %w", err)
}
parsed, err := url.Parse(u)
if err != nil {
return nil, fmt.Errorf("cannot parse gitlab members URL: %w", err)
}
q := parsed.Query()
q.Set("per_page", "100")
parsed.RawQuery = q.Encode()
next := parsed.String()
for range maxPaginationPages {
members, linkHeader, err := d.queryMembers(ctx, next)

View File

@@ -21,7 +21,6 @@ import (
"github.com/stretchr/testify/assert"
"github.com/stretchr/testify/require"
"go.probo.inc/probo/pkg/coredata"
)

View File

@@ -22,10 +22,9 @@ import (
"net/http"
"time"
"go.probo.inc/probo/pkg/coredata"
admin "google.golang.org/api/admin/directory/v1"
"google.golang.org/api/option"
"go.probo.inc/probo/pkg/coredata"
)
// GoogleWorkspaceDriver fetches user accounts from Google Workspace

View File

@@ -72,7 +72,10 @@ type herokuTeamMember struct {
func (d *HerokuDriver) ListAccounts(ctx context.Context) ([]AccountRecord, error) {
var records []AccountRecord
endpoint := fmt.Sprintf("https://api.heroku.com/teams/%s/members", url.PathEscape(d.teamID))
endpoint, err := url.JoinPath("https://api.heroku.com", "teams", d.teamID, "members")
if err != nil {
return nil, fmt.Errorf("cannot build heroku members URL: %w", err)
}
rangeHeader := ""
for range maxPaginationPages {

View File

@@ -21,7 +21,6 @@ import (
"github.com/stretchr/testify/assert"
"github.com/stretchr/testify/require"
"go.probo.inc/probo/pkg/coredata"
)

View File

@@ -248,7 +248,12 @@ func (d *Microsoft365Driver) listUsers(ctx context.Context) ([]microsoft365User,
}
func buildMicrosoft365UsersURL() (string, error) {
u, err := url.Parse(microsoft365GraphBaseURL + "/users")
endpoint, err := url.JoinPath(microsoft365GraphBaseURL, "users")
if err != nil {
return "", fmt.Errorf("cannot build graph users URL: %w", err)
}
u, err := url.Parse(endpoint)
if err != nil {
return "", fmt.Errorf("cannot parse graph users URL: %w", err)
}
@@ -263,13 +268,16 @@ func buildMicrosoft365UsersURL() (string, error) {
}
func (d *Microsoft365Driver) listDirectoryRoles(ctx context.Context) ([]microsoft365DirectoryRole, error) {
url := fmt.Sprintf("%s/directoryRoles", microsoft365GraphBaseURL)
endpoint, err := url.JoinPath(microsoft365GraphBaseURL, "directoryRoles")
if err != nil {
return nil, fmt.Errorf("cannot build graph directory roles URL: %w", err)
}
var all []microsoft365DirectoryRole
for range microsoft365MaxPaginationOK {
var page microsoft365RolesPage
if err := d.fetchJSON(ctx, url, &page); err != nil {
if err := d.fetchJSON(ctx, endpoint, &page); err != nil {
return nil, err
}
@@ -278,20 +286,23 @@ func (d *Microsoft365Driver) listDirectoryRoles(ctx context.Context) ([]microsof
return all, nil
}
url = page.NextLink
endpoint = page.NextLink
}
return nil, fmt.Errorf("cannot list all microsoft 365 directory roles: %w", ErrPaginationLimitReached)
}
func (d *Microsoft365Driver) listRoleMembers(ctx context.Context, roleID string) ([]microsoft365RoleMember, error) {
url := fmt.Sprintf("%s/directoryRoles/%s/members", microsoft365GraphBaseURL, roleID)
endpoint, err := url.JoinPath(microsoft365GraphBaseURL, "directoryRoles", roleID, "members")
if err != nil {
return nil, fmt.Errorf("cannot build graph role members URL: %w", err)
}
var all []microsoft365RoleMember
for range microsoft365MaxPaginationOK {
var page microsoft365MembersPage
if err := d.fetchJSON(ctx, url, &page); err != nil {
if err := d.fetchJSON(ctx, endpoint, &page); err != nil {
return nil, err
}
@@ -300,7 +311,7 @@ func (d *Microsoft365Driver) listRoleMembers(ctx context.Context, roleID string)
return all, nil
}
url = page.NextLink
endpoint = page.NextLink
}
return nil, fmt.Errorf("cannot list all members of role %q: %w", roleID, ErrPaginationLimitReached)

View File

@@ -22,11 +22,10 @@ import (
"net/http"
"net/url"
admin "google.golang.org/api/admin/directory/v1"
"google.golang.org/api/option"
"go.probo.inc/probo/pkg/connector"
"go.probo.inc/probo/pkg/coredata"
admin "google.golang.org/api/admin/directory/v1"
"google.golang.org/api/option"
)
// NameResolver fetches the human-readable instance name from a provider
@@ -204,12 +203,17 @@ func NewCloudflareNameResolver(httpClient *http.Client) NameResolver {
}
func (r *cloudflareNameResolver) ResolveInstanceName(ctx context.Context) (string, error) {
req, err := http.NewRequestWithContext(
ctx,
http.MethodGet,
"https://api.cloudflare.com/client/v4/accounts?page=1&per_page=1",
nil,
)
cfURL, err := url.Parse("https://api.cloudflare.com/client/v4/accounts")
if err != nil {
return "", fmt.Errorf("cannot parse cloudflare accounts URL: %w", err)
}
q := cfURL.Query()
q.Set("page", "1")
q.Set("per_page", "1")
cfURL.RawQuery = q.Encode()
req, err := http.NewRequestWithContext(ctx, http.MethodGet, cfURL.String(), nil)
if err != nil {
return "", fmt.Errorf("cannot create cloudflare accounts request: %w", err)
}
@@ -300,9 +304,12 @@ func NewTallyNameResolver(httpClient *http.Client, organizationID string) NameRe
}
func (r *tallyNameResolver) ResolveInstanceName(ctx context.Context) (string, error) {
url := fmt.Sprintf("https://api.tally.so/organizations/%s", r.organizationID)
endpoint, err := url.JoinPath("https://api.tally.so", "organizations", r.organizationID)
if err != nil {
return "", fmt.Errorf("cannot build tally organization URL: %w", err)
}
req, err := http.NewRequestWithContext(ctx, http.MethodGet, url, nil)
req, err := http.NewRequestWithContext(ctx, http.MethodGet, endpoint, nil)
if err != nil {
return "", fmt.Errorf("cannot create tally organization request: %w", err)
}
@@ -484,9 +491,12 @@ func (r *sentryNameResolver) ResolveInstanceName(ctx context.Context) (string, e
return "", nil
}
url := fmt.Sprintf("https://sentry.io/api/0/organizations/%s/", r.orgSlug)
endpoint, err := url.JoinPath("https://sentry.io", "api", "0", "organizations", r.orgSlug)
if err != nil {
return "", fmt.Errorf("cannot build sentry organization URL: %w", err)
}
req, err := http.NewRequestWithContext(ctx, http.MethodGet, url, nil)
req, err := http.NewRequestWithContext(ctx, http.MethodGet, endpoint, nil)
if err != nil {
return "", fmt.Errorf("cannot create sentry organization request: %w", err)
}
@@ -525,9 +535,12 @@ func NewGitHubNameResolver(httpClient *http.Client, org string) NameResolver {
}
func (r *githubNameResolver) ResolveInstanceName(ctx context.Context) (string, error) {
url := fmt.Sprintf("https://api.github.com/orgs/%s", r.org)
endpoint, err := url.JoinPath("https://api.github.com", "orgs", r.org)
if err != nil {
return "", fmt.Errorf("cannot build github organization URL: %w", err)
}
req, err := http.NewRequestWithContext(ctx, http.MethodGet, url, nil)
req, err := http.NewRequestWithContext(ctx, http.MethodGet, endpoint, nil)
if err != nil {
return "", fmt.Errorf("cannot create github organization request: %w", err)
}
@@ -639,7 +652,10 @@ func (r *gitlabNameResolver) ResolveInstanceName(ctx context.Context) (string, e
return "", nil
}
endpoint := fmt.Sprintf("https://gitlab.com/api/v4/groups/%s", url.PathEscape(r.groupID))
endpoint, err := url.JoinPath("https://gitlab.com", "api", "v4", "groups", r.groupID)
if err != nil {
return "", fmt.Errorf("cannot build gitlab group URL: %w", err)
}
req, err := http.NewRequestWithContext(ctx, http.MethodGet, endpoint, nil)
if err != nil {
@@ -689,7 +705,10 @@ func (r *bitbucketNameResolver) ResolveInstanceName(ctx context.Context) (string
return "", nil
}
endpoint := fmt.Sprintf("https://api.bitbucket.org/2.0/workspaces/%s", url.PathEscape(r.workspace))
endpoint, err := url.JoinPath("https://api.bitbucket.org", "2.0", "workspaces", r.workspace)
if err != nil {
return "", fmt.Errorf("cannot build bitbucket workspace URL: %w", err)
}
req, err := http.NewRequestWithContext(ctx, http.MethodGet, endpoint, nil)
if err != nil {
@@ -739,7 +758,10 @@ func (r *herokuNameResolver) ResolveInstanceName(ctx context.Context) (string, e
return "", nil
}
endpoint := fmt.Sprintf("https://api.heroku.com/teams/%s", url.PathEscape(r.teamID))
endpoint, err := url.JoinPath("https://api.heroku.com", "teams", r.teamID)
if err != nil {
return "", fmt.Errorf("cannot build heroku team URL: %w", err)
}
req, err := http.NewRequestWithContext(ctx, http.MethodGet, endpoint, nil)
if err != nil {
@@ -799,7 +821,10 @@ func (r *asanaNameResolver) ResolveInstanceName(ctx context.Context) (string, er
return "", nil
}
endpoint := fmt.Sprintf("https://app.asana.com/api/1.0/workspaces/%s", url.PathEscape(r.workspaceGID))
endpoint, err := url.JoinPath("https://app.asana.com", "api", "1.0", "workspaces", r.workspaceGID)
if err != nil {
return "", fmt.Errorf("cannot build asana workspace URL: %w", err)
}
req, err := http.NewRequestWithContext(ctx, http.MethodGet, endpoint, nil)
if err != nil {
@@ -846,7 +871,10 @@ func (r *netlifyNameResolver) ResolveInstanceName(ctx context.Context) (string,
return "", nil
}
endpoint := fmt.Sprintf("https://api.netlify.com/api/v1/accounts/%s", url.PathEscape(r.accountSlug))
endpoint, err := url.JoinPath("https://api.netlify.com", "api", "v1", "accounts", r.accountSlug)
if err != nil {
return "", fmt.Errorf("cannot build netlify account URL: %w", err)
}
req, err := http.NewRequestWithContext(ctx, http.MethodGet, endpoint, nil)
if err != nil {
@@ -891,7 +919,10 @@ func (r *clickupNameResolver) ResolveInstanceName(ctx context.Context) (string,
return "", nil
}
endpoint := fmt.Sprintf("https://api.clickup.com/api/v2/team/%s", url.PathEscape(r.teamID))
endpoint, err := url.JoinPath("https://api.clickup.com", "api", "v2", "team", r.teamID)
if err != nil {
return "", fmt.Errorf("cannot build clickup team URL: %w", err)
}
req, err := http.NewRequestWithContext(ctx, http.MethodGet, endpoint, nil)
if err != nil {
@@ -941,7 +972,10 @@ func (r *vercelNameResolver) ResolveInstanceName(ctx context.Context) (string, e
return "", nil
}
teamURL := fmt.Sprintf("https://api.vercel.com/v2/teams/%s", url.PathEscape(r.teamID))
teamURL, err := url.JoinPath("https://api.vercel.com", "v2", "teams", r.teamID)
if err != nil {
return "", fmt.Errorf("cannot build vercel team URL: %w", err)
}
teamReq, err := http.NewRequestWithContext(ctx, http.MethodGet, teamURL, nil)
if err != nil {
@@ -1107,12 +1141,16 @@ func NewMicrosoft365NameResolver(httpClient *http.Client) NameResolver {
}
func (r *microsoft365NameResolver) ResolveInstanceName(ctx context.Context) (string, error) {
req, err := http.NewRequestWithContext(
ctx,
http.MethodGet,
"https://graph.microsoft.com/v1.0/organization?$select=displayName,verifiedDomains",
nil,
)
msURL, err := url.Parse("https://graph.microsoft.com/v1.0/organization")
if err != nil {
return "", fmt.Errorf("cannot parse microsoft 365 organization URL: %w", err)
}
q := msURL.Query()
q.Set("$select", "displayName,verifiedDomains")
msURL.RawQuery = q.Encode()
req, err := http.NewRequestWithContext(ctx, http.MethodGet, msURL.String(), nil)
if err != nil {
return "", fmt.Errorf("cannot create microsoft 365 organization request: %w", err)
}

View File

@@ -56,10 +56,20 @@ type netlifyMember struct {
func (d *NetlifyDriver) ListAccounts(ctx context.Context) ([]AccountRecord, error) {
var records []AccountRecord
next := fmt.Sprintf(
"https://api.netlify.com/api/v1/%s/members?per_page=100",
url.PathEscape(d.accountSlug),
)
u, err := url.JoinPath("https://api.netlify.com", "api", "v1", d.accountSlug, "members")
if err != nil {
return nil, fmt.Errorf("cannot build netlify members URL: %w", err)
}
parsed, err := url.Parse(u)
if err != nil {
return nil, fmt.Errorf("cannot parse netlify members URL: %w", err)
}
q := parsed.Query()
q.Set("per_page", "100")
parsed.RawQuery = q.Encode()
next := parsed.String()
for range maxPaginationPages {
members, linkHeader, err := d.queryMembers(ctx, next)

View File

@@ -65,18 +65,21 @@ func (d *ProboMembershipsDriver) ListAccounts(ctx context.Context) ([]AccountRec
isAdmin := role == string(coredata.MembershipRoleOwner) || role == string(coredata.MembershipRoleAdmin)
createdAt := account.CreatedAt
records = append(records, AccountRecord{
Email: account.Email,
FullName: account.FullName,
Role: role,
Active: new(account.State == string(coredata.ProfileStateActive)),
IsAdmin: isAdmin,
ExternalID: account.ID.String(),
CreatedAt: &createdAt,
MFAStatus: coredata.MFAStatusUnknown,
AuthMethod: coredata.AccessEntryAuthMethodUnknown,
AccountType: coredata.AccessEntryAccountTypeUser,
})
records = append(
records,
AccountRecord{
Email: account.Email,
FullName: account.FullName,
Role: role,
Active: new(account.State == string(coredata.ProfileStateActive)),
IsAdmin: isAdmin,
ExternalID: account.ID.String(),
CreatedAt: &createdAt,
MFAStatus: coredata.MFAStatusUnknown,
AuthMethod: coredata.AccessEntryAuthMethodUnknown,
AccountType: coredata.AccessEntryAccountTypeUser,
},
)
}
return nil

View File

@@ -19,6 +19,7 @@ import (
"encoding/json"
"fmt"
"net/http"
"net/url"
"time"
"go.probo.inc/probo/pkg/coredata"
@@ -108,10 +109,10 @@ func (d *SentryDriver) ListAccounts(ctx context.Context) ([]AccountRecord, error
var records []AccountRecord
nextURL := fmt.Sprintf(
"https://sentry.io/api/0/organizations/%s/members/",
orgSlug,
)
nextURL, err := url.JoinPath("https://sentry.io", "api", "0", "organizations", orgSlug, "members")
if err != nil {
return nil, fmt.Errorf("cannot build sentry members URL: %w", err)
}
for range maxPaginationPages {
members, linkHeader, err := d.queryMembers(ctx, nextURL)

View File

@@ -87,7 +87,9 @@ func (h *sourceNameHandler) Claim(ctx context.Context) (coredata.AccessSource, e
}
func (h *sourceNameHandler) Process(ctx context.Context, source coredata.AccessSource) error {
h.logger.InfoCtx(ctx, "syncing source name",
h.logger.InfoCtx(
ctx,
"syncing source name",
log.String("source_id", source.ID.String()),
log.String("current_name", source.Name),
)
@@ -134,7 +136,9 @@ func (h *sourceNameHandler) Process(ctx context.Context, source coredata.AccessS
},
)
if err != nil {
h.logger.ErrorCtx(ctx, "cannot load connector for source name sync",
h.logger.ErrorCtx(
ctx,
"cannot load connector for source name sync",
log.String("source_id", source.ID.String()),
log.Error(err),
)
@@ -143,7 +147,9 @@ func (h *sourceNameHandler) Process(ctx context.Context, source coredata.AccessS
}
if resolver == nil {
h.logger.InfoCtx(ctx, "no name resolver for provider, keeping generic name",
h.logger.InfoCtx(
ctx,
"no name resolver for provider, keeping generic name",
log.String("source_id", source.ID.String()),
log.String("provider", dbConnector.Provider.String()),
)
@@ -156,7 +162,9 @@ func (h *sourceNameHandler) Process(ctx context.Context, source coredata.AccessS
instanceName, err := resolver.ResolveInstanceName(resolveCtx)
if err != nil {
h.logger.ErrorCtx(ctx, "cannot resolve instance name",
h.logger.ErrorCtx(
ctx,
"cannot resolve instance name",
log.String("source_id", source.ID.String()),
log.String("provider", dbConnector.Provider.String()),
log.Error(err),
@@ -166,7 +174,9 @@ func (h *sourceNameHandler) Process(ctx context.Context, source coredata.AccessS
}
if instanceName == "" {
h.logger.InfoCtx(ctx, "instance name is empty, keeping generic name",
h.logger.InfoCtx(
ctx,
"instance name is empty, keeping generic name",
log.String("source_id", source.ID.String()),
log.String("provider", dbConnector.Provider.String()),
)
@@ -177,7 +187,9 @@ func (h *sourceNameHandler) Process(ctx context.Context, source coredata.AccessS
displayName := drivers.ProviderDisplayName(dbConnector.Provider)
newName := displayName + " " + instanceName
h.logger.InfoCtx(ctx, "resolved source name",
h.logger.InfoCtx(
ctx,
"resolved source name",
log.String("source_id", source.ID.String()),
log.String("old_name", source.Name),
log.String("new_name", newName),

View File

@@ -95,8 +95,7 @@ func blockingCallLLM(ctx context.Context, agent *Agent, req *llm.ChatCompletionR
// Some providers (e.g. Anthropic) require streaming for large
// max_tokens or when thinking is enabled. Fall back to streaming
// transparently when the blocking call returns ErrStreamingRequired.
var streamRequired *llm.ErrStreamingRequired
if !errors.As(err, &streamRequired) {
if _, ok := errors.AsType[*llm.ErrStreamingRequired](err); !ok {
return nil, err
}

View File

@@ -54,56 +54,70 @@ func DownloadPDFTool() agent.Tool {
"Download a PDF document from a URL and extract its text content. Use this for DPAs, SOC 2 reports, privacy policies, and other documents hosted as PDFs.",
func(ctx context.Context, p downloadPDFParams) (agent.ToolResult, error) {
if err := validatePublicURL(p.URL); err != nil {
return agent.ResultJSON(downloadPDFResult{
ErrorDetail: fmt.Sprintf("URL not allowed: %s", err),
}), nil
return agent.ResultJSON(
downloadPDFResult{
ErrorDetail: fmt.Sprintf("URL not allowed: %s", err),
},
), nil
}
req, err := http.NewRequestWithContext(ctx, http.MethodGet, p.URL, nil)
if err != nil {
return agent.ResultJSON(downloadPDFResult{
ErrorDetail: fmt.Sprintf("cannot create request: %s", err),
}), nil
return agent.ResultJSON(
downloadPDFResult{
ErrorDetail: fmt.Sprintf("cannot create request: %s", err),
},
), nil
}
resp, err := client.Do(req)
if err != nil {
return agent.ResultJSON(downloadPDFResult{
ErrorDetail: fmt.Sprintf("cannot download PDF: %s", err),
}), nil
return agent.ResultJSON(
downloadPDFResult{
ErrorDetail: fmt.Sprintf("cannot download PDF: %s", err),
},
), nil
}
defer func() { _ = resp.Body.Close() }()
if resp.StatusCode != http.StatusOK {
return agent.ResultJSON(downloadPDFResult{
ErrorDetail: fmt.Sprintf("PDF download returned status %d", resp.StatusCode),
}), nil
return agent.ResultJSON(
downloadPDFResult{
ErrorDetail: fmt.Sprintf("PDF download returned status %d", resp.StatusCode),
},
), nil
}
// Read PDF into memory (max 20MB).
body, err := io.ReadAll(io.LimitReader(resp.Body, 20*1024*1024))
if err != nil {
return agent.ResultJSON(downloadPDFResult{
ErrorDetail: fmt.Sprintf("cannot read PDF body: %s", err),
}), nil
return agent.ResultJSON(
downloadPDFResult{
ErrorDetail: fmt.Sprintf("cannot read PDF body: %s", err),
},
), nil
}
// Write to temp file for pdfcpu.
tmpDir, err := os.MkdirTemp("", "pdf-extract-*")
if err != nil {
return agent.ResultJSON(downloadPDFResult{
ErrorDetail: fmt.Sprintf("cannot create temp dir: %s", err),
}), nil
return agent.ResultJSON(
downloadPDFResult{
ErrorDetail: fmt.Sprintf("cannot create temp dir: %s", err),
},
), nil
}
defer func() { _ = os.RemoveAll(tmpDir) }()
tmpFile := filepath.Join(tmpDir, "input.pdf")
if err := os.WriteFile(tmpFile, body, 0o600); err != nil {
return agent.ResultJSON(downloadPDFResult{
ErrorDetail: fmt.Sprintf("cannot write temp file: %s", err),
}), nil
return agent.ResultJSON(
downloadPDFResult{
ErrorDetail: fmt.Sprintf("cannot write temp file: %s", err),
},
), nil
}
// Get page count.
@@ -111,24 +125,30 @@ func DownloadPDFTool() agent.Tool {
pageCount, err := api.PageCountFile(tmpFile)
if err != nil {
return agent.ResultJSON(downloadPDFResult{
ErrorDetail: fmt.Sprintf("cannot read PDF: %s", err),
}), nil
return agent.ResultJSON(
downloadPDFResult{
ErrorDetail: fmt.Sprintf("cannot read PDF: %s", err),
},
), nil
}
// Extract content to output dir.
outDir := filepath.Join(tmpDir, "out")
if err := os.MkdirAll(outDir, 0o700); err != nil {
return agent.ResultJSON(downloadPDFResult{
ErrorDetail: fmt.Sprintf("cannot create output dir: %s", err),
}), nil
return agent.ResultJSON(
downloadPDFResult{
ErrorDetail: fmt.Sprintf("cannot create output dir: %s", err),
},
), nil
}
reader := bytes.NewReader(body)
if err := api.ExtractContent(reader, outDir, "content", nil, conf); err != nil {
return agent.ResultJSON(downloadPDFResult{
ErrorDetail: fmt.Sprintf("cannot extract PDF content: %s", err),
}), nil
return agent.ResultJSON(
downloadPDFResult{
ErrorDetail: fmt.Sprintf("cannot extract PDF content: %s", err),
},
), nil
}
// Read all extracted content files.
@@ -154,10 +174,12 @@ func DownloadPDFTool() agent.Tool {
text = text[:maxTextLength] + "\n[... truncated]"
}
return agent.ResultJSON(downloadPDFResult{
Text: text,
PageCount: pageCount,
}), nil
return agent.ResultJSON(
downloadPDFResult{
Text: text,
PageCount: pageCount,
},
), nil
},
)
}

View File

@@ -19,6 +19,7 @@ import (
"context"
"fmt"
"net/http"
"net/url"
"strings"
"time"
@@ -46,37 +47,49 @@ func FetchRobotsTxtTool() agent.Tool {
"Fetch and parse the robots.txt file for a domain. Returns sitemap URLs and disallowed paths, which can reveal hidden pages the crawler might miss.",
func(ctx context.Context, p robotsParams) (agent.ToolResult, error) {
if err := validatePublicDomain(p.Domain); err != nil {
return agent.ResultJSON(robotsResult{
Found: false,
ErrorDetail: fmt.Sprintf("domain not allowed: %s", err),
}), nil
return agent.ResultJSON(
robotsResult{
Found: false,
ErrorDetail: fmt.Sprintf("domain not allowed: %s", err),
},
), nil
}
u := "https://" + p.Domain + "/robots.txt"
u := &url.URL{
Scheme: "https",
Host: p.Domain,
Path: "/robots.txt",
}
req, err := http.NewRequestWithContext(ctx, http.MethodGet, u, nil)
req, err := http.NewRequestWithContext(ctx, http.MethodGet, u.String(), nil)
if err != nil {
return agent.ResultJSON(robotsResult{
Found: false,
ErrorDetail: fmt.Sprintf("cannot create request: %s", err),
}), nil
return agent.ResultJSON(
robotsResult{
Found: false,
ErrorDetail: fmt.Sprintf("cannot create request: %s", err),
},
), nil
}
resp, err := client.Do(req)
if err != nil {
return agent.ResultJSON(robotsResult{
Found: false,
ErrorDetail: fmt.Sprintf("cannot fetch robots.txt: %s", err),
}), nil
return agent.ResultJSON(
robotsResult{
Found: false,
ErrorDetail: fmt.Sprintf("cannot fetch robots.txt: %s", err),
},
), nil
}
defer func() { _ = resp.Body.Close() }()
if resp.StatusCode != http.StatusOK {
return agent.ResultJSON(robotsResult{
Found: false,
ErrorDetail: fmt.Sprintf("robots.txt returned status %d", resp.StatusCode),
}), nil
return agent.ResultJSON(
robotsResult{
Found: false,
ErrorDetail: fmt.Sprintf("robots.txt returned status %d", resp.StatusCode),
},
), nil
}
var result robotsResult

View File

@@ -52,35 +52,43 @@ func FetchSitemapTool() agent.Tool {
"Fetch and parse a sitemap XML file. Returns discovered URLs which can reveal pages not linked from the main navigation (trust centers, legal docs, status pages).",
func(ctx context.Context, p sitemapParams) (agent.ToolResult, error) {
if err := validatePublicURL(p.URL); err != nil {
return agent.ResultJSON(sitemapResult{
Found: false,
ErrorDetail: fmt.Sprintf("URL not allowed: %s", err),
}), nil
return agent.ResultJSON(
sitemapResult{
Found: false,
ErrorDetail: fmt.Sprintf("URL not allowed: %s", err),
},
), nil
}
req, err := http.NewRequestWithContext(ctx, http.MethodGet, p.URL, nil)
if err != nil {
return agent.ResultJSON(sitemapResult{
Found: false,
ErrorDetail: fmt.Sprintf("cannot create request: %s", err),
}), nil
return agent.ResultJSON(
sitemapResult{
Found: false,
ErrorDetail: fmt.Sprintf("cannot create request: %s", err),
},
), nil
}
resp, err := client.Do(req)
if err != nil {
return agent.ResultJSON(sitemapResult{
Found: false,
ErrorDetail: fmt.Sprintf("cannot fetch sitemap: %s", err),
}), nil
return agent.ResultJSON(
sitemapResult{
Found: false,
ErrorDetail: fmt.Sprintf("cannot fetch sitemap: %s", err),
},
), nil
}
defer func() { _ = resp.Body.Close() }()
if resp.StatusCode != http.StatusOK {
return agent.ResultJSON(sitemapResult{
Found: false,
ErrorDetail: fmt.Sprintf("sitemap returned status %d", resp.StatusCode),
}), nil
return agent.ResultJSON(
sitemapResult{
Found: false,
ErrorDetail: fmt.Sprintf("sitemap returned status %d", resp.StatusCode),
},
), nil
}
var reader io.Reader = resp.Body
@@ -88,10 +96,12 @@ func FetchSitemapTool() agent.Tool {
resp.Header.Get("Content-Encoding") == "gzip" {
gz, err := gzip.NewReader(resp.Body)
if err != nil {
return agent.ResultJSON(sitemapResult{
Found: false,
ErrorDetail: fmt.Sprintf("cannot decompress gzipped sitemap: %s", err),
}), nil
return agent.ResultJSON(
sitemapResult{
Found: false,
ErrorDetail: fmt.Sprintf("cannot decompress gzipped sitemap: %s", err),
},
), nil
}
defer func() { _ = gz.Close() }()
@@ -104,10 +114,12 @@ func FetchSitemapTool() agent.Tool {
urls, err := parseSitemapXML(reader)
if err != nil {
return agent.ResultJSON(sitemapResult{
Found: false,
ErrorDetail: fmt.Sprintf("cannot parse sitemap XML: %s", err),
}), nil
return agent.ResultJSON(
sitemapResult{
Found: false,
ErrorDetail: fmt.Sprintf("cannot parse sitemap XML: %s", err),
},
), nil
}
result := sitemapResult{

View File

@@ -80,11 +80,13 @@ func NavigateToURLTool(b *Browser) agent.Tool {
return agent.ResultError(b.classifyError(ctx, p.URL, err)), nil
}
return agent.ResultJSON(navigateResult{
Title: title,
Description: description,
FinalURL: finalURL,
}), nil
return agent.ResultJSON(
navigateResult{
Title: title,
Description: description,
FinalURL: finalURL,
},
), nil
},
)
}

View File

@@ -64,10 +64,12 @@ func DiffDocumentsTool() agent.Tool {
diff := computeDiff(linesA, linesB, labelA, labelB)
if diff.tooLarge {
return agent.ResultJSON(diffResult{
HasDifferences: true,
ErrorDetail: diff.output,
}), nil
return agent.ResultJSON(
diffResult{
HasDifferences: true,
ErrorDetail: diff.output,
},
), nil
}
result := diffResult{

View File

@@ -65,9 +65,17 @@ func CheckWaybackTool() agent.Tool {
var result waybackResult
// Check availability.
availURL := "https://archive.org/wayback/available?url=" + url.QueryEscape(p.URL)
availURL, err := url.Parse("https://archive.org/wayback/available")
if err != nil {
result.ErrorDetail = fmt.Sprintf("cannot parse Wayback Machine URL: %s", err)
return agent.ResultJSON(result), nil
}
body, err := httpGet(ctx, client, availURL)
q := availURL.Query()
q.Set("url", p.URL)
availURL.RawQuery = q.Encode()
body, err := httpGet(ctx, client, availURL.String())
if err != nil {
result.ErrorDetail = fmt.Sprintf("cannot check Wayback Machine availability: %s", err)
return agent.ResultJSON(result), nil

View File

@@ -68,9 +68,11 @@ func CheckCORSTool() agent.Tool {
"Send a CORS preflight (OPTIONS) request to a URL with a given Origin and analyze the Access-Control-* response headers, flagging wildcard origins and origin reflection.",
func(ctx context.Context, p corsParams) (agent.ToolResult, error) {
if err := netcheck.ValidatePublicURL(p.URL); err != nil {
return agent.ResultJSON(corsResult{
ErrorDetail: fmt.Sprintf("URL not allowed: %s", err),
}), nil
return agent.ResultJSON(
corsResult{
ErrorDetail: fmt.Sprintf("URL not allowed: %s", err),
},
), nil
}
client := &http.Client{
@@ -87,9 +89,11 @@ func CheckCORSTool() agent.Tool {
nil,
)
if err != nil {
return agent.ResultJSON(corsResult{
ErrorDetail: fmt.Sprintf("cannot build request: %s", err),
}), nil
return agent.ResultJSON(
corsResult{
ErrorDetail: fmt.Sprintf("cannot build request: %s", err),
},
), nil
}
req.Header.Set("Origin", p.Origin)
@@ -97,9 +101,11 @@ func CheckCORSTool() agent.Tool {
resp, err := client.Do(req)
if err != nil {
return agent.ResultJSON(corsResult{
ErrorDetail: fmt.Sprintf("cannot fetch %s: %s", p.URL, err),
}), nil
return agent.ResultJSON(
corsResult{
ErrorDetail: fmt.Sprintf("cannot fetch %s: %s", p.URL, err),
},
), nil
}
defer func() { _ = resp.Body.Close() }()

View File

@@ -81,16 +81,20 @@ func AnalyzeCSPTool() agent.Tool {
req, err := http.NewRequestWithContext(ctx, http.MethodGet, p.URL, nil)
if err != nil {
return agent.ResultJSON(cspResult{
ErrorDetail: fmt.Sprintf("cannot create request for %s: %s", p.URL, err),
}), nil
return agent.ResultJSON(
cspResult{
ErrorDetail: fmt.Sprintf("cannot create request for %s: %s", p.URL, err),
},
), nil
}
resp, err := client.Do(req)
if err != nil {
return agent.ResultJSON(cspResult{
ErrorDetail: fmt.Sprintf("cannot fetch %s: %s", p.URL, err),
}), nil
return agent.ResultJSON(
cspResult{
ErrorDetail: fmt.Sprintf("cannot fetch %s: %s", p.URL, err),
},
), nil
}
defer func() { _ = resp.Body.Close() }()

View File

@@ -73,10 +73,12 @@ func CheckDMARCTool() agent.Tool {
},
)
if err != nil {
return agent.ResultJSON(dmarcResult{
Found: false,
ErrorDetail: fmt.Sprintf("cannot lookup DMARC record: %s", err),
}), nil
return agent.ResultJSON(
dmarcResult{
Found: false,
ErrorDetail: fmt.Sprintf("cannot lookup DMARC record: %s", err),
},
), nil
}
for _, answer := range answers {

View File

@@ -61,10 +61,12 @@ func CheckDNSSECTool() agent.Tool {
withDNSSEC(),
)
if err != nil {
return agent.ResultJSON(dnssecResult{
Enabled: false,
ErrorDetail: fmt.Sprintf("cannot query DNSKEY records: %s", err),
}), nil
return agent.ResultJSON(
dnssecResult{
Enabled: false,
ErrorDetail: fmt.Sprintf("cannot query DNSKEY records: %s", err),
},
), nil
}
var (

View File

@@ -18,6 +18,7 @@ import (
"context"
"fmt"
"net/http"
"net/url"
"strings"
"time"
@@ -79,9 +80,11 @@ func CheckSecurityHeadersTool() agent.Tool {
"Check security-related HTTP headers for a URL (HSTS, CSP, X-Frame-Options, X-Content-Type-Options, Referrer-Policy, Permissions-Policy, Cross-Origin-*-Policy). Also checks if HTTP redirects to HTTPS.",
func(ctx context.Context, p headersParams) (agent.ToolResult, error) {
if err := netcheck.ValidatePublicURL(p.URL); err != nil {
return agent.ResultJSON(headersResult{
ErrorDetail: fmt.Sprintf("URL not allowed: %s", err),
}), nil
return agent.ResultJSON(
headersResult{
ErrorDetail: fmt.Sprintf("URL not allowed: %s", err),
},
), nil
}
client := &http.Client{
@@ -94,11 +97,19 @@ func CheckSecurityHeadersTool() agent.Tool {
// First check the HTTP version to detect HTTP→HTTPS redirect.
redirectsToHTTPS := false
httpURL := p.URL
if after, ok := strings.CutPrefix(httpURL, "https://"); ok {
httpURL = "http://" + after
parsedURL, err := url.Parse(p.URL)
if err != nil {
return agent.ResultJSON(
headersResult{
ErrorDetail: fmt.Sprintf("cannot parse URL: %s", err),
},
), nil
}
httpParsed := *parsedURL
httpParsed.Scheme = "http"
httpURL := httpParsed.String()
httpReq, err := http.NewRequestWithContext(ctx, http.MethodGet, httpURL, nil)
if err == nil {
httpResp, err := client.Do(httpReq)
@@ -114,25 +125,28 @@ func CheckSecurityHeadersTool() agent.Tool {
}
// Now check the HTTPS version for the actual security headers.
httpsURL := p.URL
if after, ok := strings.CutPrefix(httpsURL, "http://"); ok {
httpsURL = "https://" + after
}
httpsParsed := *parsedURL
httpsParsed.Scheme = "https"
httpsURL := httpsParsed.String()
followClient := &http.Client{Timeout: 10 * time.Second}
httpsReq, err := http.NewRequestWithContext(ctx, http.MethodGet, httpsURL, nil)
if err != nil {
return agent.ResultJSON(headersResult{
ErrorDetail: fmt.Sprintf("cannot create request for %s: %s", httpsURL, err),
}), nil
return agent.ResultJSON(
headersResult{
ErrorDetail: fmt.Sprintf("cannot create request for %s: %s", httpsURL, err),
},
), nil
}
resp, err := followClient.Do(httpsReq)
if err != nil {
return agent.ResultJSON(headersResult{
ErrorDetail: fmt.Sprintf("cannot fetch %s: %s", httpsURL, err),
}), nil
return agent.ResultJSON(
headersResult{
ErrorDetail: fmt.Sprintf("cannot fetch %s: %s", httpsURL, err),
},
), nil
}
defer func() { _ = resp.Body.Close() }()

View File

@@ -61,34 +61,48 @@ func CheckBreachesTool() agent.Tool {
func(ctx context.Context, p hibpParams) (agent.ToolResult, error) {
client := &http.Client{Timeout: 10 * time.Second}
req, err := http.NewRequestWithContext(
ctx,
http.MethodGet,
"https://haveibeenpwned.com/api/v3/breaches?domain="+url.QueryEscape(p.Domain),
nil,
)
hibpURL, err := url.Parse("https://haveibeenpwned.com/api/v3/breaches")
if err != nil {
return agent.ResultJSON(hibpResult{
ErrorDetail: fmt.Sprintf("cannot create request: %s", err),
}), nil
return agent.ResultJSON(
hibpResult{
ErrorDetail: fmt.Sprintf("cannot parse HIBP URL: %s", err),
},
), nil
}
q := hibpURL.Query()
q.Set("domain", p.Domain)
hibpURL.RawQuery = q.Encode()
req, err := http.NewRequestWithContext(ctx, http.MethodGet, hibpURL.String(), nil)
if err != nil {
return agent.ResultJSON(
hibpResult{
ErrorDetail: fmt.Sprintf("cannot create request: %s", err),
},
), nil
}
req.Header.Set("User-Agent", "Probo-Vendor-Assessment")
resp, err := client.Do(req)
if err != nil {
return agent.ResultJSON(hibpResult{
ErrorDetail: fmt.Sprintf("cannot fetch breaches: %s", err),
}), nil
return agent.ResultJSON(
hibpResult{
ErrorDetail: fmt.Sprintf("cannot fetch breaches: %s", err),
},
), nil
}
defer func() { _ = resp.Body.Close() }()
body, err := io.ReadAll(resp.Body)
if err != nil {
return agent.ResultJSON(hibpResult{
ErrorDetail: fmt.Sprintf("cannot read response: %s", err),
}), nil
return agent.ResultJSON(
hibpResult{
ErrorDetail: fmt.Sprintf("cannot read response: %s", err),
},
), nil
}
if resp.StatusCode == http.StatusNotFound {
@@ -96,23 +110,29 @@ func CheckBreachesTool() agent.Tool {
}
if resp.StatusCode != http.StatusOK {
return agent.ResultJSON(hibpResult{
ErrorDetail: fmt.Sprintf("HIBP API returned status %d", resp.StatusCode),
}), nil
return agent.ResultJSON(
hibpResult{
ErrorDetail: fmt.Sprintf("HIBP API returned status %d", resp.StatusCode),
},
), nil
}
var breaches []breach
if err := json.Unmarshal(body, &breaches); err != nil {
return agent.ResultJSON(hibpResult{
ErrorDetail: fmt.Sprintf("cannot parse response: %s", err),
}), nil
return agent.ResultJSON(
hibpResult{
ErrorDetail: fmt.Sprintf("cannot parse response: %s", err),
},
), nil
}
return agent.ResultJSON(hibpResult{
Found: len(breaches) > 0,
Count: len(breaches),
Breaches: breaches,
}), nil
return agent.ResultJSON(
hibpResult{
Found: len(breaches) > 0,
Count: len(breaches),
Breaches: breaches,
},
), nil
},
)
}

View File

@@ -77,10 +77,12 @@ func CheckSPFTool() agent.Tool {
},
)
if err != nil {
return agent.ResultJSON(spfResult{
Found: false,
ErrorDetail: fmt.Sprintf("cannot lookup SPF record: %s", err),
}), nil
return agent.ResultJSON(
spfResult{
Found: false,
ErrorDetail: fmt.Sprintf("cannot lookup SPF record: %s", err),
},
), nil
}
var spfRecords []string
@@ -100,21 +102,25 @@ func CheckSPFTool() agent.Tool {
}
if len(spfRecords) > 1 {
return agent.ResultJSON(spfResult{
Found: true,
ErrorDetail: fmt.Sprintf("multiple SPF records found (%d); this is an invalid configuration per RFC 7208", len(spfRecords)),
}), nil
return agent.ResultJSON(
spfResult{
Found: true,
ErrorDetail: fmt.Sprintf("multiple SPF records found (%d); this is an invalid configuration per RFC 7208", len(spfRecords)),
},
), nil
}
if len(spfRecords) == 1 {
record := spfRecords[0]
return agent.ResultJSON(spfResult{
Found: true,
RawRecord: record,
Policy: parseSPFPolicy(record),
Mechanisms: record,
}), nil
return agent.ResultJSON(
spfResult{
Found: true,
RawRecord: record,
Policy: parseSPFPolicy(record),
Mechanisms: record,
},
), nil
}
return agent.ResultJSON(spfResult{Found: false}), nil

View File

@@ -66,10 +66,12 @@ func CheckSSLCertificateTool() agent.Tool {
"Check the SSL/TLS certificate for a domain, returning issuer, expiry, protocol version, and validity.",
func(ctx context.Context, p sslParams) (agent.ToolResult, error) {
if err := netcheck.ValidatePublicDomain(p.Domain); err != nil {
return agent.ResultJSON(sslResult{
Valid: false,
ErrorDetail: fmt.Sprintf("domain not allowed: %s", err),
}), nil
return agent.ResultJSON(
sslResult{
Valid: false,
ErrorDetail: fmt.Sprintf("domain not allowed: %s", err),
},
), nil
}
// This is a certificate inspection tool: we intentionally
@@ -96,20 +98,24 @@ func CheckSSLCertificateTool() agent.Tool {
}
if err != nil {
return agent.ResultJSON(sslResult{
Valid: false,
ErrorDetail: err.Error(),
}), nil
return agent.ResultJSON(
sslResult{
Valid: false,
ErrorDetail: err.Error(),
},
), nil
}
defer func() { _ = conn.Close() }()
state := conn.ConnectionState()
if len(state.PeerCertificates) == 0 {
return agent.ResultJSON(sslResult{
Valid: false,
ErrorDetail: "no peer certificates",
}), nil
return agent.ResultJSON(
sslResult{
Valid: false,
ErrorDetail: "no peer certificates",
},
), nil
}
cert := state.PeerCertificates[0]

View File

@@ -50,17 +50,21 @@ func CheckWhoisTool() agent.Tool {
"Perform a WHOIS lookup on a domain to retrieve registration details including registrar, creation date, expiry date, registrant organization, and name servers.",
func(ctx context.Context, p whoisParams) (agent.ToolResult, error) {
if err := netcheck.ValidatePublicDomain(p.Domain); err != nil {
return agent.ResultJSON(whoisResult{
ErrorDetail: fmt.Sprintf("domain not allowed: %s", err),
}), nil
return agent.ResultJSON(
whoisResult{
ErrorDetail: fmt.Sprintf("domain not allowed: %s", err),
},
), nil
}
// Step 1: query IANA to find the referral WHOIS server.
referral, err := queryWhois(ctx, "whois.iana.org:43", p.Domain)
if err != nil {
return agent.ResultJSON(whoisResult{
ErrorDetail: fmt.Sprintf("cannot query IANA WHOIS: %s", err),
}), nil
return agent.ResultJSON(
whoisResult{
ErrorDetail: fmt.Sprintf("cannot query IANA WHOIS: %s", err),
},
), nil
}
whoisServer := parseWhoisField(referral, "refer")
@@ -87,17 +91,21 @@ func CheckWhoisTool() agent.Tool {
}
if err := netcheck.ValidatePublicDomain(whoisHost); err != nil {
return agent.ResultJSON(whoisResult{
ErrorDetail: fmt.Sprintf("WHOIS referral server not allowed: %s", err),
}), nil
return agent.ResultJSON(
whoisResult{
ErrorDetail: fmt.Sprintf("WHOIS referral server not allowed: %s", err),
},
), nil
}
// Step 2: query the registrar's WHOIS server.
raw, err := queryWhois(ctx, whoisServer, p.Domain)
if err != nil {
return agent.ResultJSON(whoisResult{
ErrorDetail: fmt.Sprintf("cannot query WHOIS server %s: %s", whoisServer, err),
}), nil
return agent.ResultJSON(
whoisResult{
ErrorDetail: fmt.Sprintf("cannot query WHOIS server %s: %s", whoisServer, err),
},
), nil
}
result := parseWhoisResponse(raw)

View File

@@ -17,6 +17,7 @@ package awsconfig
import (
"context"
"net/http"
"net/url"
"os"
"time"
@@ -86,7 +87,9 @@ func NewConfig(logger *log.Logger, httpClient *http.Client, opts Options) aws.Co
})
ecsCredentialsURI := os.Getenv("AWS_CONTAINER_CREDENTIALS_RELATIVE_URI")
ecsProvider := endpointcreds.New("http://169.254.170.2"+ecsCredentialsURI,
ecsEndpoint, _ := url.JoinPath("http://169.254.170.2", ecsCredentialsURI)
ecsProvider := endpointcreds.New(
ecsEndpoint,
func(options *endpointcreds.Options) {
options.HTTPClient = httpClient
},

View File

@@ -247,116 +247,146 @@ func (b *Builder) Build() (*probodconfig.FullConfig, error) {
}
if slackClientID := b.getEnv("CONNECTOR_SLACK_CLIENT_ID"); slackClientID != "" {
cfg.Probod.Connectors = append(cfg.Probod.Connectors, probodconfig.ConnectorConfig{
Provider: "SLACK",
Protocol: "oauth2",
RawConfig: probodconfig.ConnectorConfigOAuth2{
ClientID: slackClientID,
ClientSecret: b.getEnv("CONNECTOR_SLACK_CLIENT_SECRET"),
cfg.Probod.Connectors = append(
cfg.Probod.Connectors,
probodconfig.ConnectorConfig{
Provider: "SLACK",
Protocol: "oauth2",
RawConfig: probodconfig.ConnectorConfigOAuth2{
ClientID: slackClientID,
ClientSecret: b.getEnv("CONNECTOR_SLACK_CLIENT_SECRET"),
},
RawSettings: map[string]any{
"signing-secret": b.getEnv("CONNECTOR_SLACK_SIGNING_SECRET"),
},
},
RawSettings: map[string]any{
"signing-secret": b.getEnv("CONNECTOR_SLACK_SIGNING_SECRET"),
},
})
)
}
if hubspotClientID := b.getEnv("CONNECTOR_HUBSPOT_CLIENT_ID"); hubspotClientID != "" {
cfg.Probod.Connectors = append(cfg.Probod.Connectors, probodconfig.ConnectorConfig{
Provider: "HUBSPOT",
Protocol: "oauth2",
RawConfig: probodconfig.ConnectorConfigOAuth2{
ClientID: hubspotClientID,
ClientSecret: b.getEnv("CONNECTOR_HUBSPOT_CLIENT_SECRET"),
cfg.Probod.Connectors = append(
cfg.Probod.Connectors,
probodconfig.ConnectorConfig{
Provider: "HUBSPOT",
Protocol: "oauth2",
RawConfig: probodconfig.ConnectorConfigOAuth2{
ClientID: hubspotClientID,
ClientSecret: b.getEnv("CONNECTOR_HUBSPOT_CLIENT_SECRET"),
},
},
})
)
}
if docusignClientID := b.getEnv("CONNECTOR_DOCUSIGN_CLIENT_ID"); docusignClientID != "" {
cfg.Probod.Connectors = append(cfg.Probod.Connectors, probodconfig.ConnectorConfig{
Provider: "DOCUSIGN",
Protocol: "oauth2",
RawConfig: probodconfig.ConnectorConfigOAuth2{
ClientID: docusignClientID,
ClientSecret: b.getEnv("CONNECTOR_DOCUSIGN_CLIENT_SECRET"),
cfg.Probod.Connectors = append(
cfg.Probod.Connectors,
probodconfig.ConnectorConfig{
Provider: "DOCUSIGN",
Protocol: "oauth2",
RawConfig: probodconfig.ConnectorConfigOAuth2{
ClientID: docusignClientID,
ClientSecret: b.getEnv("CONNECTOR_DOCUSIGN_CLIENT_SECRET"),
},
},
})
)
}
if notionClientID := b.getEnv("CONNECTOR_NOTION_CLIENT_ID"); notionClientID != "" {
cfg.Probod.Connectors = append(cfg.Probod.Connectors, probodconfig.ConnectorConfig{
Provider: "NOTION",
Protocol: "oauth2",
RawConfig: probodconfig.ConnectorConfigOAuth2{
ClientID: notionClientID,
ClientSecret: b.getEnv("CONNECTOR_NOTION_CLIENT_SECRET"),
cfg.Probod.Connectors = append(
cfg.Probod.Connectors,
probodconfig.ConnectorConfig{
Provider: "NOTION",
Protocol: "oauth2",
RawConfig: probodconfig.ConnectorConfigOAuth2{
ClientID: notionClientID,
ClientSecret: b.getEnv("CONNECTOR_NOTION_CLIENT_SECRET"),
},
},
})
)
}
if githubClientID := b.getEnv("CONNECTOR_GITHUB_CLIENT_ID"); githubClientID != "" {
cfg.Probod.Connectors = append(cfg.Probod.Connectors, probodconfig.ConnectorConfig{
Provider: "GITHUB",
Protocol: "oauth2",
RawConfig: probodconfig.ConnectorConfigOAuth2{
ClientID: githubClientID,
ClientSecret: b.getEnv("CONNECTOR_GITHUB_CLIENT_SECRET"),
cfg.Probod.Connectors = append(
cfg.Probod.Connectors,
probodconfig.ConnectorConfig{
Provider: "GITHUB",
Protocol: "oauth2",
RawConfig: probodconfig.ConnectorConfigOAuth2{
ClientID: githubClientID,
ClientSecret: b.getEnv("CONNECTOR_GITHUB_CLIENT_SECRET"),
},
},
})
)
}
if sentryClientID := b.getEnv("CONNECTOR_SENTRY_CLIENT_ID"); sentryClientID != "" {
cfg.Probod.Connectors = append(cfg.Probod.Connectors, probodconfig.ConnectorConfig{
Provider: "SENTRY",
Protocol: "oauth2",
RawConfig: probodconfig.ConnectorConfigOAuth2{
ClientID: sentryClientID,
ClientSecret: b.getEnv("CONNECTOR_SENTRY_CLIENT_SECRET"),
cfg.Probod.Connectors = append(
cfg.Probod.Connectors,
probodconfig.ConnectorConfig{
Provider: "SENTRY",
Protocol: "oauth2",
RawConfig: probodconfig.ConnectorConfigOAuth2{
ClientID: sentryClientID,
ClientSecret: b.getEnv("CONNECTOR_SENTRY_CLIENT_SECRET"),
},
},
})
)
}
if intercomClientID := b.getEnv("CONNECTOR_INTERCOM_CLIENT_ID"); intercomClientID != "" {
cfg.Probod.Connectors = append(cfg.Probod.Connectors, probodconfig.ConnectorConfig{
Provider: "INTERCOM",
Protocol: "oauth2",
RawConfig: probodconfig.ConnectorConfigOAuth2{
ClientID: intercomClientID,
ClientSecret: b.getEnv("CONNECTOR_INTERCOM_CLIENT_SECRET"),
cfg.Probod.Connectors = append(
cfg.Probod.Connectors,
probodconfig.ConnectorConfig{
Provider: "INTERCOM",
Protocol: "oauth2",
RawConfig: probodconfig.ConnectorConfigOAuth2{
ClientID: intercomClientID,
ClientSecret: b.getEnv("CONNECTOR_INTERCOM_CLIENT_SECRET"),
},
},
})
)
}
if brexClientID := b.getEnv("CONNECTOR_BREX_CLIENT_ID"); brexClientID != "" {
cfg.Probod.Connectors = append(cfg.Probod.Connectors, probodconfig.ConnectorConfig{
Provider: "BREX",
Protocol: "oauth2",
RawConfig: probodconfig.ConnectorConfigOAuth2{
ClientID: brexClientID,
ClientSecret: b.getEnv("CONNECTOR_BREX_CLIENT_SECRET"),
cfg.Probod.Connectors = append(
cfg.Probod.Connectors,
probodconfig.ConnectorConfig{
Provider: "BREX",
Protocol: "oauth2",
RawConfig: probodconfig.ConnectorConfigOAuth2{
ClientID: brexClientID,
ClientSecret: b.getEnv("CONNECTOR_BREX_CLIENT_SECRET"),
},
},
})
)
}
if googleWorkspaceClientID := b.getEnv("CONNECTOR_GOOGLE_WORKSPACE_CLIENT_ID"); googleWorkspaceClientID != "" {
cfg.Probod.Connectors = append(cfg.Probod.Connectors, probodconfig.ConnectorConfig{
Provider: "GOOGLE_WORKSPACE",
Protocol: "oauth2",
RawConfig: probodconfig.ConnectorConfigOAuth2{
ClientID: googleWorkspaceClientID,
ClientSecret: b.getEnv("CONNECTOR_GOOGLE_WORKSPACE_CLIENT_SECRET"),
cfg.Probod.Connectors = append(
cfg.Probod.Connectors,
probodconfig.ConnectorConfig{
Provider: "GOOGLE_WORKSPACE",
Protocol: "oauth2",
RawConfig: probodconfig.ConnectorConfigOAuth2{
ClientID: googleWorkspaceClientID,
ClientSecret: b.getEnv("CONNECTOR_GOOGLE_WORKSPACE_CLIENT_SECRET"),
},
},
})
)
}
if microsoft365ClientID := b.getEnv("CONNECTOR_MICROSOFT_365_CLIENT_ID"); microsoft365ClientID != "" {
cfg.Probod.Connectors = append(cfg.Probod.Connectors, probodconfig.ConnectorConfig{
Provider: "MICROSOFT_365",
Protocol: "oauth2",
RawConfig: probodconfig.ConnectorConfigOAuth2{
ClientID: microsoft365ClientID,
ClientSecret: b.getEnv("CONNECTOR_MICROSOFT_365_CLIENT_SECRET"),
cfg.Probod.Connectors = append(
cfg.Probod.Connectors,
probodconfig.ConnectorConfig{
Provider: "MICROSOFT_365",
Protocol: "oauth2",
RawConfig: probodconfig.ConnectorConfigOAuth2{
ClientID: microsoft365ClientID,
ClientSecret: b.getEnv("CONNECTOR_MICROSOFT_365_CLIENT_SECRET"),
},
},
})
)
}
for _, provider := range []string{
@@ -374,28 +404,34 @@ func (b *Builder) Build() (*probodconfig.FullConfig, error) {
continue
}
cfg.Probod.Connectors = append(cfg.Probod.Connectors, probodconfig.ConnectorConfig{
Provider: provider,
Protocol: "oauth2",
RawConfig: probodconfig.ConnectorConfigOAuth2{
ClientID: clientID,
ClientSecret: b.getEnv("CONNECTOR_" + provider + "_CLIENT_SECRET"),
cfg.Probod.Connectors = append(
cfg.Probod.Connectors,
probodconfig.ConnectorConfig{
Provider: provider,
Protocol: "oauth2",
RawConfig: probodconfig.ConnectorConfigOAuth2{
ClientID: clientID,
ClientSecret: b.getEnv("CONNECTOR_" + provider + "_CLIENT_SECRET"),
},
},
})
)
}
// Vercel needs the operator-supplied integration slug to resolve the
// templated AuthURL ("https://vercel.com/integrations/{integration_slug}/new").
if vercelClientID := b.getEnv("CONNECTOR_VERCEL_CLIENT_ID"); vercelClientID != "" {
cfg.Probod.Connectors = append(cfg.Probod.Connectors, probodconfig.ConnectorConfig{
Provider: "VERCEL",
Protocol: "oauth2",
RawConfig: probodconfig.ConnectorConfigOAuth2{
ClientID: vercelClientID,
ClientSecret: b.getEnv("CONNECTOR_VERCEL_CLIENT_SECRET"),
IntegrationSlug: b.getEnv("CONNECTOR_VERCEL_INTEGRATION_SLUG"),
cfg.Probod.Connectors = append(
cfg.Probod.Connectors,
probodconfig.ConnectorConfig{
Provider: "VERCEL",
Protocol: "oauth2",
RawConfig: probodconfig.ConnectorConfigOAuth2{
ClientID: vercelClientID,
ClientSecret: b.getEnv("CONNECTOR_VERCEL_CLIENT_SECRET"),
IntegrationSlug: b.getEnv("CONNECTOR_VERCEL_INTEGRATION_SLUG"),
},
},
})
)
}
return cfg, nil

View File

@@ -32,10 +32,12 @@ func GenerateOAuth2SigningKey() (string, error) {
return "", fmt.Errorf("generate RSA key: %w", err)
}
keyPEM := pem.EncodeToMemory(&pem.Block{
Type: "RSA PRIVATE KEY",
Bytes: x509.MarshalPKCS1PrivateKey(privateKey),
})
keyPEM := pem.EncodeToMemory(
&pem.Block{
Type: "RSA PRIVATE KEY",
Bytes: x509.MarshalPKCS1PrivateKey(privateKey),
},
)
return string(keyPEM), nil
}

View File

@@ -62,15 +62,19 @@ func GenerateSAMLCertificate() (cert string, key string, err error) {
return "", "", fmt.Errorf("create certificate: %w", err)
}
certPEM := pem.EncodeToMemory(&pem.Block{
Type: "CERTIFICATE",
Bytes: certDER,
})
certPEM := pem.EncodeToMemory(
&pem.Block{
Type: "CERTIFICATE",
Bytes: certDER,
},
)
keyPEM := pem.EncodeToMemory(&pem.Block{
Type: "RSA PRIVATE KEY",
Bytes: x509.MarshalPKCS1PrivateKey(privateKey),
})
keyPEM := pem.EncodeToMemory(
&pem.Block{
Type: "RSA PRIVATE KEY",
Bytes: x509.MarshalPKCS1PrivateKey(privateKey),
},
)
return string(certPEM), string(keyPEM), nil
}

View File

@@ -21,13 +21,12 @@ import (
"strings"
"time"
"codeberg.org/miekg/dns"
"go.gearno.de/kit/log"
"go.gearno.de/kit/pg"
"go.probo.inc/probo/pkg/coredata"
"go.probo.inc/probo/pkg/crypto/cipher"
"go.probo.inc/probo/pkg/gid"
"codeberg.org/miekg/dns"
)
type (

View File

@@ -245,10 +245,12 @@ func (c *Client) doUploadRequest(
writer := multipart.NewWriter(&buf)
// Part 1: operations
operationsJSON, err := json.Marshal(graphQLRequest{
Query: query,
Variables: variables,
})
operationsJSON, err := json.Marshal(
graphQLRequest{
Query: query,
Variables: variables,
},
)
if err != nil {
return nil, fmt.Errorf("cannot marshal operations: %w", err)
}
@@ -258,9 +260,11 @@ func (c *Client) doUploadRequest(
}
// Part 2: map
mapJSON, err := json.Marshal(map[string][]string{
"0": {varPath},
})
mapJSON, err := json.Marshal(
map[string][]string{
"0": {varPath},
},
)
if err != nil {
return nil, fmt.Errorf("cannot marshal map: %w", err)
}

View File

@@ -338,10 +338,12 @@ INSERT INTO connectors (
if c.Provider == ConnectorProviderSlack {
if slackConn, ok := c.Connection.(*connector.SlackConnection); ok {
_ = c.SetSettings(&SlackConnectorSettings{
Channel: slackConn.Settings.Channel,
ChannelID: slackConn.Settings.ChannelID,
})
_ = c.SetSettings(
&SlackConnectorSettings{
Channel: slackConn.Settings.Channel,
ChannelID: slackConn.Settings.ChannelID,
},
)
}
}
@@ -554,10 +556,12 @@ WHERE
if c.Provider == ConnectorProviderSlack {
if slackConn, ok := c.Connection.(*connector.SlackConnection); ok {
_ = c.SetSettings(&SlackConnectorSettings{
Channel: slackConn.Settings.Channel,
ChannelID: slackConn.Settings.ChannelID,
})
_ = c.SetSettings(
&SlackConnectorSettings{
Channel: slackConn.Settings.Channel,
ChannelID: slackConn.Settings.ChannelID,
},
)
}
}

View File

@@ -18,7 +18,6 @@ import (
"testing"
"github.com/stretchr/testify/assert"
"go.probo.inc/probo/pkg/connector"
)

View File

@@ -822,8 +822,7 @@ VALUES (
_, err := conn.Exec(ctx, q, args)
if err != nil {
var pgErr *pgconn.PgError
if errors.As(err, &pgErr) {
if pgErr, ok := errors.AsType[*pgconn.PgError](err); ok {
if pgErr.Code == "23505" && pgErr.ConstraintName == "controls_framework_ref_unique" {
return ErrResourceAlreadyExists
}
@@ -892,8 +891,7 @@ WHERE %s
_, err := conn.Exec(ctx, q, args)
if err != nil {
var pgErr *pgconn.PgError
if errors.As(err, &pgErr) {
if pgErr, ok := errors.AsType[*pgconn.PgError](err); ok {
if pgErr.Code == "23505" && pgErr.ConstraintName == "controls_framework_ref_unique" {
return ErrResourceAlreadyExists
}

View File

@@ -72,8 +72,7 @@ VALUES (
_, err := conn.Exec(ctx, q, args)
if err != nil {
var pgErr *pgconn.PgError
if errors.As(err, &pgErr) {
if pgErr, ok := errors.AsType[*pgconn.PgError](err); ok {
if pgErr.Code == "23505" && pgErr.ConstraintName == "controls_policies_pkey" {
return ErrResourceAlreadyExists
}

View File

@@ -458,8 +458,7 @@ INSERT INTO custom_domains (
_, err := conn.Exec(ctx, q, args)
if err != nil {
var pgErr *pgconn.PgError
if errors.As(err, &pgErr) {
if pgErr, ok := errors.AsType[*pgconn.PgError](err); ok {
if pgErr.Code == "23505" && pgErr.ConstraintName == "custom_domains_domain_key" {
return ErrResourceAlreadyExists
}

View File

@@ -453,8 +453,7 @@ INSERT INTO processing_activity_data_protection_impact_assessments (
_, err := conn.Exec(ctx, q, args)
if err != nil {
var pgErr *pgconn.PgError
if errors.As(err, &pgErr) {
if pgErr, ok := errors.AsType[*pgconn.PgError](err); ok {
if pgErr.Code == "23505" && pgErr.ConstraintName == "processing_activity_dpias_processing_activity_id_snapshot_id_uniq" {
return ErrResourceAlreadyExists
}

View File

@@ -130,13 +130,16 @@ WHEN NOT MATCHED BY SOURCE
result := make(DocumentDefaultApprovers, 0, len(approverProfileIDs))
for _, profileID := range approverProfileIDs {
result = append(result, &DocumentDefaultApprover{
DocumentID: documentID,
ApproverProfileID: profileID,
OrganizationID: organizationID,
CreatedAt: now,
UpdatedAt: now,
})
result = append(
result,
&DocumentDefaultApprover{
DocumentID: documentID,
ApproverProfileID: profileID,
OrganizationID: organizationID,
CreatedAt: now,
UpdatedAt: now,
},
)
}
*das = result

View File

@@ -273,8 +273,7 @@ VALUES (
_, err := conn.Exec(ctx, q, args)
if err != nil {
var pgErr *pgconn.PgError
if errors.As(err, &pgErr) {
if pgErr, ok := errors.AsType[*pgconn.PgError](err); ok {
if pgErr.Code == "23505" {
if pgErr.ConstraintName == "document_versions_document_id_major_minor_key" || pgErr.ConstraintName == "document_one_active_version_idx" {
return ErrResourceAlreadyExists
@@ -589,9 +588,13 @@ LIMIT 1
FOR UPDATE OF dv SKIP LOCKED;
`
rows, err := conn.Query(ctx, q, pgx.StrictNamedArgs{
"max_pdf_attempts": maxAttempts,
})
rows, err := conn.Query(
ctx,
q,
pgx.StrictNamedArgs{
"max_pdf_attempts": maxAttempts,
},
)
if err != nil {
return fmt.Errorf("cannot query document versions: %w", err)
}

View File

@@ -328,19 +328,22 @@ func (ds DocumentVersionApprovalDecisions) BulkInsert(
rows := make([][]any, 0, len(ds))
for _, d := range ds {
rows = append(rows, []any{
d.ID,
scope.GetTenantID(),
d.OrganizationID,
d.QuorumID,
d.ApproverID,
d.State,
d.Comment,
d.ElectronicSignatureID,
d.DecidedAt,
d.CreatedAt,
d.UpdatedAt,
})
rows = append(
rows,
[]any{
d.ID,
scope.GetTenantID(),
d.OrganizationID,
d.QuorumID,
d.ApproverID,
d.State,
d.Comment,
d.ElectronicSignatureID,
d.DecidedAt,
d.CreatedAt,
d.UpdatedAt,
},
)
}
_, err := conn.CopyFrom(

View File

@@ -216,8 +216,7 @@ INSERT INTO document_version_signatures (
_, err := conn.Exec(ctx, q, args)
if err != nil {
var pgErr *pgconn.PgError
if errors.As(err, &pgErr) {
if pgErr, ok := errors.AsType[*pgconn.PgError](err); ok {
if pgErr.Code == "23505" && pgErr.ConstraintName == "policy_version_signatures_policy_version_id_signed_by_key" {
return ErrResourceAlreadyExists
}

View File

@@ -176,20 +176,23 @@ func (emails Emails) BulkInsert(
rows := make([][]any, 0, len(emails))
for _, e := range emails {
rows = append(rows, []any{
e.ID,
e.RecipientEmail,
e.RecipientName,
e.SenderName,
e.ReplyTo,
e.UnsubscribeURL,
e.MailingListUpdateID,
e.Subject,
e.TextBody,
e.HtmlBody,
e.CreatedAt,
e.UpdatedAt,
})
rows = append(
rows,
[]any{
e.ID,
e.RecipientEmail,
e.RecipientName,
e.SenderName,
e.ReplyTo,
e.UnsubscribeURL,
e.MailingListUpdateID,
e.Subject,
e.TextBody,
e.HtmlBody,
e.CreatedAt,
e.UpdatedAt,
},
)
}
_, err := conn.CopyFrom(

View File

@@ -204,8 +204,7 @@ VALUES (
_, err := conn.Exec(ctx, q, args)
if err != nil {
var pgErr *pgconn.PgError
if errors.As(err, &pgErr) {
if pgErr, ok := errors.AsType[*pgconn.PgError](err); ok {
if pgErr.Code == "23505" && pgErr.ConstraintName == "evidences_reference_id_key" {
return ErrResourceAlreadyExists
}

View File

@@ -20,26 +20,24 @@ import (
)
type (
EvidenceState uint8
EvidenceState string
)
const (
EvidenceStateRequested EvidenceState = iota
EvidenceStateFulfilled
EvidenceStateRequested EvidenceState = "REQUESTED"
EvidenceStateFulfilled EvidenceState = "FULFILLED"
)
func (es EvidenceState) MarshalText() ([]byte, error) {
return []byte(es.String()), nil
return []byte(es), nil
}
func (es *EvidenceState) UnmarshalText(data []byte) error {
val := string(data)
val := EvidenceState(data)
switch val {
case EvidenceStateRequested.String():
*es = EvidenceStateRequested
case EvidenceStateFulfilled.String():
*es = EvidenceStateFulfilled
case EvidenceStateRequested, EvidenceStateFulfilled:
*es = val
default:
return fmt.Errorf("invalid EvidenceState value: %q", val)
}
@@ -48,16 +46,7 @@ func (es *EvidenceState) UnmarshalText(data []byte) error {
}
func (es EvidenceState) String() string {
var val string
switch es {
case EvidenceStateRequested:
val = "REQUESTED"
case EvidenceStateFulfilled:
val = "FULFILLED"
}
return val
return string(es)
}
func (es *EvidenceState) Scan(value any) error {
@@ -70,5 +59,5 @@ func (es *EvidenceState) Scan(value any) error {
}
func (es EvidenceState) Value() (driver.Value, error) {
return es.String(), nil
return string(es), nil
}

View File

@@ -20,26 +20,24 @@ import (
)
type (
EvidenceType uint8
EvidenceType string
)
const (
EvidenceTypeFile EvidenceType = iota
EvidenceTypeLink
EvidenceTypeFile EvidenceType = "FILE"
EvidenceTypeLink EvidenceType = "LINK"
)
func (et EvidenceType) MarshalText() ([]byte, error) {
return []byte(et.String()), nil
return []byte(et), nil
}
func (et *EvidenceType) UnmarshalText(data []byte) error {
val := string(data)
val := EvidenceType(data)
switch val {
case EvidenceTypeFile.String():
*et = EvidenceTypeFile
case EvidenceTypeLink.String():
*et = EvidenceTypeLink
case EvidenceTypeFile, EvidenceTypeLink:
*et = val
default:
return fmt.Errorf("invalid EvidenceType value: %q", val)
}
@@ -48,16 +46,7 @@ func (et *EvidenceType) UnmarshalText(data []byte) error {
}
func (et EvidenceType) String() string {
var val string
switch et {
case EvidenceTypeFile:
val = "FILE"
case EvidenceTypeLink:
val = "LINK"
}
return val
return string(et)
}
func (et *EvidenceType) Scan(value any) error {
@@ -70,5 +59,5 @@ func (et *EvidenceType) Scan(value any) error {
}
func (et EvidenceType) Value() (driver.Value, error) {
return et.String(), nil
return string(et), nil
}

View File

@@ -232,8 +232,7 @@ VALUES (
_, err := conn.Exec(ctx, q, args)
if err != nil {
var pgErr *pgconn.PgError
if errors.As(err, &pgErr) {
if pgErr, ok := errors.AsType[*pgconn.PgError](err); ok {
if pgErr.Code == "23505" && pgErr.ConstraintName == "files_file_key_key" {
return ErrResourceAlreadyExists
}

View File

@@ -336,8 +336,7 @@ VALUES (
_, err := conn.Exec(ctx, q, args)
if err != nil {
var pgErr *pgconn.PgError
if errors.As(err, &pgErr) {
if pgErr, ok := errors.AsType[*pgconn.PgError](err); ok {
if pgErr.Code == "23505" && pgErr.ConstraintName == "frameworks_org_ref_unique" {
return ErrResourceAlreadyExists
}

View File

@@ -204,8 +204,7 @@ VALUES (
_, err := conn.Exec(ctx, q, args)
if err != nil {
var pgErr *pgconn.PgError
if errors.As(err, &pgErr) {
if pgErr, ok := errors.AsType[*pgconn.PgError](err); ok {
if pgErr.Code == "23505" && strings.Contains(pgErr.ConstraintName, "email_address") {
return ErrResourceAlreadyExists
}

View File

@@ -23,10 +23,9 @@ import (
"github.com/jackc/pgx/v5"
"github.com/jackc/pgx/v5/pgconn"
"go.gearno.de/kit/pg"
"go.probo.inc/probo/pkg/gid"
"go.probo.inc/probo/pkg/page"
"go.gearno.de/kit/pg"
)
type (
@@ -630,8 +629,7 @@ VALUES (
_, err := conn.Exec(ctx, q, args)
if err != nil {
var pgErr *pgconn.PgError
if errors.As(err, &pgErr) {
if pgErr, ok := errors.AsType[*pgconn.PgError](err); ok {
if pgErr.Code == "23505" && pgErr.ConstraintName == "mitigations_org_ref_unique" {
return ErrResourceAlreadyExists
}

View File

@@ -72,8 +72,7 @@ VALUES (
_, err := conn.Exec(ctx, q, args)
if err != nil {
var pgErr *pgconn.PgError
if errors.As(err, &pgErr) {
if pgErr, ok := errors.AsType[*pgconn.PgError](err); ok {
if pgErr.Code == "23505" && pgErr.ConstraintName == "measures_documents_pkey" {
return ErrResourceAlreadyExists
}

View File

@@ -20,16 +20,16 @@ import (
)
type (
MeasureState uint8
MeasureState string
)
const (
MeasureStateNotStarted MeasureState = iota
MeasureStateInProgress
MeasureStateNotApplicable
MeasureStateImplemented
MeasureStateUnknown
MeasureStateNotImplemented
MeasureStateNotStarted MeasureState = "NOT_STARTED"
MeasureStateInProgress MeasureState = "IN_PROGRESS"
MeasureStateNotApplicable MeasureState = "NOT_APPLICABLE"
MeasureStateImplemented MeasureState = "IMPLEMENTED"
MeasureStateUnknown MeasureState = "UNKNOWN"
MeasureStateNotImplemented MeasureState = "NOT_IMPLEMENTED"
)
func MeasureStates() []MeasureState {
@@ -44,25 +44,17 @@ func MeasureStates() []MeasureState {
}
func (ms MeasureState) MarshalText() ([]byte, error) {
return []byte(ms.String()), nil
return []byte(ms), nil
}
func (ms *MeasureState) UnmarshalText(data []byte) error {
val := string(data)
val := MeasureState(data)
switch val {
case MeasureStateNotStarted.String():
*ms = MeasureStateNotStarted
case MeasureStateInProgress.String():
*ms = MeasureStateInProgress
case MeasureStateNotApplicable.String():
*ms = MeasureStateNotApplicable
case MeasureStateImplemented.String():
*ms = MeasureStateImplemented
case MeasureStateUnknown.String():
*ms = MeasureStateUnknown
case MeasureStateNotImplemented.String():
*ms = MeasureStateNotImplemented
case MeasureStateNotStarted, MeasureStateInProgress,
MeasureStateNotApplicable, MeasureStateImplemented,
MeasureStateUnknown, MeasureStateNotImplemented:
*ms = val
default:
return fmt.Errorf("invalid MeasureState value: %q", val)
}
@@ -71,24 +63,7 @@ func (ms *MeasureState) UnmarshalText(data []byte) error {
}
func (ms MeasureState) String() string {
var val string
switch ms {
case MeasureStateNotStarted:
val = "NOT_STARTED"
case MeasureStateInProgress:
val = "IN_PROGRESS"
case MeasureStateNotApplicable:
val = "NOT_APPLICABLE"
case MeasureStateImplemented:
val = "IMPLEMENTED"
case MeasureStateUnknown:
val = "UNKNOWN"
case MeasureStateNotImplemented:
val = "NOT_IMPLEMENTED"
}
return val
return string(ms)
}
func (ms *MeasureState) Scan(value any) error {
@@ -101,5 +76,5 @@ func (ms *MeasureState) Scan(value any) error {
}
func (ms MeasureState) Value() (driver.Value, error) {
return ms.String(), nil
return string(ms), nil
}

View File

@@ -51,8 +51,7 @@ VALUES (@id, @organization_id, @used_at, @expires_at)
_, err := conn.Exec(ctx, query, args)
if err != nil {
var pgErr *pgconn.PgError
if errors.As(err, &pgErr) && pgErr.Code == "23505" && pgErr.ConstraintName == "iam_saml_assertions_pkey" {
if pgErr, ok := errors.AsType[*pgconn.PgError](err); ok && pgErr.Code == "23505" && pgErr.ConstraintName == "iam_saml_assertions_pkey" {
return ErrResourceAlreadyExists
}

View File

@@ -333,8 +333,7 @@ INSERT INTO iam_saml_configurations (
_, err := conn.Exec(ctx, q, args)
if err != nil {
var pgErr *pgconn.PgError
if errors.As(err, &pgErr) {
if pgErr, ok := errors.AsType[*pgconn.PgError](err); ok {
if pgErr.Code == "23505" && pgErr.ConstraintName == "idx_saml_config_domain_org_unique" {
return ErrResourceAlreadyExists
}

View File

@@ -268,8 +268,7 @@ INSERT INTO iam_scim_configurations (
_, err := conn.Exec(ctx, q, args)
if err != nil {
var pgErr *pgconn.PgError
if errors.As(err, &pgErr) {
if pgErr, ok := errors.AsType[*pgconn.PgError](err); ok {
if pgErr.Code == "23505" && pgErr.ConstraintName == "iam_scim_configurations_organization_unique" {
return ErrResourceAlreadyExists
}

View File

@@ -23,10 +23,9 @@ import (
"github.com/jackc/pgx/v5"
"github.com/jackc/pgx/v5/pgconn"
"go.gearno.de/kit/pg"
"go.probo.inc/probo/pkg/gid"
"go.probo.inc/probo/pkg/page"
"go.gearno.de/kit/pg"
)
type (
@@ -252,8 +251,7 @@ RETURNING rank, priority_rank;
err := conn.QueryRow(ctx, q, args).Scan(&t.Rank, &t.PriorityRank)
if err != nil {
var pgErr *pgconn.PgError
if errors.As(err, &pgErr) {
if pgErr, ok := errors.AsType[*pgconn.PgError](err); ok {
if pgErr.Code == "23505" && pgErr.ConstraintName == "tasks_reference_id_unique" {
return ErrResourceAlreadyExists
}

View File

@@ -94,8 +94,7 @@ INSERT INTO iam_tokens(
_, err := conn.Exec(ctx, q, args)
if err != nil {
var pgErr *pgconn.PgError
if errors.As(err, &pgErr) {
if pgErr, ok := errors.AsType[*pgconn.PgError](err); ok {
if pgErr.Code == "23505" && pgErr.ConstraintName == "iam_tokens_hashed_value_unique" {
return ErrResourceAlreadyExists
}

View File

@@ -452,8 +452,7 @@ INSERT INTO processing_activity_transfer_impact_assessments (
_, err := conn.Exec(ctx, q, args)
if err != nil {
var pgErr *pgconn.PgError
if errors.As(err, &pgErr) {
if pgErr, ok := errors.AsType[*pgconn.PgError](err); ok {
if pgErr.Code == "23505" && pgErr.ConstraintName == "processing_activity_tias_processing_activity_id_snapshot_id_uniq" {
return ErrResourceAlreadyExists
}

View File

@@ -327,8 +327,7 @@ INSERT INTO trust_centers (
_, err := conn.Exec(ctx, q, args)
if err != nil {
var pgErr *pgconn.PgError
if errors.As(err, &pgErr) {
if pgErr, ok := errors.AsType[*pgconn.PgError](err); ok {
if pgErr.Code == "23505" && pgErr.ConstraintName == "trust_centers_slug_key" {
return ErrResourceAlreadyExists
}

View File

@@ -208,8 +208,7 @@ INSERT INTO trust_center_accesses (
_, err := conn.Exec(ctx, q, args)
if err != nil {
var pgErr *pgconn.PgError
if errors.As(err, &pgErr) {
if pgErr, ok := errors.AsType[*pgconn.PgError](err); ok {
if pgErr.Code == "23505" && pgErr.ConstraintName == "trust_center_accesses_trust_center_id_email_key" {
return ErrResourceAlreadyExists
}

View File

@@ -271,8 +271,7 @@ INSERT INTO trust_center_document_accesses (
_, err := conn.Exec(ctx, q, args)
if err != nil {
var pgErr *pgconn.PgError
if errors.As(err, &pgErr) {
if pgErr, ok := errors.AsType[*pgconn.PgError](err); ok {
if pgErr.Code == "23505" {
switch pgErr.ConstraintName {
case "trust_center_document_accesse_trust_center_access_id_docume_key",

View File

@@ -171,8 +171,7 @@ RETURNING rank;
err := conn.QueryRow(ctx, q, args).Scan(&t.Rank)
if err != nil {
var pgErr *pgconn.PgError
if errors.As(err, &pgErr) {
if pgErr, ok := errors.AsType[*pgconn.PgError](err); ok {
if pgErr.Code == "23505" && pgErr.ConstraintName == "trust_center_references_trust_center_id_rank_key" {
return ErrResourceAlreadyExists
}

View File

@@ -25,12 +25,11 @@ import (
"go.gearno.de/kit/pg"
"go.gearno.de/kit/worker"
"go.gearno.de/x/ref"
emails "go.probo.inc/probo/packages/emails"
"go.probo.inc/probo/pkg/coredata"
"go.probo.inc/probo/pkg/filemanager"
"go.probo.inc/probo/pkg/gid"
"go.probo.inc/probo/pkg/mail"
emails "go.probo.inc/probo/packages/emails"
)
// EmailPresenterConfigFunc resolves the emails.PresenterConfig for the

View File

@@ -646,8 +646,7 @@ func (s AuthService) SendMagicLink(ctx context.Context, req *SendMagicLinkReques
func (s AuthService) GetMagicLinkEmail(ctx context.Context, tokenString string) (mail.Addr, error) {
payload, err := statelesstoken.ValidateToken[MagicLinkData](s.tokenSecret, TokenTypeMagicLink, tokenString)
if err != nil {
var errExpired *statelesstoken.ErrExpiredToken
if errors.As(err, &errExpired) {
if _, ok := errors.AsType[*statelesstoken.ErrExpiredToken](err); ok {
return mail.Nil, NewExpiredTokenError()
}
@@ -666,8 +665,7 @@ func (s AuthService) OpenSessionWithMagicLink(ctx context.Context, tokenString s
payload, err := statelesstoken.ValidateToken[MagicLinkData](s.tokenSecret, TokenTypeMagicLink, tokenString)
if err != nil {
var errExpired *statelesstoken.ErrExpiredToken
if errors.As(err, &errExpired) {
if _, ok := errors.AsType[*statelesstoken.ErrExpiredToken](err); ok {
return nil, nil, nil, NewExpiredTokenError()
}

View File

@@ -101,12 +101,11 @@ func (a *Authorizer) authorize(ctx context.Context, tx pg.Tx, params AuthorizePa
*params.Session,
membership.ID,
); err != nil {
var (
errSessionNotFound *ErrSessionNotFound
errSessionExpired *ErrSessionExpired
)
if _, ok := errors.AsType[*ErrSessionNotFound](err); ok {
return NewAssumptionRequiredError(params.Principal, membership.ID)
}
if errors.As(err, &errSessionNotFound) || errors.As(err, &errSessionExpired) {
if _, ok := errors.AsType[*ErrSessionExpired](err); ok {
return NewAssumptionRequiredError(params.Principal, membership.ID)
}

View File

@@ -19,7 +19,6 @@ import (
"github.com/stretchr/testify/assert"
"github.com/stretchr/testify/require"
"go.probo.inc/probo/pkg/iam/policy"
)

View File

@@ -23,11 +23,10 @@ import (
"net/http"
"strings"
admin "google.golang.org/api/admin/directory/v1"
"google.golang.org/api/option"
scimclient "go.probo.inc/probo/pkg/iam/scim/bridge/client"
"go.probo.inc/probo/pkg/iam/scim/bridge/provider"
admin "google.golang.org/api/admin/directory/v1"
"google.golang.org/api/option"
)
var _ provider.Provider = (*Provider)(nil)

View File

@@ -396,8 +396,8 @@ func mapError(err error) error {
return &llm.ErrStreamingRequired{Err: err}
}
var apiErr *anthropic.Error
if !errors.As(err, &apiErr) {
apiErr, ok := errors.AsType[*anthropic.Error](err)
if !ok {
return err
}

View File

@@ -329,9 +329,8 @@ func mapStopReason(reason types.StopReason) llm.FinishReason {
}
func mapError(err error) error {
var respErr *smithyhttp.ResponseError
if !errors.As(err, &respErr) {
// Check for common error types by message content.
respErr, ok := errors.AsType[*smithyhttp.ResponseError](err)
if !ok {
msg := err.Error()
if strings.Contains(msg, "throttling") || strings.Contains(msg, "ThrottlingException") {
return &llm.ErrRateLimit{Err: err}

View File

@@ -206,10 +206,13 @@ func (a *StreamAccumulator) Response() *ChatCompletionResponse {
var parts []Part
if thinking := a.thinking.String(); thinking != "" {
parts = append(parts, ThinkingPart{
Text: thinking,
Signature: a.thinkingSignature,
})
parts = append(
parts,
ThinkingPart{
Text: thinking,
Signature: a.thinkingSignature,
},
)
}
parts = append(parts, TextPart{Text: a.content.String()})

View File

@@ -213,9 +213,10 @@ func buildMessages(messages []llm.Message) []openai.ChatCompletionMessageParamUn
case llm.ImagePart:
parts = append(
parts,
openai.ImageContentPart(openai.ChatCompletionContentPartImageImageURLParam{
URL: p.URL,
},
openai.ImageContentPart(
openai.ChatCompletionContentPartImageImageURLParam{
URL: p.URL,
},
),
)
case llm.FilePart:
@@ -381,8 +382,8 @@ func mapFinishReason(reason string) llm.FinishReason {
}
func mapError(err error) error {
var apiErr *openai.Error
if !errors.As(err, &apiErr) {
apiErr, ok := errors.AsType[*openai.Error](err)
if !ok {
return err
}
@@ -513,9 +514,11 @@ func isReasoningModel(model string) bool {
func buildFilePart(p llm.FilePart) openai.ChatCompletionContentPartUnionParam {
switch {
case strings.HasPrefix(p.MimeType, "image/"):
return openai.ImageContentPart(openai.ChatCompletionContentPartImageImageURLParam{
URL: fmt.Sprintf("data:%s;base64,%s", p.MimeType, p.Data),
})
return openai.ImageContentPart(
openai.ChatCompletionContentPartImageImageURLParam{
URL: fmt.Sprintf("data:%s;base64,%s", p.MimeType, p.Data),
},
)
case strings.HasPrefix(p.MimeType, "text/"):
decoded, err := base64.StdEncoding.DecodeString(p.Data)
if err != nil {
@@ -524,9 +527,11 @@ func buildFilePart(p llm.FilePart) openai.ChatCompletionContentPartUnionParam {
return openai.TextContentPart(fmt.Sprintf("File: %s\n\n%s", p.Filename, string(decoded)))
default:
return openai.FileContentPart(openai.ChatCompletionContentPartFileFileParam{
FileData: param.NewOpt(fmt.Sprintf("data:%s;base64,%s", p.MimeType, p.Data)),
Filename: param.NewOpt(p.Filename),
})
return openai.FileContentPart(
openai.ChatCompletionContentPartFileFileParam{
FileData: param.NewOpt(fmt.Sprintf("data:%s;base64,%s", p.MimeType, p.Data)),
Filename: param.NewOpt(p.Filename),
},
)
}
}

View File

@@ -104,7 +104,8 @@ func (s FileService) UploadAndSaveFile(
ctx context.Context,
fileValidator *filevalidation.FileValidator,
s3Metadata map[string]string,
req *FileUpload) (*coredata.File, error) {
req *FileUpload,
) (*coredata.File, error) {
objectKey, err := uuid.NewV7()
if err != nil {
return nil, fmt.Errorf("cannot generate object key: %w", err)

View File

@@ -29,9 +29,6 @@ import (
"sync"
"time"
"go.probo.inc/probo/packages/emails"
pemutil "go.probo.inc/probo/pkg/crypto/pem"
"github.com/aws/aws-sdk-go-v2/service/s3"
proxyproto "github.com/pires/go-proxyproto"
"github.com/prometheus/client_golang/prometheus"
@@ -43,6 +40,7 @@ import (
"go.gearno.de/kit/unit"
"go.gearno.de/kit/worker"
"go.opentelemetry.io/otel/trace"
"go.probo.inc/probo/packages/emails"
"go.probo.inc/probo/pkg/accessreview"
"go.probo.inc/probo/pkg/awsconfig"
"go.probo.inc/probo/pkg/baseurl"
@@ -53,6 +51,7 @@ import (
"go.probo.inc/probo/pkg/crypto/cipher"
"go.probo.inc/probo/pkg/crypto/keys"
"go.probo.inc/probo/pkg/crypto/passwdhash"
pemutil "go.probo.inc/probo/pkg/crypto/pem"
"go.probo.inc/probo/pkg/esign"
"go.probo.inc/probo/pkg/evidencedescriber"
"go.probo.inc/probo/pkg/file"
@@ -379,11 +378,14 @@ func (impl *Implm) Run(
hasActive = true
}
oauth2SigningKeys = append(oauth2SigningKeys, oauth2server.SigningKey{
PrivateKey: rsaKey,
KID: kid,
Active: keyCfg.Active,
})
oauth2SigningKeys = append(
oauth2SigningKeys,
oauth2server.SigningKey{
PrivateKey: rsaKey,
KID: kid,
Active: keyCfg.Active,
},
)
}
if !hasActive {
@@ -1112,10 +1114,9 @@ func (impl *Implm) runTrustCenterServer(
cert, err := certSelector.GetCertificate(hello)
// Silently reject connections without SNI (load balancers, health checks, scanners)
if err != nil {
var noSNIErr *certmanager.NoSNIError
if errors.As(err, &noSNIErr) {
return nil, nil
}
if _, ok := errors.AsType[*certmanager.NoSNIError](err); ok {
return nil, nil
}
if errors.Is(err, coredata.ErrResourceNotFound) {
return nil, nil

View File

@@ -635,11 +635,14 @@ func (c *converter) convertTableCells(row ast.Node, cellType NodeType) ([]Node,
return nil, fmt.Errorf("cannot marshal table cell attrs: %w", err)
}
cells = append(cells, Node{
Type: cellType,
Attrs: attrs,
Content: content,
})
cells = append(
cells,
Node{
Type: cellType,
Attrs: attrs,
Content: content,
},
)
}
return cells, nil

View File

@@ -62,32 +62,31 @@ func NewAPIKeyMiddleware(svc *iam.Service, tokenSecret string) func(next http.Ha
return
}
apiKey, err := svc.APIKeyService.GetAPIKey(ctx, keyID)
if err != nil {
var (
errPersonalAPIKeyNotFound *iam.ErrPersonalAPIKeyNotFound
errPersonalAPIKeyExpired *iam.ErrPersonalAPIKeyExpired
)
if errors.As(err, &errPersonalAPIKeyNotFound) || errors.As(err, &errPersonalAPIKeyExpired) {
next.ServeHTTP(w, r)
return
}
panic(fmt.Errorf("cannot get personal API key: %w", err))
apiKey, err := svc.APIKeyService.GetAPIKey(ctx, keyID)
if err != nil {
if _, ok := errors.AsType[*iam.ErrPersonalAPIKeyNotFound](err); ok {
next.ServeHTTP(w, r)
return
}
identity, err := svc.AccountService.GetIdentity(ctx, apiKey.IdentityID)
if err != nil {
var errIdentityNotFound *iam.ErrIdentityNotFound
if errors.As(err, &errIdentityNotFound) {
next.ServeHTTP(w, r)
return
}
panic(fmt.Errorf("cannot get identity: %w", err))
if _, ok := errors.AsType[*iam.ErrPersonalAPIKeyExpired](err); ok {
next.ServeHTTP(w, r)
return
}
panic(fmt.Errorf("cannot get personal API key: %w", err))
}
identity, err := svc.AccountService.GetIdentity(ctx, apiKey.IdentityID)
if err != nil {
if _, ok := errors.AsType[*iam.ErrIdentityNotFound](err); ok {
next.ServeHTTP(w, r)
return
}
panic(fmt.Errorf("cannot get identity: %w", err))
}
ctx = ContextWithAPIKey(ctx, apiKey)
ctx = ContextWithIdentity(ctx, identity)

View File

@@ -65,36 +65,37 @@ func NewSessionMiddleware(svc *iam.Service, cookieConfig securecookie.Config) fu
return
}
session, err := svc.SessionService.GetSession(ctx, sessionID)
if err != nil {
var (
errSessionNotFound *iam.ErrSessionNotFound
errSessionExpired *iam.ErrSessionExpired
)
session, err := svc.SessionService.GetSession(ctx, sessionID)
if err != nil {
if _, ok := errors.AsType[*iam.ErrSessionNotFound](err); ok {
securecookie.Clear(w, cookieConfig)
next.ServeHTTP(w, r)
if errors.As(err, &errSessionNotFound) || errors.As(err, &errSessionExpired) {
securecookie.Clear(w, cookieConfig)
next.ServeHTTP(w, r)
return
}
panic(fmt.Errorf("cannot get session: %w", err))
return
}
identity, err := svc.AccountService.GetIdentity(ctx, session.IdentityID)
if err != nil {
var errIdentityNotFound *iam.ErrIdentityNotFound
if errors.As(err, &errIdentityNotFound) {
securecookie.Clear(w, cookieConfig)
next.ServeHTTP(w, r)
if _, ok := errors.AsType[*iam.ErrSessionExpired](err); ok {
securecookie.Clear(w, cookieConfig)
next.ServeHTTP(w, r)
return
}
panic(fmt.Errorf("cannot get identity: %w", err))
return
}
panic(fmt.Errorf("cannot get session: %w", err))
}
identity, err := svc.AccountService.GetIdentity(ctx, session.IdentityID)
if err != nil {
if _, ok := errors.AsType[*iam.ErrIdentityNotFound](err); ok {
securecookie.Clear(w, cookieConfig)
next.ServeHTTP(w, r)
return
}
panic(fmt.Errorf("cannot get identity: %w", err))
}
userAgent := r.UserAgent()
// TODO: will work well when no layer 7 proxy is in front of the server
var ipAddress net.IP

View File

@@ -79,13 +79,11 @@ func NewAuthorizeFunc(
}
if err := svc.Authorizer.Authorize(ctx, params); err != nil {
var errAssumptionRequired *iam.ErrAssumptionRequired
if errors.As(err, &errAssumptionRequired) {
if _, ok := errors.AsType[*iam.ErrAssumptionRequired](err); ok {
return gqlutils.AssumptionRequired(ctx, err)
}
var errInsufficientPermissions *iam.ErrInsufficientPermissions
if errors.As(err, &errInsufficientPermissions) {
if _, ok := errors.AsType[*iam.ErrInsufficientPermissions](err); ok {
return gqlutils.Forbidden(ctx, err)
}

View File

@@ -152,23 +152,27 @@ func (r *queryResolver) Node(ctx context.Context, id gid.GID) (types.Node, error
node, err := loadNode(ctx, id)
if err != nil {
var (
errOrganizationNotFound *iam.ErrOrganizationNotFound
errIdentityNotFound *iam.ErrIdentityNotFound
errSessionNotFound *iam.ErrSessionNotFound
errProfileNotFound *iam.ErrProfileNotFound
errMembershipNotFound *iam.ErrMembershipNotFound
errInvitationNotFound *iam.ErrInvitationNotFound
if _, ok := errors.AsType[*iam.ErrOrganizationNotFound](err); ok {
return nil, gqlutils.NotFound(ctx, err)
}
isNotFoundErr = errors.As(err, &errOrganizationNotFound) ||
errors.As(err, &errIdentityNotFound) ||
errors.As(err, &errSessionNotFound) ||
errors.As(err, &errProfileNotFound) ||
errors.As(err, &errMembershipNotFound) ||
errors.As(err, &errInvitationNotFound)
)
if _, ok := errors.AsType[*iam.ErrIdentityNotFound](err); ok {
return nil, gqlutils.NotFound(ctx, err)
}
if isNotFoundErr {
if _, ok := errors.AsType[*iam.ErrSessionNotFound](err); ok {
return nil, gqlutils.NotFound(ctx, err)
}
if _, ok := errors.AsType[*iam.ErrProfileNotFound](err); ok {
return nil, gqlutils.NotFound(ctx, err)
}
if _, ok := errors.AsType[*iam.ErrMembershipNotFound](err); ok {
return nil, gqlutils.NotFound(ctx, err)
}
if _, ok := errors.AsType[*iam.ErrInvitationNotFound](err); ok {
return nil, gqlutils.NotFound(ctx, err)
}

View File

@@ -36,16 +36,11 @@ func (r *mutationResolver) InviteUser(ctx context.Context, input types.InviteUse
},
)
if err != nil {
var (
errOrganizationNotFound *iam.ErrOrganizationNotFound
errUserAlreadyExists *iam.ErrUserAlreadyExists
)
if errors.As(err, &errOrganizationNotFound) {
if _, ok := errors.AsType[*iam.ErrOrganizationNotFound](err); ok {
return nil, gqlutils.NotFound(ctx, err)
}
if errors.As(err, &errUserAlreadyExists) {
if _, ok := errors.AsType[*iam.ErrUserAlreadyExists](err); ok {
return nil, gqlutils.Conflict(ctx, err)
}

View File

@@ -32,8 +32,7 @@ func (r *membershipResolver) LastSession(ctx context.Context, obj *types.Members
childSession, err := r.iam.SessionService.GetActiveSessionForMembership(ctx, session.ID, obj.ID)
if err != nil {
var errSessionNotFound *iam.ErrSessionNotFound
if errors.As(err, &errSessionNotFound) {
if _, ok := errors.AsType[*iam.ErrSessionNotFound](err); ok {
return nil, nil
}

View File

@@ -263,8 +263,7 @@ func (r *organizationResolver) ScimConfiguration(ctx context.Context, obj *types
config, err := r.iam.OrganizationService.GetSCIMConfiguration(ctx, obj.ID)
if err != nil {
var notFound *iam.ErrNoSCIMConfigurationFound
if errors.As(err, &notFound) {
if _, ok := errors.AsType[*iam.ErrNoSCIMConfigurationFound](err); ok {
return nil, nil
}
@@ -348,8 +347,7 @@ func (r *organizationResolver) Viewer(ctx context.Context, obj *types.Organizati
profile, err := r.iam.OrganizationService.GetProfileForIdentityAndOrganization(ctx, identity.ID, obj.ID)
if err != nil {
var errNotFound *iam.ErrProfileNotFound
if errors.As(err, &errNotFound) {
if _, ok := errors.AsType[*iam.ErrProfileNotFound](err); ok {
return nil, gqlutils.NotFound(ctx, err)
}

View File

@@ -41,8 +41,7 @@ func (r *mutationResolver) CreateUser(ctx context.Context, input types.CreateUse
},
)
if err != nil {
var errAlreadyExists *iam.ErrUserAlreadyExists
if errors.As(err, &errAlreadyExists) {
if _, ok := errors.AsType[*iam.ErrUserAlreadyExists](err); ok {
return nil, gqlutils.Conflict(ctx, err)
}
@@ -113,16 +112,11 @@ func (r *mutationResolver) RemoveUser(ctx context.Context, input types.RemoveUse
err := r.iam.OrganizationService.RemoveUser(ctx, input.OrganizationID, input.ProfileID)
if err != nil {
var (
errManagedBySCIM *iam.ErrUserManagedBySCIM
errLastActiveOwner *iam.ErrLastActiveOwner
)
if errors.As(err, &errManagedBySCIM) {
if _, ok := errors.AsType[*iam.ErrUserManagedBySCIM](err); ok {
return nil, gqlutils.Conflict(ctx, err)
}
if errors.As(err, &errLastActiveOwner) {
if _, ok := errors.AsType[*iam.ErrLastActiveOwner](err); ok {
return nil, gqlutils.Conflict(ctx, err)
}
@@ -147,8 +141,7 @@ func (r *profileResolver) Identity(ctx context.Context, obj *types.Profile) (*ty
identity, err := r.iam.AccountService.GetIdentity(ctx, obj.Identity.ID)
if err != nil {
var errNotFound *iam.ErrIdentityNotFound
if errors.As(err, &errNotFound) {
if _, ok := errors.AsType[*iam.ErrIdentityNotFound](err); ok {
return nil, gqlutils.NotFound(ctx, err)
}
@@ -168,8 +161,7 @@ func (r *profileResolver) Organization(ctx context.Context, obj *types.Profile)
organization, err := r.iam.OrganizationService.GetOrganization(ctx, obj.Organization.ID)
if err != nil {
var errNotFound *iam.ErrOrganizationNotFound
if errors.As(err, &errNotFound) {
if _, ok := errors.AsType[*iam.ErrOrganizationNotFound](err); ok {
return nil, gqlutils.NotFound(ctx, err)
}
@@ -189,8 +181,7 @@ func (r *profileResolver) Membership(ctx context.Context, obj *types.Profile) (*
membership, err := r.iam.AccountService.GetMembershipForOrganization(ctx, obj.Identity.ID, obj.Organization.ID)
if err != nil {
var errNotFound *iam.ErrMembershipNotFound
if errors.As(err, &errNotFound) {
if _, ok := errors.AsType[*iam.ErrMembershipNotFound](err); ok {
return nil, gqlutils.NotFound(ctx, err)
}

View File

@@ -44,8 +44,7 @@ func (r *mutationResolver) CreateSAMLConfiguration(ctx context.Context, input ty
req,
)
if err != nil {
var errSAMLConfigurationEmailDomainAlreadyExists *iam.ErrSAMLConfigurationEmailDomainAlreadyExists
if errors.As(err, &errSAMLConfigurationEmailDomainAlreadyExists) {
if _, ok := errors.AsType[*iam.ErrSAMLConfigurationEmailDomainAlreadyExists](err); ok {
return nil, gqlutils.Conflict(ctx, err)
}

View File

@@ -131,8 +131,7 @@ func (h *SCIMHandler) BearerTokenMiddleware(next http.Handler) http.Handler {
config, err := h.iam.SCIMService.ValidateToken(r.Context(), token)
if err != nil {
var invalidToken *scimservice.ErrSCIMInvalidToken
if errors.As(err, &invalidToken) {
if _, ok := errors.AsType[*scimservice.ErrSCIMInvalidToken](err); ok {
httpserver.RenderError(w, http.StatusUnauthorized, errors.New("invalid token"))
return
}
@@ -149,8 +148,7 @@ func (h *SCIMHandler) BearerTokenMiddleware(next http.Handler) http.Handler {
}
func (rc *scimRequestContext) logAndWrapError(err error, logMsg string) error {
var scimErr scimerrors.ScimError
if errors.As(err, &scimErr) {
if scimErr, ok := errors.AsType[scimerrors.ScimError](err); ok {
errMsg := scimErr.Detail
// Don't reference profileID for 404 errors - the resource doesn't exist

View File

@@ -121,8 +121,7 @@ func (r *sCIMBridgeResolver) ScimConfiguration(ctx context.Context, obj *types.S
scimConfiguration, err := r.iam.GetSCIMConfiguration(ctx, obj.ScimConfiguration.ID)
if err != nil {
var errNoSCIMConfigurationFound *iam.ErrNoSCIMConfigurationFound
if errors.As(err, &errNoSCIMConfigurationFound) {
if _, ok := errors.AsType[*iam.ErrNoSCIMConfigurationFound](err); ok {
return nil, nil
}
@@ -183,8 +182,7 @@ func (r *sCIMConfigurationResolver) Organization(ctx context.Context, obj *types
organization, err := r.iam.OrganizationService.GetOrganization(ctx, obj.Organization.ID)
if err != nil {
var errOrganizationNotFound *iam.ErrOrganizationNotFound
if errors.As(err, &errOrganizationNotFound) {
if _, ok := errors.AsType[*iam.ErrOrganizationNotFound](err); ok {
return nil, nil
}
@@ -208,8 +206,7 @@ func (r *sCIMConfigurationResolver) Bridge(ctx context.Context, obj *types.SCIMC
bridge, err := r.iam.OrganizationService.GetSCIMBridgeByID(ctx, obj.Bridge.ID)
if err != nil {
var errSCIMBridgeNotFound *iam.ErrSCIMBridgeNotFound
if errors.As(err, &errSCIMBridgeNotFound) {
if _, ok := errors.AsType[*iam.ErrSCIMBridgeNotFound](err); ok {
return nil, nil
}

View File

@@ -22,13 +22,11 @@ import (
func (r *mutationResolver) SignIn(ctx context.Context, input types.SignInInput) (*types.SignInPayload, error) {
identity, err := r.iam.AuthService.CheckCredentials(ctx, input.Email, input.Password)
if err != nil {
var errInvalidPassword *iam.ErrInvalidPassword
if errors.As(err, &errInvalidPassword) {
if _, ok := errors.AsType[*iam.ErrInvalidPassword](err); ok {
return nil, gqlutils.Invalid(ctx, err)
}
var errInvalidCredentials *iam.ErrInvalidCredentials
if errors.As(err, &errInvalidCredentials) {
if _, ok := errors.AsType[*iam.ErrInvalidCredentials](err); ok {
return nil, &gqlerror.Error{
Message: err.Error(),
Extensions: map[string]any{
@@ -81,12 +79,11 @@ func (r *mutationResolver) SignIn(ctx context.Context, input types.SignInInput)
_, _, err = r.iam.SessionService.OpenPasswordChildSessionForOrganization(ctx, session.ID, *input.OrganizationID)
if err != nil {
// Here session middleware already took care of expired/nil root session so we only handle membership related errors
var (
errMembershipNotFound *iam.ErrMembershipNotFound
errUserInactive *iam.ErrUserInactive
)
if _, ok := errors.AsType[*iam.ErrMembershipNotFound](err); ok {
return nil, gqlutils.Forbiddenf(ctx, "forbidden")
}
if errors.As(err, &errMembershipNotFound) || errors.As(err, &errUserInactive) {
if _, ok := errors.AsType[*iam.ErrUserInactive](err); ok {
return nil, gqlutils.Forbiddenf(ctx, "forbidden")
}
@@ -113,13 +110,11 @@ func (r *mutationResolver) SignUp(ctx context.Context, input types.SignUpInput)
},
)
if err != nil {
var errIdentityAlreadyExists *iam.ErrIdentityAlreadyExists
if errors.As(err, &errIdentityAlreadyExists) {
if _, ok := errors.AsType[*iam.ErrIdentityAlreadyExists](err); ok {
return nil, gqlutils.Invalid(ctx, err)
}
var errSignupDisabled *iam.ErrSignupDisabled
if errors.As(err, &errSignupDisabled) {
if _, ok := errors.AsType[*iam.ErrSignupDisabled](err); ok {
return nil, gqlutils.Forbidden(ctx, err)
}
@@ -142,8 +137,7 @@ func (r *mutationResolver) SignOut(ctx context.Context) (*types.SignOutPayload,
err := r.iam.SessionService.CloseSession(ctx, session.ID)
if err != nil {
var ErrSessionNotFound *iam.ErrSessionNotFound
if errors.As(err, &ErrSessionNotFound) {
if _, ok := errors.AsType[*iam.ErrSessionNotFound](err); ok {
return &types.SignOutPayload{}, nil
}
@@ -166,8 +160,7 @@ func (r *mutationResolver) ActivateAccount(ctx context.Context, input types.Acti
// Sign out any other account before activating a new one
err := r.iam.SessionService.CloseSession(ctx, session.ID)
if err != nil {
var ErrSessionNotFound *iam.ErrSessionNotFound
if !errors.As(err, &ErrSessionNotFound) {
if _, ok := errors.AsType[*iam.ErrSessionNotFound](err); !ok {
r.logger.ErrorCtx(ctx, "cannot close session", log.Error(err))
return nil, gqlutils.Internal(ctx)
}
@@ -184,17 +177,15 @@ func (r *mutationResolver) ActivateAccount(ctx context.Context, input types.Acti
},
)
if err != nil {
var (
errInvalidToken *iam.ErrInvalidToken
errInvitationNotFound *iam.ErrInvitationNotFound
errInvitationExpired *iam.ErrInvitationExpired
if _, ok := errors.AsType[*iam.ErrInvalidToken](err); ok {
return nil, gqlutils.Invalid(ctx, err)
}
isInvalidErr = errors.As(err, &errInvalidToken) ||
errors.As(err, &errInvitationNotFound) ||
errors.As(err, &errInvitationExpired)
)
if _, ok := errors.AsType[*iam.ErrInvitationNotFound](err); ok {
return nil, gqlutils.Invalid(ctx, err)
}
if isInvalidErr {
if _, ok := errors.AsType[*iam.ErrInvitationExpired](err); ok {
return nil, gqlutils.Invalid(ctx, err)
}
@@ -276,8 +267,7 @@ func (r *mutationResolver) ResetPassword(ctx context.Context, input types.ResetP
},
)
if err != nil {
var errInvalidToken *iam.ErrInvalidToken
if errors.As(err, &errInvalidToken) {
if _, ok := errors.AsType[*iam.ErrInvalidToken](err); ok {
return nil, gqlutils.Invalid(ctx, err)
}
@@ -295,25 +285,19 @@ func (r *mutationResolver) ResetPassword(ctx context.Context, input types.ResetP
func (r *mutationResolver) VerifyEmail(ctx context.Context, input types.VerifyEmailInput) (*types.VerifyEmailPayload, error) {
err := r.iam.AccountService.VerifyEmail(ctx, input.Token)
if err != nil {
var (
errInvalidToken *iam.ErrInvalidToken
errIdentityNotFound *iam.ErrIdentityNotFound
errEmailAlreadyVerified *iam.ErrEmailAlreadyVerified
errEmailVerificationMismatch *iam.ErrEmailVerificationMismatch
isInvalidErr = errors.As(err, &errInvalidToken) ||
errors.As(err, &errEmailVerificationMismatch)
)
if isInvalidErr {
if _, ok := errors.AsType[*iam.ErrInvalidToken](err); ok {
return nil, gqlutils.Invalid(ctx, err)
}
if errors.As(err, &errEmailAlreadyVerified) {
if _, ok := errors.AsType[*iam.ErrEmailVerificationMismatch](err); ok {
return nil, gqlutils.Invalid(ctx, err)
}
if _, ok := errors.AsType[*iam.ErrEmailAlreadyVerified](err); ok {
return nil, gqlutils.Conflict(ctx, err)
}
if errors.As(err, &errIdentityNotFound) {
if _, ok := errors.AsType[*iam.ErrIdentityNotFound](err); ok {
return nil, gqlutils.NotFound(ctx, err)
}
@@ -342,16 +326,11 @@ func (r *mutationResolver) ChangePassword(ctx context.Context, input types.Chang
},
)
if err != nil {
var (
errInvalidPassword *iam.ErrInvalidPassword
errIdentityNotFound *iam.ErrIdentityNotFound
)
if errors.As(err, &errInvalidPassword) {
if _, ok := errors.AsType[*iam.ErrInvalidPassword](err); ok {
return nil, gqlutils.Invalid(ctx, err)
}
if errors.As(err, &errIdentityNotFound) {
if _, ok := errors.AsType[*iam.ErrIdentityNotFound](err); ok {
return nil, gqlutils.NotFound(ctx, err)
}
@@ -378,16 +357,11 @@ func (r *mutationResolver) ChangeEmail(ctx context.Context, input types.ChangeEm
},
)
if err != nil {
var (
errInvalidPassword *iam.ErrInvalidPassword
errIdentityNotFound *iam.ErrIdentityNotFound
)
if errors.As(err, &errInvalidPassword) {
if _, ok := errors.AsType[*iam.ErrInvalidPassword](err); ok {
return nil, gqlutils.Invalid(ctx, err)
}
if errors.As(err, &errIdentityNotFound) {
if _, ok := errors.AsType[*iam.ErrIdentityNotFound](err); ok {
return nil, gqlutils.NotFound(ctx, err)
}
@@ -407,34 +381,28 @@ func (r *mutationResolver) AssumeOrganizationSession(ctx context.Context, input
childSession, membership, err := r.iam.SessionService.AssumeOrganizationSession(ctx, rootSession.ID, input.OrganizationID, input.Continue)
if err != nil {
var (
errMembershipNotFound *iam.ErrMembershipNotFound
errPasswordAuthenticationRequired *iam.ErrPasswordAuthenticationRequired
errSAMLAuthenticationRequired *iam.ErrSAMLAuthenticationRequired
)
switch {
case errors.As(err, &errMembershipNotFound):
if _, ok := errors.AsType[*iam.ErrMembershipNotFound](err); ok {
return nil, gqlutils.NotFound(ctx, err)
}
case errors.As(err, &errPasswordAuthenticationRequired):
if errPasswordAuthenticationRequired, ok := errors.AsType[*iam.ErrPasswordAuthenticationRequired](err); ok {
return &types.AssumeOrganizationSessionPayload{
Result: types.PasswordRequired{
Reason: types.ReauthenticationReason(errPasswordAuthenticationRequired.Reason),
},
}, nil
}
case errors.As(err, &errSAMLAuthenticationRequired):
if errSAMLAuthenticationRequired, ok := errors.AsType[*iam.ErrSAMLAuthenticationRequired](err); ok {
return &types.AssumeOrganizationSessionPayload{
Result: types.SAMLAuthenticationRequired{
Reason: types.ReauthenticationReason(errSAMLAuthenticationRequired.Reason),
},
}, nil
default:
r.logger.ErrorCtx(ctx, "cannot assume organization session", log.Error(err))
return nil, gqlutils.Internal(ctx)
}
r.logger.ErrorCtx(ctx, "cannot assume organization session", log.Error(err))
return nil, gqlutils.Internal(ctx)
}
return &types.AssumeOrganizationSessionPayload{
@@ -455,8 +423,7 @@ func (r *mutationResolver) RevokeSession(ctx context.Context, input types.Revoke
err := r.iam.SessionService.RevokeSession(ctx, identity.ID, input.SessionID)
if err != nil {
var ErrSessionExpired *iam.ErrSessionExpired
if errors.As(err, &ErrSessionExpired) {
if _, ok := errors.AsType[*iam.ErrSessionExpired](err); ok {
return &types.RevokeSessionPayload{Success: true}, nil
}

View File

@@ -55,13 +55,11 @@ func NewRecoverFunc(logger *log.Logger) mcpgenmcp.RecoverFunc {
// those. Unknown errors are logged and replaced with a generic internal error
// to avoid leaking implementation details to the client.
func sanitizeError(ctx context.Context, logger *log.Logger, err error) error {
var permissionDeniedErr *iam.ErrInsufficientPermissions
if errors.As(err, &permissionDeniedErr) {
if _, ok := errors.AsType[*iam.ErrInsufficientPermissions](err); ok {
return fmt.Errorf("permission denied")
}
var assumptionRequiredErr *iam.ErrAssumptionRequired
if errors.As(err, &assumptionRequiredErr) {
if _, ok := errors.AsType[*iam.ErrAssumptionRequired](err); ok {
return fmt.Errorf("assumption required")
}
@@ -77,13 +75,11 @@ func sanitizeError(ctx context.Context, logger *log.Logger, err error) error {
return fmt.Errorf("resource is in use")
}
var validationErrors validator.ValidationErrors
if errors.As(err, &validationErrors) {
if validationErrors, ok := errors.AsType[validator.ValidationErrors](err); ok {
return validationErrors
}
var validationError *validator.ValidationError
if errors.As(err, &validationError) {
if validationError, ok := errors.AsType[*validator.ValidationError](err); ok {
return validationError
}

View File

@@ -15,9 +15,8 @@
package mcp_v1
import (
"net/http"
"errors"
"net/http"
"go.gearno.de/kit/httpserver"
"go.gearno.de/kit/log"

View File

@@ -2435,8 +2435,7 @@ func (r *Resolver) ListUsersTool(ctx context.Context, req *mcp.CallToolRequest,
func (r *Resolver) GetUserTool(ctx context.Context, req *mcp.CallToolRequest, input *types.GetUserInput) (*mcp.CallToolResult, types.GetUserOutput, error) {
profile, err := r.iamSvc.OrganizationService.GetProfile(ctx, input.ID)
if err != nil {
var errNotFound *iam.ErrProfileNotFound
if errors.As(err, &errNotFound) {
if _, ok := errors.AsType[*iam.ErrProfileNotFound](err); ok {
return nil, types.GetUserOutput{}, fmt.Errorf("user not found: %w", err)
}
@@ -2472,8 +2471,7 @@ func (r *Resolver) CreateUserTool(ctx context.Context, req *mcp.CallToolRequest,
ContractEndDate: contractEnd,
})
if err != nil {
var errAlreadyExists *iam.ErrUserAlreadyExists
if errors.As(err, &errAlreadyExists) {
if _, ok := errors.AsType[*iam.ErrUserAlreadyExists](err); ok {
return nil, types.CreateUserOutput{}, fmt.Errorf("user with email already exists: %w", err)
}
@@ -2491,16 +2489,11 @@ func (r *Resolver) InviteUserTool(ctx context.Context, req *mcp.CallToolRequest,
ProfileID: input.ProfileID,
})
if err != nil {
var (
errOrgNotFound *iam.ErrOrganizationNotFound
errUserExists *iam.ErrUserAlreadyExists
)
if errors.As(err, &errOrgNotFound) {
if _, ok := errors.AsType[*iam.ErrOrganizationNotFound](err); ok {
return nil, types.InviteUserOutput{}, fmt.Errorf("organization not found: %w", err)
}
if errors.As(err, &errUserExists) {
if _, ok := errors.AsType[*iam.ErrUserAlreadyExists](err); ok {
return nil, types.InviteUserOutput{}, fmt.Errorf("user already in organization: %w", err)
}
@@ -2574,16 +2567,11 @@ func (r *Resolver) RemoveUserTool(ctx context.Context, req *mcp.CallToolRequest,
err := r.iamSvc.OrganizationService.RemoveUser(ctx, input.OrganizationID, input.ProfileID)
if err != nil {
var (
errManagedBySCIM *iam.ErrUserManagedBySCIM
errLastOwner *iam.ErrLastActiveOwner
)
if errors.As(err, &errManagedBySCIM) {
if _, ok := errors.AsType[*iam.ErrUserManagedBySCIM](err); ok {
return nil, types.RemoveUserOutput{}, fmt.Errorf("user is managed by SCIM and cannot be removed: %w", err)
}
if errors.As(err, &errLastOwner) {
if _, ok := errors.AsType[*iam.ErrLastActiveOwner](err); ok {
return nil, types.RemoveUserOutput{}, fmt.Errorf("cannot remove last active owner: %w", err)
}
@@ -5189,8 +5177,7 @@ func (r *Resolver) GetSCIMConfigurationTool(ctx context.Context, req *mcp.CallTo
config, err := r.iamSvc.OrganizationService.GetSCIMConfiguration(ctx, input.OrganizationID)
if err != nil {
var errNotFound *iam.ErrNoSCIMConfigurationFound
if errors.As(err, &errNotFound) {
if _, ok := errors.AsType[*iam.ErrNoSCIMConfigurationFound](err); ok {
return nil, types.GetSCIMConfigurationOutput{}, fmt.Errorf("SCIM configuration not found")
}
@@ -5255,8 +5242,7 @@ func (r *Resolver) GetSCIMBridgeTool(ctx context.Context, req *mcp.CallToolReque
bridge, err := r.iamSvc.OrganizationService.GetSCIMBridgeByID(ctx, input.ID)
if err != nil {
var errNotFound *iam.ErrSCIMBridgeNotFound
if errors.As(err, &errNotFound) {
if _, ok := errors.AsType[*iam.ErrSCIMBridgeNotFound](err); ok {
return nil, types.GetSCIMBridgeOutput{}, fmt.Errorf("SCIM bridge %s not found", input.ID)
}

View File

@@ -7,8 +7,8 @@ package trust_v1
import (
"context"
"errors"
"errors"
"go.gearno.de/kit/log"
"go.probo.inc/probo/pkg/baseurl"
"go.probo.inc/probo/pkg/coredata"
@@ -58,13 +58,11 @@ func (r *mutationResolver) VerifyMagicLink(ctx context.Context, input types.Veri
email, err := r.iam.AuthService.GetMagicLinkEmail(ctx, input.Token)
if err != nil {
var errExpiredToken *iam.ErrExpiredToken
if errors.As(err, &errExpiredToken) {
if _, ok := errors.AsType[*iam.ErrExpiredToken](err); ok {
return nil, gqlutils.Invalid(ctx, err)
}
var errInvalidToken *iam.ErrInvalidToken
if errors.As(err, &errInvalidToken) {
if _, ok := errors.AsType[*iam.ErrInvalidToken](err); ok {
return nil, gqlutils.Invalid(ctx, err)
}
@@ -81,15 +79,13 @@ func (r *mutationResolver) VerifyMagicLink(ctx context.Context, input types.Veri
identity, session, continueURL, err = r.iam.AuthService.OpenSessionWithMagicLink(ctx, input.Token)
if err != nil {
var errExpiredToken *iam.ErrExpiredToken
if errors.As(err, &errExpiredToken) {
return nil, gqlutils.Invalid(ctx, err)
}
if _, ok := errors.AsType[*iam.ErrExpiredToken](err); ok {
return nil, gqlutils.Invalid(ctx, err)
}
var errInvalidToken *iam.ErrInvalidToken
if errors.As(err, &errInvalidToken) {
return nil, gqlutils.Invalid(ctx, err)
}
if _, ok := errors.AsType[*iam.ErrInvalidToken](err); ok {
return nil, gqlutils.Invalid(ctx, err)
}
r.logger.ErrorCtx(ctx, "cannot open session with magic link", log.Error(err))
@@ -105,15 +101,13 @@ func (r *mutationResolver) VerifyMagicLink(ctx context.Context, input types.Veri
identity, session, continueURL, err = r.iam.AuthService.OpenSessionWithMagicLink(ctx, input.Token)
if err != nil {
var errExpiredToken *iam.ErrExpiredToken
if errors.As(err, &errExpiredToken) {
return nil, gqlutils.Invalid(ctx, err)
}
if _, ok := errors.AsType[*iam.ErrExpiredToken](err); ok {
return nil, gqlutils.Invalid(ctx, err)
}
var errInvalidToken *iam.ErrInvalidToken
if errors.As(err, &errInvalidToken) {
return nil, gqlutils.Invalid(ctx, err)
}
if _, ok := errors.AsType[*iam.ErrInvalidToken](err); ok {
return nil, gqlutils.Invalid(ctx, err)
}
r.logger.ErrorCtx(ctx, "cannot open session with magic link", log.Error(err))

View File

@@ -143,11 +143,9 @@ func Conflictf(ctx context.Context, format string, a ...any) *gqlerror.Error {
}
func Invalid(ctx context.Context, err error) *gqlerror.Error {
var errValidation *validator.ValidationError
var details map[string]any
if errors.As(err, &errValidation) {
if errValidation, ok := errors.AsType[*validator.ValidationError](err); ok {
details = map[string]any{
"cause": errValidation.Code,
"field": errValidation.Field,

Some files were not shown because too many files have changed in this diff Show More