rohit/probo
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Remove useless error checks

Browse Source 
Signed-off-by: Émile Ré <emile@probo.com>
This commit is contained in:
Émile Ré
2026-05-20 09:53:09 +04:00
parent 46c6068559
commit f3cc159f1f
2 changed files with 1 additions and 13 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
pkg/iam/organization_service.go
View File

@@ -1624,7 +1624,7 @@ func (s OrganizationService) DeleteSCIMConfiguration(
connector := &coredata.Connector{ID: *bridge.ConnectorID} connector := &coredata.Connector{ID: *bridge.ConnectorID}
err = connector.Delete(ctx, tx, scope) err = connector.Delete(ctx, tx, scope)
if err != nil && err != coredata.ErrResourceNotFound { if err != nil {
return fmt.Errorf("cannot delete connector: %w", err) return fmt.Errorf("cannot delete connector: %w", err)
} }
} }

12
pkg/mailman/service.go
View File

@@ -269,10 +269,6 @@ func (s *Service) UnsubscribeByEmail(
wasConfirmed := subscriber.Status == coredata.MailingListSubscriberStatusConfirmed wasConfirmed := subscriber.Status == coredata.MailingListSubscriberStatusConfirmed
if err := subscriber.Delete(ctx, tx, scope); err != nil { if err := subscriber.Delete(ctx, tx, scope); err != nil {
if errors.Is(err, coredata.ErrResourceNotFound) {
return ErrSubscriberNotFound
}
return fmt.Errorf("cannot delete mailing list subscriber: %w", err) return fmt.Errorf("cannot delete mailing list subscriber: %w", err)
} }
@@ -348,10 +344,6 @@ func (s *Service) DeleteSubscriber(
wasConfirmed := subscriber.Status == coredata.MailingListSubscriberStatusConfirmed wasConfirmed := subscriber.Status == coredata.MailingListSubscriberStatusConfirmed
if err := subscriber.Delete(ctx, tx, scope); err != nil { if err := subscriber.Delete(ctx, tx, scope); err != nil {
if errors.Is(err, coredata.ErrResourceNotFound) {
return ErrSubscriberNotFound
}
return fmt.Errorf("cannot delete mailing list subscriber: %w", err) return fmt.Errorf("cannot delete mailing list subscriber: %w", err)
} }
@@ -606,10 +598,6 @@ func (s *Service) DeleteMailingListUpdate(
func(ctx context.Context, tx pg.Tx) error { func(ctx context.Context, tx pg.Tx) error {
mlu := coredata.MailingListUpdate{ID: id} mlu := coredata.MailingListUpdate{ID: id}
if err := mlu.Delete(ctx, tx, scope); err != nil { if err := mlu.Delete(ctx, tx, scope); err != nil {
if errors.Is(err, coredata.ErrResourceNotFound) {
return ErrMailingListUpdateNotFound
}
return fmt.Errorf("cannot delete mailing list update: %w", err) return fmt.Errorf("cannot delete mailing list update: %w", err)
} }