From f33a1fe1497f584bf6bb9e89fa64c125d16879ce Mon Sep 17 00:00:00 2001 From: Bryan Frimin Date: Fri, 6 Mar 2026 11:16:50 +0100 Subject: [PATCH] Remove useless comment Signed-off-by: Bryan Frimin --- pkg/bootstrap/builder.go | 9 --------- pkg/bootstrap/write.go | 2 -- pkg/probod/api_config.go | 3 --- pkg/probod/auth_config.go | 5 +---- pkg/probod/aws_config.go | 1 - pkg/probod/connector_config.go | 14 ++++++-------- pkg/probod/custom_domains_config.go | 2 -- pkg/probod/mailer_config.go | 2 -- pkg/probod/notifications_config.go | 2 -- pkg/probod/openai_config.go | 1 - pkg/probod/pg_config.go | 1 - pkg/probod/saml_config.go | 1 - pkg/probod/scim_bridge_config.go | 6 ------ pkg/probod/slack_config.go | 1 - 14 files changed, 7 insertions(+), 43 deletions(-) diff --git a/pkg/bootstrap/builder.go b/pkg/bootstrap/builder.go index c54c27623..204048cd8 100644 --- a/pkg/bootstrap/builder.go +++ b/pkg/bootstrap/builder.go @@ -23,19 +23,14 @@ import ( "go.probo.inc/probo/pkg/probod" ) -// EnvGetter is a function that retrieves environment variables. -// This allows for easy testing by injecting a mock implementation. type EnvGetter func(key string) string -// Builder creates a Config from environment variables. type Builder struct { getEnv EnvGetter samlCertificate string samlPrivateKey string } -// NewBuilder creates a new Builder with the given environment getter. -// If getEnv is nil, os.Getenv is used. func NewBuilder(getEnv EnvGetter) *Builder { if getEnv == nil { getEnv = os.Getenv @@ -43,15 +38,11 @@ func NewBuilder(getEnv EnvGetter) *Builder { return &Builder{getEnv: getEnv} } -// SetSAMLCredentials sets pre-generated SAML certificate and private key. -// If not set, they will be generated automatically if not provided via environment. func (b *Builder) SetSAMLCredentials(certificate, privateKey string) { b.samlCertificate = certificate b.samlPrivateKey = privateKey } -// Build creates a FullConfig from environment variables. -// Returns an error if required environment variables are missing. func (b *Builder) Build() (*probod.FullConfig, error) { if err := b.validateRequired(); err != nil { return nil, err diff --git a/pkg/bootstrap/write.go b/pkg/bootstrap/write.go index a806b60dc..98f418ba8 100644 --- a/pkg/bootstrap/write.go +++ b/pkg/bootstrap/write.go @@ -23,8 +23,6 @@ import ( "gopkg.in/yaml.v3" ) -// WriteConfig writes the configuration to the specified path as YAML. -// It creates the parent directory if it doesn't exist. func WriteConfig(cfg *probod.FullConfig, path string) error { dir := filepath.Dir(path) if err := os.MkdirAll(dir, 0755); err != nil { diff --git a/pkg/probod/api_config.go b/pkg/probod/api_config.go index a651a9b5d..cdd2c8b87 100644 --- a/pkg/probod/api_config.go +++ b/pkg/probod/api_config.go @@ -14,17 +14,14 @@ package probod -// CorsConfig contains CORS settings. type CorsConfig struct { AllowedOrigins []string `json:"allowed-origins"` } -// ProxyProtocolConfig contains proxy protocol settings. type ProxyProtocolConfig struct { TrustedProxies []string `json:"trusted-proxies"` } -// APIConfig contains HTTP API configuration. type APIConfig struct { Addr string `json:"addr"` ProxyProtocol ProxyProtocolConfig `json:"proxy-protocol"` diff --git a/pkg/probod/auth_config.go b/pkg/probod/auth_config.go index 990c6cc3a..32ae0c9ea 100644 --- a/pkg/probod/auth_config.go +++ b/pkg/probod/auth_config.go @@ -19,9 +19,8 @@ import ( "fmt" ) -// AuthConfig contains authentication configuration. type AuthConfig struct { - Cookie CookieConfig `json:"cookie"` + Cookie CookieConfig `json:"cookie"` Password PasswordConfig `json:"password"` DisableSignup bool `json:"disable-signup"` InvitationConfirmationTokenValidity int `json:"invitation-confirmation-token-validity"` @@ -30,7 +29,6 @@ type AuthConfig struct { SAML SAMLConfig `json:"saml"` } -// CookieConfig contains session cookie configuration. type CookieConfig struct { Domain string `json:"domain"` Secret string `json:"secret"` @@ -39,7 +37,6 @@ type CookieConfig struct { Secure bool `json:"secure"` } -// PasswordConfig contains password hashing configuration. type PasswordConfig struct { Iterations int `json:"iterations"` Pepper string `json:"pepper"` diff --git a/pkg/probod/aws_config.go b/pkg/probod/aws_config.go index aa8f09783..70cf4bfa5 100644 --- a/pkg/probod/aws_config.go +++ b/pkg/probod/aws_config.go @@ -14,7 +14,6 @@ package probod -// AWSConfig contains AWS S3 configuration. type AWSConfig struct { Region string `json:"region"` Bucket string `json:"bucket"` diff --git a/pkg/probod/connector_config.go b/pkg/probod/connector_config.go index 133ba063b..d1808fa83 100644 --- a/pkg/probod/connector_config.go +++ b/pkg/probod/connector_config.go @@ -23,17 +23,15 @@ import ( "go.probo.inc/probo/pkg/connector" ) -// ConnectorConfig contains connector configuration. type ConnectorConfig struct { - Provider string `json:"provider"` - Protocol connector.ProtocolType `json:"protocol"` - Config connector.Connector `json:"-"` - RawConfig any `json:"config,omitempty"` - Settings any `json:"-"` - RawSettings any `json:"settings,omitempty"` + Provider string `json:"provider"` + Protocol connector.ProtocolType `json:"protocol"` + Config connector.Connector `json:"-"` + RawConfig any `json:"config,omitempty"` + Settings any `json:"-"` + RawSettings any `json:"settings,omitempty"` } -// ConnectorConfigOAuth2 contains OAuth2 connector configuration. type ConnectorConfigOAuth2 struct { ClientID string `json:"client-id"` ClientSecret string `json:"client-secret"` diff --git a/pkg/probod/custom_domains_config.go b/pkg/probod/custom_domains_config.go index 1b962ba52..bbaad2694 100644 --- a/pkg/probod/custom_domains_config.go +++ b/pkg/probod/custom_domains_config.go @@ -14,7 +14,6 @@ package probod -// CustomDomainsConfig contains custom domain configuration. type CustomDomainsConfig struct { RenewalInterval int `json:"renewal-interval"` ProvisionInterval int `json:"provision-interval"` @@ -23,7 +22,6 @@ type CustomDomainsConfig struct { ACME ACMEConfig `json:"acme"` } -// ACMEConfig contains ACME certificate configuration. type ACMEConfig struct { Directory string `json:"directory"` Email string `json:"email"` diff --git a/pkg/probod/mailer_config.go b/pkg/probod/mailer_config.go index 3edd90178..d5a9e5a76 100644 --- a/pkg/probod/mailer_config.go +++ b/pkg/probod/mailer_config.go @@ -14,7 +14,6 @@ package probod -// MailerConfig contains email mailer configuration. type MailerConfig struct { MailerInterval int `json:"mailer-interval"` SenderName string `json:"sender-name"` @@ -22,7 +21,6 @@ type MailerConfig struct { SMTP SMTPConfig `json:"smtp"` } -// SMTPConfig contains SMTP server configuration. type SMTPConfig struct { Addr string `json:"addr"` User string `json:"user"` diff --git a/pkg/probod/notifications_config.go b/pkg/probod/notifications_config.go index 1cf2b2e2f..e9d2185f6 100644 --- a/pkg/probod/notifications_config.go +++ b/pkg/probod/notifications_config.go @@ -14,14 +14,12 @@ package probod -// NotificationsConfig contains notification configuration. type NotificationsConfig struct { Mailer MailerConfig `json:"mailer"` Slack SlackConfig `json:"slack"` Webhook WebhookConfig `json:"webhook"` } -// WebhookConfig contains webhook configuration. type WebhookConfig struct { SenderInterval int `json:"sender-interval"` CacheTTL int `json:"cache-ttl"` diff --git a/pkg/probod/openai_config.go b/pkg/probod/openai_config.go index 4af203e35..b61b9e5a9 100644 --- a/pkg/probod/openai_config.go +++ b/pkg/probod/openai_config.go @@ -14,7 +14,6 @@ package probod -// OpenAIConfig contains OpenAI API configuration. type OpenAIConfig struct { APIKey string `json:"api-key"` Temperature float64 `json:"temperature"` diff --git a/pkg/probod/pg_config.go b/pkg/probod/pg_config.go index 757ec3e99..abca623d2 100644 --- a/pkg/probod/pg_config.go +++ b/pkg/probod/pg_config.go @@ -21,7 +21,6 @@ import ( "go.gearno.de/kit/pg" ) -// PgConfig contains PostgreSQL database configuration. type PgConfig struct { Addr string `json:"addr"` Username string `json:"username"` diff --git a/pkg/probod/saml_config.go b/pkg/probod/saml_config.go index 385c67e64..6a0b7153c 100644 --- a/pkg/probod/saml_config.go +++ b/pkg/probod/saml_config.go @@ -18,7 +18,6 @@ import ( "time" ) -// SAMLConfig contains SAML authentication configuration. type SAMLConfig struct { SessionDuration int `json:"session-duration"` CleanupIntervalSeconds int `json:"cleanup-interval-seconds"` diff --git a/pkg/probod/scim_bridge_config.go b/pkg/probod/scim_bridge_config.go index 239189140..ff2cb6da0 100644 --- a/pkg/probod/scim_bridge_config.go +++ b/pkg/probod/scim_bridge_config.go @@ -14,13 +14,7 @@ package probod -// SCIMBridgeConfig contains SCIM bridge configuration. type SCIMBridgeConfig struct { - // SyncInterval is the time between sync attempts for each bridge (in seconds). - // Default: 900 (15 minutes) SyncInterval int `json:"sync-interval"` - - // PollInterval is the time between polling for bridges to sync (in seconds). - // Default: 30 PollInterval int `json:"poll-interval"` } diff --git a/pkg/probod/slack_config.go b/pkg/probod/slack_config.go index c22978d44..6324eb11b 100644 --- a/pkg/probod/slack_config.go +++ b/pkg/probod/slack_config.go @@ -14,7 +14,6 @@ package probod -// SlackConfig contains Slack notification configuration. type SlackConfig struct { SenderInterval int `json:"sender-interval"` SigningSecret string `json:"signing-secret"`