From f0afde219b02d8e96f38e8fac025692b9e228238 Mon Sep 17 00:00:00 2001
From: Sacha Al Himdani <sacha@getprobo.com>
Date: Mon, 21 Jul 2025 15:54:12 +0200
Subject: [PATCH] Fix controls and frameworks small issues

Signed-off-by: Sacha Al Himdani <sacha@getprobo.com>
---
 apps/console/public/logos/hipaa.png           | Bin 0 -> 2854 bytes
 apps/console/src/components/FrameworkLogo.tsx |   2 +-
 .../frameworks/FrameworkDetailPage.tsx        |   4 +--
 packages/helpers/src/frameworks.ts            |  14 +++-----
 pkg/probo/control_service.go                  |  30 ++++++++++--------
 pkg/server/api/console/v1/schema.graphql      |   2 +-
 pkg/server/api/console/v1/schema/schema.go    |   4 +--
 pkg/server/api/console/v1/types/types.go      |  12 +++----
 pkg/server/api/console/v1/v1_resolver.go      |  10 +++---
 9 files changed, 39 insertions(+), 39 deletions(-)
 create mode 100644 apps/console/public/logos/hipaa.png

diff --git a/apps/console/public/logos/hipaa.png b/apps/console/public/logos/hipaa.png
new file mode 100644
index 0000000000000000000000000000000000000000..4a8a23df81fa9656fec1ae12b8cea605d3fde73f
GIT binary patch
literal 2854
zcmV+>3)%FEP)<h;3K|Lk000e1NJLTq004jh004jp0{{R3^x%>C0000#P)t-s03B%h
z`uhL>{{tXu01aIL6JY=uW%Km+-{R{-SC2ACgi~giB077@&)*U&ab<O)x4zS$s>X|#
zxq64M{r&wz0cAG;01Bc>L_t(|+O=DY)}lBJ4!zTsLV@>x)=5%SR8ZRA;q0EBS=4;Z
z{Z{B|9&0-x#Oj8;jKRkwC4iJE`aUdqa4WsU&(u6nL7j-(VGceSO^-3ak12nJ<ik8z
z{7`5A0|5GAmqXM_X@kd>bo$#<{%Yu53fU3R-vXe+yWA(Gm^Pd|1j8sLd%|#$4RDeC
zG!pd>#CIr=6Ddq9s>4qJAo(tPP1NDyLwwLa+ba;h0}$ODmA+2>hC!=1+wX#aud0_D
z$lutIX2kyo0Cp9VZzF$$5c3y{_y|DQQ8$yn38HtR4FDcLC-oQd1%i_ECnmtT^ld=R
zhd)0OhzYhDfEePRkAH)pQWmuU#BB6$$P)simNPNHG5gn`;Aiw%6MB1$0FK4))ep%R
zF~nm<fFt@Y{+d1_&}leA00;Dkq<>DI6v0df2;hLe{2%ns5WoR_^IzznAb>adC;gx3
z69RbCgBJk*l|CUzuaV(Z1pa^0CtHYi{Qy9OO8a|BPOtcbAWi{TG1t+j3{+L-3lhDu
zJqBRKr0W=}(m2nH*HvPZ`pFb_09G686hJRjEMUf5^}QEGgmwimnF<i9$LdrU1Je-z
zE3%T8l<px*Oxco*6BaG9Mkl4p4<W$L1AO&>61XtqkC}uyx5r9J<Ijmv$&vx$`|ojl
zF9f(VVEo1a)Oi!bhy@x#Aag24!!n)lPf}}q9isV~N=P-{SpfG8?28yNwUgt(1#(7j
z$r9-KJ5o(zz?xC{iHrAPlwTp3LA(O!KLSAVFjCbks0ZLs?eP#d0BBc}W|oxK!j145
zg4F#p0Lwf)*E~=r5P7%szDK1S4E+R&fH<GXgPDl5Grpd=kVh_jDkcf^69>eJA+c6#
z1z{lGFH&jLGgLaVSjS3;iZKx{G^?V<_o+ZwwsKm2W<de4zA~VE%}~ohfnVtK-JDeE
z03>D@vD}U^_J|E#C~D%MWa$tvgw^JdN;~86i#r6H7QnFvQ2zztCm$AWcwmJdZ)FOx
zZ=nCoBy-X`v|tlEv6NHXA#g)y^wdeBF3wv}vUdQaL(lNW0Uzgzt3?WPd{jx~N7(b|
zqLyqG+OIo9CJ5uOsibv|e(g=m3k%@T2^%Nwj~#N5`;f;RFpLDy7H9Gc2tYh}5^@@T
znOt}Oofj$Jd;tMi-J7GB#p-gNxfy5Fi$bFjPn!oovORmFR{+IrY8m@+nR9mQo1@#@
zA&?C&uPUffqK<=oX^FjgkqrQm4O$khe&Zu4Bw3A8(xK4I`zh@vg12x=FDW=31{YG`
zfeowx;Ez50(m~3Eh~GUueYtSpRRzmycR!IlLKn#7p`6<&O=q;poOpix{Gd<#F&u{>
z*6NkTi(E9Y?+)_0yTyA9OANsGo*dOapDQ1ir7oqoeGqC(at4$L9mHYwGaVu@exi&A
zMR{ii|0LO%F90%|+q9=mAJ^WwUYE-JC}*NW5(n1fILJ~(<`509O_)c6%rFJT<^eVU
zGkXfy{4VLf_RE+wn+WAAr^Pnf0leG5g9j8|k{7EtX!_1TijhTv@1zgovWcKaV<k6j
zC_^^=*pt+|0$@Z(a8~ScW(4Pf7_A)7Y4HRIAY;vlJi)>#^&UfDi4r#@<TT01aSn#P
z6asKbMT`f?oY@$8o|nL>@{*7w<(&vovG=9VCn_wW+3ahx{-Sawt!Pk`925W;x9Rx)
zG&LZ1)4`z;KKv=gI*e=n1%SK<)eQh)pwx^3C`_0wYsnBk7Y$Cp=W0l5LqP>4L7Eh9
z0E$tY4FEekk_eSHau5zf0NI6|dh@Z<MoIu*l2J;A`fNGy4(K>S8Zi$k#*k!D!Z9!S
z%yaHAa=EU=AIlB?&$%JlGki$~OHhg9R3h^#I;?IT23Y*ph5}#`FAoLKq`o)!=>Tx(
zh7Q{QDa^wzNQ-qPFR?iyTP9i-1OGIS{d)jC*Ft!UQl}UYL<z1FKRM^V06_P^PfEo)
z4+7|Ug#wd-YtJLNQXJBX|G5Pt!$UMv-7qi{<f^)I_kfDAa3BV*L|TR#I>XY|laZKr
zq7x4s4KW9Yrk{~|fzSp(jg|s%3CCNp)B<3Hz6pTl-oR#tiTs3ZX>Um#pzV7|e_c>1
z8352c;4tU-{zD$3X^{WOF&;KgD9b!xYB-8%0zkEy@Z1sDa$!kcT{KA3#0CJ&fYO_|
zC*xc&=K3bTj*uDvWKlBtT{S@eb7){@69*_illy#N3v8}l2ap3^w*VO6CjiI_>NSUR
zNtWEJ2y_d8&;Ve$sot{^&ecjtj%ch0z@;nARdxW#41L2-jWE|6FBf~0Hjk_rwqmv=
z80DrQg1OO@6a&DVk~>r`HTYBv#|_3yojEF5f>sPb#i6!g{piy`3vfa(VS+kE?hh=T
zXq>fDO4hXna-$b+%dR3*-Ox7cL@UI~sBaq6maTx29E;XbJM{qItT?^^U(&>c8vU)C
z2Bk2`tpGsXTB5UTO)Mt_Ff>j8v0O4nC2r%o#&JKIGjtb9qhs+|fnJm#P}LSxOJ*0>
z4!XAQa+`>}C_%_=2ug#ZC5CKSA=wXBLkNKyTCpvxA_s<sl*Ci#i(2;1d0pC+Euny#
zR9&}LJ5kc!74`1kAEp0M&4MztfX>!?f?Edq0I)@+>Y!@5RXemuAUpxs%_}O-;Y4Xx
z*CzCQ-op8@wCl;BY5{CxBe*)WeTqbQ-dXJd&>t!daU0;mHnpvk!9Wu;c?Up^Z(I2z
zs7UKJF|oD!!<}rGRN4+M8#1!}$fn*Ea1M$AU<05>QO$s-p;cF(6wnZ4>yT(NifToE
z8ryYiZE1~3`G7guka=c=rBdw)UIv%dmPk8EnFpFIg6ONA(DUf_Y-;f(C!45sI`p)~
zP#XvC^Lx1MFI0z9EK9Vf+!!l_`d|`n8w~gTf$Gwhj*W~g`vleKop@W}s7njbk-DBI
zCi7g~BHJ%BJ=S<CqcRH7$x<1GPF(9a@5+ILJ)*Uyyf6JR?iG)k+)-5|dTfyF0aWD$
z<a|+Uwln}GT7mv~n{2<#Rw0Dale$;OQ-u!G$o*uSPB<_%9Jmkd&2T-MpbvH8be->V
zMB4(fApn}vgX`aXUZ#6qXuPfloReTc_N0D#y564IwgygDI@hZXky8K{BXJ;KPX>r{
zA9qUE?s{0kb9V#g64b6SwK3>)srC9+qcQWgp|YM%hu;mLTfZ(gU!Q%bxJ=FsbG*2T
zj|H_A7goD3uNF(KblDex%k=G)<@U?LO_tksf1!W8-v9gS1uTDiZM~lm(DKMnAxPfG
zu$S+cP@VP59eeKTtyPy?*8Ia;2He-|Y!v{@ji;YL_<Ygm!$qfc(Z67V)MgP47oB*`
zF#h?n4<6qSqVcjDTEhZ=k^}7m&+EtQc3<ur3K#SruKOt+ocQa7$Ek0FfT!2A1Z4kw
z<&z*NsJuu)E1hAuaQ*kvrB^}Q+WPWt2CZ0?rPl5jmtKo!bhFo&FfeuPXS#X(!<*MM
z7#PN=X>08i1#fTSN8&iFm+xL*zxv$~hQ+6YyWjhp-~B=>_}!1Me(!F-yJ-$_fBW6+
z@4ip2^6q;TfExzUxhXH9=llOM(e3|{ZvU5eb+`Y!e=^T?%+p#O{r~^~07*qoM6N<$
Ef>n}DQUCw|

literal 0
HcmV?d00001

diff --git a/apps/console/src/components/FrameworkLogo.tsx b/apps/console/src/components/FrameworkLogo.tsx
index a727f7ea5..eadd2de8f 100644
--- a/apps/console/src/components/FrameworkLogo.tsx
+++ b/apps/console/src/components/FrameworkLogo.tsx
@@ -8,7 +8,7 @@ const availableLogos = new Map(
 export function FrameworkLogo({ name }: { name: string }) {
   const logo = availableLogos.get(name);
   return logo ? (
-    <img src={logo} alt="" className="size-12" />
+    <img src={logo} alt="" className="h-12" />
   ) : (
     <Avatar name={name} size="l" className="size-12" />
   );
diff --git a/apps/console/src/pages/organizations/frameworks/FrameworkDetailPage.tsx b/apps/console/src/pages/organizations/frameworks/FrameworkDetailPage.tsx
index 159c540c5..5e6af3b36 100644
--- a/apps/console/src/pages/organizations/frameworks/FrameworkDetailPage.tsx
+++ b/apps/console/src/pages/organizations/frameworks/FrameworkDetailPage.tsx
@@ -83,7 +83,7 @@ export default function FrameworkDetailPage(props: Props) {
   const controls = framework.controls.edges.map((edge) => edge.node);
   const selectedControl = controlId
     ? controls.find((control) => control.id === controlId)
-    : controls[0];
+    : controls[0] || null;
   const connectionId = framework.controls.__id;
   const deleteFramework = useDeleteFrameworkMutation(
     framework,
@@ -109,7 +109,7 @@ export default function FrameworkDetailPage(props: Props) {
     });
   };
 
-  if (!controlId) {
+  if (!controlId && controls.length > 0) {
     return (
       <Navigate
         to={`/organizations/${organizationId}/frameworks/${framework.id}/controls/${controls[0].id}`}
diff --git a/packages/helpers/src/frameworks.ts b/packages/helpers/src/frameworks.ts
index a6423c6b7..5d97b04a3 100644
--- a/packages/helpers/src/frameworks.ts
+++ b/packages/helpers/src/frameworks.ts
@@ -12,15 +12,9 @@ export const availableFrameworks = [
         description: "System and Organization Controls 2",
     },
     {
-        id: "GDPR",
-        name: "GDPR",
-        logo: "/logos/gdpr.png",
-        description: "General Data Protection Regulation",
-    },
-    {
-        id: "SOX",
-        name: "SOX",
-        logo: "/logos/sox.png",
-        description: "Sarbanes-Oxley Act",
+        id: "HIPAA",
+        name: "HIPAA",
+        logo: "/logos/hipaa.png",
+        description: "Health Insurance Portability and Accountability Act",
     },
 ];
diff --git a/pkg/probo/control_service.go b/pkg/probo/control_service.go
index 592c16c94..27ffeb5d3 100644
--- a/pkg/probo/control_service.go
+++ b/pkg/probo/control_service.go
@@ -31,11 +31,13 @@ type (
 	}
 
 	CreateControlRequest struct {
-		ID           gid.GID
-		FrameworkID  gid.GID
-		Name         string
-		Description  string
-		SectionTitle string
+		ID                     gid.GID
+		FrameworkID            gid.GID
+		Name                   string
+		Description            string
+		SectionTitle           string
+		Status                 *coredata.ControlStatus
+		ExclusionJustification *string
 	}
 
 	UpdateControlRequest struct {
@@ -498,14 +500,16 @@ func (s ControlService) Create(
 	framework := &coredata.Framework{}
 
 	control := &coredata.Control{
-		ID:           gid.New(s.svc.scope.GetTenantID(), coredata.ControlEntityType),
-		FrameworkID:  req.FrameworkID,
-		TenantID:     s.svc.scope.GetTenantID(),
-		Name:         req.Name,
-		Description:  req.Description,
-		SectionTitle: req.SectionTitle,
-		CreatedAt:    now,
-		UpdatedAt:    now,
+		ID:                     gid.New(s.svc.scope.GetTenantID(), coredata.ControlEntityType),
+		FrameworkID:            req.FrameworkID,
+		TenantID:               s.svc.scope.GetTenantID(),
+		Name:                   req.Name,
+		Description:            req.Description,
+		SectionTitle:           req.SectionTitle,
+		Status:                 *req.Status,
+		ExclusionJustification: req.ExclusionJustification,
+		CreatedAt:              now,
+		UpdatedAt:              now,
 	}
 
 	err := s.svc.pg.WithTx(
diff --git a/pkg/server/api/console/v1/schema.graphql b/pkg/server/api/console/v1/schema.graphql
index 6312138d8..319e0e081 100644
--- a/pkg/server/api/console/v1/schema.graphql
+++ b/pkg/server/api/console/v1/schema.graphql
@@ -1761,7 +1761,7 @@ input CreateControlInput {
   sectionTitle: String!
   name: String!
   description: String!
-  status: ControlStatus
+  status: ControlStatus!
   exclusionJustification: String
 }
 
diff --git a/pkg/server/api/console/v1/schema/schema.go b/pkg/server/api/console/v1/schema/schema.go
index 5a8c94c6e..bb9b3f84a 100644
--- a/pkg/server/api/console/v1/schema/schema.go
+++ b/pkg/server/api/console/v1/schema/schema.go
@@ -6718,7 +6718,7 @@ input CreateControlInput {
   sectionTitle: String!
   name: String!
   description: String!
-  status: ControlStatus
+  status: ControlStatus!
   exclusionJustification: String
 }
 
@@ -38150,7 +38150,7 @@ func (ec *executionContext) unmarshalInputCreateControlInput(ctx context.Context
 			it.Description = data
 		case "status":
 			ctx := graphql.WithPathContext(ctx, graphql.NewPathWithField("status"))
-			data, err := ec.unmarshalOControlStatus2ᚖgithubᚗcomᚋgetproboᚋproboᚋpkgᚋcoredataᚐControlStatus(ctx, v)
+			data, err := ec.unmarshalNControlStatus2githubᚗcomᚋgetproboᚋproboᚋpkgᚋcoredataᚐControlStatus(ctx, v)
 			if err != nil {
 				return it, err
 			}
diff --git a/pkg/server/api/console/v1/types/types.go b/pkg/server/api/console/v1/types/types.go
index e0df503ac..d0f1df697 100644
--- a/pkg/server/api/console/v1/types/types.go
+++ b/pkg/server/api/console/v1/types/types.go
@@ -169,12 +169,12 @@ type CreateControlDocumentMappingPayload struct {
 }
 
 type CreateControlInput struct {
-	FrameworkID            gid.GID                 `json:"frameworkId"`
-	SectionTitle           string                  `json:"sectionTitle"`
-	Name                   string                  `json:"name"`
-	Description            string                  `json:"description"`
-	Status                 *coredata.ControlStatus `json:"status,omitempty"`
-	ExclusionJustification *string                 `json:"exclusionJustification,omitempty"`
+	FrameworkID            gid.GID                `json:"frameworkId"`
+	SectionTitle           string                 `json:"sectionTitle"`
+	Name                   string                 `json:"name"`
+	Description            string                 `json:"description"`
+	Status                 coredata.ControlStatus `json:"status"`
+	ExclusionJustification *string                `json:"exclusionJustification,omitempty"`
 }
 
 type CreateControlMeasureMappingInput struct {
diff --git a/pkg/server/api/console/v1/v1_resolver.go b/pkg/server/api/console/v1/v1_resolver.go
index fbd4accfb..2c76fc59b 100644
--- a/pkg/server/api/console/v1/v1_resolver.go
+++ b/pkg/server/api/console/v1/v1_resolver.go
@@ -1201,10 +1201,12 @@ func (r *mutationResolver) CreateControl(ctx context.Context, input types.Create
 	prb := r.ProboService(ctx, input.FrameworkID.TenantID())
 
 	control, err := prb.Controls.Create(ctx, probo.CreateControlRequest{
-		FrameworkID:  input.FrameworkID,
-		Name:         input.Name,
-		Description:  input.Description,
-		SectionTitle: input.SectionTitle,
+		FrameworkID:            input.FrameworkID,
+		Name:                   input.Name,
+		Description:            input.Description,
+		SectionTitle:           input.SectionTitle,
+		Status:                 &input.Status,
+		ExclusionJustification: input.ExclusionJustification,
 	})
 	if err != nil {
 		return nil, fmt.Errorf("cannot create control: %w", err)