Rename vendors to third parties
Renames the user-facing 'vendor' concept to 'third party' across the entire codebase. The shared common_third_parties reference table is unchanged. Migration. Renames the vendor_category enum, the vendors and vendor_<entity> tables (contacts, services, compliance_reports, business_associate_agreements, data_privacy_agreements, risk_assessments) and their vendor_id columns, the asset_vendors / data_vendors / processing_activity_vendors junction tables, generated_documents.vendors_document_id, the webhook_event_type 'vendor:<verb>' values, and the snapshots_type 'VENDORS' value. Backend. Renames coredata models and SQL queries, probo services, GraphQL / MCP API surface, console / trust / webhook resolvers and types, the CLI (prb vendor* -> prb third-party*; pkg/cmd/vendormgmt -> pkg/cmd/thirdpartymgmt), the document generator, vetting agent prompts, and the common-third-parties-import command. Frontend, packages, n8n, e2e. Renames apps/console pages, components, hooks, routes, dialogs, and tabs; the shared @probo/vendors package (now @probo/third-parties); the @probo/ui Vendors atoms (now ThirdParties, VendorLogo -> ThirdPartyLogo); the n8n community node actions/vendor folder (now actions/thirdParty); and the e2e Go test suite (console and MCP). Filesystem and URL paths use kebab-case (third-parties), GraphQL fields and TypeScript identifiers use camelCase (thirdParty / thirdParties), Go types use PascalCase (ThirdParty), and human-facing text uses 'third party' with a space. Co-authored-by: Bryan Frimin <bryan@getprobo.com> Signed-off-by: Bryan Frimin <bryan@getprobo.com> Signed-off-by: Sacha Al Himdani <sacha@getprobo.com>
This commit is contained in:
@@ -52,7 +52,7 @@ type (
|
||||
NextReviewDate *time.Time
|
||||
Role coredata.ProcessingActivityRole
|
||||
DataProtectionOfficerID *gid.GID
|
||||
VendorIDs []gid.GID
|
||||
ThirdPartyIDs []gid.GID
|
||||
}
|
||||
|
||||
UpdateProcessingActivityRequest struct {
|
||||
@@ -76,7 +76,7 @@ type (
|
||||
NextReviewDate **time.Time
|
||||
Role *coredata.ProcessingActivityRole
|
||||
DataProtectionOfficerID **gid.GID
|
||||
VendorIDs *[]gid.GID
|
||||
ThirdPartyIDs *[]gid.GID
|
||||
}
|
||||
)
|
||||
|
||||
@@ -101,8 +101,8 @@ func (cpar *CreateProcessingActivityRequest) Validate() error {
|
||||
v.Check(cpar.TransferImpactAssessmentNeeded, "transfer_impact_assessment_needed", validator.Required(), validator.OneOfSlice(coredata.ProcessingActivityTransferImpactAssessments()))
|
||||
v.Check(cpar.Role, "role", validator.Required(), validator.OneOfSlice(coredata.ProcessingActivityRoles()))
|
||||
v.Check(cpar.DataProtectionOfficerID, "data_protection_officer_id", validator.GID(coredata.MembershipProfileEntityType))
|
||||
v.CheckEach(cpar.VendorIDs, "vendor_ids", func(index int, item any) {
|
||||
v.Check(item, fmt.Sprintf("vendor_ids[%d]", index), validator.Required(), validator.GID(coredata.VendorEntityType))
|
||||
v.CheckEach(cpar.ThirdPartyIDs, "third_party_ids", func(index int, item any) {
|
||||
v.Check(item, fmt.Sprintf("third_party_ids[%d]", index), validator.Required(), validator.GID(coredata.ThirdPartyEntityType))
|
||||
})
|
||||
|
||||
return v.Error()
|
||||
@@ -128,8 +128,8 @@ func (upar *UpdateProcessingActivityRequest) Validate() error {
|
||||
v.Check(upar.TransferImpactAssessmentNeeded, "transfer_impact_assessment_needed", validator.OneOfSlice(coredata.ProcessingActivityTransferImpactAssessments()))
|
||||
v.Check(upar.Role, "role", validator.OneOfSlice(coredata.ProcessingActivityRoles()))
|
||||
v.Check(upar.DataProtectionOfficerID, "data_protection_officer_id", validator.GID(coredata.MembershipProfileEntityType))
|
||||
v.CheckEach(upar.VendorIDs, "vendor_ids", func(index int, item any) {
|
||||
v.Check(item, fmt.Sprintf("vendor_ids[%d]", index), validator.GID(coredata.VendorEntityType))
|
||||
v.CheckEach(upar.ThirdPartyIDs, "third_party_ids", func(index int, item any) {
|
||||
v.Check(item, fmt.Sprintf("third_party_ids[%d]", index), validator.GID(coredata.ThirdPartyEntityType))
|
||||
})
|
||||
|
||||
return v.Error()
|
||||
@@ -160,7 +160,7 @@ func (s *ProcessingActivityService) Create(
|
||||
req *CreateProcessingActivityRequest,
|
||||
) (*coredata.ProcessingActivity, error) {
|
||||
now := time.Now()
|
||||
processingActivityVendors := &coredata.ProcessingActivityVendors{}
|
||||
processingActivityThirdParties := &coredata.ProcessingActivityThirdParties{}
|
||||
|
||||
processingActivity := &coredata.ProcessingActivity{
|
||||
ID: gid.New(s.svc.scope.GetTenantID(), coredata.ProcessingActivityEntityType),
|
||||
@@ -200,9 +200,9 @@ func (s *ProcessingActivityService) Create(
|
||||
return fmt.Errorf("cannot insert processing activity: %w", err)
|
||||
}
|
||||
|
||||
if len(req.VendorIDs) > 0 {
|
||||
if err := processingActivityVendors.Insert(ctx, conn, s.svc.scope, processingActivity.ID, req.OrganizationID, req.VendorIDs); err != nil {
|
||||
return fmt.Errorf("cannot create processing activity vendors: %w", err)
|
||||
if len(req.ThirdPartyIDs) > 0 {
|
||||
if err := processingActivityThirdParties.Insert(ctx, conn, s.svc.scope, processingActivity.ID, req.OrganizationID, req.ThirdPartyIDs); err != nil {
|
||||
return fmt.Errorf("cannot create processing activity thirdParties: %w", err)
|
||||
}
|
||||
}
|
||||
|
||||
@@ -222,7 +222,7 @@ func (s *ProcessingActivityService) Update(
|
||||
req *UpdateProcessingActivityRequest,
|
||||
) (*coredata.ProcessingActivity, error) {
|
||||
processingActivity := &coredata.ProcessingActivity{}
|
||||
processingActivityVendors := &coredata.ProcessingActivityVendors{}
|
||||
processingActivityThirdParties := &coredata.ProcessingActivityThirdParties{}
|
||||
|
||||
err := s.svc.pg.WithTx(
|
||||
ctx,
|
||||
@@ -295,9 +295,9 @@ func (s *ProcessingActivityService) Update(
|
||||
return fmt.Errorf("cannot update processing activity: %w", err)
|
||||
}
|
||||
|
||||
if req.VendorIDs != nil {
|
||||
if err := processingActivityVendors.Merge(ctx, conn, s.svc.scope, processingActivity.ID, processingActivity.OrganizationID, *req.VendorIDs); err != nil {
|
||||
return fmt.Errorf("cannot update processing activity vendors: %w", err)
|
||||
if req.ThirdPartyIDs != nil {
|
||||
if err := processingActivityThirdParties.Merge(ctx, conn, s.svc.scope, processingActivity.ID, processingActivity.OrganizationID, *req.ThirdPartyIDs); err != nil {
|
||||
return fmt.Errorf("cannot update processing activity thirdParties: %w", err)
|
||||
}
|
||||
}
|
||||
|
||||
|
||||
Reference in New Issue
Block a user