Rename vendors to third parties
Renames the user-facing 'vendor' concept to 'third party' across the entire codebase. The shared common_third_parties reference table is unchanged. Migration. Renames the vendor_category enum, the vendors and vendor_<entity> tables (contacts, services, compliance_reports, business_associate_agreements, data_privacy_agreements, risk_assessments) and their vendor_id columns, the asset_vendors / data_vendors / processing_activity_vendors junction tables, generated_documents.vendors_document_id, the webhook_event_type 'vendor:<verb>' values, and the snapshots_type 'VENDORS' value. Backend. Renames coredata models and SQL queries, probo services, GraphQL / MCP API surface, console / trust / webhook resolvers and types, the CLI (prb vendor* -> prb third-party*; pkg/cmd/vendormgmt -> pkg/cmd/thirdpartymgmt), the document generator, vetting agent prompts, and the common-third-parties-import command. Frontend, packages, n8n, e2e. Renames apps/console pages, components, hooks, routes, dialogs, and tabs; the shared @probo/vendors package (now @probo/third-parties); the @probo/ui Vendors atoms (now ThirdParties, VendorLogo -> ThirdPartyLogo); the n8n community node actions/vendor folder (now actions/thirdParty); and the e2e Go test suite (console and MCP). Filesystem and URL paths use kebab-case (third-parties), GraphQL fields and TypeScript identifiers use camelCase (thirdParty / thirdParties), Go types use PascalCase (ThirdParty), and human-facing text uses 'third party' with a space. Co-authored-by: Bryan Frimin <bryan@getprobo.com> Signed-off-by: Bryan Frimin <bryan@getprobo.com> Signed-off-by: Sacha Al Himdani <sacha@getprobo.com>
This commit is contained in:
Sacha Al Himdani
@@ -95,7 +95,7 @@ func TestMCP_AuditLog(t *testing.T) {
|
||||
orgID := owner.GetOrganizationID().String()
|
||||
|
||||
// Creating something generates audit log entries
|
||||
factory.CreateVendor(owner)
|
||||
factory.CreateThirdParty(owner)
|
||||
|
||||
var listResult struct {
|
||||
AuditLogEntries []struct {
|
||||
|
||||
142
e2e/mcp/third_party_contact_test.go
Normal file
142
e2e/mcp/third_party_contact_test.go
Normal file
@@ -0,0 +1,142 @@
|
||||
// Copyright (c) 2025-2026 Probo Inc <hello@getprobo.com>.
|
||||
//
|
||||
// Permission to use, copy, modify, and/or distribute this software for any
|
||||
// purpose with or without fee is hereby granted, provided that the above
|
||||
// copyright notice and this permission notice appear in all copies.
|
||||
//
|
||||
// THE SOFTWARE IS PROVIDED "AS IS" AND THE AUTHOR DISCLAIMS ALL WARRANTIES WITH
|
||||
// REGARD TO THIS SOFTWARE INCLUDING ALL IMPLIED WARRANTIES OF MERCHANTABILITY
|
||||
// AND FITNESS. IN NO EVENT SHALL THE AUTHOR BE LIABLE FOR ANY SPECIAL, DIRECT,
|
||||
// INDIRECT, OR CONSEQUENTIAL DAMAGES OR ANY DAMAGES WHATSOEVER RESULTING FROM
|
||||
// LOSS OF USE, DATA OR PROFITS, WHETHER IN AN ACTION OF CONTRACT, NEGLIGENCE OR
|
||||
// OTHER TORTIOUS ACTION, ARISING OUT OF OR IN CONNECTION WITH THE USE OR
|
||||
// PERFORMANCE OF THIS SOFTWARE.
|
||||
|
||||
package mcp_test
|
||||
|
||||
import (
|
||||
"testing"
|
||||
|
||||
"github.com/stretchr/testify/assert"
|
||||
"github.com/stretchr/testify/require"
|
||||
"go.probo.inc/probo/e2e/internal/factory"
|
||||
"go.probo.inc/probo/e2e/internal/testutil"
|
||||
)
|
||||
|
||||
type thirdPartyContact struct {
|
||||
ID string `json:"id"`
|
||||
Name string `json:"name"`
|
||||
Email *string `json:"email"`
|
||||
Phone *string `json:"phone"`
|
||||
Role *string `json:"role"`
|
||||
}
|
||||
|
||||
func TestMCP_AddThirdPartyContact(t *testing.T) {
|
||||
t.Parallel()
|
||||
owner := testutil.NewClient(t, testutil.RoleOwner)
|
||||
mc := testutil.NewMCPClient(t, owner)
|
||||
thirdPartyID := factory.CreateThirdParty(owner)
|
||||
|
||||
var result struct {
|
||||
ThirdPartyContact thirdPartyContact `json:"thirdPartyContact"`
|
||||
}
|
||||
mc.CallToolInto("addThirdPartyContact", map[string]any{
|
||||
"thirdPartyId": thirdPartyID,
|
||||
"name": "Alice Smith",
|
||||
"email": "alice@example.com",
|
||||
"phone": "+1-555-0100",
|
||||
"role": "Account Manager",
|
||||
}, &result)
|
||||
|
||||
assert.NotEmpty(t, result.ThirdPartyContact.ID)
|
||||
assert.Equal(t, "Alice Smith", result.ThirdPartyContact.Name)
|
||||
}
|
||||
|
||||
func TestMCP_UpdateThirdPartyContact(t *testing.T) {
|
||||
t.Parallel()
|
||||
owner := testutil.NewClient(t, testutil.RoleOwner)
|
||||
mc := testutil.NewMCPClient(t, owner)
|
||||
thirdPartyID := factory.CreateThirdParty(owner)
|
||||
|
||||
// Create
|
||||
var addResult struct {
|
||||
ThirdPartyContact thirdPartyContact `json:"thirdPartyContact"`
|
||||
}
|
||||
mc.CallToolInto("addThirdPartyContact", map[string]any{
|
||||
"thirdPartyId": thirdPartyID,
|
||||
"name": "Bob Jones",
|
||||
"email": "bob@example.com",
|
||||
}, &addResult)
|
||||
require.NotEmpty(t, addResult.ThirdPartyContact.ID)
|
||||
|
||||
// Update
|
||||
var updateResult struct {
|
||||
ThirdPartyContact thirdPartyContact `json:"thirdPartyContact"`
|
||||
}
|
||||
mc.CallToolInto("updateThirdPartyContact", map[string]any{
|
||||
"id": addResult.ThirdPartyContact.ID,
|
||||
"name": "Robert Jones",
|
||||
"role": "CTO",
|
||||
}, &updateResult)
|
||||
|
||||
assert.Equal(t, addResult.ThirdPartyContact.ID, updateResult.ThirdPartyContact.ID)
|
||||
assert.Equal(t, "Robert Jones", updateResult.ThirdPartyContact.Name)
|
||||
}
|
||||
|
||||
func TestMCP_DeleteThirdPartyContact(t *testing.T) {
|
||||
t.Parallel()
|
||||
owner := testutil.NewClient(t, testutil.RoleOwner)
|
||||
mc := testutil.NewMCPClient(t, owner)
|
||||
thirdPartyID := factory.CreateThirdParty(owner)
|
||||
|
||||
// Create
|
||||
var addResult struct {
|
||||
ThirdPartyContact thirdPartyContact `json:"thirdPartyContact"`
|
||||
}
|
||||
mc.CallToolInto("addThirdPartyContact", map[string]any{
|
||||
"thirdPartyId": thirdPartyID,
|
||||
"name": "Contact to delete",
|
||||
}, &addResult)
|
||||
require.NotEmpty(t, addResult.ThirdPartyContact.ID)
|
||||
|
||||
// Delete
|
||||
var deleteResult struct {
|
||||
DeletedThirdPartyContactID string `json:"deletedThirdPartyContactId"`
|
||||
}
|
||||
mc.CallToolInto("deleteThirdPartyContact", map[string]any{
|
||||
"id": addResult.ThirdPartyContact.ID,
|
||||
}, &deleteResult)
|
||||
|
||||
assert.Equal(t, addResult.ThirdPartyContact.ID, deleteResult.DeletedThirdPartyContactID)
|
||||
}
|
||||
|
||||
func TestMCP_ListThirdPartyContacts(t *testing.T) {
|
||||
t.Parallel()
|
||||
owner := testutil.NewClient(t, testutil.RoleOwner)
|
||||
mc := testutil.NewMCPClient(t, owner)
|
||||
thirdPartyID := factory.CreateThirdParty(owner)
|
||||
|
||||
// Create contacts
|
||||
for i := range 3 {
|
||||
var result struct {
|
||||
ThirdPartyContact thirdPartyContact `json:"thirdPartyContact"`
|
||||
}
|
||||
mc.CallToolInto("addThirdPartyContact", map[string]any{
|
||||
"thirdPartyId": thirdPartyID,
|
||||
"name": factory.SafeName("Contact"),
|
||||
"email": factory.SafeEmail(),
|
||||
}, &result)
|
||||
require.NotEmpty(t, result.ThirdPartyContact.ID)
|
||||
_ = i
|
||||
}
|
||||
|
||||
// List
|
||||
var listResult struct {
|
||||
ThirdPartyContacts []thirdPartyContact `json:"thirdPartyContacts"`
|
||||
}
|
||||
mc.CallToolInto("listThirdPartyContacts", map[string]any{
|
||||
"thirdPartyId": thirdPartyID,
|
||||
}, &listResult)
|
||||
|
||||
assert.GreaterOrEqual(t, len(listResult.ThirdPartyContacts), 3)
|
||||
}
|
||||
135
e2e/mcp/third_party_service_test.go
Normal file
135
e2e/mcp/third_party_service_test.go
Normal file
@@ -0,0 +1,135 @@
|
||||
// Copyright (c) 2025-2026 Probo Inc <hello@getprobo.com>.
|
||||
//
|
||||
// Permission to use, copy, modify, and/or distribute this software for any
|
||||
// purpose with or without fee is hereby granted, provided that the above
|
||||
// copyright notice and this permission notice appear in all copies.
|
||||
//
|
||||
// THE SOFTWARE IS PROVIDED "AS IS" AND THE AUTHOR DISCLAIMS ALL WARRANTIES WITH
|
||||
// REGARD TO THIS SOFTWARE INCLUDING ALL IMPLIED WARRANTIES OF MERCHANTABILITY
|
||||
// AND FITNESS. IN NO EVENT SHALL THE AUTHOR BE LIABLE FOR ANY SPECIAL, DIRECT,
|
||||
// INDIRECT, OR CONSEQUENTIAL DAMAGES OR ANY DAMAGES WHATSOEVER RESULTING FROM
|
||||
// LOSS OF USE, DATA OR PROFITS, WHETHER IN AN ACTION OF CONTRACT, NEGLIGENCE OR
|
||||
// OTHER TORTIOUS ACTION, ARISING OUT OF OR IN CONNECTION WITH THE USE OR
|
||||
// PERFORMANCE OF THIS SOFTWARE.
|
||||
|
||||
package mcp_test
|
||||
|
||||
import (
|
||||
"testing"
|
||||
|
||||
"github.com/stretchr/testify/assert"
|
||||
"github.com/stretchr/testify/require"
|
||||
"go.probo.inc/probo/e2e/internal/factory"
|
||||
"go.probo.inc/probo/e2e/internal/testutil"
|
||||
)
|
||||
|
||||
type thirdPartyService struct {
|
||||
ID string `json:"id"`
|
||||
Name string `json:"name"`
|
||||
Description *string `json:"description"`
|
||||
}
|
||||
|
||||
func TestMCP_AddThirdPartyService(t *testing.T) {
|
||||
t.Parallel()
|
||||
owner := testutil.NewClient(t, testutil.RoleOwner)
|
||||
mc := testutil.NewMCPClient(t, owner)
|
||||
thirdPartyID := factory.CreateThirdParty(owner)
|
||||
|
||||
var result struct {
|
||||
ThirdPartyService thirdPartyService `json:"thirdPartyService"`
|
||||
}
|
||||
mc.CallToolInto("addThirdPartyService", map[string]any{
|
||||
"thirdPartyId": thirdPartyID,
|
||||
"name": "Cloud Storage",
|
||||
"description": "Object storage service",
|
||||
}, &result)
|
||||
|
||||
assert.NotEmpty(t, result.ThirdPartyService.ID)
|
||||
assert.Equal(t, "Cloud Storage", result.ThirdPartyService.Name)
|
||||
}
|
||||
|
||||
func TestMCP_UpdateThirdPartyService(t *testing.T) {
|
||||
t.Parallel()
|
||||
owner := testutil.NewClient(t, testutil.RoleOwner)
|
||||
mc := testutil.NewMCPClient(t, owner)
|
||||
thirdPartyID := factory.CreateThirdParty(owner)
|
||||
|
||||
// Create
|
||||
var addResult struct {
|
||||
ThirdPartyService thirdPartyService `json:"thirdPartyService"`
|
||||
}
|
||||
mc.CallToolInto("addThirdPartyService", map[string]any{
|
||||
"thirdPartyId": thirdPartyID,
|
||||
"name": "Original Service",
|
||||
}, &addResult)
|
||||
require.NotEmpty(t, addResult.ThirdPartyService.ID)
|
||||
|
||||
// Update
|
||||
var updateResult struct {
|
||||
ThirdPartyService thirdPartyService `json:"thirdPartyService"`
|
||||
}
|
||||
mc.CallToolInto("updateThirdPartyService", map[string]any{
|
||||
"id": addResult.ThirdPartyService.ID,
|
||||
"name": "Updated Service",
|
||||
}, &updateResult)
|
||||
|
||||
assert.Equal(t, addResult.ThirdPartyService.ID, updateResult.ThirdPartyService.ID)
|
||||
assert.Equal(t, "Updated Service", updateResult.ThirdPartyService.Name)
|
||||
}
|
||||
|
||||
func TestMCP_DeleteThirdPartyService(t *testing.T) {
|
||||
t.Parallel()
|
||||
owner := testutil.NewClient(t, testutil.RoleOwner)
|
||||
mc := testutil.NewMCPClient(t, owner)
|
||||
thirdPartyID := factory.CreateThirdParty(owner)
|
||||
|
||||
// Create
|
||||
var addResult struct {
|
||||
ThirdPartyService thirdPartyService `json:"thirdPartyService"`
|
||||
}
|
||||
mc.CallToolInto("addThirdPartyService", map[string]any{
|
||||
"thirdPartyId": thirdPartyID,
|
||||
"name": "Service to delete",
|
||||
}, &addResult)
|
||||
require.NotEmpty(t, addResult.ThirdPartyService.ID)
|
||||
|
||||
// Delete
|
||||
var deleteResult struct {
|
||||
DeletedThirdPartyServiceID string `json:"deletedThirdPartyServiceId"`
|
||||
}
|
||||
mc.CallToolInto("deleteThirdPartyService", map[string]any{
|
||||
"id": addResult.ThirdPartyService.ID,
|
||||
}, &deleteResult)
|
||||
|
||||
assert.Equal(t, addResult.ThirdPartyService.ID, deleteResult.DeletedThirdPartyServiceID)
|
||||
}
|
||||
|
||||
func TestMCP_ListThirdPartyServices(t *testing.T) {
|
||||
t.Parallel()
|
||||
owner := testutil.NewClient(t, testutil.RoleOwner)
|
||||
mc := testutil.NewMCPClient(t, owner)
|
||||
thirdPartyID := factory.CreateThirdParty(owner)
|
||||
|
||||
// Create services
|
||||
for i := range 3 {
|
||||
var result struct {
|
||||
ThirdPartyService thirdPartyService `json:"thirdPartyService"`
|
||||
}
|
||||
mc.CallToolInto("addThirdPartyService", map[string]any{
|
||||
"thirdPartyId": thirdPartyID,
|
||||
"name": factory.SafeName("Service"),
|
||||
}, &result)
|
||||
require.NotEmpty(t, result.ThirdPartyService.ID)
|
||||
_ = i
|
||||
}
|
||||
|
||||
// List
|
||||
var listResult struct {
|
||||
ThirdPartyServices []thirdPartyService `json:"thirdPartyServices"`
|
||||
}
|
||||
mc.CallToolInto("listThirdPartyServices", map[string]any{
|
||||
"thirdPartyId": thirdPartyID,
|
||||
}, &listResult)
|
||||
|
||||
assert.GreaterOrEqual(t, len(listResult.ThirdPartyServices), 3)
|
||||
}
|
||||
@@ -23,7 +23,7 @@ import (
|
||||
"go.probo.inc/probo/e2e/internal/testutil"
|
||||
)
|
||||
|
||||
func TestMCP_Vendor_CRUD(t *testing.T) {
|
||||
func TestMCP_ThirdParty_CRUD(t *testing.T) {
|
||||
t.Parallel()
|
||||
owner := testutil.NewClient(t, testutil.RoleOwner)
|
||||
mc := testutil.NewMCPClient(t, owner)
|
||||
@@ -31,67 +31,67 @@ func TestMCP_Vendor_CRUD(t *testing.T) {
|
||||
|
||||
// Create
|
||||
var addResult struct {
|
||||
Vendor struct {
|
||||
ThirdParty struct {
|
||||
ID string `json:"id"`
|
||||
Name string `json:"name"`
|
||||
} `json:"vendor"`
|
||||
} `json:"third_party"`
|
||||
}
|
||||
name := factory.SafeName("Vendor")
|
||||
mc.CallToolInto("addVendor", map[string]any{
|
||||
name := factory.SafeName("ThirdParty")
|
||||
mc.CallToolInto("addThirdParty", map[string]any{
|
||||
"organizationId": orgID,
|
||||
"name": name,
|
||||
}, &addResult)
|
||||
require.NotEmpty(t, addResult.Vendor.ID)
|
||||
assert.Equal(t, name, addResult.Vendor.Name)
|
||||
require.NotEmpty(t, addResult.ThirdParty.ID)
|
||||
assert.Equal(t, name, addResult.ThirdParty.Name)
|
||||
|
||||
// Update
|
||||
var updateResult struct {
|
||||
Vendor struct {
|
||||
ThirdParty struct {
|
||||
ID string `json:"id"`
|
||||
Name string `json:"name"`
|
||||
} `json:"vendor"`
|
||||
} `json:"third_party"`
|
||||
}
|
||||
mc.CallToolInto("updateVendor", map[string]any{
|
||||
"id": addResult.Vendor.ID,
|
||||
"name": "Updated Vendor",
|
||||
mc.CallToolInto("updateThirdParty", map[string]any{
|
||||
"id": addResult.ThirdParty.ID,
|
||||
"name": "Updated ThirdParty",
|
||||
}, &updateResult)
|
||||
assert.Equal(t, "Updated Vendor", updateResult.Vendor.Name)
|
||||
assert.Equal(t, "Updated ThirdParty", updateResult.ThirdParty.Name)
|
||||
|
||||
// List
|
||||
var listResult struct {
|
||||
Vendors []struct {
|
||||
ThirdParties []struct {
|
||||
ID string `json:"id"`
|
||||
} `json:"vendors"`
|
||||
} `json:"third_parties"`
|
||||
}
|
||||
mc.CallToolInto("listVendors", map[string]any{
|
||||
mc.CallToolInto("listThirdParties", map[string]any{
|
||||
"organizationId": orgID,
|
||||
}, &listResult)
|
||||
assert.NotEmpty(t, listResult.Vendors)
|
||||
assert.NotEmpty(t, listResult.ThirdParties)
|
||||
|
||||
// Delete
|
||||
var deleteResult struct {
|
||||
DeletedVendorID string `json:"deletedVendorId"`
|
||||
DeletedThirdPartyID string `json:"deletedThirdPartyId"`
|
||||
}
|
||||
mc.CallToolInto("deleteVendor", map[string]any{
|
||||
"id": addResult.Vendor.ID,
|
||||
mc.CallToolInto("deleteThirdParty", map[string]any{
|
||||
"id": addResult.ThirdParty.ID,
|
||||
}, &deleteResult)
|
||||
assert.Equal(t, addResult.Vendor.ID, deleteResult.DeletedVendorID)
|
||||
assert.Equal(t, addResult.ThirdParty.ID, deleteResult.DeletedThirdPartyID)
|
||||
|
||||
// Update deleted vendor returns sanitized not-found error
|
||||
msg := mc.CallToolExpectToolError("updateVendor", map[string]any{
|
||||
"id": addResult.Vendor.ID,
|
||||
// Update deleted thirdParty returns sanitized not-found error
|
||||
msg := mc.CallToolExpectToolError("updateThirdParty", map[string]any{
|
||||
"id": addResult.ThirdParty.ID,
|
||||
"name": "Should Fail",
|
||||
})
|
||||
assert.Equal(t, "resource not found", msg)
|
||||
}
|
||||
|
||||
func TestMCP_Vendor_ValidationError(t *testing.T) {
|
||||
func TestMCP_ThirdParty_ValidationError(t *testing.T) {
|
||||
t.Parallel()
|
||||
owner := testutil.NewClient(t, testutil.RoleOwner)
|
||||
mc := testutil.NewMCPClient(t, owner)
|
||||
orgID := owner.GetOrganizationID().String()
|
||||
|
||||
msg := mc.CallToolExpectToolError("addVendor", map[string]any{
|
||||
msg := mc.CallToolExpectToolError("addThirdParty", map[string]any{
|
||||
"organizationId": orgID,
|
||||
"name": "",
|
||||
})
|
||||
@@ -100,16 +100,16 @@ func TestMCP_Vendor_ValidationError(t *testing.T) {
|
||||
assert.NotContains(t, msg, "sql:")
|
||||
}
|
||||
|
||||
func TestMCP_Vendor_PermissionDenied(t *testing.T) {
|
||||
func TestMCP_ThirdParty_PermissionDenied(t *testing.T) {
|
||||
t.Parallel()
|
||||
owner := testutil.NewClient(t, testutil.RoleOwner)
|
||||
orgID := owner.GetOrganizationID().String()
|
||||
viewer := testutil.NewClientInOrg(t, testutil.RoleViewer, owner)
|
||||
viewerMC := testutil.NewMCPClient(t, viewer)
|
||||
|
||||
msg := viewerMC.CallToolExpectToolError("addVendor", map[string]any{
|
||||
msg := viewerMC.CallToolExpectToolError("addThirdParty", map[string]any{
|
||||
"organizationId": orgID,
|
||||
"name": factory.SafeName("Vendor"),
|
||||
"name": factory.SafeName("ThirdParty"),
|
||||
})
|
||||
assert.Contains(t, msg, "permission denied")
|
||||
assert.NotContains(t, msg, "pq:")
|
||||
@@ -1,142 +0,0 @@
|
||||
// Copyright (c) 2025-2026 Probo Inc <hello@getprobo.com>.
|
||||
//
|
||||
// Permission to use, copy, modify, and/or distribute this software for any
|
||||
// purpose with or without fee is hereby granted, provided that the above
|
||||
// copyright notice and this permission notice appear in all copies.
|
||||
//
|
||||
// THE SOFTWARE IS PROVIDED "AS IS" AND THE AUTHOR DISCLAIMS ALL WARRANTIES WITH
|
||||
// REGARD TO THIS SOFTWARE INCLUDING ALL IMPLIED WARRANTIES OF MERCHANTABILITY
|
||||
// AND FITNESS. IN NO EVENT SHALL THE AUTHOR BE LIABLE FOR ANY SPECIAL, DIRECT,
|
||||
// INDIRECT, OR CONSEQUENTIAL DAMAGES OR ANY DAMAGES WHATSOEVER RESULTING FROM
|
||||
// LOSS OF USE, DATA OR PROFITS, WHETHER IN AN ACTION OF CONTRACT, NEGLIGENCE OR
|
||||
// OTHER TORTIOUS ACTION, ARISING OUT OF OR IN CONNECTION WITH THE USE OR
|
||||
// PERFORMANCE OF THIS SOFTWARE.
|
||||
|
||||
package mcp_test
|
||||
|
||||
import (
|
||||
"testing"
|
||||
|
||||
"github.com/stretchr/testify/assert"
|
||||
"github.com/stretchr/testify/require"
|
||||
"go.probo.inc/probo/e2e/internal/factory"
|
||||
"go.probo.inc/probo/e2e/internal/testutil"
|
||||
)
|
||||
|
||||
type vendorContact struct {
|
||||
ID string `json:"id"`
|
||||
Name string `json:"name"`
|
||||
Email *string `json:"email"`
|
||||
Phone *string `json:"phone"`
|
||||
Role *string `json:"role"`
|
||||
}
|
||||
|
||||
func TestMCP_AddVendorContact(t *testing.T) {
|
||||
t.Parallel()
|
||||
owner := testutil.NewClient(t, testutil.RoleOwner)
|
||||
mc := testutil.NewMCPClient(t, owner)
|
||||
vendorID := factory.CreateVendor(owner)
|
||||
|
||||
var result struct {
|
||||
VendorContact vendorContact `json:"vendorContact"`
|
||||
}
|
||||
mc.CallToolInto("addVendorContact", map[string]any{
|
||||
"vendorId": vendorID,
|
||||
"name": "Alice Smith",
|
||||
"email": "alice@example.com",
|
||||
"phone": "+1-555-0100",
|
||||
"role": "Account Manager",
|
||||
}, &result)
|
||||
|
||||
assert.NotEmpty(t, result.VendorContact.ID)
|
||||
assert.Equal(t, "Alice Smith", result.VendorContact.Name)
|
||||
}
|
||||
|
||||
func TestMCP_UpdateVendorContact(t *testing.T) {
|
||||
t.Parallel()
|
||||
owner := testutil.NewClient(t, testutil.RoleOwner)
|
||||
mc := testutil.NewMCPClient(t, owner)
|
||||
vendorID := factory.CreateVendor(owner)
|
||||
|
||||
// Create
|
||||
var addResult struct {
|
||||
VendorContact vendorContact `json:"vendorContact"`
|
||||
}
|
||||
mc.CallToolInto("addVendorContact", map[string]any{
|
||||
"vendorId": vendorID,
|
||||
"name": "Bob Jones",
|
||||
"email": "bob@example.com",
|
||||
}, &addResult)
|
||||
require.NotEmpty(t, addResult.VendorContact.ID)
|
||||
|
||||
// Update
|
||||
var updateResult struct {
|
||||
VendorContact vendorContact `json:"vendorContact"`
|
||||
}
|
||||
mc.CallToolInto("updateVendorContact", map[string]any{
|
||||
"id": addResult.VendorContact.ID,
|
||||
"name": "Robert Jones",
|
||||
"role": "CTO",
|
||||
}, &updateResult)
|
||||
|
||||
assert.Equal(t, addResult.VendorContact.ID, updateResult.VendorContact.ID)
|
||||
assert.Equal(t, "Robert Jones", updateResult.VendorContact.Name)
|
||||
}
|
||||
|
||||
func TestMCP_DeleteVendorContact(t *testing.T) {
|
||||
t.Parallel()
|
||||
owner := testutil.NewClient(t, testutil.RoleOwner)
|
||||
mc := testutil.NewMCPClient(t, owner)
|
||||
vendorID := factory.CreateVendor(owner)
|
||||
|
||||
// Create
|
||||
var addResult struct {
|
||||
VendorContact vendorContact `json:"vendorContact"`
|
||||
}
|
||||
mc.CallToolInto("addVendorContact", map[string]any{
|
||||
"vendorId": vendorID,
|
||||
"name": "Contact to delete",
|
||||
}, &addResult)
|
||||
require.NotEmpty(t, addResult.VendorContact.ID)
|
||||
|
||||
// Delete
|
||||
var deleteResult struct {
|
||||
DeletedVendorContactID string `json:"deletedVendorContactId"`
|
||||
}
|
||||
mc.CallToolInto("deleteVendorContact", map[string]any{
|
||||
"id": addResult.VendorContact.ID,
|
||||
}, &deleteResult)
|
||||
|
||||
assert.Equal(t, addResult.VendorContact.ID, deleteResult.DeletedVendorContactID)
|
||||
}
|
||||
|
||||
func TestMCP_ListVendorContacts(t *testing.T) {
|
||||
t.Parallel()
|
||||
owner := testutil.NewClient(t, testutil.RoleOwner)
|
||||
mc := testutil.NewMCPClient(t, owner)
|
||||
vendorID := factory.CreateVendor(owner)
|
||||
|
||||
// Create contacts
|
||||
for i := range 3 {
|
||||
var result struct {
|
||||
VendorContact vendorContact `json:"vendorContact"`
|
||||
}
|
||||
mc.CallToolInto("addVendorContact", map[string]any{
|
||||
"vendorId": vendorID,
|
||||
"name": factory.SafeName("Contact"),
|
||||
"email": factory.SafeEmail(),
|
||||
}, &result)
|
||||
require.NotEmpty(t, result.VendorContact.ID)
|
||||
_ = i
|
||||
}
|
||||
|
||||
// List
|
||||
var listResult struct {
|
||||
VendorContacts []vendorContact `json:"vendorContacts"`
|
||||
}
|
||||
mc.CallToolInto("listVendorContacts", map[string]any{
|
||||
"vendorId": vendorID,
|
||||
}, &listResult)
|
||||
|
||||
assert.GreaterOrEqual(t, len(listResult.VendorContacts), 3)
|
||||
}
|
||||
@@ -1,135 +0,0 @@
|
||||
// Copyright (c) 2025-2026 Probo Inc <hello@getprobo.com>.
|
||||
//
|
||||
// Permission to use, copy, modify, and/or distribute this software for any
|
||||
// purpose with or without fee is hereby granted, provided that the above
|
||||
// copyright notice and this permission notice appear in all copies.
|
||||
//
|
||||
// THE SOFTWARE IS PROVIDED "AS IS" AND THE AUTHOR DISCLAIMS ALL WARRANTIES WITH
|
||||
// REGARD TO THIS SOFTWARE INCLUDING ALL IMPLIED WARRANTIES OF MERCHANTABILITY
|
||||
// AND FITNESS. IN NO EVENT SHALL THE AUTHOR BE LIABLE FOR ANY SPECIAL, DIRECT,
|
||||
// INDIRECT, OR CONSEQUENTIAL DAMAGES OR ANY DAMAGES WHATSOEVER RESULTING FROM
|
||||
// LOSS OF USE, DATA OR PROFITS, WHETHER IN AN ACTION OF CONTRACT, NEGLIGENCE OR
|
||||
// OTHER TORTIOUS ACTION, ARISING OUT OF OR IN CONNECTION WITH THE USE OR
|
||||
// PERFORMANCE OF THIS SOFTWARE.
|
||||
|
||||
package mcp_test
|
||||
|
||||
import (
|
||||
"testing"
|
||||
|
||||
"github.com/stretchr/testify/assert"
|
||||
"github.com/stretchr/testify/require"
|
||||
"go.probo.inc/probo/e2e/internal/factory"
|
||||
"go.probo.inc/probo/e2e/internal/testutil"
|
||||
)
|
||||
|
||||
type vendorService struct {
|
||||
ID string `json:"id"`
|
||||
Name string `json:"name"`
|
||||
Description *string `json:"description"`
|
||||
}
|
||||
|
||||
func TestMCP_AddVendorService(t *testing.T) {
|
||||
t.Parallel()
|
||||
owner := testutil.NewClient(t, testutil.RoleOwner)
|
||||
mc := testutil.NewMCPClient(t, owner)
|
||||
vendorID := factory.CreateVendor(owner)
|
||||
|
||||
var result struct {
|
||||
VendorService vendorService `json:"vendorService"`
|
||||
}
|
||||
mc.CallToolInto("addVendorService", map[string]any{
|
||||
"vendorId": vendorID,
|
||||
"name": "Cloud Storage",
|
||||
"description": "Object storage service",
|
||||
}, &result)
|
||||
|
||||
assert.NotEmpty(t, result.VendorService.ID)
|
||||
assert.Equal(t, "Cloud Storage", result.VendorService.Name)
|
||||
}
|
||||
|
||||
func TestMCP_UpdateVendorService(t *testing.T) {
|
||||
t.Parallel()
|
||||
owner := testutil.NewClient(t, testutil.RoleOwner)
|
||||
mc := testutil.NewMCPClient(t, owner)
|
||||
vendorID := factory.CreateVendor(owner)
|
||||
|
||||
// Create
|
||||
var addResult struct {
|
||||
VendorService vendorService `json:"vendorService"`
|
||||
}
|
||||
mc.CallToolInto("addVendorService", map[string]any{
|
||||
"vendorId": vendorID,
|
||||
"name": "Original Service",
|
||||
}, &addResult)
|
||||
require.NotEmpty(t, addResult.VendorService.ID)
|
||||
|
||||
// Update
|
||||
var updateResult struct {
|
||||
VendorService vendorService `json:"vendorService"`
|
||||
}
|
||||
mc.CallToolInto("updateVendorService", map[string]any{
|
||||
"id": addResult.VendorService.ID,
|
||||
"name": "Updated Service",
|
||||
}, &updateResult)
|
||||
|
||||
assert.Equal(t, addResult.VendorService.ID, updateResult.VendorService.ID)
|
||||
assert.Equal(t, "Updated Service", updateResult.VendorService.Name)
|
||||
}
|
||||
|
||||
func TestMCP_DeleteVendorService(t *testing.T) {
|
||||
t.Parallel()
|
||||
owner := testutil.NewClient(t, testutil.RoleOwner)
|
||||
mc := testutil.NewMCPClient(t, owner)
|
||||
vendorID := factory.CreateVendor(owner)
|
||||
|
||||
// Create
|
||||
var addResult struct {
|
||||
VendorService vendorService `json:"vendorService"`
|
||||
}
|
||||
mc.CallToolInto("addVendorService", map[string]any{
|
||||
"vendorId": vendorID,
|
||||
"name": "Service to delete",
|
||||
}, &addResult)
|
||||
require.NotEmpty(t, addResult.VendorService.ID)
|
||||
|
||||
// Delete
|
||||
var deleteResult struct {
|
||||
DeletedVendorServiceID string `json:"deletedVendorServiceId"`
|
||||
}
|
||||
mc.CallToolInto("deleteVendorService", map[string]any{
|
||||
"id": addResult.VendorService.ID,
|
||||
}, &deleteResult)
|
||||
|
||||
assert.Equal(t, addResult.VendorService.ID, deleteResult.DeletedVendorServiceID)
|
||||
}
|
||||
|
||||
func TestMCP_ListVendorServices(t *testing.T) {
|
||||
t.Parallel()
|
||||
owner := testutil.NewClient(t, testutil.RoleOwner)
|
||||
mc := testutil.NewMCPClient(t, owner)
|
||||
vendorID := factory.CreateVendor(owner)
|
||||
|
||||
// Create services
|
||||
for i := range 3 {
|
||||
var result struct {
|
||||
VendorService vendorService `json:"vendorService"`
|
||||
}
|
||||
mc.CallToolInto("addVendorService", map[string]any{
|
||||
"vendorId": vendorID,
|
||||
"name": factory.SafeName("Service"),
|
||||
}, &result)
|
||||
require.NotEmpty(t, result.VendorService.ID)
|
||||
_ = i
|
||||
}
|
||||
|
||||
// List
|
||||
var listResult struct {
|
||||
VendorServices []vendorService `json:"vendorServices"`
|
||||
}
|
||||
mc.CallToolInto("listVendorServices", map[string]any{
|
||||
"vendorId": vendorID,
|
||||
}, &listResult)
|
||||
|
||||
assert.GreaterOrEqual(t, len(listResult.VendorServices), 3)
|
||||
}
|
||||
Reference in New Issue
Block a user