From ee22e9f964c7bc05e83d5e637876ca0d3da36ea2 Mon Sep 17 00:00:00 2001 From: Sacha Al Himdani Date: Tue, 12 May 2026 14:09:35 +0200 Subject: [PATCH] Address CodeQL findings: unused imports, missing semicolons, dead conditionals Signed-off-by: Sacha Al Himdani --- packages/emails/src/TrustCenterAccess.tsx | 1 - packages/helpers/src/file.test.ts | 1 - packages/relay/src/fetch.ts | 2 +- packages/ui/src/Molecules/DurationPicker/DurationPicker.tsx | 4 ++-- packages/vendors/scripts/build-md.mjs | 4 ++-- 5 files changed, 5 insertions(+), 7 deletions(-) diff --git a/packages/emails/src/TrustCenterAccess.tsx b/packages/emails/src/TrustCenterAccess.tsx index cece3c968..4840e73ab 100644 --- a/packages/emails/src/TrustCenterAccess.tsx +++ b/packages/emails/src/TrustCenterAccess.tsx @@ -18,7 +18,6 @@ import EmailLayout, { bodyText, button, buttonContainer, - footerText, } from "./components/EmailLayout"; export const TrustCenterAccess = () => { diff --git a/packages/helpers/src/file.test.ts b/packages/helpers/src/file.test.ts index d67497f8a..e38132a82 100644 --- a/packages/helpers/src/file.test.ts +++ b/packages/helpers/src/file.test.ts @@ -13,7 +13,6 @@ // PERFORMANCE OF THIS SOFTWARE. import { describe, it, expect } from "vitest"; -import { isEmpty } from "./array"; import { fileSize } from "./file"; describe("file", () => { diff --git a/packages/relay/src/fetch.ts b/packages/relay/src/fetch.ts index 3df073207..05d05611d 100644 --- a/packages/relay/src/fetch.ts +++ b/packages/relay/src/fetch.ts @@ -108,7 +108,7 @@ export const makeFetchQuery = (endpoint: string): FetchFunction => { const assumptionRequiredError = errors.find(hasAssumptionRequiredError); if (assumptionRequiredError) { - throw new AssumptionRequiredError(assumptionRequiredError.message) + throw new AssumptionRequiredError(assumptionRequiredError.message); } const ndaSignatureRequiredError = errors.find(hasNDASignatureRequiredError); diff --git a/packages/ui/src/Molecules/DurationPicker/DurationPicker.tsx b/packages/ui/src/Molecules/DurationPicker/DurationPicker.tsx index 03ab1bb27..80838b663 100644 --- a/packages/ui/src/Molecules/DurationPicker/DurationPicker.tsx +++ b/packages/ui/src/Molecules/DurationPicker/DurationPicker.tsx @@ -42,7 +42,7 @@ const stringify = (value: number | null, unit: string): string | null => { } }; -const parse = (value: string): { amount: number; unit: string } | null => { +const parse = (value: string): { amount: number; unit: string } => { const match = value.match(/PT?(\d+)([MDWH])/); if (!match) return { amount: 0, unit: "D" }; const amount = parseInt(match[1], 10) || 0; @@ -67,7 +67,7 @@ export function DurationPicker({ value, onValueChange, ...props }: Props) { ); } - const { amount, unit } = parse(value || "") || { amount: 0, unit: "D" }; + const { amount, unit } = parse(value); return (
diff --git a/packages/vendors/scripts/build-md.mjs b/packages/vendors/scripts/build-md.mjs index b7eb24641..694554b7b 100644 --- a/packages/vendors/scripts/build-md.mjs +++ b/packages/vendors/scripts/build-md.mjs @@ -1,11 +1,11 @@ -import { readFile, writeFile } from "node:fs/promises"; +import { readFile } from "node:fs/promises"; import { createWriteStream } from "node:fs"; import path from "node:path"; const data = await readFile(path.join(import.meta.dirname, '../data.json'), 'utf8'); const vendors = JSON.parse(data); -const output = path.join(import.meta.dirname, '../VENDORS.md') +const output = path.join(import.meta.dirname, '../VENDORS.md'); const file = createWriteStream(output); const formatAsList = (array) => {