Add Neon access review driver support

Register Neon as a connector provider and add a new access review
driver that fetches organization members from the Neon API with
cursor-based pagination.

Neon's OAuth is partner-gated, so the connector is API-key only
(Bearer, the default scheme). A personal or organization API key can
belong to several organizations; the operator supplies the ID of the
one to review. The members endpoint exposes per-user MFA state
(has_mfa) and deactivation, which map to the access entry MFA status
and active flag; the stable account UUID (user_id) is used as the
external ID over the membership ID.

Signed-off-by: Aurélien Sibiril <81782+aureliensibiril@users.noreply.github.com>
This commit is contained in:
Aurélien Sibiril
2026-06-10 00:49:57 +02:00
parent 7640376d32
commit ec858e58df
17 changed files with 763 additions and 1 deletions

View File

@@ -44,6 +44,7 @@ func NewBuiltinRegistry() *Registry {
metabaseRegistration(),
microsoft365Registration(),
mondayRegistration(),
neonRegistration(),
netlifyRegistration(),
notionRegistration(),
oktaRegistration(),

View File

@@ -0,0 +1,67 @@
// Copyright (c) 2026 Probo Inc <hello@probo.com>.
//
// Permission to use, copy, modify, and/or distribute this software for any
// purpose with or without fee is hereby granted, provided that the above
// copyright notice and this permission notice appear in all copies.
//
// THE SOFTWARE IS PROVIDED "AS IS" AND THE AUTHOR DISCLAIMS ALL WARRANTIES WITH
// REGARD TO THIS SOFTWARE INCLUDING ALL IMPLIED WARRANTIES OF MERCHANTABILITY
// AND FITNESS. IN NO EVENT SHALL THE AUTHOR BE LIABLE FOR ANY SPECIAL, DIRECT,
// INDIRECT, OR CONSEQUENTIAL DAMAGES OR ANY DAMAGES WHATSOEVER RESULTING FROM
// LOSS OF USE, DATA OR PROFITS, WHETHER IN AN ACTION OF CONTRACT, NEGLIGENCE OR
// OTHER TORTIOUS ACTION, ARISING OUT OF OR IN CONNECTION WITH THE USE OR
// PERFORMANCE OF THIS SOFTWARE.
package provider
import (
"context"
"fmt"
"net/http"
"go.gearno.de/kit/log"
"go.probo.inc/probo/pkg/accessreview/drivers"
"go.probo.inc/probo/pkg/coredata"
)
func neonRegistration() *Registration {
return &Registration{
Provider: coredata.ConnectorProviderNeon,
DisplayName: "Neon",
// Neon's API authenticates with an API key (napi_...) presented
// as Authorization: Bearer, the default APIKeyConnection scheme.
// Neon's OAuth is partner-gated (manual application), so the
// connector is API-key only. A personal or organization API key
// can belong to several organizations; the operator supplies the
// org ID (org-...) of the one to review.
//
// ProbeURL is intentionally empty: the connection probe runs only
// for OAuth2 connections, so it would be dead config for an
// API-key provider; a dead key surfaces on the first ListAccounts.
SupportsAPIKey: true,
ExtraSettings: []ExtraSetting{
{Key: "organizationId", Label: "Organization ID", Required: true},
},
NewDriver: func(_ context.Context, c *http.Client, conn *coredata.Connector, _ *log.Logger) (drivers.Driver, error) {
s, err := coredata.ConnectorSettings[coredata.NeonConnectorSettings](conn)
if err != nil {
return nil, fmt.Errorf("cannot read neon connector settings: %w", err)
}
if s.OrganizationID == "" {
return nil, fmt.Errorf("cannot create neon driver: organization_id is required")
}
return drivers.NewNeonDriver(c, s.OrganizationID), nil
},
NewNameResolver: func(ctx context.Context, c *http.Client, conn *coredata.Connector, logger *log.Logger) drivers.NameResolver {
s, err := coredata.ConnectorSettings[coredata.NeonConnectorSettings](conn)
if err != nil {
logger.ErrorCtx(ctx, "cannot read neon connector settings", log.Error(err))
return nil
}
return drivers.NewNeonNameResolver(c, s.OrganizationID)
},
}
}

View File

@@ -0,0 +1,106 @@
// Copyright (c) 2026 Probo Inc <hello@probo.com>.
//
// Permission to use, copy, modify, and/or distribute this software for any
// purpose with or without fee is hereby granted, provided that the above
// copyright notice and this permission notice appear in all copies.
//
// THE SOFTWARE IS PROVIDED "AS IS" AND THE AUTHOR DISCLAIMS ALL WARRANTIES WITH
// REGARD TO THIS SOFTWARE INCLUDING ALL IMPLIED WARRANTIES OF MERCHANTABILITY
// AND FITNESS. IN NO EVENT SHALL THE AUTHOR BE LIABLE FOR ANY SPECIAL, DIRECT,
// INDIRECT, OR CONSEQUENTIAL DAMAGES OR ANY DAMAGES WHATSOEVER RESULTING FROM
// LOSS OF USE, DATA OR PROFITS, WHETHER IN AN ACTION OF CONTRACT, NEGLIGENCE OR
// OTHER TORTIOUS ACTION, ARISING OUT OF OR IN CONNECTION WITH THE USE OR
// PERFORMANCE OF THIS SOFTWARE.
package provider_test
import (
"context"
"encoding/json"
"testing"
"github.com/stretchr/testify/assert"
"github.com/stretchr/testify/require"
"go.gearno.de/kit/httpclient"
"go.probo.inc/probo/pkg/accessreview/drivers"
"go.probo.inc/probo/pkg/connector/provider"
"go.probo.inc/probo/pkg/coredata"
)
func TestNeonRegistrationMetadata(t *testing.T) {
t.Parallel()
r := provider.NewBuiltinRegistry()
reg, ok := r.Get(coredata.ConnectorProviderNeon)
require.True(t, ok, "neon provider must be registered")
assert.Equal(t, "Neon", reg.DisplayName)
assert.True(t, reg.SupportsAPIKey)
assert.Empty(t, reg.APIKeyAuthScheme, "neon API keys use the default Bearer scheme")
require.Len(t, reg.ExtraSettings, 1)
assert.Equal(t, "organizationId", reg.ExtraSettings[0].Key)
assert.Equal(t, "Organization ID", reg.ExtraSettings[0].Label)
assert.True(t, reg.ExtraSettings[0].Required)
}
func TestNeonNewDriver(t *testing.T) {
t.Parallel()
r := provider.NewBuiltinRegistry()
reg, ok := r.Get(coredata.ConnectorProviderNeon)
require.True(t, ok, "neon provider must be registered")
require.NotNil(t, reg.NewDriver, "neon NewDriver closure must be wired")
t.Run("creates driver with valid organization_id", func(t *testing.T) {
t.Parallel()
raw, err := json.Marshal(&coredata.NeonConnectorSettings{
OrganizationID: "org-cool-breeze-12345678",
})
require.NoError(t, err)
conn := &coredata.Connector{
Provider: coredata.ConnectorProviderNeon,
RawSettings: raw,
}
drv, err := reg.NewDriver(context.Background(), httpclient.DefaultClient(httpclient.WithSSRFProtection()), conn, nil)
require.NoError(t, err)
assert.IsType(t, &drivers.NeonDriver{}, drv)
})
t.Run("errors when organization_id is missing", func(t *testing.T) {
t.Parallel()
conn := &coredata.Connector{
Provider: coredata.ConnectorProviderNeon,
RawSettings: []byte(`{}`),
}
_, err := reg.NewDriver(context.Background(), httpclient.DefaultClient(httpclient.WithSSRFProtection()), conn, nil)
require.Error(t, err)
assert.Contains(t, err.Error(), "organization_id is required")
})
}
func TestNeonNewNameResolver(t *testing.T) {
t.Parallel()
r := provider.NewBuiltinRegistry()
reg, ok := r.Get(coredata.ConnectorProviderNeon)
require.True(t, ok, "neon provider must be registered")
require.NotNil(t, reg.NewNameResolver, "neon NewNameResolver closure must be wired")
raw, err := json.Marshal(&coredata.NeonConnectorSettings{
OrganizationID: "org-cool-breeze-12345678",
})
require.NoError(t, err)
conn := &coredata.Connector{
Provider: coredata.ConnectorProviderNeon,
RawSettings: raw,
}
resolver := reg.NewNameResolver(context.Background(), httpclient.DefaultClient(httpclient.WithSSRFProtection()), conn, nil)
require.NotNil(t, resolver, "neon name resolver must be constructed for a valid connector")
}