Restrict OAuth client branding URLs to http(s)

CIMD and registration accepted any URI scheme for client_uri and
logo_uri, so allowlisted metadata could surface javascript: links on
sign-in. Validate absolute http/https at ingest and only expose those
schemes in branding.

Signed-off-by: Bryan Frimin <bryan@probo.com>
This commit is contained in:
Bryan Frimin
2026-07-17 14:01:25 +02:00
parent 6da00604ed
commit e7df6f6b2a
10 changed files with 322 additions and 17 deletions

View File

@@ -159,6 +159,45 @@ func TestValidateClientMetadataDocument(t *testing.T) {
require.Error(t, err)
},
)
t.Run(
"https client_uri and logo_uri allowed",
func(t *testing.T) {
t.Parallel()
good := doc
good.ClientURI = "https://mcp.example.com"
good.LogoURI = "https://mcp.example.com/logo.png"
require.NoError(t, validateClientMetadataDocument(clientID, &good))
},
)
t.Run(
"non-web client_uri rejected",
func(t *testing.T) {
t.Parallel()
bad := doc
bad.ClientURI = "javascript://example.com/%0Aalert(1)"
err := validateClientMetadataDocument(clientID, &bad)
require.Error(t, err)
},
)
t.Run(
"non-web logo_uri rejected",
func(t *testing.T) {
t.Parallel()
bad := doc
bad.LogoURI = "data://example.com/image"
err := validateClientMetadataDocument(clientID, &bad)
require.Error(t, err)
},
)
}
func TestCIMDFetcherFetch(t *testing.T) {