rohit/probo
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Prevent last owner from demoting themselves

Browse Source 
The UpdateMembership path allowed the sole owner of an
organization to change their role to a non-owner role,
causing permanent lockout. Add the same active-owner count
guard already used in RemoveUser.

Closes #1071

Signed-off-by: Bryan Frimin <bryan@getprobo.com>
This commit is contained in:
Bryan Frimin
2026-04-20 11:59:59 +02:00
committed by Sacha Al Himdani
parent 8ce429507b
commit dd8c3b5491
1 changed files with 12 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

12
pkg/iam/organization_service.go
View File

@@ -266,6 +266,18 @@ func (s *OrganizationService) UpdateMempership(
return NewMembershipNotFoundError(membership.ID) return NewMembershipNotFoundError(membership.ID)
} }
if membership.Role == coredata.MembershipRoleOwner && role != coredata.MembershipRoleOwner {
profiles := coredata.MembershipProfiles{}
count, err := profiles.CountActiveOwnerByOrganizationID(ctx, tx, scope, organizationID)
if err != nil {
return fmt.Errorf("cannot count active owners: %w", err)
}
if count <= 1 {
return NewLastActiveOwnerError(membershipID)
}
}
membership.Role = role membership.Role = role
membership.UpdatedAt = time.Now() membership.UpdatedAt = time.Now()