rohit/probo
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Rename NONCONFORMITY to MINOR_NONCONFORMITY and add MAJOR_NONCONFORMITY

Browse Source 
Support distinguishing between minor and major non-conformities in findings. Rename the existing NONCONFORMITY enum value to MINOR_NONCONFORMITY and add a new MAJOR_NONCONFORMITY value across all API layers (GraphQL, MCP, CLI) and the database.

Signed-off-by: Bryan Frimin <bryan@getprobo.com>
This commit is contained in:
Bryan Frimin
2026-03-19 09:37:15 +01:00
parent a46366fad4
commit d7c120c144
10 changed files with 49 additions and 31 deletions
Download Patch File Download Diff File Expand all files Collapse all files

14
e2e/console/finding_test.go
View File

@@ -68,7 +68,7 @@ func TestFinding_CreateNonconformity(t *testing.T) {
err := owner.Execute(query, map[string]any{
"input": map[string]any{
"organizationId": owner.GetOrganizationID().String(),
"kind": "NONCONFORMITY",
"kind": "MINOR_NONCONFORMITY",
"description": "Unauthorized access detected",
"rootCause": "Insufficient access controls",
"correctiveAction": "Implement MFA",
@@ -81,7 +81,7 @@ func TestFinding_CreateNonconformity(t *testing.T) {
node := result.CreateFinding.FindingEdge.Node
assert.NotEmpty(t, node.ID)
assert.Equal(t, "NONCONFORMITY", node.Kind)
assert.Equal(t, "MINOR_NONCONFORMITY", node.Kind)
assert.Equal(t, "Unauthorized access detected", node.Description)
assert.Equal(t, "Insufficient access controls", node.RootCause)
assert.Equal(t, "Implement MFA", node.CorrectiveAction)
@@ -178,7 +178,7 @@ func TestFinding_Update(t *testing.T) {
err := owner.Execute(createQuery, map[string]any{
"input": map[string]any{
"organizationId": owner.GetOrganizationID().String(),
"kind": "NONCONFORMITY",
"kind": "MINOR_NONCONFORMITY",
"description": "Original description",
"ownerId": profileID,
"status": "OPEN",
@@ -330,7 +330,7 @@ func TestFinding_List(t *testing.T) {
err := owner.Execute(createQuery, map[string]any{
"input": map[string]any{
"organizationId": owner.GetOrganizationID().String(),
"kind": "NONCONFORMITY",
"kind": "MINOR_NONCONFORMITY",
"description": fmt.Sprintf("Finding %d", i),
"ownerId": profileID,
"status": "OPEN",
@@ -402,7 +402,7 @@ func TestFinding_ListWithKindFilter(t *testing.T) {
}
`
kinds := []string{"NONCONFORMITY", "OBSERVATION", "EXCEPTION"}
kinds := []string{"MINOR_NONCONFORMITY", "MAJOR_NONCONFORMITY", "OBSERVATION", "EXCEPTION"}
for _, kind := range kinds {
var createResult struct {
CreateFinding struct {
@@ -503,7 +503,7 @@ func TestFinding_CreateAuditMapping(t *testing.T) {
err := owner.Execute(createQuery, map[string]any{
"input": map[string]any{
"organizationId": owner.GetOrganizationID().String(),
"kind": "NONCONFORMITY",
"kind": "MINOR_NONCONFORMITY",
"ownerId": profileID,
"status": "OPEN",
"priority": "HIGH",
@@ -774,7 +774,7 @@ func TestFinding_StatusAndPriorityValues(t *testing.T) {
input := map[string]any{
"organizationId": owner.GetOrganizationID().String(),
"kind": "NONCONFORMITY",
"kind": "MINOR_NONCONFORMITY",
"ownerId": profileID,
"status": status,
"priority": "LOW",