Tear down workflows when archiving documents

Archive and bulk archive now void pending approval quorums and
cancel requested signatures before freezing the document. Unarchive
reverts any leftover pending approval to draft. A migration backfills
archived documents that still carry in-flight workflow rows.

Signed-off-by: Cursor Agent <cursoragent@cursor.com>

Co-authored-by: Bryan FRIMIN <bryan@frimin.fr>
This commit is contained in:
Cursor Agent
2026-07-11 09:53:05 +00:00
committed by Bryan Frimin
parent e5c7cf9b9c
commit d2286aa1ac
5 changed files with 542 additions and 53 deletions

View File

@@ -811,6 +811,89 @@ WHERE
return nil
}
func (pvss *DocumentVersionSignatures) LoadRequestedByDocumentID(
ctx context.Context,
conn pg.Querier,
scope Scoper,
documentID gid.GID,
) error {
q := `
SELECT
document_version_signatures.id,
document_version_signatures.organization_id,
document_version_signatures.document_version_id,
document_version_signatures.state,
document_version_signatures.signed_by_profile_id,
document_version_signatures.signed_at,
document_version_signatures.requested_at,
document_version_signatures.electronic_signature_id,
document_version_signatures.created_at,
document_version_signatures.updated_at
FROM
document_version_signatures
INNER JOIN document_versions ON document_versions.id = document_version_signatures.document_version_id
WHERE
%s
AND document_versions.document_id = @document_id
AND document_version_signatures.state = @state
`
q = fmt.Sprintf(q, scope.SQLFragment())
args := pgx.StrictNamedArgs{
"document_id": documentID,
"state": DocumentVersionSignatureStateRequested,
}
maps.Copy(args, scope.SQLArguments())
rows, err := conn.Query(ctx, q, args)
if err != nil {
return fmt.Errorf("cannot query requested document version signatures: %w", err)
}
documentVersionSignatures, err := pgx.CollectRows(rows, pgx.RowToAddrOfStructByName[DocumentVersionSignature])
if err != nil {
return fmt.Errorf("cannot collect requested document version signatures: %w", err)
}
*pvss = documentVersionSignatures
return nil
}
func (pvss *DocumentVersionSignatures) DeleteRequestedByDocumentID(
ctx context.Context,
conn pg.Tx,
scope Scoper,
documentID gid.GID,
) error {
q := `
DELETE FROM document_version_signatures
WHERE
%s
AND state = @state
AND document_version_id IN (
SELECT id
FROM document_versions
WHERE document_id = @document_id
)
`
q = fmt.Sprintf(q, scope.SQLFragment())
args := pgx.StrictNamedArgs{
"document_id": documentID,
"state": DocumentVersionSignatureStateRequested,
}
maps.Copy(args, scope.SQLArguments())
if _, err := conn.Exec(ctx, q, args); err != nil {
return fmt.Errorf("cannot delete requested document version signatures: %w", err)
}
return nil
}
func (pvss *DocumentVersionSignaturesWithPeople) LoadByDocumentVersionIDWithPeople(
ctx context.Context,
conn pg.Querier,

View File

@@ -0,0 +1,66 @@
-- Copyright (c) 2026 Probo Inc <hello@probo.com>.
--
-- Permission to use, copy, modify, and/or distribute this software for any
-- purpose with or without fee is hereby granted, provided that the above
-- copyright notice and this permission notice appear in all copies.
--
-- THE SOFTWARE IS PROVIDED "AS IS" AND THE AUTHOR DISCLAIMS ALL WARRANTIES WITH
-- REGARD TO THIS SOFTWARE INCLUDING ALL IMPLIED WARRANTIES OF MERCHANTABILITY
-- AND FITNESS. IN NO EVENT SHALL THE AUTHOR BE LIABLE FOR ANY SPECIAL, DIRECT,
-- INDIRECT, OR CONSEQUENTIAL DAMAGES OR ANY DAMAGES WHATSOEVER RESULTING FROM
-- LOSS OF USE, DATA OR PROFITS, WHETHER IN AN ACTION OF CONTRACT, NEGLIGENCE OR
-- OTHER TORTIOUS ACTION, ARISING OUT OF OR IN CONNECTION WITH THE USE OR
-- PERFORMANCE OF THIS SOFTWARE.
-- Archived documents must not retain in-flight approval or signature workflows.
-- Backfill rows that were archived before archive teardown was enforced in the
-- application layer.
UPDATE document_version_approval_decisions d
SET
state = 'VOIDED',
updated_at = NOW()
FROM document_version_approval_quorums q
INNER JOIN document_versions dv ON dv.id = q.version_id
INNER JOIN documents doc ON doc.id = dv.document_id
WHERE
d.quorum_id = q.id
AND d.state = 'PENDING'
AND doc.archived_at IS NOT NULL;
UPDATE document_version_approval_quorums q
SET
status = 'VOIDED',
updated_at = NOW()
FROM document_versions dv
INNER JOIN documents doc ON doc.id = dv.document_id
WHERE
q.version_id = dv.id
AND q.status = 'PENDING'
AND doc.archived_at IS NOT NULL;
UPDATE document_versions dv
SET
status = 'DRAFT',
major = CASE
WHEN doc.current_published_major IS NOT NULL THEN doc.current_published_major
ELSE 0
END,
minor = CASE
WHEN doc.current_published_major IS NOT NULL THEN doc.current_published_minor + 1
ELSE 1
END,
updated_at = NOW()
FROM documents doc
WHERE
dv.document_id = doc.id
AND doc.archived_at IS NOT NULL
AND dv.status = 'PENDING_APPROVAL';
DELETE FROM document_version_signatures dvs
USING document_versions dv
INNER JOIN documents doc ON doc.id = dv.document_id
WHERE
dvs.document_version_id = dv.id
AND dvs.state = 'REQUESTED'
AND doc.archived_at IS NOT NULL;