Fix PR review comments and rename versions to latest-version
- Validate __typename in all list command pagination callbacks - Serialize PostHogConsent=false as explicit false (not nil) - Fix maxAgeSeconds factory to only include when value is an int - Rename cookie-banner versions to latest-version subcommand Signed-off-by: Émile Ré <emile@getprobo.com>
This commit is contained in:
@@ -25,7 +25,7 @@ import (
|
||||
"go.probo.inc/probo/pkg/cmd/cookie-banner/publish"
|
||||
"go.probo.inc/probo/pkg/cmd/cookie-banner/translate"
|
||||
"go.probo.inc/probo/pkg/cmd/cookie-banner/update"
|
||||
"go.probo.inc/probo/pkg/cmd/cookie-banner/versions"
|
||||
"go.probo.inc/probo/pkg/cmd/cookie-banner/latestversion"
|
||||
"go.probo.inc/probo/pkg/cmd/cookie-banner/view"
|
||||
)
|
||||
|
||||
@@ -44,7 +44,7 @@ func NewCmdCookieBanner(f *cmdutil.Factory) *cobra.Command {
|
||||
cmd.AddCommand(deactivate.NewCmdDeactivate(f))
|
||||
cmd.AddCommand(publish.NewCmdPublish(f))
|
||||
cmd.AddCommand(translate.NewCmdTranslate(f))
|
||||
cmd.AddCommand(versions.NewCmdVersions(f))
|
||||
cmd.AddCommand(latestversion.NewCmdLatestVersion(f))
|
||||
|
||||
return cmd
|
||||
}
|
||||
|
||||
Reference in New Issue
Block a user