From c8b7615046a98aff62eb509547b810247e214e8a Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?=C3=89mile=20R=C3=A9?= Date: Fri, 29 May 2026 19:47:45 +0200 Subject: [PATCH] Fix lint issues MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Signed-off-by: Émile Ré --- pkg/cookiebanner/pattern_analysis_worker_process_test.go | 1 + pkg/coredata/common_tracker_pattern_test.go | 1 + pkg/llm/llm.go | 6 ++++++ pkg/thirdparty/resolver_test.go | 4 ++++ 4 files changed, 12 insertions(+) diff --git a/pkg/cookiebanner/pattern_analysis_worker_process_test.go b/pkg/cookiebanner/pattern_analysis_worker_process_test.go index a503768bf..98a52be36 100644 --- a/pkg/cookiebanner/pattern_analysis_worker_process_test.go +++ b/pkg/cookiebanner/pattern_analysis_worker_process_test.go @@ -707,6 +707,7 @@ func TestPatternAnalysisWorker_GlobInheritsUnanimousMapping(t *testing.T) { for _, ep := range exacts { ep.ThirdPartyID = &thirdPartyID } + exacts[1].Description = "Google Analytics measurement cookie" require.NoError(t, client.WithTx(ctx, func(ctx context.Context, tx pg.Tx) error { diff --git a/pkg/coredata/common_tracker_pattern_test.go b/pkg/coredata/common_tracker_pattern_test.go index c419bc81c..5ecfc2ba9 100644 --- a/pkg/coredata/common_tracker_pattern_test.go +++ b/pkg/coredata/common_tracker_pattern_test.go @@ -91,6 +91,7 @@ func loadCommonTrackerPattern( t.Helper() var reloaded coredata.CommonTrackerPattern + require.NoError(t, client.WithConn(ctx, func(ctx context.Context, conn pg.Querier) error { return reloaded.LoadByID(ctx, conn, id) })) diff --git a/pkg/llm/llm.go b/pkg/llm/llm.go index 5dc761534..6afedc2e0 100644 --- a/pkg/llm/llm.go +++ b/pkg/llm/llm.go @@ -177,28 +177,34 @@ func sanitizeRequest(ctx context.Context, logger *log.Logger, req *ChatCompletio sanitized := *req dropped := make([]string, 0, 5) + if dropTemperature { sanitized.Temperature = nil + dropped = append(dropped, "temperature") } if dropTopP { sanitized.TopP = nil + dropped = append(dropped, "top_p") } if dropFrequencyPenalty { sanitized.FrequencyPenalty = nil + dropped = append(dropped, "frequency_penalty") } if dropPresencePenalty { sanitized.PresencePenalty = nil + dropped = append(dropped, "presence_penalty") } if dropStop { sanitized.StopSequences = nil + dropped = append(dropped, "stop") } diff --git a/pkg/thirdparty/resolver_test.go b/pkg/thirdparty/resolver_test.go index 57533183a..3355ed6fd 100644 --- a/pkg/thirdparty/resolver_test.go +++ b/pkg/thirdparty/resolver_test.go @@ -137,6 +137,7 @@ func TestResolveOrCreateCommonThirdParty(t *testing.T) { party := seedCatalogThirdParty(t, ctx, client, name, slug.Make(name)) var got *gid.GID + require.NoError(t, client.WithTx(ctx, func(ctx context.Context, tx pg.Tx) error { id, err := ResolveOrCreateCommonThirdParty( ctx, @@ -166,6 +167,7 @@ func TestResolveOrCreateCommonThirdParty(t *testing.T) { require.Equal(t, slug.Make(name), slug.Make(variant)) var got *gid.GID + require.NoError(t, client.WithTx(ctx, func(ctx context.Context, tx pg.Tx) error { id, err := ResolveOrCreateCommonThirdParty( ctx, @@ -189,6 +191,7 @@ func TestResolveOrCreateCommonThirdParty(t *testing.T) { expectedSlug := slug.Make(name) var got *gid.GID + require.NoError(t, client.WithTx(ctx, func(ctx context.Context, tx pg.Tx) error { id, err := ResolveOrCreateCommonThirdParty( ctx, @@ -213,6 +216,7 @@ func TestResolveOrCreateCommonThirdParty(t *testing.T) { }) var created coredata.CommonThirdParty + require.NoError(t, client.WithConn(ctx, func(ctx context.Context, conn pg.Querier) error { return created.LoadByID(ctx, conn, *got) }))