Implement continue on connect + nda

Signed-off-by: Émile Ré <emile@getprobo.com>

apps/trust/src/components/DocumentRow.tsx

@@ -1,5 +1,6 @@
 import { downloadFile, formatError } from "@probo/helpers";
 import { useTranslate } from "@probo/i18n";
+import { UnAuthenticatedError } from "@probo/relay";
 import {
   Button,
   IconArrowInbox,
@@ -8,12 +9,12 @@ import {
   Spinner,
   useToast,
 } from "@probo/ui";
-import { use, useState } from "react";
+import { useState } from "react";
 import { useFragment, useMutation } from "react-relay";
+import { useLocation, useNavigate } from "react-router";
 import { graphql } from "relay-runtime";
 
 import { useMutationWithToasts } from "#/hooks/useMutationWithToast";
-import { Viewer } from "#/providers/Viewer";
 
 import type { DocumentRow_requestAccessMutation } from "./__generated__/DocumentRow_requestAccessMutation.graphql";
 import type { DocumentRowDownloadMutation } from "./__generated__/DocumentRowDownloadMutation.graphql";
@@ -50,8 +51,9 @@ const documentRowFragment = graphql`
 
 export function DocumentRow(props: { document: DocumentRowFragment$key }) {
   const { __ } = useTranslate();
-  const viewer = use(Viewer);
   const { toast } = useToast();
+  const navigate = useNavigate();
+  const location = useLocation();
 
   const document = useFragment(documentRowFragment, props.document);
   const [hasRequested, setHasRequested] = useState(
@@ -87,6 +89,13 @@ export function DocumentRow(props: { document: DocumentRowFragment$key }) {
         });
       },
       onError: (error) => {
+        if (error instanceof UnAuthenticatedError) {
+          const searchParams = new URLSearchParams([[
+            "continue", window.location.origin + location.pathname + location.search,
+          ]]);
+          void navigate(`/connect?${searchParams.toString()}`);
+        }
+
         toast({
           title: __("Error"),
           description: error.message ?? __("Cannot request access"),
@@ -127,8 +136,7 @@ export function DocumentRow(props: { document: DocumentRowFragment$key }) {
               {downloading ? __("Downloading") : __("Download")}
             </Button>
           )
-        : viewer
+        : (
-          ? (
             <Button
               disabled={hasRequested || isRequestingAccess}
               className="w-full md:w-max"
@@ -138,16 +146,6 @@ export function DocumentRow(props: { document: DocumentRowFragment$key }) {
             >
               {hasRequested ? __("Access requested") : __("Request access")}
             </Button>
-            )
-          : (
-              <Button
-                className="w-full md:w-max"
-                variant="secondary"
-                icon={IconLock}
-                to="/connect"
-              >
-                {hasRequested ? __("Access requested") : __("Request access")}
-              </Button>
           )}
     </div>
   );

apps/trust/src/components/RootErrorBoundary.tsx

@@ -0,0 +1,41 @@
+import { NDASignatureRequiredError, UnAuthenticatedError } from "@probo/relay";
+import { Navigate, useLocation, useRouteError } from "react-router";
+
+import { getPathPrefix } from "#/utils/pathPrefix";
+
+import { PageError } from "./PageError";
+
+export function RootErrorBoundary() {
+  const error = useRouteError();
+  const location = useLocation();
+
+  const search = new URLSearchParams();
+
+  if (location.pathname !== getPathPrefix() || location.search !== "") {
+    search.set("continue", window.location.href);
+  }
+
+  const queryString = search.toString();
+
+  if (error instanceof UnAuthenticatedError) {
+    return (
+      <Navigate to={{
+        pathname: "/connect",
+        search: queryString ? "?" + queryString : "",
+      }}
+      />
+    );
+  }
+
+  if (error instanceof NDASignatureRequiredError) {
+    return (
+      <Navigate to={{
+        pathname: "/nda",
+        search: queryString ? "?" + queryString : "",
+      }}
+      />
+    );
+  }
+
+  return <PageError error={error instanceof Error ? error : new Error("unknown error")} />;
+}

apps/trust/src/pages/NDAPage.tsx

@@ -8,13 +8,14 @@ import {
   usePreloadedQuery,
   useRefetchableFragment,
 } from "react-relay";
-import { Navigate, useNavigate } from "react-router";
+import { Navigate, useSearchParams } from "react-router";
 import { graphql } from "relay-runtime";
 import { useWindowSize } from "usehooks-ts";
 import { z } from "zod";
 
 import { PDFPreview } from "#/components/PDFPreview";
 import { useFormWithSchema } from "#/hooks/useFormWithSchema";
+import { getPathPrefix } from "#/utils/pathPrefix";
 
 import type { NDAPageAcceptElectronicSignatureMutation } from "./__generated__/NDAPageAcceptElectronicSignatureMutation.graphql";
 import type { NDAPageFragment$key } from "./__generated__/NDAPageFragment.graphql";
@@ -88,8 +89,11 @@ export function NDAPage(props: {
   queryRef: PreloadedQuery<NDAPageQueryType>;
 }) {
   const { __ } = useTranslate();
-  const navigate = useNavigate();
+  const [searchParams] = useSearchParams();
   const documentViewedRef = useRef(false);
+  const { width } = useWindowSize();
+  const isMobile = width < 1100;
+  const isDesktop = !isMobile;
 
   const queryData = usePreloadedQuery(ndaPageQuery, props.queryRef);
   const trustCenter = queryData.currentTrustCenter;
@@ -101,19 +105,14 @@ export function NDAPage(props: {
   );
   const ndaSignature = data.nonDisclosureAgreement.viewerSignature;
 
-  const { width } = useWindowSize();
+  const continueUrlParam = searchParams.get("continue");
-  const isMobile = width < 1100;
+  let safeContinueUrl: string;
-  const isDesktop = !isMobile;
+  if (continueUrlParam) {
-
+    const continueUrl = new URL(continueUrlParam);
-  const {
+    safeContinueUrl = window.location.origin + continueUrl.pathname + continueUrl.search;
-    handleSubmit: handleSubmitWrapper,
+  } else {
-    register,
+    safeContinueUrl = window.location.origin + getPathPrefix();
-    formState,
+  }
-  } = useFormWithSchema(schema, {
-    defaultValues: {
-      fullName: viewer?.fullName,
-    },
-  });
 
   const [acceptSignature, isAccepting] = useMutation<NDAPageAcceptElectronicSignatureMutation>(
     acceptElectronicSignatureMutation,
@@ -130,11 +129,21 @@ export function NDAPage(props: {
   const isFailed = ndaSignature?.status === "FAILED";
   const isCompleted = ndaSignature?.status === "COMPLETED";
 
+  const {
+    handleSubmit: handleSubmitWrapper,
+    register,
+    formState,
+  } = useFormWithSchema(schema, {
+    defaultValues: {
+      fullName: viewer?.fullName,
+    },
+  });
+
   useEffect(() => {
     if (isCompleted) {
-      void navigate("/overview", { replace: true });
+      window.location.href = safeContinueUrl;
     }
-  }, [isCompleted, navigate]);
+  }, [isCompleted, safeContinueUrl]);
 
   useEffect(() => {
     if (!isProcessing) return;

apps/trust/src/providers/RelayProviders.tsx

@@ -70,7 +70,7 @@ const store = new Store(source, {
 });
 
 export const consoleEnvironment = new Environment({
-  configName: "trust",
+  configName: "compliance-page",
   network: Network.create(makeFetchQuery(buildEndpoint())),
   store,
 });

apps/trust/src/routes.tsx

@@ -7,7 +7,7 @@ import {
 } from "@probo/routes";
 import { Fragment } from "react";
 import { loadQuery } from "react-relay";
-import { createBrowserRouter, redirect, useRouteError } from "react-router";
+import { createBrowserRouter, redirect } from "react-router";
 
 import { MainLayout } from "#/layouts/MainLayout";
 import { DocumentsPage } from "#/pages/DocumentsPage";
@@ -20,19 +20,11 @@ import {
 } from "#/queries/TrustGraph";
 
 import { PageError } from "./components/PageError";
+import { RootErrorBoundary } from "./components/RootErrorBoundary";
 import { MainSkeleton } from "./components/Skeletons/MainSkeleton";
 import { TabSkeleton } from "./components/Skeletons/TabSkeleton";
 import { consoleEnvironment } from "./providers/RelayProviders";
 
-/**
- * Top level error boundary
- */
-function ErrorBoundary() {
-  const error = useRouteError();
-
-  return <PageError error={error instanceof Error ? error : new Error("unkown error")} />;
-}
-
 const routes = [
   {
     Component: lazy(() => import("#/pages/auth/AuthLayoutLoader")),
@@ -54,12 +46,12 @@ const routes = [
       throw redirect("/overview");
     },
     Component: Fragment,
-    ErrorBoundary: ErrorBoundary,
+    ErrorBoundary: RootErrorBoundary,
   },
   {
     path: "/nda",
     Component: lazy(() => import("#/pages/NDAPageLoader")),
-    ErrorBoundary: ErrorBoundary,
+    ErrorBoundary: RootErrorBoundary,
   },
   // Custom domain routes (subdomain-based)
   {
@@ -69,7 +61,7 @@ const routes = [
     ),
     Component: withQueryRef(MainLayout),
     Fallback: MainSkeleton,
-    ErrorBoundary: ErrorBoundary,
+    ErrorBoundary: RootErrorBoundary,
     children: [
       {
         path: "",
@@ -85,7 +77,7 @@ const routes = [
     ),
     Component: withQueryRef(MainLayout),
     Fallback: MainSkeleton,
-    ErrorBoundary: ErrorBoundary,
+    ErrorBoundary: RootErrorBoundary,
     children: [
       {
         path: "",
@@ -104,7 +96,7 @@ const routes = [
     ),
     Component: withQueryRef(MainLayout),
     Fallback: MainSkeleton,
-    ErrorBoundary: ErrorBoundary,
+    ErrorBoundary: RootErrorBoundary,
     children: [
       {
         path: "",

packages/relay/src/errors.ts

@@ -6,6 +6,14 @@ export class UnAuthenticatedError extends Error {
   }
 }
 
+export class NDASignatureRequiredError extends Error {
+  constructor(message?: string) {
+    super(message || "NDA_SIGNATURE_REQUIRED");
+    this.name = "NDASignatureRequiredError";
+    Object.setPrototypeOf(this, NDASignatureRequiredError.prototype);
+  }
+}
+
 export class InternalServerError extends Error {
   constructor() {
     super("INTERNAL_SERVER_ERROR");