rohit/probo
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Fix e2e test assertions: uppercase state enums, non-default slug

Browse Source 
The version state field returns uppercase enum values (DRAFT, PUBLISHED)
and "analytics" is a default category slug created with every banner.

Signed-off-by: Émile Ré <emile@getprobo.com>
This commit is contained in:
Émile Ré
2026-05-01 13:07:38 +04:00
parent 6532f16efc
commit c43f61d109
2 changed files with 5 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
e2e/console/cookie_banner_test.go
View File

@@ -642,7 +642,7 @@ func TestCookieBanner_PublishVersion(t *testing.T) {
require.NoError(t, err) require.NoError(t, err)
assert.Equal(t, 1, publishResult.PublishCookieBannerVersion.CookieBannerVersion.Version) assert.Equal(t, 1, publishResult.PublishCookieBannerVersion.CookieBannerVersion.Version)
assert.Equal(t, "published", publishResult.PublishCookieBannerVersion.CookieBannerVersion.State) assert.Equal(t, "PUBLISHED", publishResult.PublishCookieBannerVersion.CookieBannerVersion.State)
assert.Equal(t, bannerID, publishResult.PublishCookieBannerVersion.CookieBanner.ID) assert.Equal(t, bannerID, publishResult.PublishCookieBannerVersion.CookieBanner.ID)
}) })
@@ -679,7 +679,7 @@ func TestCookieBanner_PublishVersion(t *testing.T) {
err := owner.Execute(query, map[string]any{"id": bannerID}, &result) err := owner.Execute(query, map[string]any{"id": bannerID}, &result)
require.NoError(t, err) require.NoError(t, err)
require.NotNil(t, result.Node.LatestVersion) require.NotNil(t, result.Node.LatestVersion)
assert.Equal(t, "draft", result.Node.LatestVersion.State) assert.Equal(t, "DRAFT", result.Node.LatestVersion.State)
assert.Equal(t, 1, result.Node.LatestVersion.Version) assert.Equal(t, 1, result.Node.LatestVersion.Version)
}) })
} }

6
e2e/console/cookie_category_test.go
View File

@@ -106,7 +106,7 @@ func TestCookieCategory_Create(t *testing.T) {
owner := testutil.NewClient(t, testutil.RoleOwner) owner := testutil.NewClient(t, testutil.RoleOwner)
bannerID := factory.CreateCookieBanner(owner) bannerID := factory.CreateCookieBanner(owner)
factory.CreateCookieCategory(owner, bannerID, factory.Attrs{"slug": "analytics"}) factory.CreateCookieCategory(owner, bannerID, factory.Attrs{"slug": "custom-slug-dup"})
_, err := owner.Do(` _, err := owner.Do(`
mutation CreateCookieCategory($input: CreateCookieCategoryInput!) { mutation CreateCookieCategory($input: CreateCookieCategoryInput!) {
@@ -118,8 +118,8 @@ func TestCookieCategory_Create(t *testing.T) {
`, map[string]any{ `, map[string]any{
"input": map[string]any{ "input": map[string]any{
"cookieBannerId": bannerID, "cookieBannerId": bannerID,
"name": "Another Analytics", "name": "Duplicate Category",
"slug": "analytics", "slug": "custom-slug-dup",
"description": "Duplicate slug", "description": "Duplicate slug",
"rank": 10, "rank": 10,
}, },