Require CLIENT_SECRET for new access-review connectors → Drop Snyk, Ramp, Lever, Deel access-review providers
- Require CLIENT_SECRET for new access-review connectors - Use Heroku account UUID as ExternalID - Bump GitHub orgs picker to per_page=100 - Drop Snyk, Ramp, Lever, Deel access-review providers Signed-off-by: Aurélien Sibiril <81782+aureliensibiril@users.noreply.github.com>
This commit is contained in:
@@ -355,13 +355,9 @@ func (b *Builder) Build() (*probodconfig.FullConfig, error) {
|
||||
"HEROKU",
|
||||
"PAGERDUTY",
|
||||
"ASANA",
|
||||
"SNYK",
|
||||
"NETLIFY",
|
||||
"RAMP",
|
||||
"CLICKUP",
|
||||
"MONDAY",
|
||||
"LEVER",
|
||||
"DEEL",
|
||||
} {
|
||||
clientID := b.getEnv("CONNECTOR_" + provider + "_CLIENT_ID")
|
||||
if clientID == "" {
|
||||
@@ -438,6 +434,15 @@ func (b *Builder) validateRequired() error {
|
||||
{"CONNECTOR_BREX", []string{"CLIENT_SECRET"}},
|
||||
{"CONNECTOR_GOOGLE_WORKSPACE", []string{"CLIENT_SECRET"}},
|
||||
{"CONNECTOR_MICROSOFT_365", []string{"CLIENT_SECRET"}},
|
||||
{"CONNECTOR_GITLAB", []string{"CLIENT_SECRET"}},
|
||||
{"CONNECTOR_BITBUCKET", []string{"CLIENT_SECRET"}},
|
||||
{"CONNECTOR_HEROKU", []string{"CLIENT_SECRET"}},
|
||||
{"CONNECTOR_PAGERDUTY", []string{"CLIENT_SECRET"}},
|
||||
{"CONNECTOR_ASANA", []string{"CLIENT_SECRET"}},
|
||||
{"CONNECTOR_NETLIFY", []string{"CLIENT_SECRET"}},
|
||||
{"CONNECTOR_CLICKUP", []string{"CLIENT_SECRET"}},
|
||||
{"CONNECTOR_MONDAY", []string{"CLIENT_SECRET"}},
|
||||
{"CONNECTOR_VERCEL", []string{"CLIENT_SECRET", "INTEGRATION_SLUG"}},
|
||||
}
|
||||
|
||||
for _, p := range oauthProviders {
|
||||
|
||||
@@ -442,8 +442,7 @@ func TestBuilder_Build_AccessReviewConnectors(t *testing.T) {
|
||||
// CONNECTOR_VERCEL_INTEGRATION_SLUG env var.
|
||||
providers := []string{
|
||||
"GITLAB", "BITBUCKET", "HEROKU", "PAGERDUTY",
|
||||
"ASANA", "SNYK", "NETLIFY", "RAMP", "CLICKUP",
|
||||
"MONDAY", "LEVER", "DEEL",
|
||||
"ASANA", "NETLIFY", "CLICKUP", "MONDAY",
|
||||
}
|
||||
|
||||
env := requiredEnv()
|
||||
|
||||
Reference in New Issue
Block a user