From c0d5095f91ccb26d954429229a18f89ee10e148f Mon Sep 17 00:00:00 2001 From: Bryan Frimin Date: Wed, 1 Oct 2025 12:51:13 +0200 Subject: [PATCH] Fix ECDSA signature test to use pre-hashed data ECDSA's Sign() method expects already-hashed data when a hash function is specified. The test was incorrectly passing unhashed data with crypto.SHA256, causing signature operations to fail. Signed-off-by: Bryan Frimin --- pkg/crypto/pem/pem_test.go | 12 ++++++++++-- 1 file changed, 10 insertions(+), 2 deletions(-) diff --git a/pkg/crypto/pem/pem_test.go b/pkg/crypto/pem/pem_test.go index 53d7682a5..6b84a9152 100644 --- a/pkg/crypto/pem/pem_test.go +++ b/pkg/crypto/pem/pem_test.go @@ -238,8 +238,12 @@ func TestRoundTrip(t *testing.T) { case ed25519.PrivateKey: dataToSign = testData hashFunc = crypto.Hash(0) // ED25519 requires zero hash + case *ecdsa.PrivateKey: + // ECDSA requires pre-hashed data + dataToSign = hashed + hashFunc = crypto.SHA256 default: - dataToSign = testData + dataToSign = hashed hashFunc = crypto.SHA256 } @@ -253,8 +257,12 @@ func TestRoundTrip(t *testing.T) { case ed25519.PrivateKey: dataToSign = testData hashFunc = crypto.Hash(0) // ED25519 requires zero hash + case *ecdsa.PrivateKey: + // ECDSA requires pre-hashed data + dataToSign = hashed + hashFunc = crypto.SHA256 default: - dataToSign = testData + dataToSign = hashed hashFunc = crypto.SHA256 }