From bf49c825c468b52fe1fb8253e557bc2eccf24cd0 Mon Sep 17 00:00:00 2001 From: Bryan Frimin Date: Mon, 9 Mar 2026 11:15:26 +0100 Subject: [PATCH] Fix socket leak Signed-off-by: Bryan Frimin --- pkg/mailer/mailer.go | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/pkg/mailer/mailer.go b/pkg/mailer/mailer.go index 23f52026e..699a66b06 100644 --- a/pkg/mailer/mailer.go +++ b/pkg/mailer/mailer.go @@ -334,17 +334,16 @@ func (w *SendingWorker) sendMail(ctx context.Context, to []string, msg []byte) e if err != nil { return fmt.Errorf("connection error: %w", err) } + defer func() { _ = conn.Close() }() if deadline, ok := ctx.Deadline(); ok { if err := conn.SetDeadline(deadline); err != nil { - _ = conn.Close() return fmt.Errorf("cannot set connection deadline: %w", err) } } c, err := smtp.NewClient(conn, host) if err != nil { - _ = conn.Close() return fmt.Errorf("SMTP client creation error: %w", err) } defer func() { _ = c.Quit() }()