rohit/probo
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Style

Browse Source 
Signed-off-by: Bryan Frimin <bryan@probo.com>
This commit is contained in:
Bryan Frimin
2026-07-03 11:53:57 +02:00
parent b03dad70e0
commit bea410fbb7
3 changed files with 7 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
e2e/console/security_read_gap_test.go
View File

@@ -257,6 +257,7 @@ func TestSecurity_ReadGap_ApplicabilityStatementControl(t *testing.T) {
got = edge.Node.Control got = edge.Node.Control
} }
} }
require.Nil(t, got, "must not be able to read a cross-tenant control via applicabilityStatement.control") require.Nil(t, got, "must not be able to read a cross-tenant control via applicabilityStatement.control")
} }
} }
@@ -445,6 +446,7 @@ func TestSecurity_ReadGap_DocumentVersionApprovalDecisionApprover(t *testing.T)
ID string `json:"id"` ID string `json:"id"`
FullName string `json:"fullName"` FullName string `json:"fullName"`
} }
for _, qEdge := range readResult.Node.ApprovalQuorums.Edges { for _, qEdge := range readResult.Node.ApprovalQuorums.Edges {
for _, dEdge := range qEdge.Node.Decisions.Edges { for _, dEdge := range qEdge.Node.Decisions.Edges {
if dEdge.Node.ID == decisionID { if dEdge.Node.ID == decisionID {
@@ -452,6 +454,7 @@ func TestSecurity_ReadGap_DocumentVersionApprovalDecisionApprover(t *testing.T)
} }
} }
} }
require.Nil(t, got, "must not be able to read a cross-tenant profile via documentVersionApprovalDecision.approver") require.Nil(t, got, "must not be able to read a cross-tenant profile via documentVersionApprovalDecision.approver")
} }
} }

1
e2e/console/security_write_gap_test.go
View File

@@ -154,6 +154,7 @@ func seedTrustCenterAccess(t *testing.T, owner *testutil.Client, trustCenterID s
accessID.String(), tenantID.String(), owner.GetOrganizationID().String(), tcID.String(), accessID.String(), tenantID.String(), owner.GetOrganizationID().String(), tcID.String(),
owner.GetUserID().String(), factory.SafeEmail(), "Test Access", now, owner.GetUserID().String(), factory.SafeEmail(), "Test Access", now,
) )
return err return err
}) })
require.NoError(t, err, "test setup: cannot seed trust_center_accesses row") require.NoError(t, err, "test setup: cannot seed trust_center_accesses row")

3
pkg/probo/trust_center_access_service.go
View File

@@ -242,6 +242,7 @@ func (s TrustCenterAccessService) Update(
if len(req.DocumentAccesses) > 0 { if len(req.DocumentAccesses) > 0 {
var documentData []coredata.MergeTrustCenterDocumentAccessesData var documentData []coredata.MergeTrustCenterDocumentAccessesData
documentIDs := make([]gid.GID, 0, len(req.DocumentAccesses)) documentIDs := make([]gid.GID, 0, len(req.DocumentAccesses))
for _, d := range req.DocumentAccesses { for _, d := range req.DocumentAccesses {
documentData = append(documentData, coredata.MergeTrustCenterDocumentAccessesData{ documentData = append(documentData, coredata.MergeTrustCenterDocumentAccessesData{
@@ -263,6 +264,7 @@ func (s TrustCenterAccessService) Update(
if len(req.ReportAccesses) > 0 { if len(req.ReportAccesses) > 0 {
var reportData []coredata.MergeTrustCenterDocumentAccessesData var reportData []coredata.MergeTrustCenterDocumentAccessesData
reportIDs := make([]gid.GID, 0, len(req.ReportAccesses)) reportIDs := make([]gid.GID, 0, len(req.ReportAccesses))
for _, d := range req.ReportAccesses { for _, d := range req.ReportAccesses {
reportData = append(reportData, coredata.MergeTrustCenterDocumentAccessesData{ reportData = append(reportData, coredata.MergeTrustCenterDocumentAccessesData{
@@ -284,6 +286,7 @@ func (s TrustCenterAccessService) Update(
if len(req.TrustCenterFileAccesses) > 0 { if len(req.TrustCenterFileAccesses) > 0 {
var fileData []coredata.MergeTrustCenterDocumentAccessesData var fileData []coredata.MergeTrustCenterDocumentAccessesData
trustCenterFileIDs := make([]gid.GID, 0, len(req.TrustCenterFileAccesses)) trustCenterFileIDs := make([]gid.GID, 0, len(req.TrustCenterFileAccesses))
for _, d := range req.TrustCenterFileAccesses { for _, d := range req.TrustCenterFileAccesses {
fileData = append(fileData, coredata.MergeTrustCenterDocumentAccessesData{ fileData = append(fileData, coredata.MergeTrustCenterDocumentAccessesData{