rohit/probo
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Ignore existing status in bulk document update

Browse Source 
Signed-off-by: Sacha Al Himdani <sacha@getprobo.com>
This commit is contained in:
Sacha Al Himdani
2025-07-15 17:01:16 +02:00
parent de366604b6
commit be6c668aa6
1 changed files with 17 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

22
pkg/probo/document_service.go
View File

@@ -167,7 +167,7 @@ func (s *DocumentService) BulkPublishVersions(
} }
for _, documentID := range req.DocumentIDs { for _, documentID := range req.DocumentIDs {
document, version, err := s.publishVersionInTx(ctx, tx, documentID, people, &req.Changelog) document, version, err := s.publishVersionInTx(ctx, tx, documentID, people, &req.Changelog, true)
if err != nil { if err != nil {
return fmt.Errorf("cannot publish document %q: %w", documentID, err) return fmt.Errorf("cannot publish document %q: %w", documentID, err)
} }
@@ -206,7 +206,7 @@ func (s *DocumentService) PublishVersion(
return fmt.Errorf("cannot load people: %w", err) return fmt.Errorf("cannot load people: %w", err)
} }
document, documentVersion, err = s.publishVersionInTx(ctx, tx, documentID, people, changelog) document, documentVersion, err = s.publishVersionInTx(ctx, tx, documentID, people, changelog, false)
if err != nil { if err != nil {
return fmt.Errorf("cannot publish version: %w", err) return fmt.Errorf("cannot publish version: %w", err)
} }
@@ -228,6 +228,7 @@ func (s *DocumentService) publishVersionInTx(
documentID gid.GID, documentID gid.GID,
publishedBy *coredata.People, publishedBy *coredata.People,
changelog *string, changelog *string,
ignoreExisting bool,
) (*coredata.Document, *coredata.DocumentVersion, error) { ) (*coredata.Document, *coredata.DocumentVersion, error) {
document := &coredata.Document{} document := &coredata.Document{}
documentVersion := &coredata.DocumentVersion{} documentVersion := &coredata.DocumentVersion{}
@@ -242,6 +243,10 @@ func (s *DocumentService) publishVersionInTx(
return nil, nil, fmt.Errorf("cannot load current draft: %w", err) return nil, nil, fmt.Errorf("cannot load current draft: %w", err)
} }
if ignoreExisting && documentVersion.Status == coredata.DocumentStatusPublished {
return document, documentVersion, nil
}
if documentVersion.Status != coredata.DocumentStatusDraft { if documentVersion.Status != coredata.DocumentStatusDraft {
return nil, nil, fmt.Errorf("cannot publish version") return nil, nil, fmt.Errorf("cannot publish version")
} }
@@ -593,7 +598,7 @@ func (s *DocumentService) BulkRequestSignatures(
} }
for _, signatoryID := range req.SignatoryIDs { for _, signatoryID := range req.SignatoryIDs {
signature, err := s.createSignatureRequestInTx(ctx, tx, documentVersion.ID, requestedBy, signatoryID) signature, err := s.createSignatureRequestInTx(ctx, tx, documentVersion.ID, requestedBy, signatoryID, true)
if err != nil { if err != nil {
return fmt.Errorf("cannot create signature request for document %q and signatory %q: %w", documentID, signatoryID, err) return fmt.Errorf("cannot create signature request for document %q and signatory %q: %w", documentID, signatoryID, err)
} }
@@ -617,14 +622,21 @@ func (s *DocumentService) createSignatureRequestInTx(
documentVersionID gid.GID, documentVersionID gid.GID,
requestedBy *coredata.People, requestedBy *coredata.People,
signatoryID gid.GID, signatoryID gid.GID,
ignoreExisting bool,
) (*coredata.DocumentVersionSignature, error) { ) (*coredata.DocumentVersionSignature, error) {
documentVersionSignatureID := gid.New(s.svc.scope.GetTenantID(), coredata.DocumentVersionSignatureEntityType)
signatory := &coredata.People{} signatory := &coredata.People{}
if err := signatory.LoadByID(ctx, tx, s.svc.scope, signatoryID); err != nil { if err := signatory.LoadByID(ctx, tx, s.svc.scope, signatoryID); err != nil {
return nil, fmt.Errorf("cannot load signatory: %w", err) return nil, fmt.Errorf("cannot load signatory: %w", err)
} }
existingSignature := &coredata.DocumentVersionSignature{}
err := existingSignature.LoadByDocumentVersionIDAndSignatory(ctx, tx, s.svc.scope, documentVersionID, signatoryID)
if err == nil && ignoreExisting {
return existingSignature, nil
}
documentVersionSignatureID := gid.New(s.svc.scope.GetTenantID(), coredata.DocumentVersionSignatureEntityType)
now := time.Now() now := time.Now()
documentVersionSignature := &coredata.DocumentVersionSignature{ documentVersionSignature := &coredata.DocumentVersionSignature{
ID: documentVersionSignatureID, ID: documentVersionSignatureID,
@@ -667,7 +679,7 @@ func (s *DocumentService) RequestSignature(
return fmt.Errorf("cannot load requested by %q: %w", req.RequestedBy, err) return fmt.Errorf("cannot load requested by %q: %w", req.RequestedBy, err)
} }
signature, err = s.createSignatureRequestInTx(ctx, tx, req.DocumentVersionID, requestedBy, req.Signatory) signature, err = s.createSignatureRequestInTx(ctx, tx, req.DocumentVersionID, requestedBy, req.Signatory, false)
if err != nil { if err != nil {
return fmt.Errorf("cannot create signature request: %w", err) return fmt.Errorf("cannot create signature request: %w", err)
} }