Add risk assessment system

Introduce a hierarchical risk assessment model with six entity types:

- Risk Assessment: top-level container scoped to an organization
- Risk Assessment Scope: sub-container for scoping threat modeling
  exercises within an assessment
- Risk Assessment Node: DFD elements typed as ENTITY, BOUNDARY,
  ASSET, or DATA within a scope
- Risk Assessment Process: directed data flows between two nodes
- Risk Assessment Threat: descriptive threats attached to a process
  with a free-text category (e.g. Confidentiality, Integrity)
- Risk Scenario: thin join linking a threat to a risk from the
  register, carrying only a name and description

Risk scoring (likelihood, impact, treatment) remains on the existing
Risk entity. Threats are purely descriptive. Risk Scenarios connect
the threat model to the risk register without duplicating scores.

Backend: migration with PG enum for node types, coredata structs,
service layer with full CRUD and validation, GraphQL schema with
18 mutations and paginated connections, authorization actions and
policies, and base_resolvers.go Node dispatch for all entity types.

Frontend: Risk Assessments list page with create dialog, detail page
showing scopes as cards with nodes/processes/threats tables, inline
create/edit/delete actions on all entities, and a Scenarios tab on
the Risk detail page linking threats to risks. Existing RiskGraph.ts
hook file removed in favor of colocated queries in page files.

E2E tests cover CRUD for all entity types, RBAC, and tenant
isolation.

Signed-off-by: Sacha Al Himdani <sacha@getprobo.com>
This commit is contained in:
Sacha Al Himdani
2026-05-11 14:55:06 +02:00
parent 8f8f09008a
commit b9262b5150
71 changed files with 10256 additions and 257 deletions

View File

@@ -0,0 +1,172 @@
// Copyright (c) 2026 Probo Inc <hello@getprobo.com>.
//
// Permission to use, copy, modify, and/or distribute this software for any
// purpose with or without fee is hereby granted, provided that the above
// copyright notice and this permission notice appear in all copies.
//
// THE SOFTWARE IS PROVIDED "AS IS" AND THE AUTHOR DISCLAIMS ALL WARRANTIES WITH
// REGARD TO THIS SOFTWARE INCLUDING ALL IMPLIED WARRANTIES OF MERCHANTABILITY
// AND FITNESS. IN NO EVENT SHALL THE AUTHOR BE LIABLE FOR ANY SPECIAL, DIRECT,
// INDIRECT, OR CONSEQUENTIAL DAMAGES OR ANY DAMAGES WHATSOEVER RESULTING FROM
// LOSS OF USE, DATA OR PROFITS, WHETHER IN AN ACTION OF CONTRACT, NEGLIGENCE OR
// OTHER TORTIOUS ACTION, ARISING OUT OF OR IN CONNECTION WITH THE USE OR
// PERFORMANCE OF THIS SOFTWARE.
package coredata
import (
"context"
"errors"
"fmt"
"maps"
"time"
"github.com/jackc/pgx/v5"
"github.com/jackc/pgx/v5/pgconn"
"go.gearno.de/kit/pg"
"go.probo.inc/probo/pkg/gid"
"go.probo.inc/probo/pkg/page"
)
type (
RiskAssessmentScenarioThreat struct {
RiskAssessmentScenarioID gid.GID `db:"risk_assessment_scenario_id"`
RiskAssessmentThreatID gid.GID `db:"risk_assessment_threat_id"`
CreatedAt time.Time `db:"created_at"`
}
RiskAssessmentScenarioThreats []*RiskAssessmentScenarioThreat
)
func (st *RiskAssessmentScenarioThreat) Insert(ctx context.Context, conn pg.Tx, scope Scoper) error {
q := `
INSERT INTO risk_assessment_scenario_threats (
tenant_id,
risk_assessment_scenario_id,
risk_assessment_threat_id,
created_at
) VALUES (
@tenant_id,
@risk_assessment_scenario_id,
@risk_assessment_threat_id,
@created_at
)
`
args := pgx.StrictNamedArgs{
"tenant_id": scope.GetTenantID(),
"risk_assessment_scenario_id": st.RiskAssessmentScenarioID,
"risk_assessment_threat_id": st.RiskAssessmentThreatID,
"created_at": st.CreatedAt,
}
_, err := conn.Exec(ctx, q, args)
if err != nil {
if pgErr, ok := errors.AsType[*pgconn.PgError](err); ok && pgErr.Code == "23505" {
return ErrResourceAlreadyExists
}
return fmt.Errorf("cannot insert risk scenario threat: %w", err)
}
return nil
}
func (st *RiskAssessmentScenarioThreat) Delete(ctx context.Context, conn pg.Tx, scope Scoper) error {
q := `
DELETE FROM risk_assessment_scenario_threats
WHERE
%s
AND risk_assessment_scenario_id = @risk_assessment_scenario_id
AND risk_assessment_threat_id = @risk_assessment_threat_id
`
q = fmt.Sprintf(q, scope.SQLFragment())
args := pgx.StrictNamedArgs{
"risk_assessment_scenario_id": st.RiskAssessmentScenarioID,
"risk_assessment_threat_id": st.RiskAssessmentThreatID,
}
maps.Copy(args, scope.SQLArguments())
_, err := conn.Exec(ctx, q, args)
return err
}
func (ts *RiskAssessmentThreats) LoadByScenarioID(
ctx context.Context,
conn pg.Querier,
scope Scoper,
scenarioID gid.GID,
cursor *page.Cursor[RiskAssessmentThreatOrderField],
) error {
q := `
WITH linked_threats AS (
SELECT
risk_assessment_threat_id
FROM
risk_assessment_scenario_threats
WHERE
%s
AND risk_assessment_scenario_id = @scenario_id
)
SELECT
id,
organization_id,
risk_assessment_scope_id,
process_id,
name,
category,
created_at,
updated_at
FROM
risk_assessment_threats
WHERE
%s
AND id IN (SELECT risk_assessment_threat_id FROM linked_threats)
AND %s
`
q = fmt.Sprintf(q, scope.SQLFragment(), scope.SQLFragment(), cursor.SQLFragment())
args := pgx.NamedArgs{"scenario_id": scenarioID}
maps.Copy(args, scope.SQLArguments())
maps.Copy(args, cursor.SQLArguments())
rows, err := conn.Query(ctx, q, args)
if err != nil {
return fmt.Errorf("cannot query risk scenario threats: %w", err)
}
results, err := pgx.CollectRows(rows, pgx.RowToAddrOfStructByName[RiskAssessmentThreat])
if err != nil {
return fmt.Errorf("cannot collect risk scenario threats: %w", err)
}
*ts = results
return nil
}
func (ts *RiskAssessmentThreats) CountByScenarioID(
ctx context.Context,
conn pg.Querier,
scope Scoper,
scenarioID gid.GID,
) (int, error) {
q := `
WITH linked_threats AS (
SELECT
risk_assessment_threat_id
FROM
risk_assessment_scenario_threats
WHERE
%s
AND risk_assessment_scenario_id = @scenario_id
)
SELECT
COUNT(id)
FROM
risk_assessment_threats
WHERE
%s
AND id IN (SELECT risk_assessment_threat_id FROM linked_threats)
`
q = fmt.Sprintf(q, scope.SQLFragment(), scope.SQLFragment())
args := pgx.NamedArgs{"scenario_id": scenarioID}
maps.Copy(args, scope.SQLArguments())
var count int
if err := conn.QueryRow(ctx, q, args).Scan(&count); err != nil {
return 0, fmt.Errorf("cannot count risk scenario threats: %w", err)
}
return count, nil
}