From b715107e6c674a689870f58518be379e6b57b0e5 Mon Sep 17 00:00:00 2001 From: Cursor Agent Date: Wed, 29 Jul 2026 21:09:16 +0000 Subject: [PATCH] Drop empty-input guards from batch loaders ANY(@ids) with an empty array is valid in Postgres and CollectRows already yields an empty slice; the early nil assignments added noise without changing callers. Signed-off-by: Cursor Agent Co-authored-by: Bryan FRIMIN --- pkg/coredata/identity.go | 6 ------ pkg/coredata/membership_profile.go | 6 ------ pkg/coredata/personal_api_key.go | 6 ------ 3 files changed, 18 deletions(-) diff --git a/pkg/coredata/identity.go b/pkg/coredata/identity.go index e5caf8242..97345814c 100644 --- a/pkg/coredata/identity.go +++ b/pkg/coredata/identity.go @@ -393,12 +393,6 @@ func (i *Identities) LoadByIDs( conn pg.Querier, identityIDs []gid.GID, ) error { - if len(identityIDs) == 0 { - *i = nil - - return nil - } - q := ` SELECT id, diff --git a/pkg/coredata/membership_profile.go b/pkg/coredata/membership_profile.go index 28bb887f0..49854d563 100644 --- a/pkg/coredata/membership_profile.go +++ b/pkg/coredata/membership_profile.go @@ -502,12 +502,6 @@ func (p *MembershipProfiles) LoadByOrganizationIDAndUserNames( organizationID gid.GID, userNames []string, ) error { - if len(userNames) == 0 { - *p = nil - - return nil - } - q := ` SELECT p.id, diff --git a/pkg/coredata/personal_api_key.go b/pkg/coredata/personal_api_key.go index 7f14f1770..6b863b385 100644 --- a/pkg/coredata/personal_api_key.go +++ b/pkg/coredata/personal_api_key.go @@ -307,12 +307,6 @@ func (a *PersonalAPIKeys) LoadByIDs( conn pg.Querier, apiKeyIDs []gid.GID, ) error { - if len(apiKeyIDs) == 0 { - *a = nil - - return nil - } - q := ` SELECT id,