rohit/probo
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Drop redundant safecsv WriteRow helper

Browse Source 
WriteRow was a variadic alias for Write(SanitizeRecord(...))
with no extra safety or column checks. Export call sites already
use []string headers; matching encoding/csv keeps one API surface.

Signed-off-by: Cursor Agent <cursoragent@cursor.com>

Co-authored-by: Bryan FRIMIN <bryan@frimin.fr>
This commit is contained in:
Cursor Agent
2026-07-30 10:00:42 +00:00
parent 010fdcd51e
commit b44ceb32e6
3 changed files with 8 additions and 15 deletions
Download Patch File Download Diff File Expand all files Collapse all files

12
pkg/iam/log_export_csv.go
View File

@@ -99,7 +99,7 @@ func (s *LogExportService) streamAuditLogCSV(
filter *coredata.AuditLogEntryFilter, filter *coredata.AuditLogEntryFilter,
w *safecsv.Writer, w *safecsv.Writer,
) error { ) error {
if err := w.WriteRow(auditLogExportCSVHeader...); err != nil { if err := w.Write(auditLogExportCSVHeader); err != nil {
return fmt.Errorf("cannot write audit log CSV header: %w", err) return fmt.Errorf("cannot write audit log CSV header: %w", err)
} }
@@ -153,7 +153,7 @@ func (s *LogExportService) streamSCIMEventCSV(
filter *coredata.SCIMEventFilter, filter *coredata.SCIMEventFilter,
w *safecsv.Writer, w *safecsv.Writer,
) error { ) error {
if err := w.WriteRow(scimEventExportCSVHeader...); err != nil { if err := w.Write(scimEventExportCSVHeader); err != nil {
return fmt.Errorf("cannot write SCIM event CSV header: %w", err) return fmt.Errorf("cannot write SCIM event CSV header: %w", err)
} }
@@ -204,7 +204,7 @@ func writeAuditLogEntryCSVRow(
entry *coredata.AuditLogEntry, entry *coredata.AuditLogEntry,
actor auditLogActorExportInfo, actor auditLogActorExportInfo,
) error { ) error {
return w.WriteRow( return w.Write([]string{
organizationName, organizationName,
entry.ID.String(), entry.ID.String(),
entry.CreatedAt.Format(time.RFC3339), entry.CreatedAt.Format(time.RFC3339),
@@ -215,7 +215,7 @@ func writeAuditLogEntryCSVRow(
entry.Action, entry.Action,
entry.ResourceType, entry.ResourceType,
entry.ResourceID.String(), entry.ResourceID.String(),
) })
} }
func writeSCIMEventCSVRow( func writeSCIMEventCSVRow(
@@ -226,7 +226,7 @@ func writeSCIMEventCSVRow(
) error { ) error {
profile := lookup.forEvent(event) profile := lookup.forEvent(event)
return w.WriteRow( return w.Write([]string{
organizationName, organizationName,
event.ID.String(), event.ID.String(),
event.CreatedAt.Format(time.RFC3339), event.CreatedAt.Format(time.RFC3339),
@@ -238,7 +238,7 @@ func writeSCIMEventCSVRow(
strconv.Itoa(event.StatusCode), strconv.Itoa(event.StatusCode),
stringPtrValue(event.ErrorMessage), stringPtrValue(event.ErrorMessage),
event.IPAddress.String(), event.IPAddress.String(),
) })
} }
func loadAuditLogActorExportInfo( func loadAuditLogActorExportInfo(

2
pkg/safecsv/cell_test.go
View File

@@ -50,7 +50,7 @@ func TestWriterWrite(t *testing.T) {
var buf bytes.Buffer var buf bytes.Buffer
w := NewWriter(&buf) w := NewWriter(&buf)
require.NoError(t, w.WriteRow("ok", "=evil")) require.NoError(t, w.Write([]string{"ok", "=evil"}))
w.Flush() w.Flush()
require.NoError(t, w.Error()) require.NoError(t, w.Error())

9
pkg/safecsv/writer.go
View File

@@ -41,18 +41,11 @@ func NewWriter(w io.Writer) *Writer {
return &Writer{inner: csv.NewWriter(w)} return &Writer{inner: csv.NewWriter(w)}
} }
// Write encodes a CSV record after sanitizing every field. Prefer WriteRow for // Write encodes a CSV record after sanitizing every field.
// literal column values at call sites.
func (w *Writer) Write(record []string) error { func (w *Writer) Write(record []string) error {
return w.inner.Write(SanitizeRecord(record)) return w.inner.Write(SanitizeRecord(record))
} }
// WriteRow encodes one CSV record from fields, sanitizing each value before
// encoding (spreadsheet formula injection mitigation).
func (w *Writer) WriteRow(fields ...string) error {
return w.inner.Write(SanitizeRecord(fields))
}
func (w *Writer) Flush() { func (w *Writer) Flush() {
w.inner.Flush() w.inner.Flush()
} }