Switch AuthorizationAttributes to batch and add AuthorizeBatch

Change AuthorizationAttributer.AuthorizationAttributes to take a slice
of resource ids and return policy.AttributesByID, so a single SQL
round-trip can load condition attributes for a whole batch. All
coredata implementations are migrated to a single
`WHERE id = ANY(@resource_ids::text[])` query that returns only the
rows it finds.

Authorizer gains:
  - AuthorizeBatch — all-or-nothing across a homogeneous (same entity
    type, same organization) resource set; rejects mixed entity types,
    mixed organizations, and empty batches with structured errors.
  - AuthorizeMulti — heterogeneous evaluation that returns one error
    per item and writes audit log entries in a single bulk insert.

The single-resource Authorize is rewired to delegate to AuthorizeBatch
so all paths share the same condition evaluation and audit logging.
recordAuditLog is split into buildAuditLogEntry plus a batch insert.

Tests cover the new batch and multi paths, mixed/empty/unsupported
resource cases, audit log batching, and dry-run behaviour.

Signed-off-by: Bryan Frimin <bryan@probo.com>
This commit is contained in:
Bryan Frimin
2026-05-23 11:26:24 -07:00
parent 2d08dfbe2f
commit b39d880c0f
82 changed files with 4942 additions and 986 deletions

View File

@@ -25,6 +25,7 @@ import (
"github.com/jackc/pgx/v5/pgconn"
"go.gearno.de/kit/pg"
"go.probo.inc/probo/pkg/gid"
"go.probo.inc/probo/pkg/iam/policy"
"go.probo.inc/probo/pkg/page"
)
@@ -53,20 +54,49 @@ func (f *Framework) CursorKey(orderBy FrameworkOrderField) page.CursorKey {
panic(fmt.Sprintf("unsupported order by: %s", orderBy))
}
// AuthorizationAttributes returns the authorization attributes for policy evaluation.
func (f *Framework) AuthorizationAttributes(ctx context.Context, conn pg.Querier) (map[string]string, error) {
q := `SELECT organization_id FROM frameworks WHERE id = $1 LIMIT 1;`
func (f *Framework) AuthorizationAttributes(
ctx context.Context,
conn pg.Querier,
frameworkIDs []gid.GID,
) (policy.AttributesByID, error) {
q := `
SELECT
id,
organization_id
FROM
frameworks
WHERE
id = ANY(@framework_ids::text[])
`
var organizationID gid.GID
if err := conn.QueryRow(ctx, q, f.ID).Scan(&organizationID); err != nil {
if errors.Is(err, pgx.ErrNoRows) {
return nil, ErrResourceNotFound
}
return nil, fmt.Errorf("cannot query framework authorization attributes: %w", err)
args := pgx.StrictNamedArgs{
"framework_ids": frameworkIDs,
}
return map[string]string{"organization_id": organizationID.String()}, nil
rows, err := conn.Query(ctx, q, args)
if err != nil {
return nil, fmt.Errorf("cannot query framework authorization attributes batch: %w", err)
}
defer rows.Close()
attrsByID := make(policy.AttributesByID)
for rows.Next() {
var (
frameworkID gid.GID
organizationID gid.GID
)
if err := rows.Scan(&frameworkID, &organizationID); err != nil {
return nil, fmt.Errorf("cannot scan framework authorization attributes batch: %w", err)
}
attrsByID[frameworkID] = policy.Attributes{
"organization_id": organizationID.String(),
}
}
if err := rows.Err(); err != nil {
return nil, fmt.Errorf("cannot iterate framework authorization attributes batch: %w", err)
}
return attrsByID, nil
}
func (f *Frameworks) CountByOrganizationID(
@@ -100,6 +130,22 @@ WHERE
return count, nil
}
func uniqueGIDs(values []gid.GID) []gid.GID {
set := make(map[gid.GID]struct{}, len(values))
unique := make([]gid.GID, 0, len(values))
for _, value := range values {
if _, ok := set[value]; ok {
continue
}
set[value] = struct{}{}
unique = append(unique, value)
}
return unique
}
func (f *Frameworks) LoadByOrganizationID(
ctx context.Context,
conn pg.Querier,