rohit/probo
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Allow deleting access review campaigns in any status

Browse Source 
Drop the backend status gate on campaign delete and show delete in
the console whenever the user has delete permission, regardless of
whether the campaign is draft, in progress, or completed.

Signed-off-by: Cursor Agent <cursoragent@cursor.com>

Co-authored-by: Bryan FRIMIN <bryan@frimin.fr>
This commit is contained in:
Cursor Agent
2026-07-29 15:44:13 +00:00
parent 9c1cecfc1e
commit b156b0333a
6 changed files with 3 additions and 51 deletions
Download Patch File Download Diff File Expand all files Collapse all files

11
apps/console/src/pages/organizations/access-reviews/campaigns/AccessReviewCampaignsTab.tsx
View File

@@ -132,10 +132,6 @@ export default function AccessReviewCampaignsTab({ queryRef }: Props) {
deleteCampaignMutation,
);
// Only DRAFT, CANCELLED, and COMPLETED campaigns can be deleted (enforced by the backend).
const isDeletableStatus = (status: string) =>
status === "DRAFT" || status === "CANCELLED" || status === "COMPLETED";
const handleDelete = (campaignId: string, campaignName: string) => {
confirm(
() => {
@@ -182,9 +178,7 @@ export default function AccessReviewCampaignsTab({ queryRef }: Props) {
);
};
const hasActions = accessReviewCampaigns.edges.some(
edge => edge.node.canDelete && isDeletableStatus(edge.node.status),
);
const hasActions = accessReviewCampaigns.edges.some(edge => edge.node.canDelete);
return (
<div className="space-y-4">
@@ -215,8 +209,7 @@ export default function AccessReviewCampaignsTab({ queryRef }: Props) {
</Thead>
<Tbody>
{accessReviewCampaigns.edges.map((edge) => {
const canDeleteRow
= edge.node.canDelete && isDeletableStatus(edge.node.status);
const canDeleteRow = edge.node.canDelete;
return (
<Tr
key={edge.node.id}

4
apps/console/src/pages/organizations/access-reviews/campaigns/CampaignDetailPage.tsx
View File

@@ -216,9 +216,7 @@ export default function CampaignDetailPage({ queryRef }: Props) {
const isInProgress = campaign.status === "IN_PROGRESS";
const isDraft = campaign.status === "DRAFT";
const isPendingActions = campaign.status === "PENDING_ACTIONS";
const isCancelled = campaign.status === "CANCELLED";
const isCompleted = campaign.status === "COMPLETED";
const canDelete = campaign.canDelete && (isDraft || isCancelled || isCompleted);
const canDelete = campaign.canDelete;
const campaignIdRef = useRef(campaign.id);