From ac65c05488650fa16bb2df09edeee54079213400 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?=C3=89mile=20R=C3=A9?= Date: Mon, 19 Jan 2026 12:55:04 +0400 Subject: [PATCH] Clear cookie on sign out MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Signed-off-by: Émile Ré --- CHANGELOG.md | 1 + pkg/server/api/authn/cookie.go | 4 ++++ pkg/server/api/connect/v1/v1_resolver.go | 3 +++ 3 files changed, 8 insertions(+) diff --git a/CHANGELOG.md b/CHANGELOG.md index e33f905ce..70917249b 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -12,6 +12,7 @@ All notable changes to this project will be documented in this file. ### Fixed - Missing console react-pdf dependency in package.json +- On sign out, clear cookie along with the existing session expiration ## [0.116.1] - 2026-01-18 diff --git a/pkg/server/api/authn/cookie.go b/pkg/server/api/authn/cookie.go index bf4b4ff19..81f9f87de 100644 --- a/pkg/server/api/authn/cookie.go +++ b/pkg/server/api/authn/cookie.go @@ -34,6 +34,10 @@ func (c *Cookie) Set(w http.ResponseWriter, session *coredata.Session) { ) } +func (c *Cookie) Clear(w http.ResponseWriter, session *coredata.Session) { + securecookie.Clear(w, c.sessionCookieConfig(time.Until(session.ExpiredAt))) +} + func NewCookie(config *securecookie.Config) *Cookie { return &Cookie{config} } diff --git a/pkg/server/api/connect/v1/v1_resolver.go b/pkg/server/api/connect/v1/v1_resolver.go index 6ce6c5953..ea54624cd 100644 --- a/pkg/server/api/connect/v1/v1_resolver.go +++ b/pkg/server/api/connect/v1/v1_resolver.go @@ -426,6 +426,9 @@ func (r *mutationResolver) SignOut(ctx context.Context) (*types.SignOutPayload, return nil, gqlutils.Internal(ctx) } + w := gqlutils.HTTPResponseWriterFromContext(ctx) + r.sessionCookie.Clear(w, session) + return &types.SignOutPayload{Success: true}, nil }