rohit/probo
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Merge campaign scope sources in one SQL statement

Browse Source 
Add AccessReviewCampaignSources.MergeByCampaignID and use it from
syncCampaignSources instead of per-row load, upsert, and delete.

Signed-off-by: Cursor Agent <cursoragent@cursor.com>

Co-authored-by: Bryan FRIMIN <bryan@frimin.fr>
This commit is contained in:
Cursor Agent
2026-07-27 14:19:08 +00:00
parent f396107090
commit abbb1ee875
2 changed files with 141 additions and 53 deletions
Download Patch File Download Diff File Expand all files Collapse all files

57
pkg/accessreview/campaign_service.go
View File

@@ -307,66 +307,17 @@ func (s *Service) syncCampaignSources(
sourceIDs []gid.GID,
) error {
var campaignSources coredata.AccessReviewCampaignSources
if err := campaignSources.LoadByCampaignID(ctx, conn, scope, campaign.ID); err != nil {
return fmt.Errorf("cannot load campaign sources: %w", err)
}
existingSourceIDs := make([]gid.GID, 0, len(campaignSources))
for _, campaignSource := range campaignSources {
if campaignSource.AccessReviewSourceID != nil {
existingSourceIDs = append(existingSourceIDs, *campaignSource.AccessReviewSourceID)
}
}
for _, sourceID := range sourceIDs {
if containsGID(existingSourceIDs, sourceID) {
continue
if err := campaignSources.MergeByCampaignID(ctx, conn, scope, campaign.ID, sourceIDs); err != nil {
if errors.Is(err, coredata.ErrResourceNotFound) {
return coredata.ErrResourceNotFound
}
source := &coredata.AccessReviewSource{}
if err := source.LoadByID(ctx, conn, scope, sourceID); err != nil {
if errors.Is(err, coredata.ErrResourceNotFound) {
return coredata.ErrResourceNotFound
}
return fmt.Errorf("cannot load access source: %w", err)
}
if err := s.upsertCampaignSource(ctx, conn, scope, campaign.ID, source); err != nil {
return fmt.Errorf("cannot snapshot scope source: %w", err)
}
}
for _, existingSourceID := range existingSourceIDs {
if containsGID(sourceIDs, existingSourceID) {
continue
}
campaignSource := &coredata.AccessReviewCampaignSource{}
if err := campaignSource.DeleteByCampaignIDAndAccessReviewSourceID(
ctx,
conn,
scope,
campaign.ID,
existingSourceID,
); err != nil {
return fmt.Errorf("cannot delete campaign source: %w", err)
}
return fmt.Errorf("cannot merge campaign sources: %w", err)
}
return nil
}
func containsGID(ids []gid.GID, id gid.GID) bool {
for _, candidate := range ids {
if candidate == id {
return true
}
}
return false
}
func (s *Service) StartCampaign(
ctx context.Context,
scope coredata.Scoper,