Allow signature requests only on current published version

Requesting a signature only validated that the version was PUBLISHED, so a
signature could be requested on a superseded (older) published version. Reject
versions that are not the document's current published major/minor, and hide
the request button in the console for non-current versions.

Signed-off-by: Sacha Al Himdani <sacha@probo.com>
This commit is contained in:
Sacha Al Himdani
2026-06-22 18:30:26 +02:00
parent 9093be79f4
commit a8e8e3e0e7
4 changed files with 34 additions and 1 deletions

View File

@@ -42,6 +42,12 @@ const versionFragment = graphql`
fragment DocumentSignaturePlaceholder_versionFragment on DocumentVersion {
id
status
major
minor
document {
currentPublishedMajor
currentPublishedMinor
}
}
`;
@@ -81,6 +87,11 @@ export function DocumentSignaturePlaceholder(props: {
const person = useFragment<DocumentSignaturePlaceholder_personFragment$key>(personFragment, personFragmentRef);
const version = useFragment<DocumentSignaturePlaceholder_versionFragment$key>(versionFragment, versionFragmentRef);
const isCurrentPublishedVersion
= version.status === "PUBLISHED"
&& version.document.currentPublishedMajor === version.major
&& version.document.currentPublishedMinor === version.minor;
const [requestSignature, isSendingRequest] = useMutationWithToasts(
requestSignatureMutation,
{
@@ -99,7 +110,7 @@ export function DocumentSignaturePlaceholder(props: {
{person.emailAddress}
</div>
</div>
{version.status === "PUBLISHED" && canRequestSignature && (
{isCurrentPublishedVersion && canRequestSignature && (
<Button
variant="secondary"
className="ml-auto"