From a67f2433b11c91bbbb877a6ee8db4fa0c7a2643d Mon Sep 17 00:00:00 2001 From: Sacha Al Himdani Date: Tue, 12 May 2026 18:40:36 +0200 Subject: [PATCH] Address code review findings in relay fetch and iam Signed-off-by: Sacha Al Himdani --- packages/relay/src/fetch.ts | 10 +++++----- pkg/iam/organization_service.go | 6 +----- pkg/server/api/connect/v1/membership_resolvers.go | 2 +- pkg/server/api/mcp/v1/schema.resolvers.go | 2 +- 4 files changed, 8 insertions(+), 12 deletions(-) diff --git a/packages/relay/src/fetch.ts b/packages/relay/src/fetch.ts index aa0c4f271..a63fda09f 100644 --- a/packages/relay/src/fetch.ts +++ b/packages/relay/src/fetch.ts @@ -24,19 +24,19 @@ import { import { GraphQLError } from "graphql"; const hasUnauthenticatedError = (error: GraphQLError) => - error.extensions?.code == "UNAUTHENTICATED"; + error.extensions?.code === "UNAUTHENTICATED"; const hasFullNameRequiredError = (error: GraphQLError) => - error.extensions?.code == "FULL_NAME_REQUIRED"; + error.extensions?.code === "FULL_NAME_REQUIRED"; const hasAssumptionRequiredError = (error: GraphQLError) => - error.extensions?.code == "ASSUMPTION_REQUIRED"; + error.extensions?.code === "ASSUMPTION_REQUIRED"; const hasNDASignatureRequiredError = (error: GraphQLError) => - error.extensions?.code == "NDA_SIGNATURE_REQUIRED"; + error.extensions?.code === "NDA_SIGNATURE_REQUIRED"; const hasForbiddenError = (error: GraphQLError) => - error.extensions?.code == "FORBIDDEN"; + error.extensions?.code === "FORBIDDEN"; export const makeFetchQuery = (endpoint: string): FetchFunction => { return async (request, variables, _, uploadables) => { diff --git a/pkg/iam/organization_service.go b/pkg/iam/organization_service.go index eb2b565e2..4f1a594f1 100644 --- a/pkg/iam/organization_service.go +++ b/pkg/iam/organization_service.go @@ -241,7 +241,7 @@ func NewOrganizationService(svc *Service) *OrganizationService { return &OrganizationService{Service: svc} } -func (s *OrganizationService) UpdateMempership( +func (s *OrganizationService) UpdateMembership( ctx context.Context, organizationID gid.GID, membershipID gid.GID, @@ -797,10 +797,6 @@ func (s *OrganizationService) UpdateOrganization(ctx context.Context, organizati organization.Name = *req.Name } - if req.Name != nil { - organization.Name = *req.Name - } - if req.Description != nil { organization.Description = *req.Description } diff --git a/pkg/server/api/connect/v1/membership_resolvers.go b/pkg/server/api/connect/v1/membership_resolvers.go index 3dc4702c1..1878d230d 100644 --- a/pkg/server/api/connect/v1/membership_resolvers.go +++ b/pkg/server/api/connect/v1/membership_resolvers.go @@ -61,7 +61,7 @@ func (r *mutationResolver) UpdateMembership(ctx context.Context, input types.Upd } } - membership, err := r.iam.OrganizationService.UpdateMempership(ctx, input.OrganizationID, input.MembershipID, input.Role) + membership, err := r.iam.OrganizationService.UpdateMembership(ctx, input.OrganizationID, input.MembershipID, input.Role) if err != nil { r.logger.ErrorCtx(ctx, "cannot update membership", log.Error(err)) return nil, gqlutils.Internal(ctx) diff --git a/pkg/server/api/mcp/v1/schema.resolvers.go b/pkg/server/api/mcp/v1/schema.resolvers.go index 2363f8843..1d41df866 100644 --- a/pkg/server/api/mcp/v1/schema.resolvers.go +++ b/pkg/server/api/mcp/v1/schema.resolvers.go @@ -2494,7 +2494,7 @@ func (r *Resolver) UpdateMembershipTool(ctx context.Context, req *mcp.CallToolRe r.MustAuthorize(ctx, input.MembershipID, iam.ActionMembershipRoleSetOwner) } - membership, err := r.iamSvc.OrganizationService.UpdateMempership(ctx, input.OrganizationID, input.MembershipID, input.Role) + membership, err := r.iamSvc.OrganizationService.UpdateMembership(ctx, input.OrganizationID, input.MembershipID, input.Role) if err != nil { return nil, types.UpdateMembershipOutput{}, fmt.Errorf("update membership: %w", err) }