Fix PR review findings
- Replace copy-pasted New Relic URLs in Resend third-party entry with correct resend.com URLs and drop inapplicable fields - Escape single '%' instead of '%%' in LIKE pattern conversion so literal percent signs are not treated as wildcards - Return actual row ID from CommonTrackerPattern.Upsert via RETURNING id so conflict-path callers get the existing ID - Add ORDER BY id ASC to vendor-by-common-third-party query for deterministic LIMIT 1 selection Signed-off-by: Émile Ré <emile@getprobo.com> Signed-off-by: Émile Ré <emile@probo.com>
This commit is contained in:
@@ -176,7 +176,7 @@ func run() error {
|
||||
UpdatedAt: now,
|
||||
}
|
||||
|
||||
wasInserted, err := pattern.Upsert(ctx, tx)
|
||||
_, wasInserted, err := pattern.Upsert(ctx, tx)
|
||||
if err != nil {
|
||||
return fmt.Errorf("cannot upsert common tracker pattern %q: %w", p.Pattern, err)
|
||||
}
|
||||
|
||||
Reference in New Issue
Block a user