rohit/probo
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Map missing model settings to OpenAI API params

Browse Source 
FrequencyPenalty, PresencePenalty, and ParallelToolCalls were
present on ChatCompletionRequest but never forwarded in
buildParams, so agent-level settings configured via functional
options were silently ignored for the OpenAI provider.

Signed-off-by: Bryan Frimin <bryan@getprobo.com>
This commit is contained in:
Bryan Frimin
2026-03-13 19:07:56 +01:00
parent 659ff1e845
commit 9e842b8ef3
1 changed files with 9 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

9
pkg/llm/openai/provider.go
View File

@@ -140,6 +140,12 @@ func buildParams(req *llm.ChatCompletionRequest) openai.ChatCompletionNewParams
if req.TopP != nil { if req.TopP != nil {
params.TopP = param.NewOpt(*req.TopP) params.TopP = param.NewOpt(*req.TopP)
} }
if req.FrequencyPenalty != nil {
params.FrequencyPenalty = param.NewOpt(*req.FrequencyPenalty)
}
if req.PresencePenalty != nil {
params.PresencePenalty = param.NewOpt(*req.PresencePenalty)
}
if len(req.StopSequences) > 0 { if len(req.StopSequences) > 0 {
params.Stop = openai.ChatCompletionNewParamsStopUnion{ params.Stop = openai.ChatCompletionNewParamsStopUnion{
OfStringArray: req.StopSequences, OfStringArray: req.StopSequences,
@@ -151,6 +157,9 @@ func buildParams(req *llm.ChatCompletionRequest) openai.ChatCompletionNewParams
if req.ToolChoice != nil { if req.ToolChoice != nil {
params.ToolChoice = buildToolChoice(req.ToolChoice) params.ToolChoice = buildToolChoice(req.ToolChoice)
} }
if req.ParallelToolCalls != nil {
params.ParallelToolCalls = param.NewOpt(*req.ParallelToolCalls)
}
if req.ResponseFormat != nil { if req.ResponseFormat != nil {
params.ResponseFormat = buildResponseFormat(req.ResponseFormat) params.ResponseFormat = buildResponseFormat(req.ResponseFormat)
} }