Validate cookie policy link in banner description

Translations are no longer part of the version snapshot, so the
banner_description text must be validated at write time to ensure
the {{cookie_policy_link}} placeholder is present. Without it
the cookie policy URL silently disappears from the rendered banner.

Signed-off-by: Émile Ré <emile@getprobo.com>

pkg/cookiebanner/service.go

@@ -328,7 +328,12 @@ func (r *UpsertCookieBannerTranslationRequest) Validate() error {
 		if json.Unmarshal(raw, &s) != nil {
 			continue
 		}
-		v.Check(s, "translations."+key, validator.NoHTML(), validator.MaxLen(2000))
+
+		validators := []validator.ValidatorFunc{validator.NoHTML(), validator.MaxLen(2000)}
+		if key == "banner_description" {
+			validators = append(validators, validator.ContainsSubstring("{{cookie_policy_link}}"))
+		}
+		v.Check(s, "translations."+key, validators...)
 	}
 
 	return v.Error()

pkg/cookiebanner/service_test.go

@@ -126,6 +126,68 @@ func TestSnapshotsEqual(t *testing.T) {
 	})
 }
 
+func TestUpsertCookieBannerTranslationRequest_Validate(t *testing.T) {
+	t.Parallel()
+
+	bannerID := gid.New(gid.NewTenantID(), coredata.CookieBannerEntityType)
+
+	t.Run("banner_description with cookie_policy_link passes", func(t *testing.T) {
+		t.Parallel()
+
+		translations, err := json.Marshal(map[string]string{
+			"banner_title":       "Cookie Preferences",
+			"banner_description": "We use cookies. {{cookie_policy_link}}",
+		})
+		require.NoError(t, err)
+
+		req := UpsertCookieBannerTranslationRequest{
+			CookieBannerID: bannerID,
+			Language:       "en",
+			Translations:   translations,
+		}
+
+		assert.NoError(t, req.Validate())
+	})
+
+	t.Run("banner_description without cookie_policy_link fails", func(t *testing.T) {
+		t.Parallel()
+
+		translations, err := json.Marshal(map[string]string{
+			"banner_title":       "Cookie Preferences",
+			"banner_description": "We use cookies to improve your experience.",
+		})
+		require.NoError(t, err)
+
+		req := UpsertCookieBannerTranslationRequest{
+			CookieBannerID: bannerID,
+			Language:       "en",
+			Translations:   translations,
+		}
+
+		err = req.Validate()
+		require.Error(t, err)
+		assert.Contains(t, err.Error(), "translations.banner_description")
+	})
+
+	t.Run("translations without banner_description passes", func(t *testing.T) {
+		t.Parallel()
+
+		translations, err := json.Marshal(map[string]string{
+			"banner_title": "Cookie Preferences",
+			"button_save":  "Save",
+		})
+		require.NoError(t, err)
+
+		req := UpsertCookieBannerTranslationRequest{
+			CookieBannerID: bannerID,
+			Language:       "en",
+			Translations:   translations,
+		}
+
+		assert.NoError(t, req.Validate())
+	})
+}
+
 func TestBuildSnapshot_RankInvariant(t *testing.T) {
 	t.Parallel()