Allow deleting completed access review campaigns

Completed campaigns were immutable because delete only accepted draft
or cancelled status. Extend deletion to completed records and surface
delete in the console for that status.

Signed-off-by: Cursor Agent <cursoragent@cursor.com>

Co-authored-by: Bryan FRIMIN <bryan@frimin.fr>

pkg/accessreview/campaign_service.go

@@ -206,7 +206,8 @@ func (s *Service) DeleteCampaign(
 			}
 
 			if campaign.Status != coredata.AccessReviewCampaignStatusDraft &&
-				campaign.Status != coredata.AccessReviewCampaignStatusCancelled {
+				campaign.Status != coredata.AccessReviewCampaignStatusCancelled &&
+				campaign.Status != coredata.AccessReviewCampaignStatusCompleted {
 				return NewCampaignNotDeletableError(campaign.ID)
 			}
 

pkg/accessreview/errors.go

@@ -95,7 +95,7 @@ func NewCampaignNotDeletableError(campaignID gid.GID) error {
 
 func (e *CampaignNotDeletableError) Error() string {
 	return fmt.Sprintf(
-		"access review campaign %q cannot be deleted unless it is draft or cancelled",
+		"access review campaign %q cannot be deleted unless it is draft, cancelled, or completed",
 		e.CampaignID,
 	)
 }

pkg/accessreview/errors_test.go

@@ -61,7 +61,7 @@ func TestCampaignClientErrors(t *testing.T) {
 			name: "not deletable",
 			err:  accessreview.NewCampaignNotDeletableError(campaignID),
 			wantText: fmt.Sprintf(
-				"access review campaign %q cannot be deleted unless it is draft or cancelled",
+				"access review campaign %q cannot be deleted unless it is draft, cancelled, or completed",
 				campaignID,
 			),
 			sentinel: accessreview.ErrCampaignNotDeletable,