From 9c0956291823ff14278b2d95683b58ec233ac33a Mon Sep 17 00:00:00 2001 From: Cursor Agent Date: Tue, 30 Jun 2026 09:02:28 +0000 Subject: [PATCH] Remove pending entry count field Signed-off-by: Cursor Agent Co-authored-by: Bryan FRIMIN --- pkg/accessreview/entry_service.go | 27 ------------------- .../v1/access_review_campaign_resolvers.go | 17 ------------ .../v1/graphql/access_review_campaign.graphql | 2 -- 3 files changed, 46 deletions(-) diff --git a/pkg/accessreview/entry_service.go b/pkg/accessreview/entry_service.go index 56e6bdf3d..2cea2579d 100644 --- a/pkg/accessreview/entry_service.go +++ b/pkg/accessreview/entry_service.go @@ -378,33 +378,6 @@ func (s *Service) CountEntriesForCampaignIDAndSourceID( return count, nil } -func (s *Service) CountPendingEntriesForCampaignID( - ctx context.Context, - scope coredata.Scoper, - campaignID gid.GID, -) (int, error) { - var count int - - err := s.pg.WithConn( - ctx, - func(ctx context.Context, conn pg.Querier) (err error) { - entries := coredata.AccessReviewEntries{} - - count, err = entries.CountPendingByCampaignID(ctx, conn, scope, campaignID) - if err != nil { - return fmt.Errorf("cannot count pending access entries: %w", err) - } - - return nil - }, - ) - if err != nil { - return 0, err - } - - return count, nil -} - func (s *Service) EntryDecisionHistory( ctx context.Context, scope coredata.Scoper, diff --git a/pkg/server/api/console/v1/access_review_campaign_resolvers.go b/pkg/server/api/console/v1/access_review_campaign_resolvers.go index 9073e27e3..ee4bb1a71 100644 --- a/pkg/server/api/console/v1/access_review_campaign_resolvers.go +++ b/pkg/server/api/console/v1/access_review_campaign_resolvers.go @@ -98,23 +98,6 @@ func (r *accessReviewCampaignResolver) Entries(ctx context.Context, obj *types.A return types.NewAccessReviewEntryConnection(p, r, obj.ID, nil, filter), nil } -// PendingEntryCount is the resolver for the pendingEntryCount field. -func (r *accessReviewCampaignResolver) PendingEntryCount(ctx context.Context, obj *types.AccessReviewCampaign) (int, error) { - scope, err := r.authorize(ctx, obj.ID, accessreview.ActionEntryList) - if err != nil { - return 0, err - } - - count, err := r.accessReview.CountPendingEntriesForCampaignID(ctx, scope, obj.ID) - if err != nil { - r.logger.ErrorCtx(ctx, "cannot count pending access entries", log.Error(err)) - - return 0, gqlutils.Internal(ctx) - } - - return count, nil -} - // Statistics is the resolver for the statistics field. func (r *accessReviewCampaignResolver) Statistics(ctx context.Context, obj *types.AccessReviewCampaign) (*types.AccessReviewStatistics, error) { scope, err := r.authorize(ctx, obj.ID, accessreview.ActionEntryList) diff --git a/pkg/server/api/console/v1/graphql/access_review_campaign.graphql b/pkg/server/api/console/v1/graphql/access_review_campaign.graphql index fd79f4a4a..65c49ad87 100644 --- a/pkg/server/api/console/v1/graphql/access_review_campaign.graphql +++ b/pkg/server/api/console/v1/graphql/access_review_campaign.graphql @@ -364,8 +364,6 @@ type AccessReviewCampaign implements Node { filter: AccessReviewEntryFilter ): AccessReviewEntryConnection! @goField(forceResolver: true) - pendingEntryCount: Int! @goField(forceResolver: true) - statistics: AccessReviewStatistics! @goField(forceResolver: true) permission(action: String!): Boolean! @goField(forceResolver: true)