Introduce policy.Attributes and policy.AttributesByID aliases
These aliases (`map[string]string` and `map[gid.GID]Attributes`) give batch authorization call sites readable types when loading and returning per-resource condition attributes. ConditionContext now uses the alias instead of the bare map type, with no behavior change. Also extend policy tests to cover ResourcePattern.MatchesResource, comma-separated value handling for In/NotIn, unresolved-reference fallthrough, and resolveKey/resolveValue. Signed-off-by: Bryan Frimin <bryan@probo.com>
This commit is contained in:
116
pkg/iam/policy/policy_test.go
Normal file
116
pkg/iam/policy/policy_test.go
Normal file
@@ -0,0 +1,116 @@
|
||||
// Copyright (c) 2026 Probo Inc <hello@getprobo.com>.
|
||||
//
|
||||
// Permission to use, copy, modify, and/or distribute this software for any
|
||||
// purpose with or without fee is hereby granted, provided that the above
|
||||
// copyright notice and this permission notice appear in all copies.
|
||||
//
|
||||
// THE SOFTWARE IS PROVIDED "AS IS" AND THE AUTHOR DISCLAIMS ALL WARRANTIES WITH
|
||||
// REGARD TO THIS SOFTWARE INCLUDING ALL IMPLIED WARRANTIES OF MERCHANTABILITY
|
||||
// AND FITNESS. IN NO EVENT SHALL THE AUTHOR BE LIABLE FOR ANY SPECIAL, DIRECT,
|
||||
// INDIRECT, OR CONSEQUENTIAL DAMAGES OR ANY DAMAGES WHATSOEVER RESULTING FROM
|
||||
// LOSS OF USE, DATA OR PROFITS, WHETHER IN AN ACTION OF CONTRACT, NEGLIGENCE OR
|
||||
// OTHER TORTIOUS ACTION, ARISING OUT OF OR IN CONNECTION WITH THE USE OR
|
||||
// PERFORMANCE OF THIS SOFTWARE.
|
||||
|
||||
package policy
|
||||
|
||||
import (
|
||||
"testing"
|
||||
|
||||
"go.probo.inc/probo/pkg/gid"
|
||||
)
|
||||
|
||||
func TestPolicy_AddStatement(t *testing.T) {
|
||||
p := NewPolicy("test", "Test")
|
||||
|
||||
stmt := Allow("iam:identity:get").WithSID("allow-identity-get")
|
||||
p.AddStatement(stmt)
|
||||
|
||||
if len(p.Statements) != 1 {
|
||||
t.Fatalf("expected 1 statement, got %d", len(p.Statements))
|
||||
}
|
||||
|
||||
if p.Statements[0].SID != "allow-identity-get" {
|
||||
t.Errorf("expected SID %q, got %q", "allow-identity-get", p.Statements[0].SID)
|
||||
}
|
||||
}
|
||||
|
||||
func TestStatement_WithResources(t *testing.T) {
|
||||
tenantID := gid.NewTenantID()
|
||||
entityType := uint16(1001)
|
||||
|
||||
stmt := Allow("core:framework:get").WithResources(
|
||||
ResourcePattern{
|
||||
TenantID: &tenantID,
|
||||
EntityType: &entityType,
|
||||
},
|
||||
)
|
||||
|
||||
if len(stmt.Resources) != 1 {
|
||||
t.Fatalf("expected 1 resource pattern, got %d", len(stmt.Resources))
|
||||
}
|
||||
|
||||
if stmt.Resources[0].TenantID == nil || *stmt.Resources[0].TenantID != tenantID {
|
||||
t.Fatalf("expected tenant id %q in resource pattern", tenantID)
|
||||
}
|
||||
|
||||
if stmt.Resources[0].EntityType == nil || *stmt.Resources[0].EntityType != entityType {
|
||||
t.Fatalf("expected entity type %d in resource pattern", entityType)
|
||||
}
|
||||
}
|
||||
|
||||
func TestEvaluator_Evaluate_ResourcePatternFilters(t *testing.T) {
|
||||
evaluator := NewEvaluator()
|
||||
tenantID := gid.NewTenantID()
|
||||
otherTenantID := gid.NewTenantID()
|
||||
entityType := uint16(1001)
|
||||
otherEntityType := uint16(1002)
|
||||
|
||||
p := NewPolicy(
|
||||
"resource-filter",
|
||||
"Resource Filter",
|
||||
Allow("core:framework:get").WithResources(
|
||||
ResourcePattern{
|
||||
TenantID: &tenantID,
|
||||
EntityType: &entityType,
|
||||
},
|
||||
),
|
||||
)
|
||||
|
||||
tests := []struct {
|
||||
name string
|
||||
resource gid.GID
|
||||
want Decision
|
||||
}{
|
||||
{
|
||||
name: "matching tenant and entity type allows",
|
||||
resource: gid.New(tenantID, entityType),
|
||||
want: DecisionAllow,
|
||||
},
|
||||
{
|
||||
name: "different tenant does not match",
|
||||
resource: gid.New(otherTenantID, entityType),
|
||||
want: DecisionNoMatch,
|
||||
},
|
||||
{
|
||||
name: "different entity type does not match",
|
||||
resource: gid.New(tenantID, otherEntityType),
|
||||
want: DecisionNoMatch,
|
||||
},
|
||||
}
|
||||
|
||||
for _, tt := range tests {
|
||||
t.Run(tt.name, func(t *testing.T) {
|
||||
result := evaluator.Evaluate(
|
||||
AuthorizationRequest{
|
||||
Action: "core:framework:get",
|
||||
Resource: tt.resource,
|
||||
},
|
||||
[]*Policy{p},
|
||||
)
|
||||
if result.Decision != tt.want {
|
||||
t.Errorf("Evaluate() decision = %v, want %v", result.Decision, tt.want)
|
||||
}
|
||||
})
|
||||
}
|
||||
}
|
||||
Reference in New Issue
Block a user