Refacto load all functions

Unbounded LoadAll* loaders materialised an entire result set in one
query with no ceiling. A table that is small in development can grow
without bound in production, so these loaders were a latent memory
and query-time hazard.

Remove the LoadAll* methods from pkg/coredata and walk the cursor-
paginated LoadBy* siblings instead through a shared page.LoadAll
helper. The helper advances a MaxCursorSize forward cursor until the
result set is exhausted and concatenates the pages. It caps a single
call at MaxLoadAllPages (20) batches of 500 rows and errors past that
rather than materialising an unbounded set, so a runaway caller fails
loudly instead of exhausting memory.

Callers that genuinely need every row now express that explicitly,
and the coredata load-naming rule and docs are updated to discourage
new unbounded loaders.

Signed-off-by: Sacha Al Himdani <sacha@probo.com>

pkg/coredata/risk_assessment_node.go

@@ -138,49 +138,6 @@ WHERE
 	return nil
 }
 
-func (ns *RiskAssessmentNodes) LoadAllByRiskAssessmentScopeID(
-	ctx context.Context,
-	conn pg.Querier,
-	scope Scoper,
-	riskAssessmentScopeID gid.GID,
-) error {
-	q := `
-SELECT
-	id,
-	organization_id,
-	risk_assessment_scope_id,
-	boundary_id,
-	node_type,
-	name,
-	created_at,
-	updated_at
-FROM
-	risk_assessment_nodes
-WHERE
-	%s
-	AND risk_assessment_scope_id = @risk_assessment_scope_id
-ORDER BY
-	created_at ASC, id ASC
-`
-	q = fmt.Sprintf(q, scope.SQLFragment())
-	args := pgx.NamedArgs{"risk_assessment_scope_id": riskAssessmentScopeID}
-	maps.Copy(args, scope.SQLArguments())
-
-	rows, err := conn.Query(ctx, q, args)
-	if err != nil {
-		return fmt.Errorf("cannot query risk assessment nodes: %w", err)
-	}
-
-	results, err := pgx.CollectRows(rows, pgx.RowToAddrOfStructByName[RiskAssessmentNode])
-	if err != nil {
-		return fmt.Errorf("cannot collect risk assessment nodes: %w", err)
-	}
-
-	*ns = results
-
-	return nil
-}
-
 func (ns *RiskAssessmentNodes) CountByRiskAssessmentScopeID(
 	ctx context.Context,
 	conn pg.Querier,