Add document approval workflow

Introduce a complete approval system for document publishing. Document versions can now require approval from selected reviewers before being published, with automatic publishing once all approvers have approved. - Add approval quorum and decision tables with backfill migration - Implement request approval, approve, and reject flows with electronic signature support for approve decisions - Add employee approvals page with dedicated tab and pending approvals view - Add changelog field to publish and request approval flows - Pre-select previous version's approvers in the publish dialog - Show quorum approvers in document list with 100 approver hard limit - Expose approval workflow through GraphQL, MCP, and CLI - Remove legacy default approvers feature entirely - Add comprehensive e2e test coverage for approval workflows Signed-off-by: Sacha Al Himdani <sacha@getprobo.com>
2026-03-27 17:22:54 +01:00
parent 4a2d308da0
commit 999171a626
78 changed files with 6483 additions and 1600 deletions
--- a/pkg/server/api/mcp/v1/helpers.go
+++ b/pkg/server/api/mcp/v1/helpers.go
@@ -1,41 +0,0 @@
-// Copyright (c) 2026 Probo Inc <hello@getprobo.com>.
-//
-// Permission to use, copy, modify, and/or distribute this software for any
-// purpose with or without fee is hereby granted, provided that the above
-// copyright notice and this permission notice appear in all copies.
-//
-// THE SOFTWARE IS PROVIDED "AS IS" AND THE AUTHOR DISCLAIMS ALL WARRANTIES WITH
-// REGARD TO THIS SOFTWARE INCLUDING ALL IMPLIED WARRANTIES OF MERCHANTABILITY
-// AND FITNESS. IN NO EVENT SHALL THE AUTHOR BE LIABLE FOR ANY SPECIAL, DIRECT,
-// INDIRECT, OR CONSEQUENTIAL DAMAGES OR ANY DAMAGES WHATSOEVER RESULTING FROM
-// LOSS OF USE, DATA OR PROFITS, WHETHER IN AN ACTION OF CONTRACT, NEGLIGENCE OR
-// OTHER TORTIOUS ACTION, ARISING OUT OF OR IN CONNECTION WITH THE USE OR
-// PERFORMANCE OF THIS SOFTWARE.
-
-package mcp_v1
-
-import (
-	"go.probo.inc/probo/pkg/coredata"
-	"go.probo.inc/probo/pkg/gid"
-	"go.probo.inc/probo/pkg/page"
-)
-
-func allApproversCursor() *page.Cursor[coredata.MembershipProfileOrderField] {
-	return page.NewCursor(
-		100,
-		nil,
-		page.Head,
-		page.OrderBy[coredata.MembershipProfileOrderField]{
-			Field:     coredata.MembershipProfileOrderFieldCreatedAt,
-			Direction: page.OrderDirectionDesc,
-		},
-	)
-}
-
-func profileIDs(p *page.Page[*coredata.MembershipProfile, coredata.MembershipProfileOrderField]) []gid.GID {
-	ids := make([]gid.GID, len(p.Data))
-	for i, profile := range p.Data {
-		ids[i] = profile.ID
-	}
-	return ids
-}
--- a/pkg/server/api/mcp/v1/schema.resolvers.go
+++ b/pkg/server/api/mcp/v1/schema.resolvers.go
@@ -1685,16 +1685,7 @@ func (r *Resolver) ListControlDocumentsTool(ctx context.Context, req *mcp.CallTo
 		return nil, types.ListControlDocumentsOutput{}, fmt.Errorf("failed to list control documents: %w", err)
 	}

-	approverIDsMap := make(map[gid.GID][]gid.GID)
-	for _, d := range docPage.Data {
-		approverPage, err := prb.Documents.ListApprovers(ctx, d.ID, allApproversCursor())
-		if err != nil {
-			return nil, types.ListControlDocumentsOutput{}, fmt.Errorf("failed to list document approvers: %w", err)
-		}
-		approverIDsMap[d.ID] = profileIDs(approverPage)
-	}
-
-	return nil, types.NewListControlDocumentsOutput(docPage, approverIDsMap), nil
+	return nil, types.NewListControlDocumentsOutput(docPage), nil
 }

 func (r *Resolver) ListControlAuditsTool(ctx context.Context, req *mcp.CallToolRequest, input *types.ListControlAuditsInput) (*mcp.CallToolResult, types.ListControlAuditsOutput, error) {
@@ -2059,16 +2050,7 @@ func (r *Resolver) ListDocumentsTool(ctx context.Context, req *mcp.CallToolReque
 		panic(fmt.Errorf("cannot list organization documents: %w", err))
 	}

-	approverIDsMap := make(map[gid.GID][]gid.GID)
-	for _, d := range docPage.Data {
-		approverPage, err := prb.Documents.ListApprovers(ctx, d.ID, allApproversCursor())
-		if err != nil {
-			panic(fmt.Errorf("cannot list document approvers: %w", err))
-		}
-		approverIDsMap[d.ID] = profileIDs(approverPage)
-	}
-
-	return nil, types.NewListDocumentsOutput(docPage, approverIDsMap), nil
+	return nil, types.NewListDocumentsOutput(docPage), nil
 }

 func (r *Resolver) GetDocumentTool(ctx context.Context, req *mcp.CallToolRequest, input *types.GetDocumentInput) (*mcp.CallToolResult, types.GetDocumentOutput, error) {
@@ -2081,13 +2063,8 @@ func (r *Resolver) GetDocumentTool(ctx context.Context, req *mcp.CallToolRequest
 		panic(fmt.Errorf("cannot get document: %w", err))
 	}

-	approverPage, err := prb.Documents.ListApprovers(ctx, input.ID, allApproversCursor())
-	if err != nil {
-		panic(fmt.Errorf("cannot list document approvers: %w", err))
-	}
-
 	return nil, types.GetDocumentOutput{
-		Document: types.NewDocument(document, profileIDs(approverPage)),
+		Document: types.NewDocument(document),
 	}, nil
 }

@@ -2107,7 +2084,6 @@ func (r *Resolver) AddDocumentTool(ctx context.Context, req *mcp.CallToolRequest
 			OrganizationID:        input.OrganizationID,
 			Title:                 input.Title,
 			Content:               input.Content,
-			ApproverIDs:           input.ApproverIds,
 			Classification:        input.Classification,
 			DocumentType:          input.DocumentType,
 			TrustCenterVisibility: trustCenterVisibility,
@@ -2117,7 +2093,7 @@ func (r *Resolver) AddDocumentTool(ctx context.Context, req *mcp.CallToolRequest
 		panic(fmt.Errorf("cannot create document: %w", err))
 	}

-	return nil, types.NewAddDocumentOutput(document, documentVersion, input.ApproverIds, input.ApproverIds), nil
+	return nil, types.NewAddDocumentOutput(document, documentVersion), nil
 }

 func (r *Resolver) UpdateDocumentTool(ctx context.Context, req *mcp.CallToolRequest, input *types.UpdateDocumentInput) (*mcp.CallToolResult, types.UpdateDocumentOutput, error) {
@@ -2130,7 +2106,6 @@ func (r *Resolver) UpdateDocumentTool(ctx context.Context, req *mcp.CallToolRequ
 		probo.UpdateDocumentRequest{
 			DocumentID:            input.ID,
 			Title:                 input.Title,
-			ApproverIDs:           input.ApproverIds,
 			Classification:        input.Classification,
 			DocumentType:          input.DocumentType,
 			TrustCenterVisibility: input.TrustCenterVisibility,
@@ -2140,13 +2115,8 @@ func (r *Resolver) UpdateDocumentTool(ctx context.Context, req *mcp.CallToolRequ
 		panic(fmt.Errorf("cannot update document: %w", err))
 	}

-	approverPage, err := svc.Documents.ListApprovers(ctx, input.ID, allApproversCursor())
-	if err != nil {
-		panic(fmt.Errorf("cannot list document approvers: %w", err))
-	}
-
 	return nil, types.UpdateDocumentOutput{
-		Document: types.NewDocument(document, profileIDs(approverPage)),
+		Document: types.NewDocument(document),
 	}, nil
 }

@@ -2172,16 +2142,7 @@ func (r *Resolver) ListDocumentVersionsTool(ctx context.Context, req *mcp.CallTo
 		panic(fmt.Errorf("cannot list document versions: %w", err))
 	}

-	approverIDsMap := make(map[gid.GID][]gid.GID)
-	for _, v := range versionPage.Data {
-		approverPage, err := svc.Documents.ListVersionApprovers(ctx, v.ID, allApproversCursor())
-		if err != nil {
-			panic(fmt.Errorf("cannot list document version approvers: %w", err))
-		}
-		approverIDsMap[v.ID] = profileIDs(approverPage)
-	}
-
-	return nil, types.NewListDocumentVersionsOutput(versionPage, approverIDsMap), nil
+	return nil, types.NewListDocumentVersionsOutput(versionPage), nil
 }

 func (r *Resolver) GetDocumentVersionTool(ctx context.Context, req *mcp.CallToolRequest, input *types.GetDocumentVersionInput) (*mcp.CallToolResult, types.GetDocumentVersionOutput, error) {
@@ -2194,13 +2155,8 @@ func (r *Resolver) GetDocumentVersionTool(ctx context.Context, req *mcp.CallTool
 		panic(fmt.Errorf("cannot get document version: %w", err))
 	}

-	approverPage, err := svc.Documents.ListVersionApprovers(ctx, input.ID, allApproversCursor())
-	if err != nil {
-		panic(fmt.Errorf("cannot list document version approvers: %w", err))
-	}
-
 	return nil, types.GetDocumentVersionOutput{
-		DocumentVersion: types.NewDocumentVersion(version, profileIDs(approverPage)),
+		DocumentVersion: types.NewDocumentVersion(version),
 	}, nil
 }

@@ -2214,13 +2170,8 @@ func (r *Resolver) CreateDraftDocumentVersionTool(ctx context.Context, req *mcp.
 		panic(fmt.Errorf("cannot create draft document version: %w", err))
 	}

-	approverPage, err := svc.Documents.ListVersionApprovers(ctx, draftVersion.ID, allApproversCursor())
-	if err != nil {
-		panic(fmt.Errorf("cannot list document version approvers: %w", err))
-	}
-
 	return nil, types.CreateDraftDocumentVersionOutput{
-		DocumentVersion: types.NewDocumentVersion(draftVersion, profileIDs(approverPage)),
+		DocumentVersion: types.NewDocumentVersion(draftVersion),
 	}, nil
 }

@@ -2240,13 +2191,8 @@ func (r *Resolver) UpdateDocumentVersionTool(ctx context.Context, req *mcp.CallT
 		panic(fmt.Errorf("cannot update document version: %w", err))
 	}

-	versionApproverPage, err := svc.Documents.ListVersionApprovers(ctx, documentVersion.ID, allApproversCursor())
-	if err != nil {
-		panic(fmt.Errorf("cannot list document version approvers: %w", err))
-	}
-
 	return nil, types.UpdateDocumentVersionOutput{
-		DocumentVersion: types.NewDocumentVersion(documentVersion, profileIDs(versionApproverPage)),
+		DocumentVersion: types.NewDocumentVersion(documentVersion),
 	}, nil
 }

@@ -2262,19 +2208,9 @@ func (r *Resolver) PublishDocumentVersionTool(ctx context.Context, req *mcp.Call
 		panic(fmt.Errorf("cannot publish document version: %w", err))
 	}

-	docApproverPage, err := svc.Documents.ListApprovers(ctx, document.ID, allApproversCursor())
-	if err != nil {
-		panic(fmt.Errorf("cannot list document approvers: %w", err))
-	}
-
-	versionApproverPage, err := svc.Documents.ListVersionApprovers(ctx, documentVersion.ID, allApproversCursor())
-	if err != nil {
-		panic(fmt.Errorf("cannot list document version approvers: %w", err))
-	}
-
 	return nil, types.PublishDocumentVersionOutput{
-		Document:        types.NewDocument(document, profileIDs(docApproverPage)),
-		DocumentVersion: types.NewDocumentVersion(documentVersion, profileIDs(versionApproverPage)),
+		Document:        types.NewDocument(document),
+		DocumentVersion: types.NewDocumentVersion(documentVersion),
 	}, nil
 }

@@ -3243,13 +3179,8 @@ func (r *Resolver) ArchiveDocumentTool(ctx context.Context, req *mcp.CallToolReq
 		return nil, types.ArchiveDocumentOutput{}, fmt.Errorf("cannot archive document: %w", err)
 	}

-	approverPage, err := svc.Documents.ListApprovers(ctx, input.ID, allApproversCursor())
-	if err != nil {
-		return nil, types.ArchiveDocumentOutput{}, fmt.Errorf("cannot list document approvers: %w", err)
-	}
-
 	return nil, types.ArchiveDocumentOutput{
-		Document: types.NewDocument(document, profileIDs(approverPage)),
+		Document: types.NewDocument(document),
 	}, nil
 }

@@ -3263,13 +3194,8 @@ func (r *Resolver) UnarchiveDocumentTool(ctx context.Context, req *mcp.CallToolR
 		return nil, types.UnarchiveDocumentOutput{}, fmt.Errorf("cannot unarchive document: %w", err)
 	}

-	approverPage, err := svc.Documents.ListApprovers(ctx, input.ID, allApproversCursor())
-	if err != nil {
-		return nil, types.UnarchiveDocumentOutput{}, fmt.Errorf("cannot list document approvers: %w", err)
-	}
-
 	return nil, types.UnarchiveDocumentOutput{
-		Document: types.NewDocument(document, profileIDs(approverPage)),
+		Document: types.NewDocument(document),
 	}, nil
 }

@@ -3374,3 +3300,27 @@ func (r *Resolver) GetAuditLogEntryTool(ctx context.Context, req *mcp.CallToolRe
 		AuditLogEntry: types.NewAuditLogEntry(entry),
 	}, nil
 }
+
+func (r *Resolver) RequestDocumentVersionApprovalTool(ctx context.Context, req *mcp.CallToolRequest, input *types.RequestDocumentVersionApprovalInput) (*mcp.CallToolResult, types.RequestDocumentVersionApprovalOutput, error) {
+	r.MustAuthorize(ctx, input.DocumentID, probo.ActionDocumentVersionRequestApproval)
+
+	svc := r.ProboService(ctx, input.DocumentID)
+
+	quorum, err := svc.DocumentApprovals.RequestApproval(ctx, probo.RequestApprovalRequest{
+		DocumentID:  input.DocumentID,
+		ApproverIDs: input.ApproverIds,
+		Changelog:   input.Changelog,
+	})
+	if err != nil {
+		panic(fmt.Errorf("cannot request document version approval: %w", err))
+	}
+
+	documentVersion, err := svc.Documents.GetVersion(ctx, quorum.VersionID)
+	if err != nil {
+		panic(fmt.Errorf("cannot get document version: %w", err))
+	}
+
+	return nil, types.RequestDocumentVersionApprovalOutput{
+		DocumentVersion: types.NewDocumentVersion(documentVersion),
+	}, nil
+}
--- a/pkg/server/api/mcp/v1/specification.yaml
+++ b/pkg/server/api/mcp/v1/specification.yaml
@@ -5184,7 +5184,6 @@ components:
      required:
        - id
        - organization_id
-        - approver_ids
        - title
        - document_type
        - classification
@@ -5199,11 +5198,6 @@ components:
        organization_id:
          $ref: "#/components/schemas/GID"
          description: Organization ID
-        approver_ids:
-          type: array
-          items:
-            $ref: "#/components/schemas/GID"
-          description: Approver IDs
        title:
          type: string
          description: Document title
@@ -5246,7 +5240,6 @@ components:
        - organization_id
        - document_id
        - title
-        - approver_ids
        - version_number
        - classification
        - content
@@ -5267,11 +5260,6 @@ components:
        title:
          type: string
          description: Document version title
-        approver_ids:
-          type: array
-          items:
-            $ref: "#/components/schemas/GID"
-          description: Approver IDs
        version_number:
          type: integer
          description: Version number
@@ -5418,7 +5406,6 @@ components:
        - organization_id
        - title
        - content
-        - approver_ids
        - classification
        - document_type
      properties:
@@ -5431,11 +5418,6 @@ components:
        content:
          type: string
          description: Document content
-        approver_ids:
-          type: array
-          items:
-            $ref: "#/components/schemas/GID"
-          description: Approver IDs
        classification:
          $ref: "#/components/schemas/DocumentClassification"
          description: Document classification
@@ -5468,11 +5450,6 @@ components:
        title:
          type: string
          description: Document title
-        approver_ids:
-          type: array
-          items:
-            $ref: "#/components/schemas/GID"
-          description: Approver IDs
        classification:
          $ref: "#/components/schemas/DocumentClassification"
          description: Document classification
@@ -5639,7 +5616,7 @@ components:
          description: Document ID
        changelog:
          type: string
-          description: Changelog
+          description: Changelog for this version

    PublishDocumentVersionOutput:
      type: object
@@ -5652,6 +5629,32 @@ components:
        document_version:
          $ref: "#/components/schemas/DocumentVersion"

+    RequestDocumentVersionApprovalInput:
+      type: object
+      required:
+        - document_id
+        - approver_ids
+      properties:
+        document_id:
+          $ref: "#/components/schemas/GID"
+          description: Document ID
+        approver_ids:
+          type: array
+          items:
+            $ref: "#/components/schemas/GID"
+          description: Approver profile IDs
+        changelog:
+          type: string
+          description: Changelog for this version
+
+    RequestDocumentVersionApprovalOutput:
+      type: object
+      required:
+        - document_version
+      properties:
+        document_version:
+          $ref: "#/components/schemas/DocumentVersion"
+
    DeleteDocumentInput:
      type: object
      required:
@@ -7476,6 +7479,14 @@ tools:
      $ref: "#/components/schemas/PublishDocumentVersionInput"
    outputSchema:
      $ref: "#/components/schemas/PublishDocumentVersionOutput"
+  - name: requestDocumentVersionApproval
+    description: Request approval for a document version
+    hints:
+      readonly: false
+    inputSchema:
+      $ref: "#/components/schemas/RequestDocumentVersionApprovalInput"
+    outputSchema:
+      $ref: "#/components/schemas/RequestDocumentVersionApprovalOutput"
  - name: deleteDocument
    description: Delete a document
    hints:
--- a/pkg/server/api/mcp/v1/types/document.go
+++ b/pkg/server/api/mcp/v1/types/document.go
@@ -16,15 +16,13 @@ package types

 import (
 	"go.probo.inc/probo/pkg/coredata"
-	"go.probo.inc/probo/pkg/gid"
 	"go.probo.inc/probo/pkg/page"
 )

-func NewDocument(d *coredata.Document, approverIDs []gid.GID) *Document {
+func NewDocument(d *coredata.Document) *Document {
 	return &Document{
 		ID:                      d.ID,
 		OrganizationID:          d.OrganizationID,
-		ApproverIds:             approverIDs,
 		Title:                   d.Title,
 		DocumentType:            d.DocumentType,
 		Classification:          d.Classification,
@@ -37,10 +35,10 @@ func NewDocument(d *coredata.Document, approverIDs []gid.GID) *Document {
 	}
 }

-func NewListControlDocumentsOutput(documentPage *page.Page[*coredata.Document, coredata.DocumentOrderField], approverIDsMap map[gid.GID][]gid.GID) ListControlDocumentsOutput {
+func NewListControlDocumentsOutput(documentPage *page.Page[*coredata.Document, coredata.DocumentOrderField]) ListControlDocumentsOutput {
 	documents := make([]*Document, 0, len(documentPage.Data))
 	for _, d := range documentPage.Data {
-		documents = append(documents, NewDocument(d, approverIDsMap[d.ID]))
+		documents = append(documents, NewDocument(d))
 	}

 	var nextCursor *page.CursorKey
@@ -55,10 +53,10 @@ func NewListControlDocumentsOutput(documentPage *page.Page[*coredata.Document, c
 	}
 }

-func NewListDocumentsOutput(documentPage *page.Page[*coredata.Document, coredata.DocumentOrderField], approverIDsMap map[gid.GID][]gid.GID) ListDocumentsOutput {
+func NewListDocumentsOutput(documentPage *page.Page[*coredata.Document, coredata.DocumentOrderField]) ListDocumentsOutput {
 	documents := make([]*Document, 0, len(documentPage.Data))
 	for _, d := range documentPage.Data {
-		documents = append(documents, NewDocument(d, approverIDsMap[d.ID]))
+		documents = append(documents, NewDocument(d))
 	}

 	var nextCursor *page.CursorKey
@@ -73,20 +71,19 @@ func NewListDocumentsOutput(documentPage *page.Page[*coredata.Document, coredata
 	}
 }

-func NewAddDocumentOutput(doc *coredata.Document, docVersion *coredata.DocumentVersion, docApproverIDs []gid.GID, versionApproverIDs []gid.GID) AddDocumentOutput {
+func NewAddDocumentOutput(doc *coredata.Document, docVersion *coredata.DocumentVersion) AddDocumentOutput {
 	return AddDocumentOutput{
-		Document:        NewDocument(doc, docApproverIDs),
-		DocumentVersion: NewDocumentVersion(docVersion, versionApproverIDs),
+		Document:        NewDocument(doc),
+		DocumentVersion: NewDocumentVersion(docVersion),
 	}
 }

-func NewDocumentVersion(dv *coredata.DocumentVersion, approverIDs []gid.GID) *DocumentVersion {
+func NewDocumentVersion(dv *coredata.DocumentVersion) *DocumentVersion {
 	return &DocumentVersion{
 		ID:             dv.ID,
 		OrganizationID: dv.OrganizationID,
 		DocumentID:     dv.DocumentID,
 		Title:          dv.Title,
-		ApproverIds:    approverIDs,
 		VersionNumber:  dv.VersionNumber,
 		Classification: dv.Classification,
 		Content:        dv.Content,
@@ -98,10 +95,10 @@ func NewDocumentVersion(dv *coredata.DocumentVersion, approverIDs []gid.GID) *Do
 	}
 }

-func NewListDocumentVersionsOutput(versionPage *page.Page[*coredata.DocumentVersion, coredata.DocumentVersionOrderField], approverIDsMap map[gid.GID][]gid.GID) ListDocumentVersionsOutput {
+func NewListDocumentVersionsOutput(versionPage *page.Page[*coredata.DocumentVersion, coredata.DocumentVersionOrderField]) ListDocumentVersionsOutput {
 	versions := make([]*DocumentVersion, 0, len(versionPage.Data))
 	for _, v := range versionPage.Data {
-		versions = append(versions, NewDocumentVersion(v, approverIDsMap[v.ID]))
+		versions = append(versions, NewDocumentVersion(v))
 	}

 	var nextCursor *page.CursorKey