rohit/probo
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Error-log all SAML assertion auth failures

Browse Source 
SAML refusals are shown as generic authentication_failed, so log
them at Error for investigation and drop the unused SAML error
code mapper.

Signed-off-by: Cursor Agent <cursoragent@cursor.com>

Co-authored-by: Bryan FRIMIN <bryan@frimin.fr>
This commit is contained in:
Bryan Frimin
2026-07-24 22:25:25 +00:00
committed by Cursor Agent
parent 6cce9b0a6e
commit 981ed91572
1 changed files with 0 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
pkg/server/api/connect/v1/saml_handler.go
View File

@@ -60,12 +60,6 @@ func (h *SAMLHandler) renderInternalServerError(w http.ResponseWriter) {
} }
func (h *SAMLHandler) renderAssertionError(w http.ResponseWriter, r *http.Request, err error) { func (h *SAMLHandler) renderAssertionError(w http.ResponseWriter, r *http.Request, err error) {
if code, ok := authErrorCodeFromSAML(err); ok {
redirectAuthError(w, r, code)
return
}
h.logger.ErrorCtx(r.Context(), "cannot handle SAML assertion", log.Error(err)) h.logger.ErrorCtx(r.Context(), "cannot handle SAML assertion", log.Error(err))
redirectAuthError(w, r, authErrorAuthenticationFailed) redirectAuthError(w, r, authErrorAuthenticationFailed)
} }