rohit/probo
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Fix active session must not be return if expired

Browse Source 
Signed-off-by: Bryan Frimin <bryan@getprobo.com>
This commit is contained in:
Bryan Frimin
2025-12-18 18:24:06 +01:00
parent 7a26473e8f
commit 970a734964
2 changed files with 13 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
pkg/iam/session_service.go
View File

@@ -300,6 +300,14 @@ func (s SessionService) GetActiveSessionForMembership(ctx context.Context, rootS
return fmt.Errorf("cannot load child session: %w", err) return fmt.Errorf("cannot load child session: %w", err)
} }
if childSession.ExpireReason != nil {
return NewSessionExpiredError(childSession.ID)
}
if time.Now().After(childSession.ExpiredAt) {
return NewSessionExpiredError(childSession.ID)
}
return nil return nil
}, },
) )

7
pkg/server/api/connect/v1/v1_resolver.go
View File

@@ -144,9 +144,12 @@ func (r *membershipResolver) ActiveSession(ctx context.Context, obj *types.Membe
session, err := r.iam.SessionService.GetActiveSessionForMembership(ctx, rootSession.UserID, obj.ID) session, err := r.iam.SessionService.GetActiveSessionForMembership(ctx, rootSession.UserID, obj.ID)
if err != nil { if err != nil {
var errSessionNotFound *iam.ErrSessionNotFound var (
errSessionNotFound *iam.ErrSessionNotFound
errSessionExpired *iam.ErrSessionExpired
)
if errors.As(err, &errSessionNotFound) { if errors.As(err, &errSessionNotFound) || errors.As(err, &errSessionExpired) {
return nil, nil return nil, nil
} }