Fix listeners cleaning on unmount
Signed-off-by: Émile Ré <emile@getprobo.com>
This commit is contained in:
@@ -98,8 +98,6 @@ export function TableRowMenu({ editor }: TableRowMenuProps) {
|
||||
|
||||
const [hoveredRow, setHoveredRow] = useState<HoveredRow | null>(null);
|
||||
|
||||
if (!hoveredRow && !menuOpen) return null;
|
||||
|
||||
return (
|
||||
<>
|
||||
<TableRowMenuTrigger
|
||||
|
||||
@@ -45,11 +45,18 @@ export function TableRowMenuTrigger({
|
||||
const dragStartPos = useRef({ x: 0, y: 0 });
|
||||
const rafId = useRef<number | null>(null);
|
||||
const hoveredRowRef = useRef<HoveredRow | null>(null);
|
||||
const dragCleanupRef = useRef<(() => void) | null>(null);
|
||||
|
||||
useEffect(() => {
|
||||
hoveredRowRef.current = hoveredRow;
|
||||
}, [hoveredRow]);
|
||||
|
||||
useEffect(() => {
|
||||
return () => {
|
||||
dragCleanupRef.current?.();
|
||||
};
|
||||
}, []);
|
||||
|
||||
useEffect(() => {
|
||||
if (editor.isDestroyed || !editor.isEditable) return;
|
||||
|
||||
@@ -285,6 +292,7 @@ export function TableRowMenuTrigger({
|
||||
const onMouseUp = (ev: MouseEvent) => {
|
||||
document.removeEventListener("mousemove", onMouseMove);
|
||||
document.removeEventListener("mouseup", onMouseUp);
|
||||
dragCleanupRef.current = null;
|
||||
|
||||
if (draggingRef.current) {
|
||||
setDragIndicator(null);
|
||||
@@ -327,6 +335,10 @@ export function TableRowMenuTrigger({
|
||||
|
||||
document.addEventListener("mousemove", onMouseMove);
|
||||
document.addEventListener("mouseup", onMouseUp);
|
||||
dragCleanupRef.current = () => {
|
||||
document.removeEventListener("mousemove", onMouseMove);
|
||||
document.removeEventListener("mouseup", onMouseUp);
|
||||
};
|
||||
};
|
||||
|
||||
return (
|
||||
|
||||
Reference in New Issue
Block a user